GitLab

These DCHECKs are firing in telemetry tests on the GPU bots.  Removes the
DCHECKs and instead adds debug logging to help track down the root cause.

Since the window size invariants are not holding in some situations, this CL
also contains code to fixup the window size if it is wrong.

BUG=464754
TEST=None

Review URL: https://codereview.chromium.org/1018693003

Cr-Commit-Position: refs/heads/master@{#321000}

BUG=437865

Review URL: https://codereview.chromium.org/1006813008

Cr-Commit-Position: refs/heads/master@{#320999}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/1018543002

Cr-Commit-Position: refs/heads/master@{#320998}

media: Check kDisableInfobarForProtectedMediaIdentifier in ProtectedMediaIdentifierPermissionContext.

Previously this flag was checked in BrowserCdmManager. When this flag is set,
we would NOT check any preference and content setting related to protected
media identifier. Permission was granted blindly by default.

This CL moves the check to ProtectedMediaIdentifierPermissionContext. Now the
impact of this flag is more restrictive: only when the permission status is
"ASK" will we replace it with "ALLOW". This applies to both permission request
and permission check. If the permission is "BLOCKED" for any reason (e.g.
invalid origin, disabled by master switch, blocked in content setting), the
permission request/check will be blocked.

BUG=456219
TEST=Manually tested with and without the switch.

Review URL: https://codereview.chromium.org/1007163003

Cr-Commit-Position: refs/heads/master@{#320997}

Summary of changes:

Global renaming:
  test     => QUnit.test()
  equal    => assert.equal()
  notEqual => assert.notEqual()
  deepEqual=> assert.deepEqual()
  ok       => assert.ok()
  module   => QUnit.module()
  setup    => beforeEach
  teardown => afterEach

Async test migration:
  asyncTest     => QUnit.test(function(assert) {
                     ...
                   });
  QUnit.start() => var done = assert.async();
                   done();
  return promise directly for async tests.

BUG=467817

Review URL: https://codereview.chromium.org/1017613002

Cr-Commit-Position: refs/heads/master@{#320996}

BUG=467785

Review URL: https://codereview.chromium.org/1018763002

Cr-Commit-Position: refs/heads/master@{#320995}

Revert of Call RegisterCrashKeys for chrome.exe in static build. (patchset #5 id:140001 of https://codereview.chromium.org/1008523002/)

Reason for revert:
Test failures.

Original issue's description:
> Call RegisterCrashKeys for chrome.exe in static build.
>
> In component builds the single invocation from child_process_logging_win is sufficient (as there is only a single copy of base).
>
> BUG=460512
>
> Committed: https://crrev.com/0bfeabec41ac37bc9e8c0b62316a11269db156e5
> Cr-Commit-Position: refs/heads/master@{#320967}

TBR=rsesek@chromium.org,grt@chromium.org,kbr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460512

Review URL: https://codereview.chromium.org/1016933002

Cr-Commit-Position: refs/heads/master@{#320994}

This CL moves the PlatformNotificationContext and the
NotificationDatabaseData classes into the //content API. Serialization
behavior for NotificationDatabaseData will remain content-private.

The primary users of this will be (1) clearing browser data, (2) UA-
triggered notification closures and (3) forced push notifications.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1010833002

Cr-Commit-Position: refs/heads/master@{#320993}

The extension already had access to this API on account of being a
component. This change just makes things "right".

Review URL: https://codereview.chromium.org/1008373006

Cr-Commit-Position: refs/heads/master@{#320992}

This method makes the device think that it is not charging. This is useful
for getting battery data from dumpsys.

BUG=

Review URL: https://codereview.chromium.org/993733002

Cr-Commit-Position: refs/heads/master@{#320991}

1) Move the serving_dir related logic to one place and add some comments to improve hackability and stability for cloud_storage in telemetry.

2) Make serving_dirs available for user stories as part of the refactor to remove page_sets.

This is the second part of https://codereview.chromium.org/794493004/, broken out for reviewer ease.

BUG=454531
BUG=435063

Committed: https://crrev.com/eed596dced7b9e3f7d21c84f695a39b946c62bf2
Cr-Commit-Position: refs/heads/master@{#320523}

Review URL: https://codereview.chromium.org/838253005

Cr-Commit-Position: refs/heads/master@{#320990}

BUG=450050

Review URL: https://codereview.chromium.org/1013263002

Cr-Commit-Position: refs/heads/master@{#320989}

https://chromium.googlesource.com/angle/angle/+log/524e3bde19..6bd5831261

BUG=466735,466704

Review URL: https://codereview.chromium.org/1011213002

Cr-Commit-Position: refs/heads/master@{#320988}

BUG=

Review URL: https://codereview.chromium.org/1004843002

Cr-Commit-Position: refs/heads/master@{#320987}

Allow pull-to-refresh activation when the overscroll glow effect is
active but mostly transparent. This accomodates accidental refresh
prevention while easing the frustration of having to wait until
the overscroll glow has completely faded.

BUG=428429

Review URL: https://codereview.chromium.org/993613007

Cr-Commit-Position: refs/heads/master@{#320986}

BUG=467260

Review URL: https://codereview.chromium.org/1017863003

Cr-Commit-Position: refs/heads/master@{#320985}

These Android lint warnings have been fixed.

BUG=411461

Review URL: https://codereview.chromium.org/993483003

Cr-Commit-Position: refs/heads/master@{#320984}

Change for building font cache into separate thread inside utility process so that IO thread remains responsive.

BUG=458751, 436195
R=cpu,scottmg

Review URL: https://codereview.chromium.org/1011023002

Cr-Commit-Position: refs/heads/master@{#320983}

Latest EME spec has added new values to MediaKeyStatus
(https://w3c.github.io/encrypted-media/#idl-def-MediaKeyStatus),
so pass these though Pepper. Changes to the CDM interface will
come later.

BUG=465592
TEST=none, as the new values not currently used

Review URL: https://codereview.chromium.org/1005213002

Cr-Commit-Position: refs/heads/master@{#320982}

BUG=463611

Review URL: https://codereview.chromium.org/1014843003

Cr-Commit-Position: refs/heads/master@{#320981}

Make HttpServerProperties::GetAlternateProtocol return AlternativeService, and
rename it to GetAlternativeService.  Rename its parameter, as well as parameters
of other alternate protocol or alternative service related functions, from
server to origin.  Update all clients of GetAlternateProtocol.  Also rename
anonymous namespace HasAlternateProtocol to HasAlternativeService in tests.

BUG=392576

Review URL: https://codereview.chromium.org/1017453008

Cr-Commit-Position: refs/heads/master@{#320980}

- Request permission in ProxyDecryptor.
- Check (instead of request) permission in BrowserCdmManager.

BUG=446263,455271
TEST=Manually tested on Android.

Review URL: https://codereview.chromium.org/1013913002

Cr-Commit-Position: refs/heads/master@{#320979}

Define gypi_skia_gpu and gypi_skia_pdf only if they will be used.

R=alokp@chromium.org,reed@google.com
BUG=none

Review URL: https://codereview.chromium.org/1008603002

Cr-Commit-Position: refs/heads/master@{#320978}

These are used, e.g., for the Bookmark -> Edit... dialogs on Cocoa and
Views.

This gets WidgetTestInteractive.*Window*ModalWindowDestroyedActivationTest
passing.

WidgetTestInteractive.*System*ModalWindowReleasesCapture is disabled in
this CL. System modal windows are not needed on Mac.

Currently the implementation on MacViews assumes all modal dialogs are
shown using a sheet. On Cocoa, this is not always true for
WebContents-Modal dialogs (e.g. cookies and site data), but it is true
for some WebContents-Modal dialogs (e.g. certificate information).

A follow-up will add logic to ensure WebContents-Modal dialogs are
handled appropriately, and have good test coverage.

After this all tests pass on the current mac trybot configuration with
toolkit_views=1.

BUG=403679

Review URL: https://codereview.chromium.org/993253002

Cr-Commit-Position: refs/heads/master@{#320977}

GLSL precision qualifiers have no effect in OpenGL.
On Mac the precision qualifiers cause the shader not to compile.

BUG=

Review URL: https://codereview.chromium.org/1011503002

Cr-Commit-Position: refs/heads/master@{#320976}

This CL makes Apple Touch Icon URLs will be parsed in Blink and passed to
FaviconTabHelper::DidUpdateFaviconURL().  This used to be enabled for Android
only.  On desktop the URLs are parsed, but ignored (so storage into Favicon
DB and no image fetching yet).

BUG=467712

Review URL: https://codereview.chromium.org/1007563004

Cr-Commit-Position: refs/heads/master@{#320975}

This allows ui::Layer to take scale factor into consideration when updating the cc::NinePatchLayer.

BUG=466950
R=danakj@chromium.org
R=oshima@chromium.org
TBR=sky@chromium.org
TEST=verify on HiDPI display as well as HiDPI + LowDPI extended mode that shadows are correct.

Review URL: https://codereview.chromium.org/1002393002

Cr-Commit-Position: refs/heads/master@{#320974}

Uses the enhanced bookmarks Finch experiment as the only mechanism for
enabling enhanced bookmarks in Chrome. With this change we no longer
need the EnhancedBookmarks.SyncExperimentState UMA histogram since we
can now get all the relevant metrics via Finch.

BUG=467040

Review URL: https://codereview.chromium.org/1009673002

Cr-Commit-Position: refs/heads/master@{#320973}

If the current wallpaper was set by a third party application, we should disable surprise me feature,
otherwise the wallpaper will still be changed periodically.

Also fix the issue that wallpaper picker application can't load the local resource:
chrome://resources/css/text_defaults.css.

BUG=466709
TEST=Manually tested

Review URL: https://codereview.chromium.org/1004263002

Cr-Commit-Position: refs/heads/master@{#320972}

Previously extensions::Dispatcher was responsible for creating ScriptContexts
then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them
itself. This prepares the Extension system for later changing to lazily or
asynchronously creating ScriptContexts.

BUG=466373
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/995283004

Cr-Commit-Position: refs/heads/master@{#320971}

Pre-ICS Android is not supported.

Review URL: https://codereview.chromium.org/1016553003

Cr-Commit-Position: refs/heads/master@{#320970}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/706d98e..9d2049d

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1013123003

Cr-Commit-Position: refs/heads/master@{#320969}

This flag now does not bypass the checks for whether the app has been
added to the homescreen or not.

BUG=467374

Review URL: https://codereview.chromium.org/1011963003

Cr-Commit-Position: refs/heads/master@{#320968}

In component builds the single invocation from child_process_logging_win is sufficient (as there is only a single copy of base).

BUG=460512

Review URL: https://codereview.chromium.org/1008523002

Cr-Commit-Position: refs/heads/master@{#320967}

BUG=460512

Review URL: https://codereview.chromium.org/1017453002

Cr-Commit-Position: refs/heads/master@{#320966}

Avoid IPC from ChildDiscardableSharedMemoryManager dtor in case the
channel has been closed at destruction time.

BUG=467958
TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.*

Review URL: https://codereview.chromium.org/1012163002

Cr-Commit-Position: refs/heads/master@{#320965}

BUG=467806

Review URL: https://codereview.chromium.org/1004623005

Cr-Commit-Position: refs/heads/master@{#320964}

This allows jinja2 templates to reference other templates by path name,
e.g. to extend them or include them.

BUG=467069

Review URL: https://codereview.chromium.org/1002313002

Cr-Commit-Position: refs/heads/master@{#320963}

Revert of [Ozone] Fix Vaapi unittest builds (patchset #1 id:1 of https://codereview.chromium.org/1014623003/)

Reason for revert:
Breaks CrOS !ozone build.

Original issue's description:
> [Ozone] Fix Vaapi unittest builds
>
> BUG=none
>
> Committed: https://crrev.com/638dcf8ea48510475248361caeca547c4541b950
> Cr-Commit-Position: refs/heads/master@{#320758}

TBR=dnicoara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1012213002

Cr-Commit-Position: refs/heads/master@{#320962}

R=michaelpg@chromium.org, dzhioev@chromium.org

Review URL: https://codereview.chromium.org/1011993002

Cr-Commit-Position: refs/heads/master@{#320961}