- 22 Oct, 2020 40 commits
-
-
Rakina Zata Amni authored
These tests do not intend to have failed navigations, but they actually failed silently, mostly due to 404s because of bad URLs. Soon (after crrev.com/c/2487024 lands) these tests will actually fail and result in error pages. See navigation-dev thread for more context: https://groups.google.com/a/chromium.org/g/navigation-dev/c/WbNkf2alpPU/m/2tQQ-cXWBgAJ Bug:1133115 Change-Id: Ib75a04aa90635b9eb778ce2da56fcee83965b053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483748 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819688}
-
Nic Hollingum authored
This reverts commit b6deb469. Reason for revert: Deterministically breaks linux-chromeos-dbg, e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20956 Original change's description: > cbui crostini: refactor away CrostiniAppRestartView > > This change removes CrostiniAppRestartView, replacing it with: > * Construction and configuration of a bare View + DialogDelegate pair > * A pair of public functions that create and show this dialog > > This change also adds some unit test coverage for this dialog to > ensure that I didn't break it when doing this refactor. > > Bug: 1075649 > Change-Id: I7de0e2386de14aa6aec8917c630f64a69df26832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819545} TBR=ellyjones@chromium.org,joelhockey@chromium.org Change-Id: I230664fa24b78125632310bf05edd6a3d219f18b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490971Reviewed-by:
Nic Hollingum <hollingum@google.com> Auto-Submit: Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#819687}
-
Matthew Mourgos authored
This is a reland of 315d5cdf The original change was reverted because of test failures due to the feature not being added to tools/metrics/histograms/enums.xml. Original change's description: > Multipaste: Add flag for resetting nudge prefs on new session > > Add a flag which, when enabled, will reset the clipboard nudge prefs > on a new user session. This will allow the nudge to be shown again. > > Bug: 1140656 > Change-Id: I312f05eed655fc1657843d2b7a45214bb671bebe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489020 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819483} Bug: 1140656 Change-Id: I476e50a8ce89a810608636123bf0187e9f360b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490853 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819686}
-
Joel Hockey authored
VolumeMetadata.remoteMountPath is the path on the remote host where this volume is mounted, for crostini this is the user's homedir (/home/<username>). The remoteMountPath will be used in crostini trash to prefix Path in *.trashinfo files so that paths reflect the valid local path, and our trash interactions can interoperate with other linux file managers. Bug: 953310 Change-Id: I623781a63d32564f0a705aed47188b0c26b945c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490961 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#819685}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I42c9d272577419c343a6bd08f5c2cc33f3f8631e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491484Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819684}
-
Kuo-Hsin Yang authored
Add vovoy@chromium.org as owner for oom_memory_details.* and memory_kills_* files, remove cylee@chromium.org. Change-Id: Ie0789315943a0adea4a9fa05107174ce39770448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489381Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819683}
-
Joel Hockey authored
On a device, MyFiles/Downloads is a separate volume to MyFiles which is bind mounted. As a result, moving a file from MyFiles/Downloads/ into MyFiles/.Trash is a copy operation rather than move. To fix this, we will have a dedicated MyFiles/Downloads/.Trash for items under Downloads which guarantees that all deletes will stay fast. Bug: 953310 Change-Id: Ib1bc6d9da2aec45e1d4b43eae25cb02b230b117f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469645Reviewed-by:
-
Clark DuVall authored
This is a reland of b9d174e5 This time component builds should be actually fixed with http://crrev.com/c/2490668. Original change's description: > Enable isolated splits in canary > > All known issues have been fixed so enabling this in canary to see if > there are any major problems. > > Bug: 1126301 > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819200} TBR=agrieve@chromium.org Bug: 1126301 Change-Id: I71afd73c704deb6c7d65a76c6ea8a2b6f0b6fb57 Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490871Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819681}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a8cdc94e138d..d975e29d1e93 2020-10-21 jophba@chromium.org Add SessionMessager class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I91be3fccdcf759851cad1ded01d4fae53decf3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819680}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie791e22c49996e80b0e4c07d641d4dea10321957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491301Reviewed-by:
-
Julie Jeongeun Kim authored
This CL extends expiry for Accessibility.ATK-APIs histogram. Bug: 1138235 Change-Id: I2c0f575ec7d484479c2b70696762aef25078c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483947Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#819678}
-
Joel Hockey authored
go/chrome-ss/b025494050650332c0d6964cb82b977199bd9fd0 go/chrome-ss/8d3b3f36cf84c787244001584e2b8425be3e7549 The foreground page adds a listener to the background 'delete' event, and for any of the operation-done events (CANCEL, ERROR, SUCCESS) where trashedItems is populated, the foreground page will display an Undo toast. The toast message is '<filename> deleted' or '<n> items deleted', and has an action 'Undo' button to allow users to undo the delete. Bug: 953310 Change-Id: I55f2a59e03fc6c355f3362db9cc5a6767c4086ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469340Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/726aef930d80..c51c18a5866c 2020-10-21 andoli@chromium.org [ts] Typecheck settings/SettingsScreen.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10a1ce658a5d4e0aa3d0eb65732ac25b857b8b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491046Reviewed-by:
-
Yicheng Li authored
It is a security concern that users potentially get trained to use their GAIA password for 3rd party websites / apps, so after discussing with the browser side and GAIA team, we decided to not offer the password option in this auth dialog. The dialog will be triggered if either PIN or fingerprint is available. Bug: b/156258540 Change-Id: I9dffaa1fed36ca476cb5976d5229d5f49278e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487826 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819675}
-
Sven Zheng authored
This reverts commit afa62bad. Reason for revert: crbug.com/1140928 linux-lacros-rel browser tests become very flaky. Error: FATAL:wayland_buffer_manager_host.cc(371)] Check failed: !submitted_buffer->released. Original change's description: > Reland "[ozone/wayland] Use 4x4 opaque background and stack underlay correctly" > > This is a reland of aa21781d > Root-cause of previous issue was Gnome's interpretation of whether > buffer.release should be triggered for buffers preempted from subsurface > cache. > > Original change's description: > > [ozone/wayland] Use 4x4 opaque background and stack underlay correctly > > > > Using a 4x4 sized opaque background will not regress performance in > > underlay cases because the root surface is still opaque. The background > > will be stretched out by wayland viewporter extension. > > > > This is 6/? CL for overlay forwarding using wl_subsurface. > > > > Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 > > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#810527} > > Change-Id: I7ecbc27a82598479f7131b5645dfe96136d227a1 > Bug: 1133195, 1063865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442137 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819226} TBR=rjkroege@chromium.org,msisov@igalia.com,fangzhoug@chromium.org Change-Id: I8a4b069f29a20ba9bcd38e0f37cc29651e960d75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133195 Bug: 1063865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490858Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819674}
-
Kenichi Ishibashi authored
Hide it behind ServiceWorkerStorageControlImpl as a preparation for the Storage Service move. Bug: 1055677 Change-Id: Ia672decab9670c662470c26fbd83d25f6361274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477141 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819673}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603302740-e55fee2d2ced5621a041f91ab31ac53e5d576c91.profdata to chrome-linux-master-1603322998-a2bfaa167e3697b2b14734e406c0399abff8eaf1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I479ad9a6ba5795e45aaeb0c5f42a59cfc9961bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491480Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d 2020-10-21 treehugger-gerrit@google.com Merge "Fix RAIL_MODE_LOADING->LOAD in RAIL Mode query" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4b0500f6c502e046b04116d29e513ff95b562b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489755Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1d63011799833cb8a46cf7cf6c8c77936a87ed3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490351Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/45b6de9149c1..22505a5afe1f 2020-10-21 enga@chromium.org Fix systemName output on Mac/iOS 2020-10-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 0ce070474164 to 8f7c80347dc6 (1 revision) 2020-10-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4f79c8405028 to 0ce070474164 (1 revision) 2020-10-21 dsinclair@chromium.org Update type for atomic. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I6caf6c5b83495d5207835aab9fe7da8c6da01d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491049Reviewed-by:
-
Andrew Grieve authored
This reverts commit 49fdeca1. Reason for revert: Breaking presubmit due to stale .pydeps file: android_webview/tools/run_cts.pydeps Original change's description: > Android: Use locally-build devil deps only when build_with_chromium=true > > Bug: 1120190 > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819489} TBR=agrieve@chromium.org,bpastene@chromium.org Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819668}
-
Thomas Lukaszewicz authored
This fixes a bad revert of the tab strip in the below CL https://crrev.com/c/2487252 Bug: 1099917 Change-Id: Ied10f472e699daadb280640f7455fc3685cb9826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490490Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819667}
-
Peter Kasting authored
Bug: 772945 Change-Id: I5b0720ca91cee30529e893ffa5924a9ada68f451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490324 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819666}
-
Jinsuk Kim authored
Add a new watch definition 'android_toolbar' and a list for watching chrome/browser/toolbar java package. Change-Id: I1cc0ffa66d59abe55974f73700a14b62ec21e59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490963Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819665}
-
Reilly Grant authored
Bug: 707640 Change-Id: Ic48094a645da16c1c59e5403aabd2f4a0ee6218b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490762 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#819664}
-
Nina Satragno authored
Calculate the pin param based on the hash of the set parameter instead of the raw value. Bug: 1114875 Change-Id: I1b443e4ce5d932445ae1e6bf965e5aee1b878369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487460 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#819663}
-
Francois Doray authored
28-days of Beta experiment revealed no regression: go/onecopyrasterbufferplaybacknormalthreadpriority-beta-results Bug: 1072756 Change-Id: Ib2e06e1e748073321ca37618b2466a2880b12ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485590 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#819662}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.27 TBR=estaab@chromium.org Bug: 1041619 Change-Id: Ife0f4a802666a3836c26eb8657b3b99f15a3de50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490925Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819661}
-
Josh Simmons authored
1) Tests were failing on pie-rel bots because swarmed builds do not include API keys. I've updated the tests to set a flag to ignore these missing keys. 2) Tests were still flaking quite a bit due to batching and state not being cleared between runs. I've tried a couple things (enabling extensive clearing, opening new tabs and closing tabs after tests) but the only way I've been able to get them to run without flakes is by disabling batching. I'll need to dig into translate internals to determine what the right fix is here. 3) Tests were failing the network_service_out_of_process_chrome_public_test_apk phase because, while the network monitor _says_ it has a connection to the internet during these tests, tests run under this configuration will actually refuse to resolve any DNS requests. I've added early returns for when the network service is out of process, but longer term I've opened crbug/1134812 to track the removal of the internet dependency. Similar to #2 this will take digging into Translate internals to make them more testable. BUG=1141160 Change-Id: I4cac8deed71235c2e2da6a6a690edbbaed047b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461711 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#819660}
-
Jinsuk Kim authored
Made HomeButton work without dependency on chrome.browser.homepage classes. All the deps are now deferred to ToolbarManager. The dependencies are injected not through ctor but init method introduced in this CL since the home button and the enclosing view (ToolbarLayout) are instantiated from xml. Menu handling logic was moved to HomepageManager to make it test- friendly. Also removed a bunch of dead code in HomeButton. Several public setters (ActivityTabObserver, ThemeColorProvider, StartSurfaceSupplier) were used by BrowsingModeBottomToolbarCoordinator only (see https://crrev.com/c/1981099). There's no callsite left any more as the class was already gone. Bug: 1127732 Change-Id: I56b8cc200d79a2790f0fd81b515bbe0d41fe5d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459428Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819659}
-
Jinsuk Kim authored
This CL is a speculative fix that adds null checks against the native pointer before calling into native layer. The native pointer gets nulled out when the native object is destroyed, so this can help avoid potential UAF. Bug: 1131346 Change-Id: Ie27dc55f308d64638ff09b5bcdbeb53ef2f8edde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483740Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819658}
-
Morten Stenshorne authored
Certain source files here depend on generated core files, such as core/css/css_property_names.h . Expressing this dependency without causing linker errors is tricky. This solution is based on CL:2489922. Bug: 1140604 Change-Id: I91932db7d3df4ce517950e0bd2c747e4468cef69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488560 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819657}
-
Ben Pastene authored
This moves the remainder of the tests in pool=chromium.tests.cros.vm to the main test pool by applying the magic named-cache optional-dimension to every test/bot that uses the 'chromeos-amd64-generic' mixin. Bug: 1132206 Change-Id: I94dcaecdb21f2a8b36c432273ef7dc0ae690f4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490549Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#819656}
-
Chong Gu authored
Bug: 1141040 Change-Id: I80a3482481762231b35a7cba82bb3781f6706b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490331 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
-
Kartik Hegde authored
Add the DnsResolution routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied DnsResolution changes and successfully ran the DnsResolution routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=dns_resolution). Change-Id: If10388526b50c05aab047ba30d00642d28c9e079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345005 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819654}
-
Shakti Sahu authored
This CL adds 1 - Country code flag for testing 2 - Instant fetch flag to fetch on startup 3 - Don't show the IPH card if there are no tutorials 4 - Fixed a UI bug in chrome://translate-internals where it doesn't allow overriding the country code when country code is undefined. Change-Id: I2277b2844c78278cfe91b15d56c1c0c9a52da326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490545 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819653}
-
Yue Li authored
The current annotation model does not work well with non-English words. Prioritize translation to solve the issue. Also increase the translation text length threshold. Bug: b/158509369 Test: Run existing tests Change-Id: I7316a55f934f570f5c035ced35b03369717a160f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487540Reviewed-by:
-
Brandon Wylie authored
Bug: 1123209 Change-Id: I9115677e06b9e2ca8486c028f005f757b7a33ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490338 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Tom Anderson authored
The X server may send unsolicited events (from clients calling XSendEvent() or from new keyboard mappings). So we must check that the event is the correct type before dispatching it. R=dalecurtis Change-Id: Ic3e19f7da1415c358991609c9b016bd60ead2038 Bug: 1140927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490674 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819650}
-
Xing Liu authored
This CL obsoletes the following metric: Notifications.Announcement.Events. Bug: 1130635 Change-Id: Id5fd616571e3b3c59b9bed483aa02e2c97b4b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486031Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819649}
-
