- 04 Jan, 2017 40 commits
-
-
rtoy authored
Only the tests using Audit are converted here, using the script: for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(".*")\|finishJSTest()\);[ ]*/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f done Additional manual changes were needed to replace methods defined by js-test. Expected results files also removed. BUG=676355 TEST=audiobuffer-copy-channel.html, audiobuffer-getChannelData.html Review-Url: https://codereview.chromium.org/2593083002 Cr-Commit-Position: refs/heads/master@{#441383}
-
joedow authored
This change adds retry logic for applying resolution changes when the session is first started. The RDP API we rely on can return E_UNEXPECTED for a few seconds after the user logs in. This is not documented on MSDN but has been experienced by other users of the API. This change adds a timer which is used to retry the resolution update until it succeeds or reaches the max number of attempts. Once the user is logged on, we do not use the retry logic as calls after that point are expected to succeed. BUG=392220 Review-Url: https://codereview.chromium.org/2600623002 Cr-Commit-Position: refs/heads/master@{#441382}
-
avayvod authored
BUG=678108 TEST=manual Review-Url: https://codereview.chromium.org/2614583002 Cr-Commit-Position: refs/heads/master@{#441381}
-
msarda authored
This CL removes the temporary hack to disable the sync confirmaton page on linux and windows as the sync confirmation dialog is browser modal on these platforms and thus the dialog is no longer dismissed on page navigation. BUG=657924 Review-Url: https://codereview.chromium.org/2614703002 Cr-Commit-Position: refs/heads/master@{#441380}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/4741b291f462..fff400a5df03 $ git log 4741b291f..fff400a5d --date=short --no-merges --format='%ad %ae %s' 2017-01-04 tsepez Remove CFX_ArrayTemplate in BC_QRCoderEncoder. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2615533003 Cr-Commit-Position: refs/heads/master@{#441379}
-
asvitkine authored
This was a result of the FRE refactor work for first run experiments, which had moved FirstRunActivity creation to be before native init. As a result of that, the removeBackground() ChromeTabbedActivity ended up happening when the activity was not foreground, which apparently caused the bug. This change fixes it by making the removeBackground() call happen later, when the ChromeTabbedActivity is visible. The logic is such that we do it once both native init and window focus events have been received. BUG=673831 Review-Url: https://codereview.chromium.org/2613573003 Cr-Commit-Position: refs/heads/master@{#441378}
-
rohitrao authored
BUG=None Review-Url: https://codereview.chromium.org/2612733004 Cr-Commit-Position: refs/heads/master@{#441377}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/9ea894b4d030..671163843681 $ git log 9ea894b4d..671163843 --date=short --no-merges --format='%ad %ae %s' 2017-01-03 caryclark fix fuzz Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2615633002 Cr-Commit-Position: refs/heads/master@{#441376}
-
sdefresne authored
Since SigninStatusMetricsProvider::CreateInstance returns a newly created object owned by the caller, enforce this by returning a std::unique_ptr<> instead of a raw pointer. Remove unnecessary calls to base::WrapUnique() after this API change. BUG=None Review-Url: https://codereview.chromium.org/2609213002 Cr-Commit-Position: refs/heads/master@{#441375}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a067dd2f2b17..9e6944a8f310 $ git log a067dd2f2..9e6944a8f --date=short --no-merges --format='%ad %ae %s' 2017-01-04 perezju [dashboard] Do not use --story-filter on webrtc.* benchmarks Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2617483002 Cr-Commit-Position: refs/heads/master@{#441374}
-
sdefresne authored
The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. Also remove the helper method ::IsOffTheRecordSessionActive and directly call the real implementation from BrowserListIOS. Convert naked "new" call initializing std::unique_ptr<> to instead use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)"). BUG=676278 Review-Url: https://codereview.chromium.org/2615433002 Cr-Commit-Position: refs/heads/master@{#441373}
-
nasko authored
This CL prefixes the DidStartLoading and DidStopLoading methods in RenderFrameImpl, so they don't conflict with the WebFrameClient versions which currently start with lowercase letter. As part of the Blink rewrite to match Chromium style, those will be conflicting. BUG=582312 Review-Url: https://codereview.chromium.org/2612653002 Cr-Commit-Position: refs/heads/master@{#441372}
-
kjellander authored
Add third_party/xmllite and third_party/xmpp source repos, which used to be located in third_party/webrtc/libjingle since the code is no longer used by WebRTC; only Chromium. Modifications made: * Include paths in jingle/ and remoting/ are updated to reflect the new location of xmllite and xmpp. * Include paths in third_party/libjingle_xmpp/xmllite and third_party/libjingle_xmpp/xmpp are updated to reflect the new absolute paths to their own headers. * Update previous include paths using non-absolute paths referencing "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp. * Update includes from webrtc/ to third_party/webrtc * Update includes of webrtc/base/logging.h to third_party/webrtc_overrides/webrtc/base/logging.h * Added DEPS file in each folder, to restrict includes. BUG=webrtc:5539 Review-Url: https://codereview.chromium.org/2443903004 Cr-Commit-Position: refs/heads/master@{#441371}
-
perezju authored
Local tests on a svelte device show the test is no longer failing. BUG=676338 Review-Url: https://codereview.chromium.org/2601533002 Cr-Commit-Position: refs/heads/master@{#441370}
-
rohitrao authored
Most of this CL was automated using the following commands: tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType Also renames some methods to have less generic names, now that they are no longer in the ios_internal namespace. BUG=677941 Review-Url: https://codereview.chromium.org/2608253003 Cr-Commit-Position: refs/heads/master@{#441369}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ef5214e..a559520b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2613713003 Cr-Commit-Position: refs/heads/master@{#441368}
-
fmalita authored
This helper no longer provides any scoped/RAII functionalty, and can be replaced with a GetNativeDrawingContext() function. BUG=675977 R=reed@google.com TBR=sky@chromium.org,danakj@chromium.org Review-Url: https://codereview.chromium.org/2613583002 Cr-Commit-Position: refs/heads/master@{#441367}
-
mlippautz authored
- Remove mixin code as we don't support those cases - Remove markAndTraceWrappers as it is not needed anymore BUG=468240 Review-Url: https://codereview.chromium.org/2609383002 Cr-Commit-Position: refs/heads/master@{#441366}
-
davidben authored
Even with a password, the encryption scheme used here is really not what we'd want people to use. This does two things: 1. Cut down on the number of ways to use ExportEncryptedPrivateKey and makes it less likely someone will mistakenly use it for security purposes. 2. When we ported to BoringSSL, we added "raw" versions of PKCS8_{encrypt,decrypt} to account for confusion about two ways to encode the empty password. But PKCS8_{encrypt,decrypt} already handled this by treating NULL and "" differently. Limiting to just the empty password lets us trim BoringSSL's API surface in preparation for decoupling it from crypto/asn1. BUG=603319 Review-Url: https://codereview.chromium.org/2608453002 Cr-Commit-Position: refs/heads/master@{#441365}
-
sigbjornf authored
Switch to using a 'mere' HashSet<> for these event listeners. Mainly done to diagnose GC instability, but removing the use of an involved abstraction like HeapListHashSet<> is something wanted regardless. R= BUG=677654 Review-Url: https://codereview.chromium.org/2609413002 Cr-Commit-Position: refs/heads/master@{#441364}
-
wychen authored
The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 Review-Url: https://codereview.chromium.org/2603573002 Cr-Commit-Position: refs/heads/master@{#441363}
-
perkj authored
It turns out the tests are flaky. TBR=guidou@chromium.org BUG=611620 Review-Url: https://codereview.chromium.org/2615583002 Cr-Commit-Position: refs/heads/master@{#441362}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/661a53a2..0ef5214e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2610153002 Cr-Commit-Position: refs/heads/master@{#441361}
-
gambard authored
Hitting the escape key on the bluetooth keyboard closes the history and the reading list views. BUG=676994 Review-Url: https://codereview.chromium.org/2611543002 Cr-Commit-Position: refs/heads/master@{#441360}
-
msarda authored
This CL adds an observer for the web contents of the sign-in email confirmation dialog and closes the sign-in confirmation dialog when the renderer process is killed. BUG=671983 Review-Url: https://codereview.chromium.org/2603493003 Cr-Commit-Position: refs/heads/master@{#441359}
-
mlippautz authored
In-between TraceEpilogue and performCleanup the write barrier used to fire in the tri-color marking scheme because we eagerly mark but lazily cleanup. This change avoids marking new headers after TraceEpilogue has been called. BUG=468240, 676700 Review-Url: https://codereview.chromium.org/2609883003 Cr-Commit-Position: refs/heads/master@{#441358}
-
rune authored
Found while checking performance for issue 603621. Style sharing is done during style recalc at which point we know that the active style is up-to-date. Instead of using the API for document.styleSheets, compare active stylesheets in ScopedStyleResolver directly. BUG=603621 Review-Url: https://codereview.chromium.org/2610513003 Cr-Commit-Position: refs/heads/master@{#441357}
-
fs authored
SVGAnimateElement (and derived classes) is where 'attributeName' has any meaning. Move setting/updating of the resolved 'attributeName' value there. This allows setAttributeName to be devirtualized. Storage is kept at the SVGSMILElement level because of how it's used at schedule/unschedule time. BUG=641437 Review-Url: https://codereview.chromium.org/2602423002 Cr-Commit-Position: refs/heads/master@{#441356}
-
delphick authored
Use runAfterLayoutAndPaint instead of requestAnimationFrame and setTimeout(..., 0) as it's simpler and will continue to work when setTimeout no longer waits at least 1ms. BUG=402694 Review-Url: https://codereview.chromium.org/2609923002 Cr-Commit-Position: refs/heads/master@{#441355}
-
gambard authored
This CL adds a update_title_time field to the reading list entries, allowing the title to be correctly merged during sync. BUG=675644 Review-Url: https://codereview.chromium.org/2592043002 Cr-Commit-Position: refs/heads/master@{#441354}
-
vitaliii authored
The click based ranker must "forget" history with time, so that changes in the user behavior are reflected by the order in reasonable time. This is done in thic CL using multiplicative click count decay with time. Count overflow is ignored (it is unlikely to happen due to the decay) and a comment is added. BUG=675918,676279 Review-Url: https://codereview.chromium.org/2599293002 Cr-Commit-Position: refs/heads/master@{#441353}
-
sigbjornf authored
R= BUG= Review-Url: https://codereview.chromium.org/2610113002 Cr-Commit-Position: refs/heads/master@{#441352}
-
fs authored
This replaces the "open-coded" (and somewhat compacted) version of a ShadowData structure within DropShadowFilterOperation with an actual ShadowData. While this makes the structure slightly larger, it allows for some additional code-reuse - mostly around style resolution. It's also a first step against more correct handling of the 'currentcolor' value within the drop-shadow(...) filter function. There's a slight change in behavior since ShadowData stores the relevant values as 'float' rather than as 'int' like the "open-coded" version. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2609803002 Cr-Commit-Position: refs/heads/master@{#441351}
-
pasko authored
BUG=none Review-Url: https://codereview.chromium.org/2602413003 Cr-Commit-Position: refs/heads/master@{#441350}
-
mlamouri authored
Per spec. Also, because the dictionary has a default value for each field so passing {} or no parameter should have the same effect. BUG=677955 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2614463002 Cr-Commit-Position: refs/heads/master@{#441349}
-
jschuh authored
TBR=tsepez Review-Url: https://codereview.chromium.org/2614643002 Cr-Commit-Position: refs/heads/master@{#441348}
-
atotic authored
Connects ng_block_algorithm with ng_absolute_utils. block_algorithm collects all the oof blocks, and positions them using ng_out_of_flow_layout_part. Future work: 1) use ResolveInline/Block Length to compute width/height inside ng_absolute_utils. This is needed to properly resolve MinContent/MaxContent lengths. 2) Investigate what happens when out_of_flow blocks cross the old/new layout boundary. There might be cases we are not handling. 3?) Unify ComputeAbsoluteHorizontal and ComputeAbsoluteVertical. They are almost the same function (Ian would like this). BUG=635619 [ng_place] Review-Url: https://codereview.chromium.org/2568743005 Cr-Commit-Position: refs/heads/master@{#441347}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b106f795..661a53a2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2610123002 Cr-Commit-Position: refs/heads/master@{#441346}
-
philipp.hancke authored
This maps the internal names of the values in the iceConnectionStateChange, iceGatheringStateChange and signalingStateChange to their equivalents defined in the specification. This is only done before displaying the values in order not to change the format of the JSON dump. BUG= Review-Url: https://codereview.chromium.org/2602603002 Cr-Commit-Position: refs/heads/master@{#441345}
-
jbriance authored
Allow a user to make a Chromium build where binaries and shared libraries are meant to be installed into separate directories, like /usr/bin/chromium and /usr/lib/chromium for instance. It is useful when a build system that generates a whole target root filesystem (like Yocto) is used on top of gn, especially when cross-compiling. Note: this gn arg is similar to gyp target_rpath generator flag. BUG=none Review-Url: https://codereview.chromium.org/2605673002 Cr-Commit-Position: refs/heads/master@{#441344}
-