- 22 Oct, 2019 40 commits
-
-
Andrew Grieve authored
Was hitting this locally: 2019-10-22 04:06:38 -0400 ERROR at //chrome/android/BUILD.gn:2339:11: Assignment had no effect. 2019-10-22 04:06:38 -0400 "monochrome_public_bundle.android_manifest.failed" 2019-10-22 04:06:38 -0400 ^------------------------------------------------- Bug: 1011227 Change-Id: I850fc129d8c2e1c7190266735f2fab97f7efebc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873240 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708221}
-
Mike Wittman authored
This class is POSIX-specific rather than Android-specific. Treating it as such will facilitate build configuration for future Android/Linux profiler work. Adds a StackSampler stub for iOS to avoid a dependency on ThreadDelegatePosix since that platform doesn't have pthread_getattr_np. Also cleans up some out of date comments. TBR=gab@chromium.org Bug: 988579 Change-Id: If4df5da23f4ba9664f33a097c5387f6725b8301d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854502 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#708220}
-
minch authored
Bug: 1002733 Change-Id: I79cff30c75781b5bb99aaf6d9d9a613506a23e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872446Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#708219}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ec0e215bc4a..0dbd897b2d65 Created with: gclient setdep -r src-internal@0dbd897b2d65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic2e1cc9991d01ceb916f649056deac0d1cfff6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873868Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708218}
-
Andrew Grieve authored
Bug: 1016766 Change-Id: I822ed63030f2af290141f95e05829647d0fd30f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872733 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708217}
-
Steven Bennetts authored
This add 'gzip' compression to a handful of 'about' pages. Confirmed that these load OK and that there are no unusual references to the IDR constants in the code. Bug: 965089 Change-Id: I2feef1291e50583009c370133d6af0f9cdecf8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873145 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708216}
-
Vadym Doroshenko authored
The problem is that success of submission is checked in any call of OnPasswordFormsRendered for any frame (which is called on DidFinishLoad for a frame). And if a not related frame is loaded it might lead to check of submission. This CL fixed it by checking only the main frame and the frame of the form. Bug: 1015793 Change-Id: I3e17736f20dcb0ebea70b50ec618c6820e8fc429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871511 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#708215}
-
Tomasz Wiszkowski authored
All platforms are shifting weather icons to Material design. This change introduces weather fallback icon for Android (consistency). Bug: 955558 Change-Id: Ic7d640d6b18d9be25da9907b62ee38ce6e2cdf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872992 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#708214}
-
Mirko Bonadei authored
This is a reland of 7777033e This should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1872785/1..2. Original change's description: > Introduce an empty WebRTC component. > > While testing the WebRTC component build in [1], there was a problem > with some testonly code Chromium depends on (which cannot be part of the > WebRTC component). > > In order to support this use case, [2] will make the testonly code > needed by Chromium depend on the WebRTC component and this CL is needed > in order to land everything in an incremental fashion. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961 > [2] - https://webrtc-review.googlesource.com/c/src/+/157427 > > Bug: webrtc:9419 > Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707985} Bug: webrtc:9419 Change-Id: Idca3459d4abe35e7a2b4a646bb4fe336fb2d419d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872785Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#708213}
-
Ella Ge authored
This reverts commit 1b9a5e97. Reason for revert: test failing on linux-trusty-rel bot: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/3887 Original change's description: > Revert "Disable flaky system_health.memory_desktop/browse_accessibility:media:youtube" > > This reverts commit 02b03541. > > Reason for revert: Test no longer appears to fail. > > Original change's description: > > Disable flaky system_health.memory_desktop/browse_accessibility:media:youtube > > > > TBR=perezju@chromium.org > > > > Bug: 983326 > > Change-Id: I22be996f9054935f378a05b95f7f7924a9c5f63b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699097 > > Reviewed-by: danakj <danakj@chromium.org> > > Commit-Queue: danakj <danakj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#677130} > > TBR=crouleau@chromium.org > > Bug: 983326 > Change-Id: If9cb5e9a1d674e49709edbbee4dd2ceafe5bb21b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871998 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708139} TBR=perezju@chromium.org,crouleau@chromium.org Change-Id: Ibdecece827edcd82efbfba5261e53c0a8e5585fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874054Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708212}
-
Arthur Wang authored
R=jbudorick@chromium.org Bug: 1016804 Tbr: obrufau@igalia.com No-Try: true No-Tree-Checks: true Change-Id: Ic22d9998c1afc57b9cb060d05cbda8aecd8ca491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872307Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708211}
-
Łukasz Anforowicz authored
This reverts commit 2875b7b9. Reason for revert: Seems to cause build failures - see https://ci.chromium.org/p/chromium/builders/ci/ios-device/139149 Original change's description: > SuperSize: 3x speedup by minimizing string allocations > > The previous bottleneck was allocating a million std::strings, so the > obvious fix is to not allocate a million strings - after unzipping the > .size file into a 100MB character buffer, we can insert null terminators > so that pointers into the middle of the buffer scan as symbol names. > > Hosting the website locally this brings the WebAssembly parsing time > down from 6s down to 2.2s. Considering that we're unzipping a 130MB file > and parsing it, I don't anticipate future big optimizations without > parallelizing parsing. > > Bug: 1011921 > Change-Id: I43eea11bda87012c40b47457457c6c649631df0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863362 > Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708208} TBR=huangs@chromium.org,agrieve@chromium.org,jaspercb@chromium.org Change-Id: I7b92b476f48bc21d57ee4c94a783aef51e20e3c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874051Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#708210}
-
Andrew Grieve authored
Before: * ninja chrome_public_apk_incremental After: * gn gen --args='incremental_install=true ...' . * ninja chrome_public_apk Why make this change? * Simpler mental model (e.g. most other build things use GN args) * Reduces the load on bots that build all targets * "gn gen" on my machine goes from 7200ms -> 6500ms Bug: 1013688 Change-Id: I62c7c1cea2002a6932867ebf91b31ffbaa8d6a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856438 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#708209}
-
Jasper Chapman-Black authored
The previous bottleneck was allocating a million std::strings, so the obvious fix is to not allocate a million strings - after unzipping the .size file into a 100MB character buffer, we can insert null terminators so that pointers into the middle of the buffer scan as symbol names. Hosting the website locally this brings the WebAssembly parsing time down from 6s down to 2.2s. Considering that we're unzipping a 130MB file and parsing it, I don't anticipate future big optimizations without parallelizing parsing. Bug: 1011921 Change-Id: I43eea11bda87012c40b47457457c6c649631df0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863362 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#708208}
-
Xiaoqian Dai authored
When swiping up on the shelf to go to homescrene, the active window should collapse into its associated app item bounds. If the app item is not visible on the home screen, it should collapse into the center of the app grid. Bug: 997885 Change-Id: I40bb8c1b190958049044f6dbea823a31e7e02578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871897Reviewed-by:
-
Brian White authored
Change-Id: Ib63a04cc663011872f60bd04be420b3207dffb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869451 Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#708206}
-
Donn Denman authored
Moves the vertical centering of the text and other content such as icons in the Bar by centering them the space below the Drag handle instead of the whole Bar height. BUG=1013333 Change-Id: Ib02b3d434e4f8ed2e4065b8f42219f0372c3f14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854362 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#708205}
-
Maks Orlovich authored
We're becoming picker about 1st party vs. 3rd party distinction, requiring explicit marking, so adjust tests. This doesn't help some of the metrics tests in URLRequest Bug: 1016512 Change-Id: Ib07d460840d7c7796810b57b0ee95d8676b7bb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872638 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#708204}
-
Felipe Andrade authored
Kerberos credentials manager should notify observers if at least one of the account addition succeed. Howerver, there should be at most one notification for a given list of accounts added. This CL adds a flag to manage this notifications. Change-Id: I6f40ed930dd98e9f760a9de9869452d94cec4295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871881 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#708203}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e3dcc758ca56..62b5cdc733cc git log e3dcc758ca56..62b5cdc733cc --date=short --no-merges --format='%ad %ae %s' 2019-10-22 vapier@chromium.org cgpt: fix output handling Created with: gclient setdep -r src/third_party/chromite@62b5cdc733cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic27bb11d84bebeea4c98270151630c535a41c80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708202}
-
Istiaque Ahmed authored
ScopedWorkerBasedExtensionsChannel was introduced recently to centralize worker's channel requirement for test. However, some tests are still using manual channel override with ScopedCurrentChannel, this CL updates them. This makes moving SWs to different channel in future easier. Bug: None Change-Id: Iacc9faa2dbaf3569c0988893c1c542c19800e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869016Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708201}
-
Stephen McGruer authored
This test is blocking the WPT importer, as it generates different output every time it fails. I'm not sure if it ever passes, but in the interest of getting the importer unblocked marking pass/fail. Bug: 1016762 Change-Id: Ibe8f5220ba55531ff4610da3ec6fdacc3074b1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873237 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#708200}
-
Henrique Nakashima authored
More logic related to tabs will be moved to TabFeatureUtilities in follow-ups. Bug: 1012975 Change-Id: Ib4aa13e2cc94340b733326140656c48d0a5e52c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857581 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708199}
-
gogerald authored
Bug: 1016548 Change-Id: I5ec93b4081bc29c7a10b657859a9ff4e775e91d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872421Reviewed-by:
-
Juan Antonio Navarro Pérez authored
Revert "Disable flaky SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/play:media:soundcloud:2018" This reverts commit e955ed2d. Reason for revert: Attempt to gain more debug information. Sheriffs: Please do revert this CL if flakiness reoccurs. Original change's description: > Disable flaky SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/play:media:soundcloud:2018 > > TBR=perezju@chromium.org > > Bug: 987858 > Change-Id: I7dbd4dc300f38c9aacad4a214a6618c8120e0dd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722578 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681723} TBR=perezju@chromium.org,rakina@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=crouleau@chromium.org Bug: 987858 Change-Id: I805d54768ca7eb571bef2bb0602fae8898d0236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872101 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708197}
-
Dave Tapuska authored
As outlined in https://docs.google.com/document/d/1QO99UstlPTY8eK4Lnc9qcNq3wQYTBDBsRZu6nGC4XG4/edit Create a RemoteFrame mojo interface in blink so the browser can talk directly to the RemoteFrame in blink. Since there aren't any other mojo interfaces on the remote frame in blink this required a bunch of InterfaceRegistry plumbing to be added. This change also moves the first message over WillEnterFullscreen. BUG=1008432 Change-Id: Ib386cdbf1de595dd622e6942e4ed4c3378a912f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865473 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#708196}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3f8ac37e468..e25df6cf7879 git log f3f8ac37e468..e25df6cf7879 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 kjlubick@google.com [canvaskit] Expose Malloc to save copies in some places Created with: gclient setdep -r src/third_party/skia@e25df6cf7879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I8c22d54a01764dfb49bc3e31a383a3dd083a70c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873865Reviewed-by:
-
Francois Doray authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1804786. The difference is that we don't check thread priority in angle_deqp_tests_main, as these tests do change thread priority on purpose. This CL verifies that the thread priority is normal when a test process is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931706). TBR=sky@chromium.org,michaelpg@chromium.org,thakis@chromium.org,eseckler@chromium.org Bug: 931706 Change-Id: I92a827d014278b1f5b3504f48c2441ad2e83bc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865405Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/528a03441eac..d15a0283d1d8 git log 528a03441eac..d15a0283d1d8 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 danilchap@webrtc.org Hide deprecated SingleThreadedTaskQueueForTest behind an accessor Created with: gclient setdep -r src/third_party/webrtc@d15a0283d1d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I8630a14ca5ba5d16c6e3c9c6b78ce7a8aa07fd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873866Reviewed-by:
-
Ionel Popescu authored
The UI for time picker is updated to support high contrast by using the forced-colors media query. The in-page icon is also updated to work correctly in HC. Bug: 1015096, 1015097 Change-Id: I6eb44b0072239950804a185059de603379c3de9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869354 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#708192}
-
John Delaney authored
There are a few tests in AdsPLMO that still create a mock noise provider with 0 noise, even though this is now the default for all tests after https://crrev.com/c/1849130 .These tests landed shortly after that change. Change-Id: Icd8a1468b38a2943dcf94f148249a5e6f0ba96c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869471Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708191}
-
ckitagawa authored
As noted in crbug/1010396 dropping hints breaks some CJK Freetype fonts. Disabling this will slightly increase subset font sizes for fonts that rely on bytecode hints. However, this seems to be uncommon based on the discussion in the bug. Change-Id: Ib2a621ebfcfad3fbc015f50ec7c5bf3b18e6fa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873238 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#708190}
-
Elly Fong-Jones authored
This dialog gets its strings from an ExtensionInstallPrompt::Prompt, via the Get{Accept,Abort}ButtonLabel methods. Those methods, in turn, depend on two fields of Prompt: type_ and extension_. Better yet, type_ is already const. I attempted to make extension_ const but wasn't able to do so. Instead, this change relies on the current behavior of that class, which is that it is always used like this: auto prompt = make_unique<Prompt>(); // somewhere else: prompt->set_extension(...); // yet a third place: ShowDialog(..., std::move(prompt), ...) Not all the places where Prompt is constructed have ready access to the extension it will eventually represent, which makes passing the extension as a constructor parameter to Prompt infeasible. Rats. This change calls the prompt from ExtensionInstallDialogView's constructor to get the appropriate button labels and apply them. Bug: 1011446 Change-Id: If4ceff51f3aa4a5ca3cb8c3013954748377c8544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872420Reviewed-by:Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708189}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/704ce5c7..0b40cfb3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I310c508378eacad976e34712b7b2c9813743869e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871905Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708188}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4191602bb51..bfdfc7ac4118 git log c4191602bb51..bfdfc7ac4118 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 perezju@chromium.org [Telemetry] Stricter check on Tracing.requestMemoryDump response Created with: gclient setdep -r src/third_party/catapult@bfdfc7ac4118 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:987858 Change-Id: I2cdb495564f320c08857ef546f3e54e64357bb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871648Reviewed-by:
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/acb77af66d..2c3fbc1c99 TBR=bmeurer@chromium.org Change-Id: Iea5088922dbaf74235d7fa67b52e312ae684dc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871886Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708186}
-
Martin Robinson authored
This will ensure that Orca knows to properly move the text caret after anchor navigation even when Chromium-based text caret navigation is disabled. Normally, this is handled by the sequential focus navigation starting point, but this value is not propagated to the accessibility layer. Bug: 1011942 Change-Id: I21d2cde59e12f8aff212b2d9bf3700dad27242c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871887 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Auto-Submit: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#708185}
-
Gyuyoung Kim authored
This CL applies new Mojo types to VideoSourceProvider interface. - Replace MakeStrongBinding with MakeSelfOwnedReceiver. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Replace std::find_if with a for-loop. - Replace mojo::Binding with mojo::Receiver Bug: 955171 Change-Id: I9ce0a8a075b84ce4f65a6ebd79e025e598faa3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863795Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#708184}
-
Ruslan Burakov authored
Intent to ship here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4W4orKqA3Rs This concludes origin trial for RTCJitterBufferDelayHint described here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Tgm4qiNepJc We embed it to RTCRtpReceiver under different name - playoutDelayHint. The spec describing it can be found here: https://henbos.github.io/webrtc-extensions/#dom-rtcrtpreceiver-playoutdelayhint Bug: webrtc:10287 Change-Id: I24edf1b6146a0ad1c8d979833e53a27617af44af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836508 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#708183}
-
Francois Beaufort authored
Following Web NFC spec change at https://github.com/w3c/web-nfc/pull/303, this CL makes sure NFC is not suspended when frame loses focus. http://crrev.com/c/1862475 added a focused test but it wasn't working. Later http://crrev.com/c/186439 fixed it and added a timeout test expectation. This CL removes it as focus is not a requirement anymore. Bug: 996250, 520391 Change-Id: I6b5d14796dc00c8d3c8634dd9caac6da337df10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764132 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#708182}
-
