Commits · 018df572c1c7c0fb0821d0f60f152e0435e52129 · eriksson monteiro / tangled

06 Apr, 2020 40 commits

Update V8 to version 8.3.110.3. · 018df572

v8-ci-autoroll-builder authored Apr 06, 2020

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1668abdd..7fc37290

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I85458429f762a24460450921e106ec7aae288124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136249Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756630}

018df572

Add support for WPT crash tests & TestRendered events to blinkpy · 50774260

Stephen McGruer authored Apr 06, 2020

This registers 'crashtests' as a known type in WPTManifest, and
alters SingleTestRunner to ignore their output and just look for
crashes when running them.

On the content_shell side, it adds support for the 'test-wait'
class on the root element, as well as firing the TestRendered
event (which was already part of reftests but also not
supported in content_shell!)

See https://web-platform-tests.org/writing-tests/crashtest.html

Bug: 1058042, 1028631
Change-Id: Ib467593afe735e334ce44a412f4435454dccd034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133378Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756629}

50774260

fix: add a missing data dependency · b3aaa794

Richard Townsend authored Apr 06, 2020

Our Windows on Arm testing setup relies on using GN to extract the
runtime_deps of each test suite. All but one test
(PrefetchStoreSchemaTest.TestCreateOrMigrate) pass once this is added
(the remaining failure is because different line-endings are used on
Windows).

Change-Id: I754d0d9c001ebd16b474fe7dcfad83850d16e003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107869Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#756628}

b3aaa794

media/gpu/v4l2: add and use V4L2Device::DequeueEvent() · 0127af1e

Alexandre Courbot authored Apr 06, 2020

Add a method to try and dequeue and event from a V4L2 device, so clients
don't need to call the ioctl directly.

BUG=b:149663704
TEST=vdatest passing on Hana.

Change-Id: Ib6a30f3003dde603b5dee2e9c2a7c26ea02ba260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131432Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756627}

0127af1e

Roll src/third_party/dawn c00163ba0925..c7f454c24191 (4 commits) · 368974e7

chromium-autoroll authored Apr 06, 2020

https://dawn.googlesource.com/dawn.git/+log/c00163ba0925..c7f454c24191

git log c00163ba0925..c7f454c24191 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 cwallez@chromium.org Revert "D3D12: Stage BindGroups on CPU descriptor heaps."
2020-04-03 hao.x.li@intel.com Roll third_party/shaderc/ f085b9745..f175adffa (4 commits)
2020-04-03 enga@chromium.org Support chained extension structs on the wire
2020-04-03 bryan.bernhart@intel.com D3D12: Stage BindGroups on CPU descriptor heaps.

Created with:
gclient setdep -r src/third_party/dawn@c7f454c24191

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia414a4180f5e3faf54788fca1954cab620680a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137135Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756626}

368974e7

[iOS] Prevent Text Zoom from closing FIP unexpectedly · 95815078

Robbie Gibson authored Apr 06, 2020

The root cause here was that [textZoomCoordinator stop] was being
called as part of some routine cleanup, and -stop was dismissing the
presenter, despite the presenter not presenting the coordinator's VC.
Now, the coordinator only dismisses the presenter if it is presenting
its own VC.

Bug: 1067526
Change-Id: I06372272f0651a36dec2e7bfdf18fce61d049488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134256Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#756625}

95815078

[css-filters] Migrate background-image-blur-repaint.html test to WPT · 5626d004

Mario Sanchez Prada authored Apr 06, 2020

Migrate this test out of third_party/blink/web_tests/css3/filters
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Note that this test depends on the runAfterLayoutAndPaint() helper
function from run-after-layout-and-paint.js, which is based on
testRunner. Thus, this migration also includes the required changes
to the test to implement the same functionality in the reftest,
that is, relying on two chained runs of requestAnimationFrame()
to make sure that at least one frame has been rendered and then
using <html class="reftest-wait"> as described in [1] to make
sure we don't take the screenshot until the desired changes have
been made (i.e. shrinking a box, in this particular test).

Last, a new file in external/wpt/css/filter-effects/support has
been added as required by this test, as well as by many other ones
under css3/filters that will be migrated in the future.

[1] https://web-platform-tests.org/writing-tests/reftests.html?highlight=reftests#controlling-when-comparison-occurs

Bug: 1063749
Change-Id: Iebc5db044597853ab47d723337c6235a84f9cf5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134297
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756624}

5626d004

Roll src/third_party/freetype/src 13c0df80dca5..7a019a63ed97 (1 commits) · e988e5cb

chromium-autoroll authored Apr 06, 2020

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/13c0df80dca5..7a019a63ed97

git log 13c0df80dca5..7a019a63ed97 --date=short --first-parent --format='%ad %ae %s'
2020-04-04 ramakrishnan.nikhil@gmail.com [woff2] Return if single stream operation fails.

Created with:
gclient setdep -r src/third_party/freetype/src@7a019a63ed97

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Bug: None
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I337bae0fada9b149b7dc7244219c7a4d7c35cacb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135914Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756623}

e988e5cb

heap mojo: migrate presentation_controller_receiver_ · 3fdb86f3

Johann authored Apr 06, 2020

Use the HeapMojoReceiver wrapper so that Oilpan will GC the object.

BUG=chromium:1049056

Change-Id: Ifd776d9ab60a46db315ecca41912073921621ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132657
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756622}

3fdb86f3

Roll Fuchsia SDK from 0.20200405.3.1 to 0.20200406.1.1 · c0600176

chromium-autoroll authored Apr 06, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I121b4be86f544e7d8088227e57f45fe9a1e8627b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756621}

c0600176

Roll src/third_party/perfetto 396c6f4d6378..c90c562668d0 (1 commits) · 1fbeb2e6

chromium-autoroll authored Apr 06, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/396c6f4d6378..c90c562668d0

git log 396c6f4d6378..c90c562668d0 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 treehugger-gerrit@google.com Merge "Client API: Gracefully fail data source registration"

Created with:
gclient setdep -r src/third_party/perfetto@c90c562668d0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I51794661535c02145c44af84995484e83e20cc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137361Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756620}

1fbeb2e6

bind-gen: Implement DOMException's prototype chain · 91d1eb91

Yuki Shiino authored Apr 06, 2020

Sets DOMException.prototype.__proto__ to %ErrorPrototype%.

Bug: 839389
Change-Id: Ifba243e49ae7095c73bf094740b3d447f5a53413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135668
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756619}

91d1eb91

[iOS][Credential-Provider] Add default store path. · 98b51f4c

Javier Ernesto Flores Robles authored Apr 06, 2020

Bug: 1045457
Change-Id: I950bf2a89018d22a5c3ffa1e6d2f08e800d72b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137320
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756618}

98b51f4c

Revert "

🛃

Move Custom Tabs example into Chromium." · 25dfa202

Christos Froussios authored Apr 06, 2020

This reverts commit d7a01422.

Reason for revert: Broke compilation on android-archive-rel
E.g. https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10635

Original change's description:
> 🛃 Move Custom Tabs example into Chromium.
> 
> This CL moves the custom_tabs_client_example_apk target into the
> Chromium repo. This means that we can remove the
> third_party/custom_tabs_client dependency.
> 
> While moving the custom_tabs_client_example_apk target, it was updated
> to depend on androidx.browser instead of the Android Support Library.
> Support for browser actions was also removed as Chrome discontinued
> support that feature half a year ago.
> 
> Bug: 980567
> Change-Id: I716658d3407ef28630dea94d75e9f672eca797d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120724
> Auto-Submit: Peter Conn <peconn@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756593}

TBR=yfriedman@chromium.org,twellington@chromium.org,agrieve@chromium.org,peconn@chromium.org,dominickn@chromium.org

Change-Id: Id6e43385725459a51d7b07cce9577ff7d4ee22af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 980567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137325Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756617}

25dfa202

[Sheriff] Disable flaky ProfileMenuClickTest_SyncEnabled on Windows · 7181d0ab

Christos Froussios authored Apr 06, 2020

TBR=rhalavati

Bug: 1068103
Change-Id: I1f1a8b16a4ab49e32c9e571b0fc664c2a30e7901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135624Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756616}

7181d0ab

Roll src/third_party/perfetto d49a958f8fdf..396c6f4d6378 (5 commits) · 15f45a68

chromium-autoroll authored Apr 06, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/d49a958f8fdf..396c6f4d6378

git log d49a958f8fdf..396c6f4d6378 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 primiano@google.com Merge "GN: fix chromium roll."
2020-04-06 ilkos@google.com Handle absence of profile type
2020-04-06 taylori@google.com Merge "perfetto-ui: Change request track data"
2020-04-03 treehugger-gerrit@google.com Merge "Clean up build files"
2020-04-03 joelaf@google.com Merge "Use protobuf from the system if requested"

Created with:
gclient setdep -r src/third_party/perfetto@396c6f4d6378

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:153257273
Tbr: perfetto-bugs@google.com
Change-Id: Iffa4be281c20e585991028e2afccbc235380bc3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137136Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756615}

15f45a68

Migrate PushMessagingBridge to use GC mojo wrappers. · 67dd6c74

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ibc8df682db4772ceedd4ddffbf781058bb7e6465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134098Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756614}

67dd6c74

Roll src/third_party/devtools-frontend/src 7ff61c6fba28..23b1ed62a107 (1 commits) · eb5433d3

chromium-autoroll authored Apr 06, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7ff61c6fba28..23b1ed62a107

git log 7ff61c6fba28..23b1ed62a107 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 wolfi@chromium.org Add infobar about issues panel to console

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@23b1ed62a107

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I25140a99ba41196c783f4f128c2c94b65cbd5460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756613}

eb5433d3

Reenable UsernameChangedAfterPasswordInput_FormSubmitted test. · 889a75ce

Vasilii Sukhanov authored Apr 06, 2020

Fixed: 835865
Change-Id: I2c7dc836036c3316010c5990487bae62f33c80e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135617Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756612}

889a75ce

[Autofill Assistant] Extend AA histogram expirations. · 02e17943

Mathias Carlen authored Apr 06, 2020

These histograms are still needed and used, extending the expiration to
M90.

Bug: 1066009
Bug: 1066010
Bug: 1066011
Bug: 1066012
Change-Id: I4816144528d7925133a07133844057f431bbb8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129546
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756611}

02e17943

CodeGen: Make generated Enumeration classes more useful · 065e3983

Hitoshi Yoshida authored Apr 06, 2020

Makes generated code of IDL Enumeration more useful in following ways;
- Drops declaration of friend operators == and !=.  Those operators
  become able to work.
- Adds == and != operators to compare with other types, e.g. String,
  AtomicString, and char[], in the base class as migration adapters.
- Adds ToString() method to allow CHECK() output the value.


Bug: 839389
Change-Id: I05dbeb2a2f4eae51b67b14ef676941eab93c6862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134002Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756610}

065e3983

Move site settings helpers into WebUI settings folder and extend OWNERS · e4d57011

sauski authored Apr 06, 2020

The recent_site_settings_helper & site_settings_helper files are almost
exclusively used by setting handlers located in the /webui/settings
folder.

This CL moves these files from /webui into /webui/settings so they
are located with the settings handlers that use them.

OWNERship for these files is also extended to include msramek & sauski.

Bug: 1032584
Change-Id: Iffc1179932de87ffb12c98fbbe5a6035fcdb32e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133927
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756609}

e4d57011

BackForwardCache: Remove content::IsInBackForwardCache · 9d1473b1

Hajime Hoshi authored Apr 06, 2020

Use RenderFrameHost::IsInBackForwardCache, which was introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/2073980
instead.

Bug: 1001087
Change-Id: I715eabc805610c6eff8b801ec9a60419582b7c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091325
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756608}

9d1473b1

Move NotifyUISignoutWillDeleteCredentials out of signin notifier · 7347f6a0

Victor Hugo Vianna Silva authored Apr 06, 2020

This CL reverts the changes to PasswordStoreSigninNotifier and moves the
API to new a dedicated class, owned by the PasswordStore. The class is
lazily initialized via a setter method (as it is done for the notifier),
and only for the account store, since that's the only place where it
should be exercised.

Bug: 1060132
Change-Id: I6d78fc5e2c061acb474fec4cf7be7418368fd8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135750
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756607}

7347f6a0

Reland "First browser tests for upgrader dialog" · a478dc51

Nicholas Verne authored Apr 06, 2020

This reverts commit 31a96092.

Reason for revert: Browser test failure only happens for
is_chrome_branded build. Disabled that case only.

Original change's description:
> Revert "First browser tests for upgrader dialog"
>
> This reverts commit 54171d06.
>
> Reason for revert: crbug/1067636 CrostiniUpgraderDialogBrowserTest.ShowsOnAppLaunch failed on linux-chromeos-chrome
>
> Original change's description:
> > First browser tests for upgrader dialog
> >
> > These tests cover the correct behavior on app launch.
> >
> > Bug: 1024693
> > Change-Id: I9808e7492e696f8fea89bf5c7eba49439c9fc5aa
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135091
> > Commit-Queue: Nicholas Verne <nverne@chromium.org>
> > Reviewed-by: Nic Hollingum <hollingum@google.com>
> > Cr-Commit-Position: refs/heads/master@{#756193}
>
> TBR=nverne@chromium.org,hollingum@google.com
>
> Change-Id: I520ae534296f744c59f29aca7cbdaada5dc94327
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1024693
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135871
> Reviewed-by: Owen Min <zmin@chromium.org>
> Commit-Queue: Owen Min <zmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756282}

TBR=zmin@chromium.org,nverne@chromium.org,hollingum@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1024693
Change-Id: I859ced5cc37e9f3248fb9fba4f793db917f8a5cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136981
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756606}

a478dc51

⏱

️ Extend and obsolete various histograms. · 08bf60b8

Peter E Conn authored Apr 06, 2020

Bug: 1066066
Change-Id: I66aabe9dfdd68b5774445aefe45c0da263740a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133979Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756605}

08bf60b8

[webcodecs] Beginnings of VideoEncoder · bc496c93

Eugene Zemtsov authored Apr 06, 2020

- Basic interface without streams
- VideoFrame creation
- Basic web tests

Coming soon: actual calls to a real video encoder.

Bug: 897297, 1045248
Change-Id: I8e29055aa63cdb4d95dbd184437c880052baba6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124294Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756604}

bc496c93

BackForwardCache: Add PageLoadMetricsObserver::OnEnterBackForwardCache · bbc509ce

Hajime Hoshi authored Apr 06, 2020

This CL is a preparation to enable PageLoadMetricsObserver with back-
forward cache. After this CL, PageLoadMetricsObserver lives even after
the page is put into the back-forward cache, but the observation stops
by STOP_OBSERVING.

This CL adds PageLoadMetricsObserver::OnEnterBackForwardCache, which is
called when the page goes to back-forward cache. The default
implementation of OnEnterBackForwardCache invokes OnComplete and returns
STOP_OBSERVING in order to ensure the recorded data is dumped.

In the current implementation, the observer is destroyed when navigation
commits regardless of whether page will be destroyed or stored in back-
forward cache after that. However, even if we change the lifetime of the
observer and the observer lives in the back-forward cache,
PageLoadMetricsObserver should not cause problems thanks to
STOP_OBSERVING.

Bug: 1001087
Change-Id: If133a50baa93f8a313229bffcd5e48bc7463961e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073980
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756603}

bbc509ce

Migrate DeprecatedStorageQuota to use GC mojo wrappers. · f8dca7b4

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: If1be564636cc503e6e3f88edda7122bad1b4013d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135658Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756602}

f8dca7b4

Revert "Add a counter for the number of LayoutNG-based LayoutObject instances" · 1c98130f

Kent Tamura authored Apr 06, 2020

This reverts commit c0b367bf.

Reason for revert: Found that this was an incorrect approach.

Original change's description:
> Add a counter for the number of LayoutNG-based LayoutObject instances
> 
> This CL has no user-visible behavior changes.
> 
> Note that LayoutNG ratio computed by this counter and |LocalFrameView::
> layout_object_counter_| is 55.1% on nytiimes.com.
> 
> Bug: 1067527
> Change-Id: I73e349a6f5daab79c5f4005ffc28997167f35788
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136011
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756573}

TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org

Change-Id: Ib534cb175a327ef6ee0bac05057bdd0b5dcb4d6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1067527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137192Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756601}

1c98130f

[cros colors] Update cros_colors.json5 with some new names/colors. · 586d07b9

Christopher Lam authored Apr 06, 2020

This CL updates cros_colors.json5 with a few new colors from gogoy@ and
changes the comment to reflect the latest thinking on what belongs in
that file.

Bug: 1018654
Change-Id: I285e08ba0db930f7c6110a21c9b302154456c7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126408Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756600}

586d07b9

bind-gen: Update generated file list · f38817b3

Yuki Shiino authored Apr 06, 2020

ScrollTimelineElementBasedOffset is now IDL dictionary, not IDL
interface.

Bug: 839389
Change-Id: I9e8705476d1ad9aaa844b3a372eb3717dc7db3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134035Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756599}

f38817b3

Migrate ContactsManager to use GC mojo wrappers. · 68ba639c

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ie721f00888b7874cb563d84f7216ebe5a984b559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136983Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756598}

68ba639c

Migrate ClipboardPromise to use GC mojo wrappers. · 57c570f0

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ic32ad2f916e83423158bf77e846bd0e21cfafe5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136571Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756597}

57c570f0

bind-gen: Workaround misuse of [HTMLConstructor] in the new bindings gentor · 5cb122f3

Yuki Shiino authored Apr 06, 2020

The current IDL definitions misuse [HTMLConstructor].  Workarounds
it in the new Web IDL database.

Bug: 839389, 1068098
Change-Id: I00905dafeb25392b7d2a910b78e26dfd89316ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136979
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756596}

5cb122f3

Migrate ResourceFetcher to use GC mojo wrappers. · 186f9ae1

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Icb0a4d27b2bc6559642b1735dffcd4211d03190e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136572Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756595}

186f9ae1

Migrate FileSystemDispatcher to use GC mojo wrappers. · a3f2827e

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: I2a4e8323ce14e7f557ff2de93192a0061e879cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136570Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756594}

a3f2827e

🛃

Move Custom Tabs example into Chromium. · d7a01422

Peter E Conn authored Apr 06, 2020

This CL moves the custom_tabs_client_example_apk target into the
Chromium repo. This means that we can remove the
third_party/custom_tabs_client dependency.

While moving the custom_tabs_client_example_apk target, it was updated
to depend on androidx.browser instead of the Android Support Library.
Support for browser actions was also removed as Chrome discontinued
support that feature half a year ago.

Bug: 980567
Change-Id: I716658d3407ef28630dea94d75e9f672eca797d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120724
Auto-Submit: Peter Conn <peconn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756593}

d7a01422

Migrate InstalledAppController to use GC mojo wrappers. · 5f59f88a

Minoru Chikamune authored Apr 06, 2020

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: I50f4ee672c7c94c37655107c4eeab8c8960bd6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134094Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756592}

5f59f88a

[clang-tidy] Fix use-after-move in devtools/InputHandler · c2dd43c1

Zinovy Nis authored Apr 06, 2020

Bug: 995566
Change-Id: Ia71ae2c5b7f423e685d4a88fabc3bc21c22e307a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135694Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Zinovy Nis <zynis@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#756591}

c2dd43c1