- 17 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/df4ef89b8001..0f1656a03a06 git log df4ef89b8001..0f1656a03a06 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 yarneo@gmail.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@0f1656a03a06 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I799559bd1b86c779b7b265a442c11f68a9d2aeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669876}
-
Nicolas Ouellet-payeur authored
This is a reland of r/668010 that fixes some CQ issues. This command-line flag can be used to run the auditor with the `python_script' backend, although it still defaults to the `clang_tool' backend. TESTED= * ran extractor_tests.py (tested on Linux + Windows) * ran `check_annotations.py --complete' before & after adding `extractor-backend=python_script' in it. There is only 1 annotation that gives different output, because of how the script works: https://pastebin.com/gWJ2WSDH (tested both on Linux, only tested python_script on Windows) * changed some annotations in C++ code, and checked that both modes suggest annotations.xml changes (tested on Linux + Windows) Bug: 966883 Change-Id: I47f10434b65fda5233dcdb0063143170a8e9569f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660773 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#669875}
-
Peter Boström authored
Makes the ExtensionToolbarContainer aware of hover, active and other state changes. Uses the plumbing and visual treatment already implemented in ToolbarPageActionIconContainerView. Bug: None Change-Id: I0fa8dbabe15ac2883a5fe4e09d95e07127fe3bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663034 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#669874}
-
Ce Chen authored
We will load the new model and clean up the old one when COMPONENT_UPDATED event from updater is received. Bug: 925072 Change-Id: I7ba69c352e20869aea3f8ea406b39a486a6bed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652628Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#669873}
-
Kyle Milka authored
Explicitly set the size of the browser window so that the customizate button will always appear. Bug: 971853 Change-Id: I61e33767456031d5104554279e1cb19c09a10621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663052Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669872}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b97824d4d1d1..2935638a1b16 git log b97824d4d1d1..2935638a1b16 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 bsalomon@google.com Make SkASSERT not break build in constexpr GrSwizzle method on GCC 2019-06-17 bsalomon@google.com Add function to GrDataUtils to handle color conversions. Created with: gclient setdep -r src/third_party/skia@2935638a1b16 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: Ic85a1c4ea6f395f16b8c5e9e1ce87aa9705078f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662025Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669871}
-
Mason Freed authored
Prior to this CL, src_image->makeSubset() was always called, regardless of whether anything was actually being cropped. Now, it is only called if needed. Change-Id: I9469ac523b6ac365829cc245b1c576eeab7b6e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660781 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#669870}
-
Mike Wasserman authored
Replace mojom with an abstract singleton controller, c++ struct & enums. Update impl & tests, expose a protected static helper for simplicity. Remove an unnecessary test subclass, unit test passes without this. Bug: 958129 Test: Automated; no accessibility focus ring regressions. Change-Id: I34acd91fa9e093309a89edf74e2395d5de5ec2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660107 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#669869}
-
Gil Dekel authored
This CL generalizes some functions in VaapiWrapper that will be shared by all potential implementing classes of VaapiImageDecoder. In addition, this CL refactors (cleans up) the way VaapiImageDecoder initializes the VaapiWrapper member. Bug: 877694 Test: jpeg_decode_accelerator_unittest Change-Id: Ic1fe5a1c4a104ed1cf27533af65f811e7db5e534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660829Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669868}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/fc3777b44c04..a1e3f35842de $ git log fc3777b44..a1e3f3584 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 krishnaniyer97 arm:mc: NEON implementation of blend, blend_h and blend_v function 2019-06-04 lu_zero checkasm: Add an option to benchmark the C code as well 2019-06-04 lu_zero checkasm: Add a --help option to checkasm 2019-06-03 lu_zero checkasm: Add a readtime impl for ppc 2019-06-03 lu_zero Initial PowerPC support 2019-06-10 martin meson: Look for librt if clock_gettime isn't found without it 2019-06-05 jamrial meson: simplify a few checks for x86 targets 2019-06-05 jamrial x86: include config.asm in x86inc instead of every asm file 2019-06-06 martin checkasm: Check for __ARM_ARCH >= 7 for the arm cpu timer inline assembly 2019-06-06 thresh CI: Added ppc64le build and test jobs 2019-05-22 jb Update NEWS for 0.4.0 2019-06-05 tmatth output: automatically use null muxer for /dev/null 2019-06-04 epirat07 meson: Fix nasm detection 2019-06-01 gramner checkasm: Fix out-of-bounds read in warp8x8 tests 2019-05-31 gramner x86: Optimize warp8x8 AVX2 asm 2019-05-24 janne-vlc build: add option for fuzzer specific LDFLAGS 2019-05-23 martin arm: Mark the stack as non-executable on ELF 2019-05-23 gramner Optimize coefficient decoding 2019-05-21 jamrial dav1d: reserve some bytes in Dav1dSettings 2019-05-16 gramner build: Enable SSE2 by default on x86-32 2019-05-16 gramner x86: Enable msac asm on x86-32 2019-05-20 me Update THANKS.md 2019-05-18 me Hard wrap contribs. Add self for logo 2019-05-19 martin ci: Add full testdata tests on aarch64 2019-05-19 gramner checkasm: Update the mc test to check all valid heights 2019-05-19 martin arm: mc: Fix 8tap_v w8 with OBMC 3/4 heights 2019-05-18 gramner Optimize obmc blend 2019-05-17 ltrudeau Remove one multiply in Z2 filter top left 2019-05-17 ltrudeau Reduce branching in intra angle to mode 2019-05-17 ltrudeau small code cleaning in intra_edge init_mode Created with: roll-dep src/third_party/dav1d/libdav1d TBR=chcunningham BUG=none Change-Id: Icc4493c607089696d19f17ae212448168975b202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662833Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669867}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d00e241a16e0..b9797b31f7a1 Created with: gclient setdep -r src-internal@b9797b31f7a1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:972709 TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: Iacaef8cca0ca154e4a68ed458729ea9aa86a8846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662888Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669866}
-
Peter Kasting authored
https://groups.google.com/a/chromium.org/d/topic/cxx/gv7E_n4AnP4/discussion Bug: none Change-Id: I5d787e8965d5d6ed0d5037550405aba0375ba2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661211 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#669865}
-
Sunny Sachanandani authored
An earlier CL (crrev.com/c/1588933) added new GL enums without running build_gles2_cmd_buffer.py. This change wasn't caught by PRESUBMIT because it was a header only change. The PRESUBMIT needs to be fixed to fixed (crrev.com/c/1662711) so that it doesn't reject this CL because it only contains autogen changes without a corresponding change to the generator scripts. TEST=git cl presubmit works Bug: 974337 Change-Id: I0e09893282298574264c5380ae7d10e3fe39fad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660418 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#669864}
-
Tomasz Wiszkowski authored
In cases where Omnibox interaction executes a complete cycle (from highlight to navigate / close) before native code completes loading, we trip UnsatisfiedLinkError causing application to crash. This fix ensures we only attempt to record metrics if we know the Native is initialized. BUG: 971626 Change-Id: Ic0ef632d6da993516170b943ae20e5cda427fd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662840Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#669863}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7e5908802f90..79b2847f611f git log 7e5908802f90..79b2847f611f --date=short --no-merges --format='%ad %ae %s' 2019-06-17 thestig@chromium.org Remove core/fxcodec/codec. 2019-06-17 thestig@chromium.org Move more code out of core/fxcodec/codec. 2019-06-17 thestig@chromium.org Remove core/fxcodec/codec/codec_int.h. 2019-06-17 thestig@chromium.org Move more codec modules into their own directories. 2019-06-17 thestig@chromium.org Move XFA codec code into their own directories. Created with: gclient setdep -r src/third_party/pdfium@79b2847f611f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: If480382460b5384948eed2702608f12bd41a7a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669862}
-
Sunny Sachanandani authored
Current implementation of PRESUBMIT makes it impossible to fix autogen files by running the generator if it wasn't run by accident and missed by PRESUBMIT earlier. New implementation removes this check, and replaces it with a more robust check for running the generator which won't reject changes unless there's an actual mismatch with generator output. TEST=Ran git cl presubmit on CL from running build_gles2_cmd_buffer.py Bug: 974337 Change-Id: Ic812bf44b921fd0718a58b70892b042876e3d357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662711 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#669861}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1d02819..83ce6ba1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54c811146dca716cf17bb51057de288e99903a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662602Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669860}
-
Peter Kasting authored
The caller just wants to check the full container, so do so. Bug: 956419 Change-Id: Ib661e0bce4e9888b0394c7a6961fd68a28f790ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661296Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#669859}
-
Alex Gough authored
- Regularised capitalisation of Windows. - Removed some hemming and hawing about out of support Windows versions. - Tidied a couple of broken links and references. Change-Id: I2e84b9ee6ec83ad77a31f4998273989c9dd1852b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649299Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669858}
-
Johannes Henkel authored
New revision: 83b1154a9661d22bba9a368d368214cc20880419 This updates the usages of the protocol types to the new definitions, using std::vector-based implementations of protocol::Array. - In many places we can now use the C++11 style for( : ) loops. - We use std::make_unique for creation. - We use emplace_back to insert elements, which sometimes allows us to create strings etc. in place. - Accessing strings in arrays is cheaper, since vector[i] returns a reference (protocol::Array::get made a copy!). - One can assert equivalence of vectors with strings in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); - Overall the code is shorter, as the vector API is more concise. Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#669857}
-
Christopher Cameron authored
Bug: 938241 Change-Id: I6e93338c53a5fc407a19d07d2d5b7626bf26afc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659561Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669856}
-
khmel@chromium.org authored
As described TEST=Locally BUG=b/132709527 Change-Id: I94572a590724969e54d865d54bf1f40fc4c7d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662734Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669855}
-
Patrick Noland authored
This means we won't handle AMP pages that don't use SXG(signed exchanges). Trusting the canonical URL blindly has potential privacy risks. Trusting only Google-provided AMP urls is also the wrong solution; we want to rely on the long term solution that is SXG. Bug: 961814 Change-Id: Ib3544e8c478a3a9089d8c7414f7ea42bb65b8794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659511Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#669854}
-
Matt Simmons authored
Bug: 970585 Change-Id: I6c745300316a9548a28e862aa44871c3cdf066a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656810 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669853}
-
Peter Kasting authored
* Unbans std::aligned_storage * Bans string/number conversions * Bans std::weak_ptr The next patch set will default-allow all of C++11, meaning all remaining TBD features will become allowed. https://groups.google.com/a/chromium.org/d/topic/cxx/iH4v7yfKX2A/discussion Bug: none Change-Id: If90aa78a36580dea3c1e77497eb7ebcbdd725e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659968 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#669852}
-
Christopher Cameron authored
Because PWAs (and anything using RemoteCocoa) need an app shim to be running to get anything on-screen, we added code to re-create an app shim if one cannot be launched. But this re-creation wasn't guarded on being a PWA, and as a consequence platform apps would go and create app shims that nobody expected to exist. So let's not do that. Some tests were inappropriately relying on this behavior. Update WebAppShortcutCreator to be more explicit about where it creates and updates its shortcuts. This was previously landed in crrev.com/669111 and reverted in crrev.com/669194. This time, do not re-enable tests in component build (and add comments explaining why). TBR=dominickn (reviewed previous instance) Bug: 941160 Change-Id: I43df81b36682c46eb1535d502c461a39e6cf0395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662910Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669851}
-
khmel@chromium.org authored
This build input tracing model from generic model. TEST=Locally, unit test BUG=b/132709527 Change-Id: Id7997001bf87548f9de04df85a06e2042d5a9e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640702 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669850}
-
Xianzhu Wang authored
This reverts commit 0f75b5b5. Reason for revert: For debugging crbug.com/974639. Original change's description: > Change CHECKs for debugging crbug.com/816810 to DCHECK > > Bug: 816810 > Change-Id: I7d3a9062f940cf0b16350c9cd2d7cae3d95ef152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553807 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647896} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974639 Change-Id: I29aa03beff64b97a36ea0aa727e478310994eeb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662503 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#669849}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibfccd10c3b49d2183c301c6b7705bbb65ec80cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662676Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669848}
-
Eugene But authored
The crash happened because decisionHandler was called multiple times from webView:decidePolicyForNavigationAction: This CL adds early return to avoid extra calls and adds EG test for window.open test case. Bug: 965067 Change-Id: I970aff7313e0c5c52f46de63e62ac3c17d6ca6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661502 Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#669847}
-
Katie D authored
Fades icon to a lower opacity in order that content behind the icon is still partially visible. Per UX request. Bug: 947068 Change-Id: I36d61f461af622c24cb1bf442c823730143e2a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662829Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#669846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bc23ca13f1b3..3390eddc9717 git log bc23ca13f1b3..3390eddc9717 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@3390eddc9717 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I10cd64f6a0f017144c6fa1fb5382a0aa3ce42d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669845}
-
Evan Stade authored
This relands commit 243f71cb. Difference to original: SetQuietMode remains a part of the interface for now. Original change's description: > Mash cleanup: message center part 4. > > This pulls all notifier related code out of AshMessageCenterController > and AshMessageCenterClient into new C++ interfaces > NotifierSettingsController and NotifierSettingsObserver. > > TBR=tsepez@chromium.org,hidehiko@chromium.org > > Bug: 958191 > Change-Id: Ice561f2f1f4e90979847c5f410779a34691926a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653858 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669417} TBR=hidehiko@chromium.org Change-Id: I63dd4a2d46e39609573debd4268436d163b896df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662596Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#669844}
-
Daniel Murphy authored
Refactors the IndexedDBClassFactory: * Moves construction of classes in the leveldb/ directory to the indexed_db::LevelDBFactory to keep separation between the two systems, * stops all calls to IndexedDBClassFactory::Get() except for in the IndexedDBContextImpl to construct the IndexedDBFactoryImpl, and * passes a pointer to the IndexedDBClassFactory (or LevelDBFactory) to classes that need it to construct classes. There are no functional changes in this patch, only refactoring. R=jam@chromium.org, pwnall@chromium.org Bug: 965282 Change-Id: Icda64b9c56522a934827826fdb55fc5d25e35dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636551 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#669843}
-
Aleks Totic authored
Bug: 970166 Change-Id: Ib85e5b819e5870c1867e6c753d9a250ea4e4a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660205 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#669842}
-
Michael Lippautz authored
Bug: 971424 Change-Id: I10c9379d0548ebeebe08e8ad08c69a959076a7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660346Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#669841}
-
Jeffrey Kardatzke authored
These should be stripped from feedback reports. They can appear via 3 different logging techniques. They can be output after a Serialize call in AccountId, assertion failure in construction of AccountId and also via the ostream operator in AccountId. Callers could also get the GAIA ID by itself and log that out, but I didn't find any occurences of that in the source. Bug: 575821 Test: Unit tests pass Change-Id: Ib5241382c88d811471a26628a427b461d90c8d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658937 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#669840}
-
Morten Stenshorne authored
Fails in legacy, though. Must have got added to the expectations file during landing of the rebaseline for NG. TBR=eae@chromium.org Change-Id: I24756c7ccf52e4f11d1e3770fbff079e3224eaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662455Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#669839}
-
Aleks Totic authored
Bug: 974712 Change-Id: I8cd7c9ab91a0722782d444ccece69d705bfe1074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661485 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#669838}
-
Julian Kung authored
The MakeRedImageTestScript function used by the takeElementScreenshot* tests is difficult to understand and would benefit form being abstracted away since the code following it was identical for every test. In this CL MakerRedImageTestScript is replaced in the tests with a new function takeScreenshotAndVerifyCorrect, which calls MakeRedImageTestScript and passes on its output. R=johnchen@chromium.org Bug: chromedriver:2957 Change-Id: Id66c0165acd52a09c1fc9569a2ddbd94970dbdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662589Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Julian Kung <juliankung@google.com> Cr-Commit-Position: refs/heads/master@{#669837}
-