- 26 Feb, 2019 40 commits
-
-
Chris Hamilton authored
This moves the implementation of PageAlmostIdle from PageSignal(Generator|Receiver|Observer), to a new "decorator" that runs directly in the graph. BUG=931407 Change-Id: I1e8c86e34f4cdd224cb3b77c7545debcffc820a4 Reviewed-on: https://chromium-review.googlesource.com/c/1471750 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#635589}
-
Xiaocheng Hu authored
[Sheriff] Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-alphabetic-invalid.html as failure on Mac Bug: 935689 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: Iaf8fc68d5fa7aeea1f81cff12ae165d1fe92f206 Reviewed-on: https://chromium-review.googlesource.com/c/1489306Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635588}
-
Owen Min authored
The new policy sources is used by the cloud policies that have high priority than other policies. Also do some other refactor: 1) Move the CloudPolicyOverridesMachinePolicy pref registy to policy component. 2) Delete policy_helper.h/cc because it's empty. 3) Make policy_ui_handler and policy_conversions share the same instance of PolicyStringMap. Bug: 749530 Change-Id: Ie3a9c9ce87bd78bc9159582eae4d463616fd9aeb Reviewed-on: https://chromium-review.googlesource.com/c/1488011Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635587}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/804f17e35b25..0c48681e58d6 git log 804f17e35b25..0c48681e58d6 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 brianosman@google.com Few more particle features and some generalization work Created with: gclient setdep -r src/third_party/skia@0c48681e58d6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I3fca99ac14e3911dc3bb88bdcba2cfb9e606213e Reviewed-on: https://chromium-review.googlesource.com/c/1489064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635586}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59fd65cbda8c..f53e1f6e2d49 git log 59fd65cbda8c..f53e1f6e2d49 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 khokhlov@google.com Use JS trace model in memory dump tests 2019-02-26 sadrul@chromium.org speed: Look only for the appropriate devices/browsers. Created with: gclient setdep -r src/third_party/catapult@f53e1f6e2d49 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932409,chromium:935578 TBR=sullivan@chromium.org Change-Id: I06a2f51e6421a89e0ff41caa6775babc712c380a Reviewed-on: https://chromium-review.googlesource.com/c/1489252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635585}
-
Olya Kalitova authored
Add progress reporting for unzipping of downloaded PluginVm image archive. This CL also changes signature of OnProgressUpdated method so this method is consistent with the new OnUnzippingProgressUpdated method and not only fraction complete could be reported, but the number of bytes processed as well. Test: unit_tests --gtest_filter="PluginVmImageManager*" Bug: 904851 Change-Id: I66333f3e31ee339673889e39fab7c5da59303142 Reviewed-on: https://chromium-review.googlesource.com/c/1484097 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635584}
-
Nico Weber authored
TBR=jschuh Bug: 926235 Change-Id: I82aef9e11b7943a0d5fa956d0d7ce41b538b1331 Reviewed-on: https://chromium-review.googlesource.com/c/1489135 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635583}
-
Gang Wu authored
No Sizes info for this DEPs roll since the CL https://chromium-review.googlesource.com/c/chromium/src/+/1478174, the CL using FeedHostServiceFactory in internal page's code, and when compile when the Feed disabled, we got compile error. Change-Id: I5cdea66b8fb4ffdc25ec759c59663e644e51ab30 Reviewed-on: https://chromium-review.googlesource.com/c/1487951 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#635582}
-
Nico Weber authored
Bug: 926235,936004 Change-Id: Ie999c91d5f9aed729ff1c1d412af441f64da8fbe Reviewed-on: https://chromium-review.googlesource.com/c/1489138 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635581}
-
Etienne Bergeron authored
This CL is adding the FROM_HERE location of the call sites to each ScopedBlockingCall. This modification will provide the detailed location to the trace events and allow developpers do understand cause of janks of long tasks. This CL is trying to catch most of the call sites using this pattern: ^(\s*)(base::)?ScopedBlockingCall ([a-zA-Z0-9_]*)\((base::)?BlockingType --> \1\2ScopedBlockingCall \3\(FROM_HERE, \4BlockingType Over every .cc, .h and .mm files under chromium. TBR=gab@chromium.org (mechanical change for //base) Bug: 934302 Change-Id: I9b7a573ab84d81cae1b8fc173b6e8ff96155ccb6 Reviewed-on: https://chromium-review.googlesource.com/c/1483834 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#635580}
-
Tibor Goldschwendt authored
Bug: 935527 Change-Id: Icde2604869ee225853104a3bbe62e5948cb93946 Reviewed-on: https://chromium-review.googlesource.com/c/1486672 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#635579}
-
Jan Krcal authored
This CL adds one missing unit-test for reacting to local changes. Bug: 936013 Change-Id: Ie494115465e0c61fca74a101e64ee801daf48675 Reviewed-on: https://chromium-review.googlesource.com/c/1489244 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#635578}
-
Corentin Wallez authored
use_dawn controls whether Dawn and its dependencies are integrated in Chromium to support WebGPU. It currently defaults to false while we work out the details of the integration of Dawn both code-wise and for the launch. BUG=877147 Change-Id: I31c3780e024f325c6dbcd4b89dd809199de8df0d Reviewed-on: https://chromium-review.googlesource.com/c/1488921Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#635577}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/53c8957c337d..024f271ae0c7 git log 53c8957c337d..024f271ae0c7 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 capn@google.com Fix fuzzer build 2019-02-26 capn@google.com Work around x86-64 calling convention bug 2019-02-26 headlessclayton@gmail.com SpirvShader: Decouple SPIR-V type attributes from object representation 2019-02-26 bclayton@google.com Strongly type object / type identifiers. 2019-02-26 chrisforbes@google.com Remove VertexProcessor::multisampling state bit Created with: gclient setdep -r src/third_party/swiftshader@024f271ae0c7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/126126820 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I221df04b5d938a0c892b89780429ec93a9d540a0 Reviewed-on: https://chromium-review.googlesource.com/c/1488833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635576}
-
David Roger authored
The strategy for reconciliation is to always reconcile, and keep the current default Gaia account if there is one, otherwise the first system account. This strategy can be refined later. Change-Id: Ia1e0e1d08e5f071159b07474ab6d56a169822316 Reviewed-on: https://chromium-review.googlesource.com/c/1475405 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#635575}
-
Becca Hughes authored
Add a MediaControllerImageObserver that can observe images of a certain size and type on a media controller. When the controller receives new images from the session it will handle the rank and retrieval so the client does not have to. BUG=914430 Change-Id: Ib6d0fc0b232efc790f3018b6687d969deb7111cd Reviewed-on: https://chromium-review.googlesource.com/c/1464649Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#635574}
-
Juan Antonio Navarro Perez authored
Looking through `git log` it appears these were used in the past for a benchmark that no longer exists. TBR=crouleau@chromium.org Bug: 921000 Change-Id: I8d77e167cf5dc244552bb7ecfdc0f83dadabf9f8 Reviewed-on: https://chromium-review.googlesource.com/c/1489197Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#635573}
-
Tanya Gupta authored
ReceivingUIHandler: Interface that platforms can be implement to update the UI when there is a new or modified share entry. All handlers must be registered through the ReceivingUiHandlerRegistry. ReceivingUiHandlerRegistry: Singleton registry that keeps track of the right handlers for each platform. Called by the SendTabToSelf Client Service. SendTabToClientService: Listens for updates to the SendTabToSelf Model and calls the appropriate handlers to update the UI. Change-Id: I7c366cb42de8f97bb09ca60ca5985af2290fc75f Bug: 901429 Reviewed-on: https://chromium-review.googlesource.com/c/1477754Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#635572}
-
Rune Lillesveen authored
We don't know if there will be any slots added for an attached shadow root. If no slots are added, there will be no slot re-assignment and no other way to inform the shadow host children that their flat tree position changed. LazyReattachLayoutTree will not clear ComputedStyle because it uses true for performing_reattach in AttachContext. Instead call RemovedFromFlatTree which detaches the layout tree and clears the computed style. Bug: 932871 Change-Id: I3dd8f7f3d4b4eb1fb8a745c2849840b1b4c3d89d Reviewed-on: https://chromium-review.googlesource.com/c/1477695Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635571}
-
Matthew Jones authored
This reverts commit 4eb3219b. Reason for revert: Still failing consistently on KitKat Tablet Tester: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Tablet%20Tester Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8920505223364583920/+/steps/chrome_public_test_apk_on_Android_device_Nexus_7__2013_/0/logs/org.chromium.chrome.browser.offlinepages.OfflinePageAutoFetchTest_testAutoFetchRequestRetainedOnOtherTabClosed__status_FAILURE_/0 Original change's description: > Re-enable testAutoFetchRequestRetainedOnOtherTabClosed > > I ran the test 40 times on my local device, and it passed each one. > Hopefully the previous changes to this test file have fixed the flake. > > Bug: 923212 > Change-Id: Ic8b3e6e6b82b60d14bdef9975d5d70e256dcf1b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1470634 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Dan H <harringtond@google.com> > Cr-Commit-Position: refs/heads/master@{#635255} TBR=carlosk@chromium.org,harringtond@google.com Change-Id: I697b84adf6ed3def942aaa0653488d89b8b6107d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923212 Reviewed-on: https://chromium-review.googlesource.com/c/1489095Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635570}
-
Daniel Bratell authored
The target gfx_unittests used the system's fontconfig which stopped working on Ubuntu 16.04 without sysroot when the tests started using FcConfigParseAndLoadFromMemory which is a newly (2017) added fontconfig function. The test should have used third_party/fontconfig all the time but the test didn't have the necessary deps in the build system for that to happen. Follow-up to https://chromium-review.googlesource.com/c/1019978 Change-Id: Ie0dab4632aff454b6c33405d3076c87e226b7e18 Reviewed-on: https://chromium-review.googlesource.com/c/1489237 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635569}
-
Eugene But authored
Dependencies refactoring in a preparation for storing pending navigation item in NavigationContext. This CL extracts wk_navigation_util and navigation_manager_util from core as separate targets. Breaking up core into smaller targets will allow navigation_manager_util to depend on ios/web/web_state:navigation_context without having a circular dependency (navigation_context currently depends on core). navigation_manager_util needs to depend on navigation_context in http://crrev.com/c/1455658/25/ios/web/navigation/navigation_manager_util.mm#10 Bug: 899827 Change-Id: I1aa72fc156ab23aac9124c70ebc5a36b619a6b0c Reviewed-on: https://chromium-review.googlesource.com/c/1486684 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635568}
-
Michael Lippautz authored
This was introduced in https://crrev.com/635139 where the responsibility of liveness management was moved to PannerNode from PannerHandler. Since CrossThreadWeakPersistent is cleared before executing the destructor of the Handler we need to check whether the AudioListener died in the same GC cycle. Bug: 935854 Change-Id: Ifaa0880c356a4a7b09726a9ddf5b700a65de93bc Reviewed-on: https://chromium-review.googlesource.com/c/1488912Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635567}
-
Fredrik Söderquist authored
This better matches what BackgroundImageGeometry checks. Rename the somewhat terse |img| to the ever so slightly less terse |image|, and mark it const. Change-Id: I9e3cbe86285bc448c2e79d31c813071191150a11 Reviewed-on: https://chromium-review.googlesource.com/c/1489235 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#635566}
-
Brad Hall authored
These tests are killing a bunch of bots currently Bug: 935598 Change-Id: Ib92d0b2e7044a4a0e3c1ea49afdd34e3eb632fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1487692Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635565}
-
Egor Pasko authored
IIUC the target telemetry_chrome_test_without_chrome in //tools/perf/chrome_telemetry_build controls what is built on bots prior to running any benchmark. Add stack symbolization helpers to this target for cases when a crash is intercepted by Crashpad. Also add a tiny self-doc about dependency on dump_syms in crashpad_stackwalker. Bug: 925453 Change-Id: I8687c693221d33f9a2b3306519211c708092d72a Reviewed-on: https://chromium-review.googlesource.com/c/1486353 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#635564}
-
Stephane Zermatten authored
Before this change, when there were no matching scripts for a page, or when fetching scripts failed, the client would wait always 20s before displaying an error message. With this change, the client complains as soon as it's clear that there are no scripts for the current page and that there cannot be any on the current URL. This change updates the way the case where we don't have a committed URL yet is handled, to avoid ever checking scripts with an empty URL. Before this change, the first run of CheckScripts would almost always run against an empty URL, so all preconditions would fail. With this change, the first run of CheckScripts runs with the initial URL, the one passed to CCT. This change updates most test in ControllerTest, which were written in such a way as to always start with a no-script answer. Bug: 806868 Change-Id: I819fce0aadf4263ea0d17e8d58bd4371d5beec00 Reviewed-on: https://chromium-review.googlesource.com/c/1486274 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635563}
-
Daniel Bratell authored
There is both a ::mojom namespace and a ::metrics::mojom namespace so inside metrics its best to qualify which is intended or name lookup will depend on what the compiler happens to be aware of. In particular, in some jumbo builds "mojom" resolved to "::metrics::mojom" while in other builds where the compiler was unaware of ::metrics::mojom, it instead resolved to "::mojom". This is probably one of the reasons there is a style guide instruction to not have sub namespaces with the same name as a common top level namespace. Change-Id: I06545d34fac67b5f3f42fa1821eb33d381e04a41 Reviewed-on: https://chromium-review.googlesource.com/c/1485934Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#635562}
-
Michael Lippautz authored
GCs should be run async if they require that objects are guaranteed to be collected. Bug: 843903 Change-Id: I1e55646e3c2e9f9625c71b45d0c16d8477b4566d Reviewed-on: https://chromium-review.googlesource.com/c/1488880Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635561}
-
Yuly Novikov authored
This reverts commit 79a6357d. Reason for revert: Increased the number of failures instead of decreasing Original change's description: > Run angle_end2end_tests in batches > > An unknown leak is causing OOM failures on the Intel/Windows bot. While > that's being investigated, this change unblocks developers by making > sure the tests are done in batches and memory is reclaimed occasionally. > > Bug: angleproject:3153 > No-Try: True > Change-Id: Ia03e8996554b308e0bd8a59d13bffc8bde3fbfba > Reviewed-on: https://chromium-review.googlesource.com/c/1481854 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635377} TBR=kbr@chromium.org,syoussefi@chromium.org,jmadill@chromium.org Change-Id: Ie07f4654a694d20bcbd953d353aa39666aa77326 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3153 Reviewed-on: https://chromium-review.googlesource.com/c/1488510Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#635560}
-
Eric Willigers authored
This reverts the use counters added in https://chromium-review.googlesource.com/c/chromium/src/+/1354751 The CSS Working Group was considering allowing :not() to ignore selectors that are invalid or not accepted by the browser. Use counts showed that this would affect a large percentage of pages https://github.com/w3c/csswg-drafts/issues/3264#issuecomment-463036664 and so the decision was made to not change the behavior of :not https://github.com/w3c/csswg-drafts/issues/3264#issuecomment-467190906 Data collection is no longer required. BUG=568705 Change-Id: I38ddaee5339e19b70c1c13c9507a50ae27c354b0 Reviewed-on: https://chromium-review.googlesource.com/c/1487753 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635559}
-
Collin Baker authored
Bug: 887991 Change-Id: I4403b4fd6501c97132e666c768b2eb981648ab19 Reviewed-on: https://chromium-review.googlesource.com/c/1488056 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635558}
-
Colin Blundell authored
IdentityTestEnvironment is the only caller and it can just call AccountTrackerService directly. Bug: 935998 Change-Id: Ic5c1546359e38ba97bda9f33f92ba53918660ce9 Reviewed-on: https://chromium-review.googlesource.com/c/1489198Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635557}
-
Justin Cohen authored
TBR: sergeyberezin@ Change-Id: I0102c0a90770cb6b580348c0108827c56c67db1c Reviewed-on: https://chromium-review.googlesource.com/c/1487526 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635556}
-
Huanzhong Huang authored
Introduce TableViewClearBrowsingDataCell, as specified in https://docs.google.com/presentation/d/1fVw0i0fuuuLbHDsYmVkQ4K8Cw5OMtKyl1RhWLKx_LtU/edit#slide=id.g4a820179a3_0_226, and apply it on TableViewClearBrowsingDataItem. Changing the |cellClass| of TableViewClearBrowsingDataItem introduces no visible differences yet due to autolayout. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=935346 Change-Id: I9ad5ee02422998fd46aeca2e86a61539f35dd38a Reviewed-on: https://chromium-review.googlesource.com/c/1474944 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635555}
-
Elly Fong-Jones authored
Bug: 852872 Change-Id: I9f484dcc5fc73fc7e664f84aab2c7dd74e321288 Reviewed-on: https://chromium-review.googlesource.com/c/1489133 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635554}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38fb70186109..ab2257c7e108 git log 38fb70186109..ab2257c7e108 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 fmayer@google.com Merge "Fix check in UnixSocketTest::ReleaseSocket." Created with: gclient setdep -r src/third_party/perfetto@ab2257c7e108 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I95e038c341ee8fb758df3110634fcb40f703ac6a Reviewed-on: https://chromium-review.googlesource.com/c/1489063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635553}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9061ec504ae9..264b7c18a357 Created with: gclient setdep -r src-internal@264b7c18a357 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia224b266e4c9211c4dc583ea29d33e9cb118376c Reviewed-on: https://chromium-review.googlesource.com/c/1489062Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635552}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a32d20ab..f073572f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If003cc65e516711dbc4a65cef3b92afcfd495e27 Reviewed-on: https://chromium-review.googlesource.com/c/1488954Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635551}
-
Fredrik Söderquist authored
This renames: Image::HasRelativeSize, StyleImage::ImageHasRelativeSize and LayoutImageResource::ImageHasRelativeSize to the common name HasIntrinsicSize. This flips the meaning of this flag/method, but the new name is using a term that is more relatable from a spec-perspective. Change-Id: I2509926a186f8c81534800362becd585fb0bd024 Reviewed-on: https://chromium-review.googlesource.com/c/1488885 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#635550}
-