- 27 Dec, 2019 32 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d5e76cf5d68..88c34f0d6d87 git log 9d5e76cf5d68..88c34f0d6d87 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6e3a387c0159..59465799210b (1 commits) Created with: gclient setdep -r src/third_party/skia@88c34f0d6d87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Idb21df677c03facb9d300462ca4a812d68b8839a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982963Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727545}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c170824..26d06749 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46d898acf9c23c7759f8bb3fafb7be97daea60af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982402Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727544}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6e3a387c0159..59465799210b git log 6e3a387c0159..59465799210b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 capn@google.com Remove Reactor/MutexLock.hpp Created with: gclient setdep -r src/third_party/swiftshader@59465799210b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic99d29b331c0f09df318070e468d2fa9ca0b64e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982961Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.0-1576497268-benchmark-81.0.4001.0-r1 to 81-3987.0-1577099071-benchmark-81.0.4005.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I84fe68e9d5b8b0698017be044f8829545aaca9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982967Reviewed-by:
-
Yuki Shiino authored
Makes ListNode insert the head and tail section iff the content is not empty. Bug: 839389 Change-Id: Ie154a6f252814abc3a51284f22ac04188e168e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981417Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#727541}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c708e597115..ebdff3e12e9a Created with: gclient setdep -r src-internal@ebdff3e12e9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie490c1dc0930934c558de42c5b4bff2560ff547f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982960Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727540}
-
Colin Blundell authored
WebLayer's CrashReporterControllerImpl is is always initialized as part of WebLayer initialization. Currently, CrashReporterControllerImpl registers to observe child process crashes and process their minidumps in its own initialization. This processing involves interaction with the CrashReporterControllerClient. However, not all WebLayer embedders set a client; e.g., WebLayer Shell does not. Without a client having been set, a child process crash causes the app to crash due to CrashReporterControllerImpl accessing a null client instance. This CL changes CrashReporterControllerImpl to register for child process crashes when its client is set. Change-Id: I280b68766cc3c5e59ca02fa685575cfe67715f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980741Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#727539}
-
Colin Blundell authored
As crbug.com/1037884 details, Blink currently implicitly requires that the embedder of //content supply an InstalledAppProvider implementation on Android (on all other platforms a default no-op implementation is provided by //content, but on Android a production implementation is provided in //chrome). That bug will hopefully be fixed soon, but in the meantime this CL provides a stub implementation in WebLayer on Android so that pages that trigger this flow don't crash in debug mode. When that bug is fixed, I will remove this workaround. Bug: 1037884 Change-Id: I7eb17431a8b43704f0ce3056babf4a5f95b6a6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980743 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727538}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/89bf1547f3aa..9d5e76cf5d68 git log 89bf1547f3aa..9d5e76cf5d68 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 48115d33..d814fc7e (94 commits) Created with: gclient setdep -r src/third_party/skia@9d5e76cf5d68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I07f76e24593cfe55e53b2d27c01d4866ee99b318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982698Reviewed-by:
-
Dan Beam authored
Because of various technical details, we can show search bubbles only in cases in which the UI is fairly stably visible (i.e. not subpages). Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=355446#c14 Bug: 355446 Change-Id: I732e64da8916e183655e406b18f06f0a0b02ed31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962797 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727536}
-
Kuo Jen Wei authored
Bug: 1037982 Test: Remove chrome and rebuild and redeploy chrome, verify CCA function normally. Change-Id: I1d8f6fc121734516a0bdc77d6e5d9f2a602d3b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982506 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#727535}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/451736382565..b015b7d12040 git log 451736382565..b015b7d12040 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b015b7d12040 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc67266b2674de3157ea9989f66db56f7ad97f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982697Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/198da190b2a3..4c708e597115 Created with: gclient setdep -r src-internal@4c708e597115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie5f7313bb6aa6a903eae0e8e2d6f1f314374c291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982667Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9cde626b8052da5eab820dddbcfec53acd524467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980471Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727532}
-
rbpotter authored
Remove OS settings only toggles from the browser settings privacy page, since these toggles are always hidden for showOSSettings=false. Bug: 990132 Change-Id: I568a7a3f72cd2078b74c0f6b024a463c7829c85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982142Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727531}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3057725. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I1aedf762eaf394445d049638f3652f3d3718e59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982398Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727530}
-
Kurt Horimoto authored
|sender| was unused in InfobarCoordinator's implementation, and The InfobarBannerViewController only ever requested animated dismissals with no completion blocks. These unused parameters were removed to simplify the delegate interface. Bug: 1030357 Change-Id: I248b4a956d0b41e6f8acd54b4c603f6acc29784d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974894 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727529}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and manually validate tooltips function of CCA works correctly. Change-Id: I65f8286c208ba922b2d6574ab836e0b77a2a39d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982341 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
rbpotter authored
allowexternalscript="true" was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1980212 As a result this now causes a console error and prevents the people page from loading in debug builds. Remove flattenhtml as well, since there does not seem to be a reason to keep it for this file. Bug: None Change-Id: I43d92c68b76ae423e53cf4ce9010ee823bf9622c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982725Reviewed-by:
-
Andrey Kosyakov authored
TBR=kvitekp@chromium.org Change-Id: I53da1f16c88d4a3c5c5bc203a9e036c6bb93e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982228Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727526}
-
Kurt Horimoto authored
Previously, each OverlayRequestCoordinator had an associated OverlayRequestMediator that also supported the same request type. However, with the introduction of infobar overlays, we will have a single OverlayRequestCoordinator managing the UI, but separate mediators that support only a specific request config type used to configure the shared consumer protocol. This CL adds class properties to the coordinator and mediator interfaces that return OverlayRequestSupports rather than keeping |+supportsRequest:|. This allows each class to specify its request support separately without the need to introduce an additional |+supportRequest:| to the mediator. Bug: none Change-Id: I990467855d6cd1193db9d70e68ce412866128f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981198 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727525}
-
Devlin Cronin authored
Refactor PageAction commands tests to be less reliant on waiting for success, and introduce a couple of helper methods. This allows us to exercise that the page action is *not* triggered in certain cases (whereas with the way the tests were structured before, there was no way to do so). Also add a new test that leverages to test that the page action is not triggered if the action is not visible on the given tab. This is also a precursor for getting overflowed page action keyboard commands to work properly. Bug: 1037685 Change-Id: I2e5bec90bf3a5f1aeb00e115b94a82863a68e092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981192Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727524}
-
Nate Fischer authored
This repopulates the Spinners in the Flags UI when the Activity is recreated, to ensure the Activity and Service/ContentProvider have consistent state. Without this change, the flags UI would have an empty map of flag overrides, and would clear most of the Service's flags when the user toggles the first Spinner. This moves some the ContentProvider communication logic to a separate bridge class to be shared by both the dev UI and the embedded WebView browser process. TBR=torne@chromium.org Fixed: 1036538 Test: Manual - toggle flags in the Activity, swipe away the Activity, \ Test: and relaunch to see the UI is restored correctly Change-Id: Ife42a0633707c9d59e5678483a95f4267fbbe739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980857Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727523}
-
Khushal authored
TBR=kbr@chromium.org Bug: 1037958 Change-Id: If8cc58b0bacc1ed5b50dfd32c2b3638acf17d589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982176Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#727522}
-
Regan Hsu authored
In order to make a specific collection of wallpaper photos ("Anna's Garden") only available on "Made by Google" chromebooks, a new filtering label must be added to whitelist that collection to "Made by Google" chromebooks. Bug: 1009025 Change-Id: I1a253d9786e9294cb523158421cb32519be45182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849100 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727521}
-
Dan Beam authored
* Move X into middle of focus outline * Fix incorrect padding around X (it should be 4px top/bottom, 2px left/right) Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1036708#c6 Fixed: 1036708, 1001637 Change-Id: I9ab51b17487808d1891a98e446060a6375f6ac60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982720 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79f46fe255a1..198da190b2a3 Created with: gclient setdep -r src-internal@198da190b2a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idac1f5d8bd046109473ce7667af7c7f3f5100c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982815Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I827501caa0f162ffbb5ffeb320b60555b35578ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982136Reviewed-by:
-
Khushal authored
TBR=kbr@chromium.org Bug: 1037949 Change-Id: I078b0dd5e7f3af777245683dd734b71fd4309f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982134Reviewed-by:
-
Kurt Horimoto authored
Many OverlayPresenterObservers for the infobar refactor will only need to observer OverlayRequests created with a specific config type. ADding an OverlayRequestSupport to OverlayPresenterObserver allows the observer callbacks to only be sent for these requests rather than requiring each observer subclass to check against the request's config type. Bug: none Change-Id: I5517f1e04431ec1639cdb790bf4058bb8dcb3c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981251 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Reid Kleckner authored
This reverts commit 0d406dbc. Reason for revert: - Fuchsia arm64 bug (crbug.com/1037700) - Android arm64 bug (crbug.com/1037912) - 10% perf regression (crbug.com/1036818) Original change's description: > Reland "Roll clang n332890-c2443155-1 : n333938-3a6da112-1." > > This is a reland of b21c79dc > > Original change's description: > > Roll clang n332890-c2443155-1 : n333938-3a6da112-1. > > > > Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`. > > > > Bug: 1030664 > > Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387 > > Auto-Submit: Reid Kleckner <rnk@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#727069} > > Bug: 1030664 > Change-Id: I7a7fdcf7b0c6bd22f4840748318f7180931ea468 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979068 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727096} TBR=thakis@chromium.org,ukai@chromium.org,hans@chromium.org,rnk@chromium.org Bug: 1030664, 1037700, 1037912, 1036818 Change-Id: If73d19f7f5a0febdd83087b0a6f257f8ad21a36f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982227 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727515}
-
Dana Fried authored
Resetting the starting layout loses context about views that are fading in our out, causing popping of layouts in some cases (especially during slide animations). Having a layout reset multiple times can happen when one view is hidden and another view shown within the same host view with an animating layout. Ensuring that only the final change "sticks" makes for a smooth transition from the pre-modification state. Bug: 1037947 Change-Id: Ibc1dbb2f249d1edfd21294202467d2292d0591a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981333 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#727514}
-
- 26 Dec, 2019 8 commits
-
-
Caleb Rouleau authored
For gtests, do the conversion to histograms in run_performance_tests.py. This is cleaner than doing it in process_perf_results.py and has the benefit that Pinpoint will use in in the same way as well. Bug: 923564 Change-Id: I8eddd2d0934f68d45b278494eb67990ae9a30414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981633Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727513}
-
Andrey Kosyakov authored
Bug: 1036627, 1036627, 1034954 TBR=gab@chromium.org, fdegans@chromium.org This re-enables multiple headless tests suppressed after https://crrev.com/c/1977741 following the latter being reverted. Change-Id: I074e9ba1c5fa752a0773301dc3881d3a34662cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982762 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f2d522a3f434..89bf1547f3aa git log f2d522a3f434..89bf1547f3aa --date=short --first-parent --format='%ad %ae %s' 2019-12-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 52dae168b48b..01dd6f6ca430 (3 commits) 2019-12-26 brianosman@google.com Actually update win_toolchain to 2019 (14.24.28314) 2019-12-26 herb@google.com Do vertex color adjustment before atlas calculations 2019-12-26 herb@google.com Move vertex translation into SubRun Created with: gclient setdep -r src/third_party/skia@89bf1547f3aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Iffcdaa01eac5a5f2d80953176df25a02b909f955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982688Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0edda42e7d3..79f46fe255a1 Created with: gclient setdep -r src-internal@79f46fe255a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1035074 Tbr: jbudorick@google.com Change-Id: I08dad6a2bded1d5244a1e4696ec8bb86870a0774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982685Reviewed-by:
-
Caleb Rouleau authored
1. Add backup reviewer John Chen. 2. Add Wenbin as non-committer owner. 3. Add component Speed>Benchmarks. 4. Remove John B since this isn't his responsibility anymore (unless he wants to stay on?) Change-Id: I4ec8ed9a406ab7be47bcf71c6961164c558be2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982683Reviewed-by:
-
James Vecore authored
Some metrics were set to expire at M81 that we want to keep. Also vecore@ is taking ownership of the MultiDevice metrics. Fixed: 1037153,1037152,1037151 Change-Id: I5e19f3eadfc17a731acc6bc899f8ebef3dec5146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981109Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#727508}
-
Demetrios Papadopoulos authored
- Add missing |search_label| js_library target. - Make dependencies more accurate and stop relying on transitive dependencies. Bug: None Change-Id: I69a5421459011ec58bfbba2f7a7502983bd1b43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980180Reviewed-by:
-
Khushal authored
TBR=kbr@chromium.org Bug: 1037650 Change-Id: I1172bf08c5de2ddc4ea06c1b22019015074aae81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982224Reviewed-by:
-
