GitLab

TBR=rsleevi@chromium.org

Change-Id: I00610747dc0dc84f3c9f6b79964062f03fa3d940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737011Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684080}

This is in line with a new design of base::Value described
at https://cs.chromium.org/chromium/src/base/values.h?l=56
and also simplifies memory management in tests.

Bug: 956036
Change-Id: I14a1c404567608fe1ecaa4529ef1e9f14d70f81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717780Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684079}

Switches the browser used by the Windows XR perf tests from "release" to
"release_x64" since the bot was changed to 64-bit and Telemetry is
now failing to find the 32-bit browser that is requested.

TBR=ynovikov@chromium.org

Bug: 988833
Change-Id: I498e65f1ac4182718ccf83495d6ff1eb3eacbe73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735553Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684078}

This prevents the ModuleInspector service process connection from being
too aggressively torn down, allowing for reuse of the same service
process over multiple module inspection operations.

Bug: 990205
Change-Id: I7c0b083141ff058b6045acf3c8d299e54f11e0bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734172
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684077}

Bug: 990512
Change-Id: Iac340a45ca4bccc4c08d1176bd263284b53faef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733751Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Sofiya Semenova <sofiyase@google.com>
Cr-Commit-Position: refs/heads/master@{#684076}

This feature only ever existed as a safeguard; it was default-enabled
from the beginning.

Bug: 983940
Change-Id: I2d1a7d6662853c278592a7609aa5d1267b3e2098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735155
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684075}

vpython uses both HOME and TMPDIR as workspaces. Now that /tmp is
mounted with noexec, we need to point vpython to a tmp dir without that
restriction.

Bug: 990859
Change-Id: I17629676abb898923658a48862a909e99d4fac1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735554Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684074}

There was a crash report indicating this was a null deref, and the code
clearly shows the calling function can return a null pointer so account
for that case.

Bug: chromium:990507
Test: Builds
Change-Id: I3b78de23dca40637661d1a9619adf9c00593c485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733739
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684073}

Using ChromeTypographyProvider to set the color instead of hard coding.
Normal mode keeps using kGoogleGrey700. Dark mode use kGoogleGrey500.

Before: https://drive.google.com/open?id=1qGdPgomtoXVPkAZ4XZr5gzd5ckBcfLzz
After: https://drive.google.com/open?id=1MZ4wt7LW68CK-KqzLKgLKuZNNUBcrS59

Bug: 990406
Change-Id: I4f088d4d49e4b0df0b467b1f195dcd16f08aa84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732480Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684072}

This feature was removed in http://crrev.com/c/1732409, so we no longer
need these tests.

Bug: 824840
Change-Id: I582216aac6a27bf14b04ed6760b25aa65f698628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735949
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684071}

Record UMA metrics whenever the Mirroring Service encounters a
SessionError.

Change-Id: Ic1f6eb02232dcb4164bf5a9ba0d6105fa7128c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714208Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684070}

Bug: 747715
Change-Id: I957d86b986d2da087c0ade85e8cc04228a7a4eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725050
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684069}

TBR=nhiroki@chromium.org

Bug: 990900
Change-Id: I585308ff8ccb07c933f6c79a585a209be194785a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737093Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684068}

Adds "Win10 FYI x64 Release (Intel UHD 630)" to chromium.gpu.fyi, which
is identical to "Win10 FYI x64 Release (Intel HD 630)" except that it
triggers tests on a machine with a newer GPU.

Bug: 986939
Change-Id: Ia7408cad7b862738d7562f954cf213e2bd9355c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734166
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684067}

https://chromium.googlesource.com/catapult.git/+log/a5468613faff..53d495005f0c

git log a5468613faff..53d495005f0c --date=short --no-merges --format='%ad %ae %s'
2019-08-05 perezju@chromium.org [Telemetry] Fix handling of default arguments set by benchmarks

Created with:
  gclient setdep -r src/third_party/catapult@53d495005f0c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: chromium:990395,chromium:985712
Change-Id: Iaa78c593bd01e10fb17b0ca69f91180361ffa03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735898Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684066}

We're renaming core/scheduler to core/scheduler_integration_tests
because the new name more fully reflects the purpose of its contents,
and distinguishes it from modules/scheduler which contains the
experimental postTask API.

Bug: 979017
Change-Id: I0d2956a0e51e5661c29cc015abf8a68052cd0540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729061Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684065}

If engine initialization fails, the code passes an empty string as
cache GUID, hence the DCHECK is not legit.

Bug: None
Change-Id: I5a8f4d96e0c3994407444d2b344f3cae8c800be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736360
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684064}

This reverts commit 2e872764.

Reason for revert: Breaks webrtc msvc bots: https://webrtc-review.googlesource.com/c/src/+/147948/

Original change's description:
> Roll src/third_party/nasm/ f564874f4..da0dcccc4 (1 commit)
>
> https://chromium.googlesource.com/chromium/deps/nasm.git/+log/f564874f4955..da0dcccc44f1
>
> $ git log f564874f4..da0dcccc4 --date=short --no-merges --format='%ad %ae %s'
> 2019-08-01 rnk Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics
>
> Created with:
>   roll-dep src/third_party/nasm
>
> Bug: 989745
> Change-Id: I712bc7d2cb6b3d6ab8315174459f9837581d84b5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734032
> Commit-Queue: David Benjamin <davidben@chromium.org>
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Auto-Submit: David Benjamin <davidben@chromium.org>
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683807}

TBR=davidben@chromium.org,rnk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 989745
Change-Id: I6aac384304d31e714595633d18b5a1b2f62de2c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736684Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Artem Titov <titovartem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684063}

Bug: 977430
Change-Id: I35b13019f049ac4f90a3b5add999da0061931a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673966Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684062}

Bug: 990196
Change-Id: I5177f0ef7fbf764e9bf79b5ab1ed167d96b04eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733098
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684061}

Bug: 989497
Change-Id: I83cafb3fdb0a5e8695d89eab7ede78628e1f26e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730558
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684060}

Although only one icon is still passed, this is the first step to allow
having multiple icons per content index registration.

Bug: 973844
Change-Id: Ie699ecbd5d92b37c78fa9ae389e02d7667da7276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732086Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684059}

I found a workaround for crrev.com/c/1728889 so it no longer needs to
use this method, so it can safely be removed.

Bug: 824840
Change-Id: I9e1ac8a2beadb8de7bcf8f690599fde2b53c349d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734975
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684058}

This reverts commit b8ad61c0.

Reason for revert:
  The operators for +,-,+=,-= used base::Clamp{Add,Sub} which didn't
  apply the new limits. As such it was possible for the code to get
  into a state where:
  LayoutUnit test = LayoutUnit::Min();
  test -= LayoutUnit(1);
  LOG(INFO) << "result: " << (test < LayoutUnit::Min());
  The above would log "true".

  Code which operated near these limits was now fragile.
  Causing crbug.com/989742.

Original change's description:
> [Layout] Make LayoutUnit::Min() be -LayoutUnit::Max()
> 
> Some table code adds positive size to negative padding to get final
> size. A pathological page with padding and size of equal magnitudes
> could saturate size to LayoutUnit::Max() and padding to
> LayoutUnit::Min(), causing the result to be -1 instead of 0.
> 
> Bug: 966564
> Change-Id: I1b48a13691c63c916d705e0fd62831c63f1a3363
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639481
> Commit-Queue: David Grogan <dgrogan@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#670977}

TBR=dgrogan@chromium.org,eae@chromium.org,cavalcantii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 966564, 989742
Change-Id: Ic363c34409eda992dbf1dc3b4b4b56d5ea715887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730527Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684057}

In addition to the valid key types (Number, Date, String, Binary,
Array) which correspond to the web standard, Chromium code has three
others: Null, Min, and Invalid.

Invalid: Used in the front-end when an invalid key is passed from JS.

Null: Lack of a key, e.g. in a key range with no upper/lower bound.

Min: Used in the back-end to encode the ranges of stores/indexes.

Document what they mean and where they are used, in the mojom file.

Comments only, so TBRing.

TBR=tsepez@chromium.org

Change-Id: I89123fbd11424c852e4dc5a004911f1cce0e49fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733706
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684056}

Test color-profile-munsell-adobe-to-srgb.html renders an AdobeRGB test
Munsell chart image on a 2d <canvas> and checks the rendered colors of
the <canvas> image are color corrected to sRGB.

Add a webgl <canvas> version of the same test: render the image on the
3d <canvas>, check the <canvas> image colors are sRGB color-correct.

Bug: 739339
Change-Id: I2a41e964c4204d2706c253aebd2f7de1503dab9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735086
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684055}

Mark external/wpt/svg/animations/correct-events-for-short-animations-with-syncbases.html as flaky on Linux

TBR=edvardt@opera.com

Bug: 981522
Change-Id: Ic4782fb135b1ce984448c30a637b9e2b407341c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736436Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684054}

This reverts commit 2a6e4af1.

Reason for revert: The test should no longer be flaky on Windows.

Original change's description:
> [Sheriff] Disable SingleProcessBrowserTest.Test on Win.
> 
> Flaky.
> 
> TBR=rockot@google.com
> 
> Bug: 987448
> Change-Id: I6db59e7ce6ac618320e10bfe85b1aa700e0fbce1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730902
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683173}

TBR=rockot@google.com,vitaliii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 987448
Change-Id: Ia37df33292f76bf965d07da3168933586e564061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736439Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#684053}

This CL sets up the unit test for notification scheduler glue layer.

Also initialization is covered in this CL, other logic will be covered
in following CLs.

Bug: 963304
Change-Id: If2ae52428a7262a8eac23e7ab2efdd2d6bbbb1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730601Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684052}

When the kNonModalDialogs feature is enabled, app launch alerts will be
presented using OverlayPresenter in the kWebContentArea modlity.
This prevents a page from DOS'ing the entire app by repeated app
launch navigation requests since the user can close the tab.

Bug: 976919, 989296, 989316
Change-Id: Id2044d693766dccaf5c6cfa3df679b5ee2581722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726667
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684051}

This cuts the cost of an include of login_type.h from 100,000 lines of
mojom generated code to < 1000 lines.

Bug: none
Change-Id: I8897016fb1dade7bdd5fe5e2f60cbbe7880d3ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735950
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684050}

This is a reland of cca6943d

Original change's description:
> CacheStorage: Allow reads to be executed in parallel.
>
> This CL adds the CacheStorageParallelOps feature with the associated
> "max_shared_ops" parameter.  Enabling the feature and setting the
> parameter to greater than one will allow read-only cache_storage
> operations to run in parallel.  By default parallel operation is
> disabled.
>
> The overall design is to treat each CacheStorageScheduler as if it
> has its own read-write-lock.  When an operation is scheduled it must
> be flagged as either "shared" or "exclusive".  Some number of shared
> operations (determined by the feature param) may run in parallel.
> Exclusive operations always run by themselves without parallelism.
>
> This CL also includes the ServiceWorkerCache.PeakParallelSharedOps
> histogram which will measure how much parallelism we actually see in
> practice.  The peak is measured across a small time period defined by
> when an idle scheduler begins running its first shared op to until it
> stops running all shared ops.
>
> Bug: 985379
> Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Rayan Kanso <rayankans@chromium.org>
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680986}

TBR=jwd@chromium.org,dmurph@chromium.org,jam@chromium.org,rayankans@chromium.org

Bug: 985379
Change-Id: I83d8ce38a647b00e658dc1e2e17828468475cc66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737031Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684049}

Some of them were left in //chromeos/constants/chromeos_switches.h for
historical reasons.

Fix a few IMYU issues.

Bug: none
Test: bots
Change-Id: I1480c141a76a69c4153d6d1019530e9efcaa80e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731957Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684048}

This reverts commit 7188deb6.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Enable interactive uitests on Mac
> 
> Re-enable interactive uitests that were disabled for crbug/823543
> and crbug/824418. These issues are because of crbug/641969 which is
> no longer reproduced on MacViews browser.
> 
> BUG=823543, 824418, 641969
> 
> Change-Id: Id5de29e9d95962f98748d140469f4709fcbd4fb9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699665
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683998}

TBR=ellyjones@chromium.org,sky@chromium.org,robliao@chromium.org,jongkwon.lee@navercorp.com

Change-Id: I5fa5df976a6ad68618dd43951637e6b15d276eb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823543, 824418, 641969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737095Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684047}

The norm is to have a space between # and COMPONENT.

Change-Id: I89ccd42c92f65ee84abcbb8a17074f25d6112961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736699
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684046}

We aren't experimenting with this anymore.

Bug: 956102
Change-Id: I93b9d512453ddc156717735b6f2d8d345175b45c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733012Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684045}

This is to support the split of OS settings from browser settings.

Bug: None
Change-Id: I994a8e4c4cb27801fdf979025c291211324bcecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732806
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684044}

https://skia.googlesource.com/skia.git/+log/96555343063b..4df3d5340ef3

git log 96555343063b..4df3d5340ef3 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 halcanary@google.com rewrite_includes.py: make it work on windows
2019-08-05 halcanary@google.com experimental/tools/gerrit_percent_encode
2019-08-05 fmalita@chromium.org Add missing GrLumaColorFilterEffect opt flag
2019-08-05 michaelludwig@google.com Update tests to use new image filter factories
2019-08-05 michaelludwig@google.com Fix GMs broken during API porting

Created with:
  gclient setdep -r src/third_party/skia@4df3d5340ef3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@google.com

Bug: None
Change-Id: Iac6be37572f7ae820ae6c35e1c37325cc9d05167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736168Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684043}

Specifically run it on the FYI waterfall release bots.

BUG=982294
BUG=989194
BUG=990368
BUG=angleproject:3766
BUG=angleproject:3768
BUG=angleproject:3769
BUG=angleproject:3770
BUG=angleproject:3771
BUG=angleproject:3772
BUG=angleproject:3774

Change-Id: Ibbc52471256cd8c7af8d0c95d4ebba8f1afb653d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709934
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684042}

No change to NS path, this only removes the legacy path.

This removes some cookie code used in the legacy code path. This is
mostly deleting files, but also modifies a couple classes to remove
legacy-path-only code and reduce some complexity.

Bug: 990437
Test: run_webview_instrumentation_test_apk -f CookieManagerTest.*
Change-Id: I0418c6f76af19052d5ff597ba54f8ec773ea914d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733847Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684041}