Commits · 019ea4204c911d6244de2c723568aff1b1e8ec43 · eriksson monteiro / tangled

30 Apr, 2012 40 commits

Add key modifier to minimize/restore button click to minimize/restore-all panels for GTK · 019ea420

jianli@chromium.org authored Apr 30, 2012

BUG=123176
TEST=existing tests


Review URL: http://codereview.chromium.org/10209037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134579 0039d316-1c4b-4281-b951-d872f2087c98

019ea420

Fix sign-in. · 6531ef33

jamiewalch@google.com authored Apr 30, 2012

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10260019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134578 0039d316-1c4b-4281-b951-d872f2087c98

6531ef33

convert history page to loadTimeData · 154417d3

estade@chromium.org authored Apr 30, 2012

BUG=122753
TEST=manual


Review URL: http://codereview.chromium.org/10238016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134577 0039d316-1c4b-4281-b951-d872f2087c98

154417d3

Avoid using/setting cookies when fetching sdch dictionary · 33acd002

jar@chromium.org authored Apr 30, 2012

SDCH is used to fetch a dictionary for decompression,
and is generally not protected (and generally has no
PII).  It specifically does not use SSL in handling
compressed content, and so other than plausibly gathering
stats, there is no reason to use, or save cookies
during a dicitonary fetch.

r=rtenneti
bug=118952

Review URL: http://codereview.chromium.org/10271011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134576 0039d316-1c4b-4281-b951-d872f2087c98

33acd002

M20 translations. · 729e7294

jamiewalch@google.com authored Apr 30, 2012

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10265011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134575 0039d316-1c4b-4281-b951-d872f2087c98

729e7294

Fix VideoFrameGenerator so Flush() callback always runs after a pending Read() callback. · b8a3cff7

acolwell@chromium.org authored Apr 30, 2012


BUG=125366
TEST=platform/chromium/media/video-capture-preview.html LayoutTest


Review URL: http://codereview.chromium.org/10261012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134573 0039d316-1c4b-4281-b951-d872f2087c98

b8a3cff7

more s/localStrings/loadTimeData · c0fc0a42

estade@chromium.org authored Apr 30, 2012

BUG=122753
TEST=manual


Review URL: http://codereview.chromium.org/10160006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134572 0039d316-1c4b-4281-b951-d872f2087c98

c0fc0a42

avoid race between dir existence check and dir creation · d1f4b72d

scottmg@chromium.org authored Apr 30, 2012

On clean builds, if there's two instances running at the same time makedirs occasionally raises and kills the build.

R=ajwong@chromium.org

Review URL: http://codereview.chromium.org/10051026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134571 0039d316-1c4b-4281-b951-d872f2087c98

d1f4b72d

net: Use operator!= from scoped_ptr to check if |db_| is NULL. · efba87c4

tfarina@chromium.org authored Apr 30, 2012

The pattern get() ? true : false isn't widely used and has one more occurrence
in chrome_frame/.

R=willchan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10255019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134570 0039d316-1c4b-4281-b951-d872f2087c98

efba87c4

Disabling chrome_frame_tests.exe ContextMenuTest.CFBackForward since it times out. · c6134e75

grt@chromium.org authored Apr 30, 2012

BUG=121097
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10261014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134569 0039d316-1c4b-4281-b951-d872f2087c98

c6134e75

add GrSoftwarePathRenderer files to skia's gyp · 4e62da92

reed@google.com authored Apr 30, 2012

Review URL: https://chromiumcodereview.appspot.com/10271015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134568 0039d316-1c4b-4281-b951-d872f2087c98

4e62da92

[Chromoting] Sign uninstaller and fixup user-visible package and dmg names. · e8e87a32

garykac@chromium.org authored Apr 30, 2012

DMG and final PKG names are now properly branded and have spaces to make
them more human-readable.
Update the script to sign the chromoting host uninstaller.

Review URL: http://codereview.chromium.org/10243015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134567 0039d316-1c4b-4281-b951-d872f2087c98

e8e87a32

Expose PostTaskAndReplyWithResult in BrowserThread · 745fc0dc

szager@google.com authored Apr 30, 2012

BUG=
TEST=


Review URL: http://codereview.chromium.org/10198042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134566 0039d316-1c4b-4281-b951-d872f2087c98

745fc0dc

Revert 134347 - Disable a gtalk test on QA bots · 804039d8

nirnimesh@chromium.org authored Apr 30, 2012

Will re re-enabled tomorrow.

TBR=vivianz@chromium.org
R=vivianz@chromium.org
BUG=125386
TEST=

Review URL: https://chromiumcodereview.appspot.com/10254019

TBR=nirnimesh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10261015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134565 0039d316-1c4b-4281-b951-d872f2087c98

804039d8

SPDY - Don't add any users into SPDY/3 experiment in · f7b27dcc

rtenneti@chromium.org authored Apr 30, 2012

Beta or Stable channels.

R=rch
TEST=browser unit tests

Review URL: http://codereview.chromium.org/10261013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134564 0039d316-1c4b-4281-b951-d872f2087c98

f7b27dcc

ash/chromeos: Search key opens new tab in last active browser. · d5ce4787

xiyuan@chromium.org authored Apr 30, 2012

When possible, use last active browser's profile to open new tab.

BUG=125311
TEST=Verify fix for issue 125311.


Review URL: http://codereview.chromium.org/10206033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134563 0039d316-1c4b-4281-b951-d872f2087c98

d5ce4787

Fix spacing around left tab, increment theme resource ID · a3b99646

jamescook@chromium.org authored Apr 30, 2012

* Adjust spacing between incognito man and leftmost tab.
* Make pinned tabs closer to their width in R19.
* Increment theme pack ID so tab background images get rebuilt.

BUG=125005
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/10270016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134560 0039d316-1c4b-4281-b951-d872f2087c98

a3b99646

Remove panel size limit when user resizes it. · 14decadb

dimich@chromium.org authored Apr 30, 2012

BUG=123669
TEST=existing panel resize tests, modified

Review URL: https://chromiumcodereview.appspot.com/10260001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134559 0039d316-1c4b-4281-b951-d872f2087c98

14decadb

Update .DEPS.git · bc8b93e0

chrome-admin@google.com authored Apr 30, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134558 0039d316-1c4b-4281-b951-d872f2087c98

bc8b93e0

Revert 134533 - Roll V8 to 3.10.7. · a856c531

zmo@google.com authored Apr 30, 2012

fast/regex/pcre-test-4.html is crashing after this roll.

R=jkummerow@chromium.org


Review URL: http://codereview.chromium.org/10268008

TBR=danno@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134557 0039d316-1c4b-4281-b951-d872f2087c98

a856c531

views/importer: Avoid conversions to wide in ImportProgressDialogView. · 8da19bca

tfarina@chromium.org authored Apr 30, 2012

BUG=23581
R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10221023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134556 0039d316-1c4b-4281-b951-d872f2087c98

8da19bca

Disable testStartupOptionsHomepage on CrOS · 2a476c9d

tbreisacher@chromium.org authored Apr 30, 2012


BUG=none
TEST=none
NOTRY=true


Review URL: http://codereview.chromium.org/10257016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134554 0039d316-1c4b-4281-b951-d872f2087c98

2a476c9d

NaCl: Move sel_ldr_launcher_chrome.cc into the Chromium repo · 7b3a1b3f

mseaborn@chromium.org authored Apr 30, 2012

This will allow the launch_nacl_process() callback to be simplified by
removing unused arguments.  But for now, I have left
sel_ldr_launcher_chrome.cc unchanged except to change its use of
namespaces.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=nacl_integration etc.

Review URL: https://chromiumcodereview.appspot.com/10266003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134552 0039d316-1c4b-4281-b951-d872f2087c98

7b3a1b3f

Update .DEPS.git · 20a8ddee

chrome-admin@google.com authored Apr 30, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134551 0039d316-1c4b-4281-b951-d872f2087c98

20a8ddee

Roll Skia DEPS to 3787 · 3158fef9

epoger@google.com authored Apr 30, 2012

Review URL: https://chromiumcodereview.appspot.com/10270011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134550 0039d316-1c4b-4281-b951-d872f2087c98

3158fef9

Style: move non-simple getters from hacker_style to CamelCase. · ae4d54aa

gavinp@chromium.org authored Apr 30, 2012

See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Names#Function_Names

BUG=None

Review URL: http://codereview.chromium.org/10260013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134549 0039d316-1c4b-4281-b951-d872f2087c98

ae4d54aa

Remove reference to file deleted in r134284 · ecdd4fcb

rsleevi@chromium.org authored Apr 30, 2012

BUG=119511
TEST=none
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/10260015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134548 0039d316-1c4b-4281-b951-d872f2087c98

ecdd4fcb

Use synced favicons in the Other Devices menu when possible. · 97642ce9

dubroy@chromium.org authored Apr 30, 2012

BUG=124441
TEST=Open two signed-in sessions, and visit a page in one browser that
has never been visited in the other browser (verify that the favicon is
not cached in browser #2 by checking chrome://favicon). When the open
tab is synced to browser #2, it should also get the favicon.

Review URL: https://chromiumcodereview.appspot.com/10205014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134547 0039d316-1c4b-4281-b951-d872f2087c98

97642ce9

views: Return the appropriate value for GetDialogButtons() in AboutIPCDialog. · 9314a40e

tfarina@chromium.org authored Apr 30, 2012

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10178027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134546 0039d316-1c4b-4281-b951-d872f2087c98

9314a40e

Reset Official builds expectations · e5a5bac6

kerz@chromium.org authored Apr 30, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134545 0039d316-1c4b-4281-b951-d872f2087c98

e5a5bac6

Change the name of the Pepper Flash field trial. · 8c0da9f6

yzshen@chromium.org authored Apr 30, 2012

This will change its position in the --force-fieldtrials value, moving it to the front.

Note:
- For channels that are not running the field trial (e.g., Canary or Beta), --force-fieldtrials won't show ApplyPepperFlash at all.
- The value of ApplyPepperFlash (Enable/DisableByDefault) doesn't necessarily reflect whether Pepper Flash is in use. The user may mannually change the settings.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/10254022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134544 0039d316-1c4b-4281-b951-d872f2087c98

8c0da9f6

Fix GetAppShortcutName to return a localized name for Chrome. · acd1ba02

gab@chromium.org authored Apr 30, 2012

Fixes a regression introduced in r108297.

std::wstring --> string16 in chrome/installer/util/browser_distribution.h and all of its descendants.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/10246007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134543 0039d316-1c4b-4281-b951-d872f2087c98

acd1ba02

Suppress RenderWidgetHelper leak detected by DrMemory in DelayProfileDestruction test. · 0ff3cbb9

rnk@chromium.org authored Apr 30, 2012

TBR=mad@chromium.org
BUG=125565

Review URL: https://chromiumcodereview.appspot.com/10266013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134542 0039d316-1c4b-4281-b951-d872f2087c98

0ff3cbb9

Revert 134283. Speculative revert, it looks like this caused many leaks (http://crbug.com/125564 ). · d23c9f93

thakis@chromium.org authored Apr 30, 2012

If the revert doesn't help, I'll reland.

- Preventing our default handlers for ChromeOS to show up or confuse the user


BUG=123368
TEST=None


Review URL: http://codereview.chromium.org/10139002

TBR=skuhne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10266012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134541 0039d316-1c4b-4281-b951-d872f2087c98

d23c9f93

Move the rest of the Flash functions to the thunk system. · 724fbd31

brettw@chromium.org authored Apr 30, 2012

This removes the manual Flash interface registration and adds them via the
interfaces_ppb_private_flash.h header. I moved File_ModulalLocal and
File_FileRef to the Flash API virtual interface which allowed me to delete
the separate proxies and stuff associated with those interfaces.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10169040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134540 0039d316-1c4b-4281-b951-d872f2087c98

724fbd31

Shift media_stream::StreamOptions to align with the new getUserMedia spec · e5bbe3d1

yujie.mao@intel.com authored Apr 30, 2012

The new getUserMedia spec accept user media options like a dictionary format navigator.webkitGetUserMedia({audio:true, video:true}, ...) to replace its old style navigator.webkitGetUserMedia("audio, video", ...)

BUG=113673
TEST=content_unittests, media_unittests

Review URL: http://codereview.chromium.org/10177008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134539 0039d316-1c4b-4281-b951-d872f2087c98

e5bbe3d1

Makes WorkspaceManager correctly reset animation types when animating. · 5674720e

sky@chromium.org authored Apr 30, 2012

BUG=124349
TEST=covered by unit tests
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10262007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134538 0039d316-1c4b-4281-b951-d872f2087c98

5674720e

Generate crash dumps when a hung PPAPI plugin is force terminated. · e7b9ab2e

brettw@chromium.org authored Apr 30, 2012

Reland of 134443 with Auro build change.

TEST=none
BUG=123021
Review URL: https://chromiumcodereview.appspot.com/10272007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134537 0039d316-1c4b-4281-b951-d872f2087c98

e7b9ab2e

Fix a small layout glitch in Metro after the recent Ash/Desktop merge. · 2fb310fb

joi@chromium.org authored Apr 30, 2012

The top of the tab center was getting rendered two pixels too low.

TBR=jamescook@chromium.org
BUG=125547


Review URL: http://codereview.chromium.org/10274006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134536 0039d316-1c4b-4281-b951-d872f2087c98

2fb310fb

Suppress Windows system leaks through winhttp and our proxy config and resolution code. · 26abd4c9

rnk@chromium.org authored Apr 30, 2012

TBR=sergeyu@chromium.org
BUG=125558

Review URL: https://chromiumcodereview.appspot.com/10267010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134535 0039d316-1c4b-4281-b951-d872f2087c98

26abd4c9