- 18 Oct, 2018 40 commits
-
-
David Tseng authored
Bug: 887235 Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad Reviewed-on: https://chromium-review.googlesource.com/c/1286905 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#600924}
-
Manu Cornet authored
* Reduce space to edge of screen. * Draw the indicators as strokes, not rects, to be able to use "softer" flags (stroke cap, etc.). Bug: 880578 Change-Id: Ic4268766561d2d038589f5216d22084463f551d4 Reviewed-on: https://chromium-review.googlesource.com/c/1288505Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#600923}
-
Christian Biesinger authored
This will let us avoid an allocation in many cases and is never worse than the previous code, and saves heap memory. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0e63a318d495747c322224b70175954a889e4ea8 Reviewed-on: https://chromium-review.googlesource.com/c/1289082Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600922}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3f3d4308509c..80c79964c796 git log 3f3d4308509c..80c79964c796 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 fmayer@google.com Merge "profiling: Simplify heapprofd CLI." Created with: gclient setdep -r src/third_party/perfetto@80c79964c796 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I782dedcb523da237207aad6132df4df8bf6861ea Reviewed-on: https://chromium-review.googlesource.com/c/1288957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600921}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4765aa78267..2b73d6251f92 git log c4765aa78267..2b73d6251f92 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 jmadill@chromium.org Remove SpvPostProcess.h from glslang's BUILD.gn. 2018-10-18 syoussefi@chromium.org Vulkan: Enable 16bpp texture tests 2018-10-18 syoussefi@chromium.org Vulkan: Implement GL_EXT_disjoint_timer_query Created with: gclient setdep -r src/third_party/angle@2b73d6251f92 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8efa2f6c22a4ddabd300c10e5a04b02de62c1689 Reviewed-on: https://chromium-review.googlesource.com/c/1289443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600920}
-
dpapad authored
This is in preparation of gzipping files for this WebUI. Bug: 895633 Change-Id: I43cbb74a11a5ab6317cf2a4cf42d77592a06ae46 Reviewed-on: https://chromium-review.googlesource.com/c/1285210Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600919}
-
Victor Vasiliev authored
Merge internal change: 217614033 R=rch@chromium.org Change-Id: I98840145bf0ce13e165e17acac196fb92af6f7af Reviewed-on: https://chromium-review.googlesource.com/c/1288849 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#600918}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/364a0d6bd98c..f94579d3c84c git log 364a0d6bd98c..f94579d3c84c --date=short --no-merges --format='%ad %ae %s' 2018-10-18 dgarrett@chromium.org Revert "chromeos_config: Move all CQ slaves to swarming." 2018-10-18 derat@chromium.org Revert "tast_test_stages: Use cros_run_vm_test" Created with: gclient setdep -r src/third_party/chromite@f94579d3c84c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5e83070d783a9e9a16060a2e313cc0c718978896 Reviewed-on: https://chromium-review.googlesource.com/c/1289133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600917}
-
Bo Liu authored
Test is expected to fail until we roll CTS containing this change: https://android-review.googlesource.com/792536 Bug: 896857 Change-Id: I4a14763088982c6c9a300fd442eb1d4fa0d897be TBR: aluo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1289678Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600916}
-
Annie Sullivan authored
Bug: 896871, 896851 Change-Id: I242b8e853359ff9ded6c427874a034202bcda8c0 TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/1289682Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600915}
-
Brandon Wylie authored
Follow-up from previous histogram CL: https://chromium-review.googlesource.com/c/chromium/src/+/1250061/5 comments in cached_image_fetcher.h. Bug: 888712 Change-Id: I87b769eb0754b4e49917ea0f62eeaf12513ec72d Reviewed-on: https://chromium-review.googlesource.com/c/1286897 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600914}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1922eb00bbd9..7c50ac5ddf5b git log 1922eb00bbd9..7c50ac5ddf5b --date=short --no-merges --format='%ad %ae %s' 2018-10-18 bpastene@chromium.org Reenable telemetry test timings. Created with: gclient setdep -r src/third_party/catapult@7c50ac5ddf5b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891898 TBR=sullivan@chromium.org Change-Id: Ib547b3179bf070844b75250f963ee7b950d1c221 Reviewed-on: https://chromium-review.googlesource.com/c/1289549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600913}
-
Eugene But authored
When enabled the page can always be scaled, regardless of author intent. Bug: 719573 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I01051016300e816daf0335c8394ad607cdb5d9b8 Reviewed-on: https://chromium-review.googlesource.com/c/1289440Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c583af06d50..1cb0e3a86df8 git log 0c583af06d50..1cb0e3a86df8 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms f3e50cfac5bc..1ce6da5c8d99 (1 commits) 2018-10-18 bsalomon@google.com Validate allocation size in GrBufferAllocPool using SkSafeMath. 2018-10-18 scroggo@google.com Properly fill in memory in sampled RLE BMPs 2018-10-18 kjlubick@google.com Add Bloaty (with demangling) for wasm BuildStats 2018-10-18 mtklein@google.com split out effect deserialization, disable in flutter 2018-10-18 herb@google.com Simplify atlas calculation for dimension only 2018-10-18 jvanverth@google.com Reland: Widen internal API to support more complex YUV formats 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 scroggo@google.com Blacklist PNGs with CRC errors when using platform 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 25843dd65181..c4765aa78267 (3 commits) 2018-10-18 mtklein@google.com only build non-prod skottie/sksg code in our tree 2018-10-18 caryclark@skia.org fix pathops fuzz 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0b3d56aa8983..a9999ce938be (2 commits) 2018-10-18 bsalomon@google.com Make GrBufferAllocPool reject very large allocation requests 2018-10-18 brianosman@google.com In makeColorSpace, hoist the null -> sRGB optimization 2018-10-18 jvanverth@google.com Revert "Widen internal API to support more complex YUV formats" 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e70c3514e5a0..0b3d56aa8983 (2 commits) 2018-10-18 bsalomon@google.com Enable validation of sampler object GL functions 2018-10-18 brianosman@google.com Always require a color space on picture-backed images Created with: gclient setdep -r src/third_party/skia@1cb0e3a86df8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:895362 TBR=egdaniel@chromium.org Change-Id: If01f6ada18ffa5f2ec0b3b0e6b808ac4dae198b5 Reviewed-on: https://chromium-review.googlesource.com/c/1289120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600911}
-
Scott Violet authored
This adds the ability to register a callback on a KeyEvent that is called when async processing completes. This is important for content as key events may be handed to the renderer, which means the event is asynchronously processed. BUG=891489 TEST=none Change-Id: Ifaad1b88b0256ea2c69128663c24b1803e7f7321 Reviewed-on: https://chromium-review.googlesource.com/c/1262405Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600910}
-
Joe Downing authored
This reverts commit ae60a134. Reason for revert: Multiple tests are failing on the Linux ASan/LSan servers and this appears to tbe the cause. Link to builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29646 Original change's description: > Disable blur for suggestion chip and folder icon in clamshell mode > > Changes: > 1. Destroy layer for suggestion chip in clamshell mode. > 2. Set blur to 0 for folder icon in clammshell mode. > 3. Avoid recreation of suggestion chip views after update. > > Bug: 896525 > Change-Id: I4cb84c06f5e0ed5a0cc70c0c2338028573bd7017 > Reviewed-on: https://chromium-review.googlesource.com/c/1287709 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600819} TBR=xiyuan@chromium.org,weidongg@chromium.org Change-Id: I0d5c0d9cb63b2f0ff45f7f3af20e171a9bb0fc60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896525 Reviewed-on: https://chromium-review.googlesource.com/c/1289676Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#600909}
-
Jazz Xu authored
Bug: 857120 Change-Id: I8e3f9f3ca0061f03f2f28388d13936c24371828f Reviewed-on: https://chromium-review.googlesource.com/c/1287297 Commit-Queue: Jazz Xu <jazzhsu@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600908}
-
Andrey Kosyakov authored
Bug: 850689,838291 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4017d89466de05936b697385436e6519934a9f19 Reviewed-on: https://chromium-review.googlesource.com/c/1282443 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600907}
-
Devlin Cronin authored
The chrome.webstore API is used (exclusively) for inline install, which is deprecated and to be removed in M71. [1] Remove the webstore entry from the extensions features files; this will result in chrome.webstore being undefined for all JS contexts. [1] https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 895868 Change-Id: Idce382e5dd967a22ba779204d63e1ec509493ff4 Reviewed-on: https://chromium-review.googlesource.com/c/1283485Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600906}
-
Robbie McElrath authored
Bug: 881976 Change-Id: I8a74b511bb58c88fb10ad2121a27b058ce854f71 Reviewed-on: https://chromium-review.googlesource.com/c/1287178 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#600905}
-
Annie Sullivan authored
Disable failing loading.mobile/TribunNews_3g and system_health.common_mobile/background:tools:gmail on N5, and fix startup.mobile disables. Bug: 894744, 896851, 896088 Change-Id: I08abf22dc487dd54fe0d3de9170f3f6cac74888c TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/1289573Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600904}
-
Kurt Horimoto authored
The previous implementation of ToolbarContainer scaled each toolbar's interpolation progress at the same rate, resulting in accordion-like behavior where all toolbars were expanded and collapsed at the same time. The desired effect is to have telescopic behavior, where the toolbars are extended one at a time. This is needed on iPad, where a scroll event should first reduce the height of the tab strip to 0.0 before reducing the height of the primary toolbar. This CL adds logic to convert the [0.0, 1.0] fullscreen progress range for the overall stack to individual progress values for each toolbar, such that the last toolbar is expanded first, and the previous toolbars don't start expanding until all subsequent ones are fully expanded. The range of stack-level progress values corresponding to a particular toolbar is proportional to that toolbar's height delta relative to the height delta of the overall stack. In addition, this CL also introduces HeightRange, a simple container object that can be used to hold max and min heights and perform interpolation calculations. Bug: 880672, 895766 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1205ec75ac3e9a0e57dc19d1ebcc1f1740f8aeac Reviewed-on: https://chromium-review.googlesource.com/c/1231933 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#600903}
-
David Benjamin authored
BoringSSL should be clean w.r.t. this flag now. Bug: 785442 Change-Id: I8fa8b2589c82a7c446a01d96c4702a2d1535de1e Reviewed-on: https://chromium-review.googlesource.com/c/1289160Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#600902}
-
Renjie authored
Bug: 787942 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia9d210d3d427de332dae4f7ad7fb988239819926 Reviewed-on: https://chromium-review.googlesource.com/c/1289158 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#600901}
-
Yao Xiao authored
For each download, it records the following dimensions: - FrameType: kMainFrame/kSameOriginAdSubframe/kSameOriginNonAdSubframe /kCrossOriginAdSubframe/kCrossOriginNonAdSubframe - GestureType: kWithoutGesture/kWithGesture The code where download behavior is identifiable and ad bit is accessible lives in two distinct places. They will be sharing blink/public/common/download/download_stats.h to log the metrics. Bug: 881345 Change-Id: Ic9f62b8b4eee3e55212df9e336f0ac10ce962c85 Reviewed-on: https://chromium-review.googlesource.com/c/1230441 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600900}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d876a0dad49c..2ec8dc1f8ab8 Created with: gclient setdep -r src-internal@2ec8dc1f8ab8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1ccd301224b0e301ea8ec9f885ec144edb9cb44c Reviewed-on: https://chromium-review.googlesource.com/c/1288963Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600899}
-
Scott Chen authored
Make css selectors more specific so that it works both in polymer 1 and 2. Bug: 874151 Change-Id: Ie39ea7a9a919b5d627491ba8b8d301720aa2cc32 Reviewed-on: https://chromium-review.googlesource.com/c/1287266Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600898}
-
Eric Aleshire authored
Internal .json config: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/700088 api.py CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1287890 This removes the step downloading the test files from GCS, as well as some other minor test runner fixes encountered in manual testing. Deploying test files with CIPD should be more straightforward to configure. Bug: 892381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib083cedad09ec8df1b250c092ee41e9739e0f2b6 Reviewed-on: https://chromium-review.googlesource.com/c/1287630Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#600897}
-
Eugene But authored
SetDisplayingNativeError should not be used if kWebErrorPages is enabled. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8a8be55dc0312fe60e9a4d403ed5e1ad78cbbf32 Reviewed-on: https://chromium-review.googlesource.com/c/1288975Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600896}
-
Xianzhu Wang authored
Bug: 627683 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib5e777a993b64f2efaf1b4f0952e506f8e3010a0 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1289389Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600895}
-
Christian Biesinger authored
This allows me to remove the otherwise-unnecessary constructors I added in https://chromium-review.googlesource.com/c/chromium/src/+/1286884 R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I720e6a128b6aa16db734bbc4bad94c0af827782d Reviewed-on: https://chromium-review.googlesource.com/c/1289304Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#600894}
-
Matthew Denton authored
Adds a check in the DnsQuery to ensure we don't parse extra bytes from the buffer. Also adds a check in DnsResponse that ensures we don't leak any uninitialized bytes if we allocated the buffer too large, after constructing the DnsResponse from a DnsQuery. Bug: 891521 Test: ./net_unittests Change-Id: Ia0fd4c677be71efec55e452e5219c34c8112a5e5 Reviewed-on: https://chromium-review.googlesource.com/c/1263280 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#600893}
-
Francois Doray authored
The histogram shows that 99.9% of the time, less than 1000 BLOCK_SHUTDOWN tasks are posted during shutdown. This CL replaces the histogram with a crash when the number is to high, which will be more actionnable. Note: Current histogram data shows that this crash will happen less than 0.1% of the time. Bug: 697731 Change-Id: I553caf93b0109a1bd44c5c841d0f557e6cad16cd Reviewed-on: https://chromium-review.googlesource.com/c/1280670Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#600892}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/488362624b6d..c1e6594df580 git log 488362624b6d..c1e6594df580 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 iannucci@chromium.org [roll-dep] Use Bug: instead of BUG= 2018-10-18 scottmg@chromium.org Support target_arch for WindowsSDK Created with: gclient setdep -r src/third_party/depot_tools@c1e6594df580 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892712 TBR=agable@chromium.org Change-Id: Iffc29d1699a639e3443d1bc4690878f283f95164 Reviewed-on: https://chromium-review.googlesource.com/c/1288961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600891}
-
Joshua Pawlicki authored
We don't appear to be close to ready to experiment with Mac. Bug: 687231 Change-Id: I4969c762b691faa6c714359116f143afe20d22bf Reviewed-on: https://chromium-review.googlesource.com/c/1289429Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#600890}
-
Jun Mukai authored
I've got a report saying some SpokenFeedbackTest cases fail with some leaks when SingleProcessMash is enabled. It can be fixed by disabling AutomationManagerAura at shutdown since the leaked objects are allocated through some asynchronous events after shutting down (QuitBrowsers()). BUG=896728 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I215c3d5990cc78653c7fd44d378f7130a137a219 Reviewed-on: https://chromium-review.googlesource.com/c/1289295Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600889}
-
Sergei Istomin authored
StreamMixer can be configured to use audio post processor. The test did not set any post processing pipeline for StreamMixer. When the test ran on a device test failed because a device additionaly processed audio and test got audio data changed. The test succeeded only when it is run on host (testx86). The test was fixed to use fake post processor. Bug: 117792326 Test: Unittests on device. Change-Id: Ife64df2690504bac249829f98ca659b19d763f23 Reviewed-on: https://chromium-review.googlesource.com/c/1285124 Commit-Queue: Sergei Istomin <sistomin@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#600888}
-
Maks Orlovich authored
Bug: 882585 Change-Id: Ic740f1ccd310ba5fc23f7bbb6f6bb40d6a3c59c2 Reviewed-on: https://chromium-review.googlesource.com/c/1287069Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600887}
-
James Cook authored
Window close events are sent over mojo between browser and ash. The test needs to wait for in-flight messages to complete before making assertions about the state of ash. Also fix a problem where the window delete message wasn't being sent by WindowTreeClient. Bug: 877118 Test: DeviceLocalAccountTest.LastWindowClosedLogoutReminder Change-Id: I43145c8140462428a7db050489593038745c8f94 Reviewed-on: https://chromium-review.googlesource.com/c/1284059 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600886}
-
Leonard Grey authored
Bug: 850098 Change-Id: Ia9559f323ba5d8d7b74578c91a4fee0618d3bd53 Reviewed-on: https://chromium-review.googlesource.com/c/1288854Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#600885}
-