GitLab

Removed the JID check from PushNotificationsListenTask::IsValidNotification. This was causing issues because the case did not match in some instances. We could do a case-insensitive check but we really do not need to check the TO: JID here.

BUG=None
TEST=Cloud Printing should work with users who signed up for Gmail specifying a non-lowercase username.

Review URL: http://codereview.chromium.org/6309017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72612 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72611 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6294016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5509
TEST=waterfall

Review URL: http://codereview.chromium.org/6388005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72609 0039d316-1c4b-4281-b951-d872f2087c98

It seems r72539 <http://crrev.com/72539> changed ui::GetXWindowStack() so it returns false if XGetWindowProperty() returns 0 (Success). This change just compares the return value of XGetWindowProperty() with Success as the function did before r72539.

BUG=70870
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/6350017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72608 0039d316-1c4b-4281-b951-d872f2087c98

This will make it easier to identify specific TCP connections in a wireshark trace.

BUG=70649
TEST=Connect somewhere, check about:net-internals to see that source ip and port are logged.

Review URL: http://codereview.chromium.org/6394004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5509
TEST=manual

Review URL: http://codereview.chromium.org/6356009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70560
TEST=none

Review URL: http://codereview.chromium.org/6379005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66472
TEST=none

Review URL: http://codereview.chromium.org/6313014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70826
TEST=remoting_unittests under valgrind

Review URL: http://codereview.chromium.org/6266020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72601 0039d316-1c4b-4281-b951-d872f2087c98

Note, this isn't a complete fix for the bug. We need to persist information for that.

BUG=66472
TEST=none

Review URL: http://codereview.chromium.org/6340016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72600 0039d316-1c4b-4281-b951-d872f2087c98

This change puts the AboutIPCDialog::RunDialog() function into common cross platform header.

BUG=None
TEST=Opened the IPC dialog on my Mac.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72598 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6334011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72597 0039d316-1c4b-4281-b951-d872f2087c98

WebGraphicsContext3D implementations. (The
GL_EXT_framebuffer_multisample and GL_ANGLE_framebuffer_multisample
extensions are advertised in Chrome's command buffer implementation as
GL_CHROMIUM_framebuffer_multisample.)

Tested manually in WebKit with accelerated 2D canvas with
multisampling turned on. This must land before the associated WebKit
patch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6369016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72596 0039d316-1c4b-4281-b951-d872f2087c98

Add support for GL_OES_rgb8_rgba8. Update feature_info unit tests.

Tested with the accelerated 2D canvas in WebKit with multisampling
turned on.

BUG=none
TEST=gpu_unittests

Review URL: http://codereview.chromium.org/6268016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72595 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rniwa

Review URL: http://codereview.chromium.org/6274011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70452
TEST=none

Review URL: http://codereview.chromium.org/6274010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72591 0039d316-1c4b-4281-b951-d872f2087c98

If X errors after the notification service has been destroyed (during browser shutdown), we'll deref NULL. Instead, we should just ignore the X error (aside from logging it to ERROR).

BUG=70852
TEST=none

Review URL: http://codereview.chromium.org/6379009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70861
TEST=none

Review URL: http://codereview.chromium.org/6250029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72588 0039d316-1c4b-4281-b951-d872f2087c98

And move the include of views/view.h from the header to the source file.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6332013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70807
TEST=See bug report.

Review URL: http://codereview.chromium.org/6334017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67039
TEST=unit-tested. Any network sniffer could be used to test that there no subsequent calls to the web for the same form.
Review URL: http://codereview.chromium.org/6366014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70860
TEST=none
Review URL: http://codereview.chromium.org/6254019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6378011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72582 0039d316-1c4b-4281-b951-d872f2087c98

Windows and Mac implementations lacked IDR_INPUT_SPEECH* handling.
This change fixes them by removing resource ID checking.

TEST=Some of LayoutTests/fast/speech/.
BUG=none
Review URL: http://codereview.chromium.org/6303017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72581 0039d316-1c4b-4281-b951-d872f2087c98

Allow CDSA/CSSM to be used on worker threads in debug builds by making both the CSSM init singleton and the Mac Security Services lock singleton leaky.

This primarily affects the use of <keygen> in a debug build, as the RSA private key is generated on a worker thread and needs to hold the Mac Security Services lock.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6354017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70809

TEST=
TBR=battre@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72579 0039d316-1c4b-4281-b951-d872f2087c98

* Only show the obfuscated CC number on editor load.
* Clear the input field if the user modifies the obfuscated number.

BUG=70452
TEST=none

Review URL: http://codereview.chromium.org/6369015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os:11110
TEST=existing

Review URL: http://codereview.chromium.org/6374010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72576 0039d316-1c4b-4281-b951-d872f2087c98

This adds support for glResizeCHROMIUM for off-screen contexts.

BUG=none
TEST=Pepper flash.

Review URL: http://codereview.chromium.org/6241015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72575 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration tests are broken on chrome OS because a cros_string
is not being passed to GetProfileSyncService() in
ProfileSyncServiceHarness::SetupSync(), causing no ProfileSyncService
object to be returned.

This patch passes an empty cros_user string to GetProfileSyncService(),
thereby fixing the sync integration tests on chrome OS.

BUG=70854, chromium-os:11319, chromium-os:9262
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6248019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72574 0039d316-1c4b-4281-b951-d872f2087c98

(PrerenderBrowserTest.PrerenderPage)

Also switch PrerenderManager from inheriting from
NonThreadSafe to using explicit DCHECKs, so doesn't
cause a debug assertion when destroyed on another
thread.

BUG=70398
TEST=PrerenderBrowserTest.PrerenderPage

Review URL: http://codereview.chromium.org/6255005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72573 0039d316-1c4b-4281-b951-d872f2087c98

Partially styling focus rings on the Mac looks weird, and we can't do completely custom styling that looks good until outlines follow border-radius correctly, so use the standard OS look. Also adjust button focus ring location on the Mac to adjust for changes to button elements.

BUG=None
TEST=Focus rings in DOMUI prefs should look have the standard platform look on the Mac.

Review URL: http://codereview.chromium.org/6320015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72572 0039d316-1c4b-4281-b951-d872f2087c98

Currently the "Edit -> Spelling and Grammar -> Check Spelling While Typing" menu item is always disabled.

The problem is that the logic to enable / disable this item lives in the render process and not in the UI.

This patch implements a generic message that the render process can send to the browser to update the state of view commands. This is used to enable and disable the "Check Spelling While Typing" menu item.

BUG=38440
TEST=Clicked in an edit box and verified that the "Check Spelling While Typing" menu item was enabled. Verified that changing the value from the context menu correctly updates the Edit menu as well.


TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6326011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72571 0039d316-1c4b-4281-b951-d872f2087c98

Currently the "Edit -> Spelling and Grammar -> Check Spelling While Typing" menu item is always disabled.

The problem is that the logic to enable / disable this item lives in the render process and not in the UI.

This patch implements a generic message that the render process can send to the browser to update the state of view commands. This is used to enable and disable the "Check Spelling While Typing" menu item.

BUG=38440
TEST=Clicked in an edit box and verified that the "Check Spelling While Typing" menu item was enabled. Verified that changing the value from the context menu correctly updates the Edit menu as well.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72570 0039d316-1c4b-4281-b951-d872f2087c98

CL http://codereview.chromium.org/6162008 broke descriptions for pepper plugins.
This puts it back to the previous state (we don't have a way to separately give
mime type descriptions vs plugin descriptions)

BUG=cros:11298
TEST=Flash on CNN

Review URL: http://codereview.chromium.org/6327019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72569 0039d316-1c4b-4281-b951-d872f2087c98

Adding a refcounted PepperViewProxy so that we can detach PepperView when
ChromotingInstance is destroyed. PepperViewProxy also performs the task of
thread delegation for PepperView so we can assume PepperView is used only on
pepper thread.

BUG=65696
TEST=None

Review URL: http://codereview.chromium.org/6359010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72568 0039d316-1c4b-4281-b951-d872f2087c98

Only works with logs created by the new "--log-net-log=file",
which writes NetLog events to the specified file, regardless
of other logging command line parameters.

Using "--log-net-log" without a file name will just write
NetLog events to VLOG(1), as before.

BUG=63687
TEST=None

Review URL: http://codereview.chromium.org/6025017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70782
TBR=ahendrickson

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72566 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony,yuzo
Review URL: http://codereview.chromium.org/6263013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72565 0039d316-1c4b-4281-b951-d872f2087c98