- 09 Dec, 2020 40 commits
-
-
Xida Chen authored
The root cause of this crash is: At DiscardableImageMap::GatherDiscardableImages, we got early exist when the PaintOp::ComputePaintRect. The early out makes sense because there is nothing to paint if the paint rect is empty. Due to the above early out, the |paint_worklet_records_| in the PictureLayerImpl is empty. But later on at DrawImageRectOp::RasterWithFlags, we do not have the same check using PaintOp::ComputePaintRect, so it will try to look for the RasterContent in the |paint_worklet_records_|. The solution is that at DrawImageRectOp::RasterWithFlags, if the PaintOp::ComputePaintRect is empty, we should just early return because there is nothing to paint, so no paint record at all. Bug: 1095163, 1156955 Change-Id: Ic46636cfe7c256f58261430e07c9ff3a9efa6c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570548 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#835369}
-
Xida Chen authored
This is the reland of: https://chromium-review.googlesource.com/c/chromium/src/+/2549530/15 The above CL was reverted because it causes a layout test to fail on dgb build. To re-land it, I mark some of layout tests flaky because from the flaky dashboard, I can see that these tests were flaky even before the above CL was landed. It would require time to investigate the flakiness. PS#1 is the original CL and PS#2 has the change. Bug: 1139008 Change-Id: Id530452d98ffa2b981c9dc9add660758f09ac265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579949Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835368}
-
Mohsen Izadi authored
We expect that EventMetrics::Create() is called with non-null event timestamps. However, not all tests setup events properly and this has caused issues for some build bots. Removing the DCHECK temporarily until we investigate the failing tests. Bug: 1157090 Change-Id: I046cc8b1e0e7b52a80c1e9f1fc218c82b40cb3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582606Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835367}
-
Andres Calderon Jaramillo authored
This CL removes the usage of the GpuMemoryBufferFactory from the VaapiVideoEncodeAccelerator. This is because the GMB factory is not really needed to allocate buffers and not having it simplifies things. Note that we must start the |encoder_task_runner_| with base::MayBlock() because the first encoder to make use of this path will open the render node. Bug: b:173167846 Test: video.EncodeAccel.h264_720p_nv12_dmabuf on atlas Change-Id: Iafa78e7027d65182408416cba2ad6f997b24c299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568549 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835366}
-
John Lee authored
Bug: 1083307 Change-Id: I5bcc6fb7ca061db2b43c5f8a87876ef0f30a4cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580427Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#835365}
-
Ryan Sturm authored
The service worker navigation preload is issued as part of a Service Worker navigation URLLoader interceptor. In a similar vein, Search Prefetch uses the same type of interceptor, but at lower priority. Once Service Worker has decided to intercept the navigation (generally, this means there is a fetch handler), it issues a direct network service request to get the resource when navigation preload is enabled in the service worker. This means lower priority interceptors are never consulted (i.e., app cache is not consulted, which is good; search prefetch is not consulted, which is not ideal). This CL adds functionality to handle synchronous interception decisions, but stops short of copying the interception logic in the navigation pathway that handles asynchronous decisions with multiple interceptors. Bug: 1155330 Change-Id: Iae225c0b4926946a4ec9fccc5dc5d240dc53c058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570392 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835364}
-
Andre Le authored
Reduce icon size for phone signal when connected and add extra padding for battery label. Bug: 1106937,1126208 Change-Id: I4190ffa78c3774e2cc2408bf4e227abfb465ba9f Fixed: 1154527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575402Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#835363}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I28dd398ae34e7e7ce876c6d0eb644decc0f39d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582731Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835362}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/83448c4da727..627f4a6b8dc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If0701308e824041777151c7bc0fdbeb233bc5550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835361}
-
Nate Fischer authored
No change to logic. This disables HistoryActivityTest.testOpenSelectedItems because it's flaky. Tbr: twellington@chromium.org Bug: 1157189 Test: None Change-Id: Iaa1991e3ba978937d3470b8ca8ad93a37e7f2e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582826Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835360}
-
Glenn Hartmann authored
Change-Id: Ie4be68f2c648e0ea43d5494e7211df2b27a21d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582903Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835359}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6f117ee1befb547561f9fa3d6220468db9ece931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582692Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibba904d1e8faa57d98bc9ec717d72693d9fa2dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582727Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#835357}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/195917c0be32..c82eeeef0783 2020-12-09 dneto@google.com re-enable Tint testing 2020-12-09 dneto@google.com spirv-reader: convert signedness of texturing result when needed 2020-12-09 bclayton@google.com Implement textureLoad() 2020-12-09 bclayton@google.com transform: Fix Manager::Run() with no transforms 2020-12-09 cwallez@chromium.org CMake: Add a flag to control whether to built tint_unittests 2020-12-09 dneto@google.com spirv-reader: Fix signedness for extended instructions 2020-12-09 dneto@google.com spirv-reader: support ldexp 2020-12-08 dneto@google.com Fix doxygen for src/transform/first_index_offset.h 2020-12-08 enrico.galli@intel.com [transform] Add first index offset transform 2020-12-08 bclayton@google.com Fix spelling mistake in comment 2020-12-08 bclayton@google.com Update texture intrinsic writer tests for signed params If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Iff77df4fcfc1c826d7eaed5d0c62fdacaad586b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582686Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f0f79e083662..378653f844d4 2020-12-09 xinghua.cao@intel.com D3D: throw a perf warning for uniform block If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ib071c0c50127b66ef568382fcc74ba98de2368ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582183Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53c2ae23b73c..c3ea632dc5db 2020-12-09 mathias@chromium.org Add <title> to entrypoint HTML document 2020-12-09 chrche@microsoft.com Make collect-strings work with .ts files 2020-12-09 chrche@microsoft.com [Loc] Migrate input to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:864768 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I29bac46d10e050efea759bc67bc31061ebe1384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582685Reviewed-by:
-
Illia Klimov authored
Flash has been removed from Chrome almost entirely. Ephemeral provider was used only by these two content settings - PLUGINS and PERIODIC_BACKGROUND_SYNC. PERIODIC_BACKGROUND_SYNC is no longer registered and PLUGINS is deprecated. Bug: 1149381 Change-Id: Iae296732d1caaf9ff8e55ab484bbf8384e79a33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577782Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#835353}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607493425-f89e2101ace78ecc71e64b80849cb2e4ad48ac79.profdata to chrome-win64-master-1607525538-a962c6e7f864d3587aeaa1e7bb0caf9929474c9a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I08ceb0821bdf353a821b44486c87787ed8479658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582179Reviewed-by:
-
Yaron Friedman authored
BUG=783819 Change-Id: I57be107bbf7203b41b40d570ff4c4aa28beab644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577589 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835351}
-
Andrew Xu authored
This CL does the following things: (1) Note that a clipboard history menu item is removed asynchronously. This CL ensures that only the menu item finally selected is announced. (2) This CL also changes the a11y announcement when a manu item is removed. Bug: 1150503 Change-Id: I0ea16ff1b93cdb3a749833c2e0b08a3616e79108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513749Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835350}
-
Jeffrey Kardatzke authored
BUG=b:153111783 TEST=HEVC 10bit files play on volteer Change-Id: Iaeb7e3d423f0c8b9b0672203f0637fb21c4f61ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582802 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#835349}
-
Nektarios Paisios authored
Once a getter method is not marked const, it could force other parts of the codebase to drop const as well, requiring a larger refactoring to fix in the future. Also took the opportunity to add a comment describing the related member variables and clarify some other comments. Split out from a larger patch dealing with ignored Views. AX-Relnotes: n/a. TBR=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: Ic7c4f6d38f83ef2a22401b0edd342cef5f61c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581220Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#835348}
-
George Burgess IV authored
This target comprises 1.17% of our total Chrome samples on CrOS, but isn't optimized for speed. It may be worthwhile to optimize it in this way. Bug: 1143481 Change-Id: I9432b15330ab4fadf79a643a3abc54e8b59ed0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507829Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#835347}
-
Julian Pastarmov authored
This changes the level of the policy to recommended if it is set to enabled and the level isn't recommended to make the policy compliant with the privacy expectations of the browser. Bug: 1155602 Change-Id: I133a7cd58a729fae06c151c742569cf5c80cb500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575056 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#835346}
-
Amanda Deacon authored
This is a very small change which affects 30 bugs. All 30 bugs relate to near-expiring histograms with the suffix CpuTimeMicrosec or TotalMemoryDeltaKb. View the relevant bugs: https://bugs.chromium.org/p/chromium/issues/list?sort=summary%20id&q=owner%3Aamandadeacon%40chromium.org%20%22Check%20expiry%22&can=2 Bug: chromium:1151993, chromium:1151994, chromium:1151995, chromium:1151996, chromium:1151997, chromium:1151998, chromium:1151999, chromium:1152000, chromium:1152001, chromium:1152002, chromium:1152003, chromium:1152004, chromium:1152005, chromium:1152006, chromium:1152007, chromium:1152008, chromium:1152009, chromium:1152010, chromium:1152011, chromium:1152012, chromium:1152013, chromium:1152014, chromium:1152015, chromium:1152016, chromium:1152017, chromium:1152018, chromium:1152019, chromium:1152020, chromium:1152021, chromium:1152022 Change-Id: Id0f3ee9d6fb988ffe3ede8e4ddc32852a1b0cb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580379Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Amanda Deacon <amandadeacon@chromium.org> Cr-Commit-Position: refs/heads/master@{#835345}
-
Jesse Schettler authored
Bug: 1153405 Change-Id: I076eb7e4868a9671553426a0a247116fd20bb54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583102 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835344}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607515179-092361bc7a185424dad74bccdfea645817af1d61.profdata to chrome-mac-master-1607536746-da55b5a139e52763d98214355eab95e70f45f788.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id0c43f51a9e0a83203453e94f8daf565389bfdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582689Reviewed-by:
-
Rune Lillesveen authored
This line was added for a wpt import not changing this test or code. The test was actually renamed and modified[1] and there was an existing line for it. [1] https://crrev.com/aa3b0d88e9377209b6d53345c792528805a59c46 Bug: 1156501, 846656 Change-Id: I411b9c32fc8387f8d80f5d5443f640782377fc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574988Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835342}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f87c8f0d0c37..3bb1e43440ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC skare@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968 Tbr: skare@google.com,anthonyvd@google.com Change-Id: Iec48a0b8030cc1b825f7e5d5136f39712ef1dc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582527Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Travis Skare <skare@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835341}
-
Vladimir Levin authored
This patch adds an intermediate class to help with the document transitions. The idea is that Blink would create this request, and transfer it to the compositor on commit. When the compositor decides to submit a frame to viz, it would then construct viz directives from this request and send it over to viz. This patch also adds an include and a type usage in Blink to ensure presubmit is happy. R=khushalsagar@chromium.org Bug: 1150461 Change-Id: I8e2bcc18b8bd9f1de0d057a8bf608365ac5aa10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574600Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Max Curran authored
load. This CL adds tracking of the time between calls to LogTranslationStarted and LogTranslationFinished of the TranslateMetricsLoggerImpl class. The maximum such time is stored for each page load, and will later be logged via UKM. Note that this time corresponds to the what the user experiences between requesting a translation and the page being updated with the translation. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I142300e2f472c1de713e9035b5669f1e3d2c2c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572121 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#835339}
-
Sigurdur Asgeirsson authored
This is a reland of 7fb78e28 The crashes and DCHECKs should be fixed with https://crrev.com/c/2581939. Original change's description: > PM: Enable service worker relationships. > > This change is to get some DCHECK crashes on Albatross. It will be > reverted after it's been on Canary for a day or so. > > Bug: 1143281 > Change-Id: I6d125dfbae9699e7292a9aa0336070b005bd03c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571638 > Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833405} Bug: 1143281 Change-Id: I52a8332dcd151cd42d6e85f5bbaf4dc094e7d995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582726 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#835338}
-
Ryan Hansberry authored
These metrics are currently prefixed with "Nearby.Share". Nearby Share is an application that depends on the Nearby Connections library. In reality, these metrics actually instrument an implementation of the Nearby Connections library, not an application like Nearby Share, and should instead be prefixed with "Nearby.Connections". This mistake was made because this logic resides in a 'nearby_sharing' directory, which is an unfortunate historical artifact. All of this logic needs to eventually be migrated to a more generic location, but more urgently, these metrics need to be migrated to their correct prefix. The previous metrics, prefixed with "Nearby.Share", have only been deployed to dev-channel, for a week, and will never be used, so I have not applied aa 'obsolete' label to them, opting instead to outright remove them. Bug: 1123172 Change-Id: Ia22407469f4bc9a7f84813c17e37a5ce5d888624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580907Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#835337}
-
Yuheng Huang authored
Add this metric to track time and frequency of infinite list update. Use benchmark_value instead of benchmark_begin and benchmark_end to avoid event interference by overlap. Bug: 1099917 Change-Id: I5e623acc723cd220da1fa1b06a1a8d6cbd749856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580508Reviewed-by:
Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835336}
-
Joe Downing authored
I noticed today that the file logger in Windows still wrote a file after I disabled it via the registry. I tracked the issue down and it's because the current impl starts the file/event log loggers if the registry key exists (instead of checking for existence and then checking the value). This CL fixes that by only creating the logger instance if the pertinent reg key exists and has a non-zero value. Change-Id: I2dabd7c52af831af228fbc2217ced7fd14126ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582425 Auto-Submit: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#835335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bfb5e2c0. With Chromium commits locally applied on WPT: 8a17eed8 "Fix sandbox flags inheritance with javascript-url." bf9563fb "Revert "IO: Use pre-margin target rect for an empty check for intersection threshold"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia4e3c6fcdd864c910628734ab4b65599a4d55abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581687Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835334}
-
Jeffrey Kardatzke authored
Obviously the wrong variable name was used here, fix it. Fuzzer caught this. BUG=chromium:1157168 TEST=Fuzzer test passes now Change-Id: I55a33b1ec1ddaf5f7f30e27608b87b57ddcb062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582507 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835333}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eb597ff5b7f6..8837f2e7f4f0 2020-12-09 natsu@google.com Update AHB default YUV dataspace to YCBCR_709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I16782ea4d5c9393ffe23a159e677bcd60798443b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582185Reviewed-by:
-
Nina Satragno authored
Do not call AuthTokenRequester::InternalUVLockedForAuthToken() until an authenticator has been selected. This fixes a bug where tapping an authenticator that was not uv-locked would still show a uv-locked warning if another uv-locked authenticator was also plugged in. Fixed: 1154872 Change-Id: I518c57524513ea3663b0c0d6d39f0ccaf7ef17ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580144 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#835331}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/. Bug: 1113033 Change-Id: Icd19286adba43b2f52ef49b874dd8116de00dbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572728 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#835330}
-
