- 06 Feb, 2019 40 commits
-
-
sebsg authored
Bug: 920663 Change-Id: Ieec35e703fe5fd0619c70c800879b0f8995afd8b Reviewed-on: https://chromium-review.googlesource.com/c/1450021 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#629612}
-
Miguel Casas authored
This CL address multiple cleanups I found during crrev.com/c/1452720: - Removes unused member variables. - Makes IsValid() non-const: const for no reason; but makes some member vars const. - Prefers early return: fights arrow code. - Removes unnecessary {}. - Collapses if()+if() conditions. - Removes unnecessary enum and uses constexpr next to the only use site: makes it clearer. No new functionality intended. Test:webkit_unit_tests --gtest_filter=Canvas2DLayerBridgeTest*:CanvasRenderingContext2DTest* Bug: 927103 Change-Id: Ic2e6e26e3792d186a5d3f7671f0c7021315478a4 Reviewed-on: https://chromium-review.googlesource.com/c/1452618 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#629611}
-
Robert Liao authored
Win32 system colors currently don't support Dark Mode. As a result, fallback on the Aura colors. Inverted color schemes can be ignored here as it's only true when Chrome is running on a high-contrast AND when the relative luminance of COLOR_WINDOWTEXT is greater than COLOR_WINDOW (e.g. white on black), which is basically like dark mode. BUG=928378 Change-Id: I71ae0c1dd13213278461c04f50ae8ae8e5599a87 Reviewed-on: https://chromium-review.googlesource.com/c/1455646 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#629610}
-
Pedro Amaral authored
Native page theming and background colors are confusing. I believe the correct behavior for native pages is to have theming be done only based on incognito state which means we can use TabThemeColorHelper#getDefaultColor() as the native page's theme color. As for background color all BasicNativePages except for IncognitoNTP have the background color set to modern_primary_color. IncognitoNTP has it set to ntp_bg_incognito. So I made BasicNativePage#getBackgroundColor() return modern_primary_color and overrode that method in IncogitoNTP to return the ntp_bg_incognito color. Bug: 927692 Change-Id: I85065739a27074949e7b4636d82d0ac11d6f021c Reviewed-on: https://chromium-review.googlesource.com/c/1453551 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629609}
-
Dale Curtis authored
Will be useful in determining if there are any regressions between dav1d and libaom when playing AV1 content. BUG=924370 TEST=chrome://histograms has the histogram during playback. Change-Id: Icb9d8466d267226ba20ff356bada0486c8486c94 Reviewed-on: https://chromium-review.googlesource.com/c/1450736 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Renjie authored
Change-Id: I610e1b1ac312232187422a94743b6415d98c4731 Reviewed-on: https://chromium-review.googlesource.com/c/1455616 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629607}
-
Francois Doray authored
With this CL, PriorityQueue keeps track of the number of Sequences of each TaskPriority that it contains. This will be used in an upcoming CL to ensure that the appropriate number of workers are woken up when new Sequences are scheduled or when the maxmium number of tasks that can run concurrently is updated. Bug: 889029 Change-Id: I644dc3fb5d59f9f408b99d35af8a8187b03cf313 Reviewed-on: https://chromium-review.googlesource.com/c/1452484 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#629606}
-
John Delaney authored
This test is flaking on bots due to incorrectly recording the size of adframes with a display: none style. The underlying problem is that display:none frames do not send size updates to the browser process. As such, in this test there is a race condition between the first size update being sent, and the display property being set on the frame. Because we do not really care about the size of display:none frames as they are not visible to the user, I will remove this part of the test and replace with a TODO until the underlying issue can be solved. This was previously not flaking because we did not record the size of display:none iframes. FintIt: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjQ5NjAyODVhYzAyYmYzM2M0NjNhZjI5MmQ5ZTVhNzZkN2JlNWUzZAw Bug: 924357 Change-Id: I12ff78c8aad14cd44767ce916e162e53636e4c6c Reviewed-on: https://chromium-review.googlesource.com/c/1456496 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629605}
-
Abhijeet Kandalkar authored
This CL replaces usage of SigninManager and ProfileOAuth2TokenService with IdentityManager and also removes respective headers. Bug: 920229 Change-Id: I4241e1c5914e92cf4a3b92e8889a036007222d05 Reviewed-on: https://chromium-review.googlesource.com/c/1454105Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#629604}
-
David 'Digit' Turner authored
This CL modifies the implementation of third_party/ashmem/ to use the ASharedMemory function provided by libandroid.so when possible (i.e. starting with API level 26). This is in preparation for the future removal of the Ashmem device from Android. The libandroid functions will provide working alternatives, but pin/unpin will probably not work anymore. The current code will try to use Ashmem ioctls whenever possible, i.e.: - Perform runtime probing to determine the system's current API level. - If API level is below 26, do not change the way regions are created / managed through the Ashmem device file and ioctls. - If API level is 26 or above, exclusively use the libandroid functions related to ASharedMemory to create / size / protect regions. Even if this currently wraps ashmem device open() and ioctls(), this may change in a future Android release but these APIs will keep working as intended. - If API level is 26 or above, try to detect that the Ashmem device is available, and if so, continue performing pin / unpin on it. If this is not the case, these operations become no-ops. NOTE: A CL was uploaded to disable this explicitly by faking a non-Ashmem device to verify that this didn't break our unit tests. See patchset 8 at [1] + Remove ashmem_purge_all(), since it was unused. + Add ashmem_device_is_supported() since this must be surfaced to avoid breaking one unit-test that checks for explicit behaviour that cannot be supported in the future. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1450259/8 BUG=914650 R=lizeb@chromium.org Change-Id: Iffee23bf8bad8b68a3efdb2208c0a9494432731b Reviewed-on: https://chromium-review.googlesource.com/c/1454628 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#629603}
-
danakj authored
We null away the WebViewClient already, but once the WebWidget parts are closed we want to accept the RenderWidget (ie WebWidgetClient) being destroyed. So drop the pointer to the WebWidgetClient when the main frame is detached from Close(). R=dcheng@chromium.org Bug: 912193 Change-Id: Ib4e0916c5e4cefaf49cb529135d38010809c3ea0 Reviewed-on: https://chromium-review.googlesource.com/c/1454135 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629602}
-
Eric Orth authored
Motivation is that HostResolver::Resolve() is soon to be deleted and all usage converted to CreateRequest (or to network service APIs). Need to ensure cronet/StaleHostResolver continue working during transition. Fully implemented StaleHostResolver::CreateRequest(). StaleHostResolver::Resolve() now implemented using CreateRequest() and HostResolver::ResolveLegacy(). As the new API is more focused on the ResolveHostRequest object, it made more sense to convert the StaleHostResolver::RequestImpl to be a direct implementation, rather than using a separate Handle. Main difference is lifetime semantics. The object is now owned by the client instead of self-destroying on completion. Extra orphaned requests (allowed to complete to backfill the cache) are then detached to be owned by StaleHostResolver instance itself as the client will likely destroy the request after getting results. With added weak ptr back to StaleHostResolver, it became simpler to have RequestImpl directly read options_ and implement the stale usable checks rather than pass in a callback. Bug: 922699 Change-Id: Iadb48c0d574cc47ff6f79a6d313164b126c1d76d Reviewed-on: https://chromium-review.googlesource.com/c/1452699Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#629601}
-
Dominik Röttsches authored
We no longer rely on ttf-mscorefonts for Debian or Linux testing, the special instructions on how to add the contribu repository to Debian can be removed. Change-Id: Ieabbc527dc47db294f394261087274fca3c54c6b Reviewed-on: https://chromium-review.googlesource.com/c/1455916 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#629600}
-
Etienne Pierre-doray authored
Now that Zucchini based patches are shipped by default, try Zucchini first and use Courgette/Bsdiff as a fallback. Change-Id: If2c34892c47fe8b22866ee2e1b6bb52800fceeb5 Reviewed-on: https://chromium-review.googlesource.com/c/1455457 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#629599}
-
Sahel Sharify authored
With autoscroll being handled by browser side fling, there are GSU events with AUTOSCROLL source device type. This cl fixes the assumption of not wheel is equal to touch in input_handler_proxy and layer_tree_host_impl. Change-Id: Id5c54245aa10c6e958fe4e3a8ec7d338923101db Reviewed-on: https://chromium-review.googlesource.com/c/1081163Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629598}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf5dbd8d67fe..eb47e2c4bd08 git log bf5dbd8d67fe..eb47e2c4bd08 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 syoussefi@chromium.org Vulkan: improve calculation of swapchain image count Created with: gclient setdep -r src/third_party/angle@eb47e2c4bd08 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I6045c32ffe351c5c7f88618e6fc358f622ace5fd Reviewed-on: https://chromium-review.googlesource.com/c/1456437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629597}
-
Sergio Villar Senin authored
ChildAccountService listens to GaiaCookieManagerService for notifications about signed in/out accounts. The code was starting to observe in the constructor and stopping in the destructor. That is not totally correct as services should start observing in Init() and stop on Shutdown(). Moved the AddObserver/RemoveObserver calls to their proper locations. Bug: 921007 Change-Id: I6a0afef6845ab59c2f7bf4994cb8a9c90b8ef034 Reviewed-on: https://chromium-review.googlesource.com/c/1454500Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Andrew Grieve authored
No behaviour change Change-Id: I457a35b215c545a5049b67739607aa5b331ca301 Reviewed-on: https://chromium-review.googlesource.com/c/1455115 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#629595}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e956049450f6..faa44a4c490b git log e956049450f6..faa44a4c490b --date=short --no-merges --format='%ad %ae %s' 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@faa44a4c490b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: If3548c7f23c6f546c80b49cdab3c0088553257e4 Reviewed-on: https://chromium-review.googlesource.com/c/1456436Reviewed-by:
-
Tibor Goldschwendt authored
This fixes a bug where Chrome is left in the black state after resuming. Bug: 927031 Change-Id: Idc26d76ceff7b9555bd551ab84fa6af039291ba2 Reviewed-on: https://chromium-review.googlesource.com/c/1456220 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#629593}
-
Mirko Bonadei authored
More info: https://webrtc-review.googlesource.com/c/src/+/120930. Bug: webrtc:8620 Change-Id: If1e7ca21db44d6e3c97c62142421fa3128e008c0 Reviewed-on: https://chromium-review.googlesource.com/c/1454898Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#629592}
-
Sam Maier authored
This is a reland of 8e470e32 Original change's description: > Rerouting all Java tasks through TaskRunner API > > Pre-native Java tasks are now having their priority set when started. > Also switches dynamicmodule's ModuleLoader to use the TaskTrait's > priority setting instead of manually setting the thread priority. > > Bug: 863457 > Change-Id: Iee601ca1e18e2637f8e930c6d212c8115e682fc3 > Reviewed-on: https://chromium-review.googlesource.com/c/1407374 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626095} Bug: 863457 Change-Id: Icf625b8df9e8335d9f59e979a9cbf423dec1af04 Reviewed-on: https://chromium-review.googlesource.com/c/1439300 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Robert Flack authored
In order to dispatch transitioncancel we need to allow dispatching events for non animation frame timing updates as a canceled transition does not run on the next frame. Bug: 642487 Change-Id: I1225b60dc1666d5f225f9ddff1b3f9603b1b378b Reviewed-on: https://chromium-review.googlesource.com/c/1450047 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#629590}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4cf541859e6..a2d5f7847748 git log c4cf541859e6..a2d5f7847748 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 machenbach@chromium.org Add fetch config for new node-ci repository. Created with: gclient setdep -r src/third_party/depot_tools@a2d5f7847748 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If9dc33922a4e74dcc596b111f5f79e86b6b193c7 Reviewed-on: https://chromium-review.googlesource.com/c/1456439Reviewed-by:
-
David 'Digit' Turner authored
This CL adds Android resource strings xml files to various android_resources() targets, which didn't previously included them to avoid embedding them inside Chrome APKs (in order to save space). However, a previous CL [1] has changed the way resource strings are packaged by our build system, with better control of how these end up inside APKs and App Bundles. In a nutshell, these new strings will only be added to app bundles, while APKs will still be limited to our subset of 45 locales (out of 53) to reduce install size. Most of the changes here were performed automatically by simply running the following command: build/android/check_android_grit_strings.py \ --scan-dir . \ --fix-inplace Which was written to fix BUILD.gn and GRIT input files. Other changes include: - Adding the necessary lines to build/android/lint/supressions.xml - Changing the definition |ui_locales| in ui/android/BUILD.gn to include the new locales as well. I have manually verified the content of the newly generated packages using build/android/dump_apk_resource_strings.py, i.e. that: - The output of Chrome / ChromeModern is unchanged (both public and internal versions). - The output of SystemWebview and Monochrome includes new translations for existing WebView-related strings. This is responsible for an increase of about 26 kiB in size. - The output of Chrome / ChromeModern / Monochrome bundles include new strings for the 9 new locales. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1448169 BUG=882860 R=agrieve@chromium.org, estevenson@chromium.org, benmason@chromium.org, yfriedman@chromium.org, boliu@chromium.org Change-Id: Id233e1974d0102f444c8194dcce2f21a9e923899 Binary-Size: Increase is due to new translations for WebView strings. Reviewed-on: https://chromium-review.googlesource.com/c/1448170 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#629588}
-
Sami Kyostila authored
If BrowserChildProcessHostImpl is deleted before a pending child process launch has finished, child process disconnection can be notified without a valid process id for the child process. This patch changes the child exit observer to deal with this case. By code inspection both clients of this class (AwBrowserTerminator, ChildProcessCrashObserver) can already deal with notifications without a valid process id. Bug: 863341 Change-Id: I4237b1df68072263916e31dd23684519b6810bd4 Reviewed-on: https://chromium-review.googlesource.com/c/1455944 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629587}
-
Alexander Dunaev authored
Two issues have been discovered and resolved: - The client is now destroyed properly when the test server thread is stopped, so the socket descriptors are freed. - The buffer manager now handles the passed file properly so the file descriptor is freed. R=msisov@igalia.com Bug: 873132 Change-Id: I8aabc38da915b61987a995a94fe7c343ce982f06 Reviewed-on: https://chromium-review.googlesource.com/c/1454530 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#629586}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27a01705d27f..dac626c6844c Created with: gclient setdep -r src-internal@dac626c6844c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icceae0f87bb62c0e5195193f69e53b1da072b48a Reviewed-on: https://chromium-review.googlesource.com/c/1456189Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629585}
-
Nasko Oskov authored
This CL updates some navigation unit tests to use the NavigationSimulator code, which abstracts a lot of details in how navigation works away and allows navigation unit tests to focus on the key properties to test without lots of boilerplate code. Bug: 918565 Change-Id: If13f329f8ffa8b051eb4fc9f912fadc23783700a Reviewed-on: https://chromium-review.googlesource.com/c/1453582Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#629584}
-
Dan Harrington authored
Bug: 883486 Change-Id: Ic698365fead980646255f6026a393af7a374b11c Reviewed-on: https://chromium-review.googlesource.com/c/1454805Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#629583}
-
Michael Lippautz authored
DragState is a ScriptWrappable which can keep alive JavaScript upon unified heap garbage collection resulting in a leak of the last Window that used a drag event. Clear the state when the drag ended. Bug: 843903, 928781 Change-Id: Id86a1a917fe772f56fb679e1d73ef3453785ce6d Reviewed-on: https://chromium-review.googlesource.com/c/1456073Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629582}
-
Ivan Sandrk authored
There was a bug in locked fullscreen where docked magnifier mode wasn't properly cleaning up after being closed - the pinned (fullscreen) window wasn't being restored to it's full height (it kept the smaller height into which the docked magnifier pushed it). Bug: 901485 Change-Id: I4121444506a0da349f8a1ea300c225a7c32b434d Reviewed-on: https://chromium-review.googlesource.com/c/1454629 Auto-Submit: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#629581}
-
Andrew Grieve authored
* Add example in docs * Don't store previous sources value (there is none) Change-Id: I5b876905d4117a7f9d1966a70ce7134aef3110b8 Reviewed-on: https://chromium-review.googlesource.com/c/1455340 Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#629580}
-
Michael Spang authored
- Paths intererpreted by GN such as paths in inputs, sources, lib_dirs, etc should either be relative to BUILD.gn, or GN-absolute (relative to source root and start with "//"). They should not be rebased as system-absolute paths; those are only needed for paths that are actually outside the source tree. If paths are used in multiple contexts, rebasing should be deferred until they are used in a context where rebased paths are required. - Paths passed as arguments to scripts should be rebased on root_build_dir, which is the current working directory of the build. They should not be rebased on root_out_dir, as that is only the current working directory for the default toolchain. Using root_out_dir in place of root_build_dir breaks cross compilation. They should also not be resolved to system-absolute paths, as that introduces an undesired dependency on the location of the source tree. - The 3rd argument to rebase_path has no effect for GN-absolute paths, which includes all paths built by appending to predefined variables such as root_out_dir. Change-Id: I54ff2d9fed0daadacf5bd1bd8fdadc561c3a2882 Reviewed-on: https://chromium-review.googlesource.com/c/1448694 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629579}
-
Tim Volodine authored
Disable failing test due to permission model change. Failing on WebView M and N bots. (filed crbug.com/929129 to track this issue) BUG=927055,929129 NOTRY=true TBR=ntfschr@chromium.org,toyoshim@chromium.org Change-Id: I9dd4e11036b5a2bc4205da551008423b6ce40350 Reviewed-on: https://chromium-review.googlesource.com/c/1456576Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Auto-Submit: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629578}
-
sebsg authored
external/wpt/html/dom/interfaces.worker.html is failing consistently. Tbr: tkent@chromium.org Bug: 929122 Change-Id: Ic11fbea14f6b0ce84cc3d34c93af6b33922ead32 Reviewed-on: https://chromium-review.googlesource.com/c/1456282Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#629577}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/1a51a5b4a6bdf7ee11b443f21f08dc2ba2de9815..70fe6105565e71e44e0a2a4ee617a26fd8fdcd96 The following commits have Chromium bugs associated: d7266ecc9 Enforce key usage for RSA keys in TLS 1.2. Bug: 795089 Change-Id: Icd7b0f0e2bf96fdd56b1a740766576d2d6484265 Reviewed-on: https://chromium-review.googlesource.com/c/1455639 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#629576}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/484d74fa21a5..c4cf541859e6 git log 484d74fa21a5..c4cf541859e6 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c4cf541859e6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idd6673eb41507a2d9e871bb5fd296c135f5f1e71 Reviewed-on: https://chromium-review.googlesource.com/c/1456396Reviewed-by:
-
Roman Aleksandrov authored
Currently in Chrome OS the upgrade_detected_time is reset on each new update downloaded. It causes RelaunchNotificationPeriod policy could never force install new version of Chrome OS. upgrade_detected_time should be set once when first upgrade downloaded and becomes null due ChromeOS relaunch to install new upgrade. Bug: 928266 Change-Id: Ibd7c8829685e278e5579c08a11e70cc848bec426 Reviewed-on: https://chromium-review.googlesource.com/c/1452168Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f408d006a60..38c83b97138a git log 3f408d006a60..38c83b97138a --date=short --no-merges --format='%ad %ae %s' 2019-02-06 solenberg@webrtc.org Remove unused file. Created with: gclient setdep -r src/third_party/webrtc@38c83b97138a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b5086d806c09b18b7951edb98f87613abdf7c31 Reviewed-on: https://chromium-review.googlesource.com/c/1456197Reviewed-by:
-
