- 05 Jan, 2021 40 commits
-
-
Sergey Ulanov authored
Previously FuchsiaAudioRenderer was stopping at EOS without updating buffering state to HAVE_ENOUGH. This means that when stream is seeked to the end of file playback never resumes. Fixed it to update buffering state as soon as EOS is reached. Bug: 1162503 Change-Id: I57d6a08469830c069a13252c4767f3b7f57ed24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606034 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840224}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Icb72de6d168cde6195662ee906cd8fd28d4836c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610926Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840223}
-
Stephen McGruer authored
Bug: 1163175, 1163176, 1163178 Change-Id: I1e11bb23cd9212a7da2439d65e6acfec7865b2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611285 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#840222}
-
Dominique Fauteux-Chapleau authored
This relands crrev.com/c/2590429 with the exact same changes, except with some changes to avoid the CFI error that caused a revert (crrev.com/c/2597715). Those differences with the original CL can be seen by looking at the patchset 1-3 diff. This is a reland of 4ee6e77f Original change's description: > Add profile DM token reading code to ConnectorsService > > This adds the main code to read the DM token from the profile instead of > CBCM. The PerProfileConnectorsEnabled feature guards these changes from > affecting working Connector policies. This change is insufficient to > test per-profile Connectors since the authentication and reporting code > still assume the DM token is from the browser. > > This adds a tweak to Connector policy test setters to ensure existing > tests don't break and still use the browser DM token. > > Bug: 1148789, 1155585 > Change-Id: I64bb1714667b0b61fdfdbadffbc153328e22f741 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590429 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838139} Bug: 1148789 Bug: 1155585 Change-Id: Ic69ae3760171932f1f7dde8674a90b860ce22b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603586Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840221}
-
Tanmoy Mollik authored
Replace IdentityManager.Observer.(onPrimaryAccountSet/Cleared) calls with onPrimaryAccountChanged call. This cl also fixes an issue where the IdentityDisc is not shown until first refresh when the user signs in without sync consent. Bug: 1132291, 1158855 Change-Id: Iefec79c38f39af8927ac5a30648e19f398e16401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598915 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840220}
-
Ryan Sturm authored
BF and restore navigations are allowed to use cache even when the cache-control headers would otherwise require revalidation. When this occurs on a previously served Search Prefetch URL, Chrome should attempt to serve the prefetch response from cache, and then fallback to the navigation URL on the network. Bug: 1162121 Change-Id: I5ec8c82fe772e57acce812987efed2baa3301ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605414Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840219}
-
Gil Dekel authored
Most internal panels expose a single native mode, and for those internal displays with additional modes, Chrome does not have use-cases which require those extra modes. This CL restrict internal displays to expose only their preferred mode to Chrome. Test: ozone_unittests && display_unittests Change-Id: I0f9480846dc7876992110aca0f28e81384a33cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595621Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840218}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc435fa60df6..7d63f91e4a43 2021-01-05 jcgregorio@google.com Add optional --yes argument to tools/install_dependencies.sh. 2021-01-05 johnstiles@google.com Add unit test for casting between float, int and bool. 2021-01-05 mtklein@google.com remove 32-bit iOS builders 2021-01-05 reed@google.com Move to sampling for async-rescale routines 2021-01-05 johnstiles@google.com Implement `roundEven` intrinsic in Metal (as `rint`). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ifbd981e791d5a73afbcd0e7f38a104c7ce07e34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840217}
-
John Abd-El-Malek authored
Missing: publisher URL support currently not working, see https://crbug.com/1158037 Bug: 1144912 Change-Id: I8a3021416c107ff47ea652f60be65c6ddb57b411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600244 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840216}
-
Eric Orth authored
Tests expecting a new popup window (just secure DNS tests) were expecting the new window to always be the "last active" Browser window, but that is apparently not the case despite everything appearing to work correctly with creation of the new popup. Remove checks against GetLastActive(). Also fix cases where it was assumed GetLastActive() could be used as a shortcut to retrieve the popup window. Instead the code for validating creation of the popup window can optionally return a pointer to the created window. Bug: 11139282 Change-Id: Ic900d0deb881eacc53099de07c5e8cdd68b39be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606525 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840215}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609847937-c4d97125a43c3c1ad7fc53512c61f5ef8ccc043d.profdata to chrome-win64-master-1609858728-6f035387130eda965f3c879c319423c426ffdda8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4ec804318f6dd7fa58613c6c34a2523b31a92fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611009Reviewed-by:
-
Ella Ge authored
Bug: 1152282 Change-Id: Ib8179b27a3e04191b44b1f932886ce3bdf74f20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600389Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#840213}
-
Stepan Khapugin authored
Adds the Getaway UI to showcase for convenient debugging/iteration. Improves the UI per new mocks. Capitalizes an existing string (no need to re-translate, only capitalization in En-US changed). Makes the blur less transparent by adding a black semi-transparent view below it. Bug: none Change-Id: I69f9fb932b210143780a9be736201daa6be0a689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602418 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#840212}
-
Bartek Nowierski authored
On one hand, trim down the set of Android bots, because some of them fail even without PA-Everywhere. On the other hand, improve the coverage for the common case, by switching to chromium_gtests, which looks like a very well rounded set of unit tests. Bug: 1121427 Change-Id: Ia816d857fe616cd0cf6bdf9ef4a7bc0df2e4256d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596911 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840211}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bc804095bcad..ee8ca5255488 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idd9a40054e0e502da73b63f20d41b5223d866228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610723Reviewed-by:
-
David Maunder authored
Speedup: 9317ms -> 4019ms (58% speedup) Bug: 1161045 Change-Id: Ifa48f266bc5182b33184816c7100bd87ecebc732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600363Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840209}
-
Devlin Cronin authored
The new doc site forked all the static content into a new repo (outside of Chromium). Remove the old content. Bug: 1161364 Change-Id: I0c3626a783361bdf12bb6a2ed4e55e9aada431b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602445Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840208}
-
Abigail Klein authored
expose role description in AXPlatformNodeMac. This ensures that screen reader users have context about what type of button they are focused on when their focus moves to a bookmarks button. This is particularly important when screen reader users move by accessible pane to the bookmarks bar. This CL also removes the message name IDS_ACCNAME_BOOKMARKS_MENU which was no longer being used. description of UI elements. Bug: 1097760 Change-Id: If8d567bc349d21138fac83b19958aaf340803b09 AX-Relnotes: Give bookmarks buttons a role description and expose role Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605467Reviewed-by:
-
Vidhan authored
AlternativeStateNameMapUpdater is now implemented as an observer of PersonalDataManager that keeps track of any changes in the profile data and accordingly, it updates the AlternativeStateNameMap. Bug: 1111960 Change-Id: I2f12e1e9cb17b5cfcbe1e766d4a4fe928951f4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520897Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#840206}
-
Sebastien Marchand authored
Bug: 1159407 Change-Id: Ibbc21edbc342c5850a3f20679a41a18722850156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595452Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#840205}
-
Matt Menke authored
This matches what components/captive_portal/OWNERS does. Bug: None Change-Id: I59122d9bc35dabc06fecf207f34b683eba6395dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611045Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7adb896f3ba8..30550a74a101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,schwering@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,schwering@google.com Change-Id: I6446b87a23d481ddc5c22a3a5d2e3cecdd083b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610266Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840203}
-
Abigail Klein authored
The name is redundant because the role is also toolbar. Keep the toolbar as an AXNode so that it is a group for screen readers. This allows for easier navigation around the chrome. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2588893. name. Bug: 1097760 Change-Id: I283d0d69b10db2e837575f6b2ce1ae3b7070a044 AX-Relnotes: Keep the toolbar as its own group but remove the redundant Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605468Reviewed-by:
-
Asanka Herath authored
"Identifiability" -> "IdentifiabilityStudy" in `fieldtrial_testing_config.json`. Bug: 973801 Change-Id: I03e8ca482122973eacd643b46f2a26301f4ed811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605354 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#840201}
-
Alison Maher authored
With CL:2587618, we no longer need to check for a Windows dependency in NativeThemeBase::GetControlColor(). Instead, we can call InForcedColorsMode(), which in practice is only ever true on Windows. There is work underway to add a devtools emulation feature for Windows high contrast to allow developers to test their webpages in forced colors mode without a Windows device. This change will likely allow for controls to be rendered correctly in this case. This CL should not result in any functional changes. Bug: 1107431 Change-Id: I268e73ea574dd55c535ae3bb031c1d06b84d1d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590589 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840200}
-
dpapad authored
Fixed: 1163041 Change-Id: Id8ca2ae1832431b5c6cc0c02895ff88acbf09a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609847 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#840199}
-
David Van Cleve authored
A Trust Tokens issuance request is a request created by fetch(..., {trustToken: {type: 'token-request'}}) With the new "platform-provided trust tokens" expansion of the Trust Tokens feature, the request's destination origin can provide configuration indicating that the browser should divert the origin's Trust Tokens issuance requests to system-local providers, on platforms that support this behavior (currently Android). [1] In this case, there's no need to send an HTTP request directly to the destination URL provided in the fetch() call, so we return early via URLLoader::OnComplete(URLLoaderCompletionStatus). We provide a non-net::OK error code to this URLLoader::OnComplete call since we won't receive an HTTP response from the request's destination. Since this case is semantically a success, we don't want it to show up as an error in the DevTools console. This change gives it the same treatment as Trust Tokens redemption cache hits, making it return TRUST_TOKEN_OPERATION_SUCCESS_WITHOUT_SENDING_REQUEST from URLLoader. In order to support the DevTools browser test covering this behavior, this CL exposes some platform-provided issuance support fixtures from trust_token_browsertest.cc in the corresponding header file. [1]: https://bit.ly/platform-provided-trust-tokens Test: A DevTools browser test confirms the request shows as "finished" Bug: 1154847 Change-Id: I2d8a00b780f12faa16052d07ccba88c50dbde848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587436 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840198}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b54debc350a1..fc6b87192db6 2021-01-05 hta@webrtc.org Make the JsepSessionDesription clone() method copy candidates. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaed926c6f4ea9a85552735b7133838bf4ce6f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610816Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1fe7f95b0ecc..75eced6da617 2021-01-05 adithyas@chromium.org Revert "Portals: Fix for duplicate messages after activation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069487,chromium:1158210 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic073db99d1f38b5e919291a9e81436a5bfe7c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608790Reviewed-by:
-
Alison Maher authored
With CL:2587618, we no longer need to block forced colors mode from affecting Mac in blink. The reason being that we are tracking forced colors separately from high contrast in NativeTheme, so we don't need to worry about increased contrast accidentally triggering forced colors on Mac. There is work underway to add a devtools emulation feature for Windows high contrast to allow developers to test their webpages in forced colors mode without a Windows device. This change will likely allow for a proper emulation on Mac. This CL should not result in any functional changes (other than the fact that forcing high contrast will now affect Mac, which is why the forced colors tests now pass on Mac, and various related web tests needed to be rebaselined.) Bug: 1107431 Change-Id: Ie3a3547c927587dd638a53f6307c69aca9d99779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591489 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Austin Sullivan authored
Bug: N/A Change-Id: I403af0c25c2c3b1354cbb5f4fcd07dd9757c16ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602109 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Benoit Lize authored
No need to call the destructor anywhere, and this is also dangerous in principle, since raw pointers to the partitions are captured and used everywhere in blink. Change-Id: I84f62502003ac2bb3da6d1c48e6e28f7e8c81fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607312Reviewed-by:
-
Jesse McKenna authored
This change removes some unneeded using-declarations from content/browser/renderer_host/. This doesn't cover all the files, just some instances I noticed. In a few places where usage was inconsistent, this unifies the usage. Change-Id: I15ab5d80c481efe913285b42f2d7e7fdaff4d913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606189Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#840192}
-
Peng Huang authored
Bug: 1161513 Change-Id: Ia0a82f44b878dbcb7589a2aec9ec597ff517660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600390Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840191}
-
Lily Chen authored
Bug: 1161591 Change-Id: I7615a4cdd970ea42cc6a93ebacc5928d1febbda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610785 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840190}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101050600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/P17q_sHuEKbXoL-17YZCO_KTWxU2eHK2U4HqRas0jY8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/175636382 Tbr: help-app@grotations.appspotmail.com Change-Id: I794d15b5c064d29083a720f89ef7e48fad45e35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610267Reviewed-by:
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Change-Id: Idc37eba5389894123cee25c1cabb1119e63a8bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600238 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840188}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609837154-532701be902ffaddff8f4f0b9fc00b7f3e25a5e8.profdata to chrome-win32-master-1609847937-cf5cc478b4222d5ab5a9c5d5ace2908da8c23e42.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9671c4c3efd709ecf2985b3e719d85bf7604dd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608789Reviewed-by:
-
Ryan Sleevi authored
The unit tests for certificate verification are dependent upon the system clock, because they interact with the system verifier, and as a result periodically expire and require re-generation in order to continue to function. Previously, all of the certificates generated via the Python tools were set to expire on Jan 1, 2021 by default, and have thus all expired. This regenerates the test certs, setting them to expire on November 3, 2021 (a non-holiday Wednesday). Bug: 1162837 Change-Id: I6fc5af79d95a641c15955ef2c6771cfa4d15c17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610066 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840186}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84cad4eea312..ee8ca5255488 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id337fd0fdc49bb5990876990545554c72e33b958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610864Reviewed-by:
-
