- 05 Nov, 2020 40 commits
-
-
Abigail Klein authored
caption bubble. If 5 seconds pass with no activity, hide the caption bubble. Activity is defined as one of the following occurring: - Transcription received from the speech service - User interaction, such as clicking a button or focusing the bubble More refinements to this will occur in a follow-up, such as clearing the caption text. Bug: 1055150 Change-Id: I33c96c09bc89bbfe68b1c8899f3aa5289ed44f76 AX-Relnotes: N/A (feature has not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518129Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#824586}
-
Eugene But authored
According to Stability.iOS.UTE.MobileSessionAppState, a large number of Unexplained Termination Events happen in background. There is an assumption that "clean exit beacon" does not get written because prefs file is protected. This CL allows removing protection in the experiment. The experiment will be run on Canary and Dev to test the assumption. There is no intention to roll this out to Beta or Stable. If experiment will confirm the assumption, then clean exit beacon file will be decoupled from prefs to remove the protection. Bug: None Change-Id: If816c4b3ed28ba5b2649e63526d5cfea93f839c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506175Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#824585}
-
dpapad authored
In preparation of moving all IDR_WEBUI_JS_* resources to webui_generated_resources.grd, the new webui_generated_resources.pak file needs to be included in fuchsia/engine/. Bug: 1132403 Change-Id: I5c762bb01d30401866b266f9b9c374636e78ec69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521841 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824584}
-
Chong Gu authored
Add fuchsia-board-astro tag. Apply tag to flaky/failing tests. Bug: 1080853 Change-Id: If2c42204b690ac8b6ccf3e47d2edea91e73ef622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520719Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#824583}
-
Scott Violet authored
When history adds a page with redirects the transition qualifier is not applied to redirects. This resulted in FROM_API_3 being dropped, and pages that should be hidden being shown. This patch adds FROM_API_3 to CHAIN_END if FROM_API_3 was present in the requested transition. It's only necessary to add for CHAIN_END, as CHAIN_END must be present in order for the visit to be considered visible. BUG=1145208 TEST=HistoryBackendTest.AddPageWithRedirectsAndFromApi3IsNotVisible Change-Id: I4ac41e5385fe58b249532f1251612b6c1112005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521833 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824582}
-
Allen Bauer authored
Add metadata - remove manually overridden GetClassName. Add view builders and update view tree construction to use the builder. TBR=katie@chromium.org Bug: 772945, 938501, 1130078 Change-Id: Id105b26afb15138ee6e70e7ade5e43be11671a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505880Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#824581}
-
Daniel Cheng authored
Bug: 1131879 Change-Id: I12e46e7c7edcbf41a6c51b5f2210a3eaed1412ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521872Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824580}
-
Ben Pastene authored
crrev.com/i/3385048 allocates the machines for these builders, so this can't land until that is deployed. Bug: 1140727 Change-Id: Ib09a59fdfd0aa4bba54a091606c08f76b59c48f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521352Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#824579}
-
Evan Stade authored
Bug: 1144109 Change-Id: I2b61d941b7538cbb504e2b8bab87b9ff2091169a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520201Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#824578}
-
Mitsuru Oshima authored
Bug: None Change-Id: I0235c23d4bb1664d1e701b54dfe196d36cc473db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521200 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#824577}
-
Lijin Shen authored
More unit tests of message queues so that delegate methods are called as expected. Bug: 1123947 Change-Id: Ibc23469925bd68cce19b126f4cc395bcc0877789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505745 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#824576}
-
Regan Hsu authored
* Indents subfeatures. * Clicking on the row of editable features that don't link to a subpage will cause the feature to toggle. Specs: https://carbon.googleplex.com/cros-ux/pages/phone-hub/settings Screenshots: https://screenshot.googleplex.com/3qpNqzYoNvdL8dN https://screenshot.googleplex.com/5ejywFFaUtfetrF Fixed: 1141609 Bug: 1106937 Change-Id: I342aa77a067b4301f3d676177bfa920ae86a385b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518424 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824575}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0c27a3cfcc80030ca5ff83e7e6f136fb4f8d378d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521045Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#824574}
-
Clark DuVall authored
In some cases, a library with the name we want will be present in a system directory such as /system/product/lib. The isolated split class loader will then "find" the lib there and return it. To get around this, first we check for libs with the base class loader, then fallback to ContextUtils.getApplicationContext() class loader if it's not found. Bug: 1126301 Change-Id: I551b6a59c75711bdf6cccae0dde8d7c658eff0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521293 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824573}
-
Piotr Bialecki authored
Change-Id: I82cc7d33ec13eff0e036cb346af40cc25f29a755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521289 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#824572}
-
Christopher Cameron authored
Use IOSurfaceAlignProperty to align the following properties: - kIOSurfacePlaneBytesPerRow - kIOSurfacePlaneSize - kIOSurfacePlaneOffset - kIOSurfaceBytesPerRow - kIOSurfaceAllocSize Clean up the structure of CreateIOSurface by merging the two "if (num_planes > 1)" branches. Bug: 1134712 Change-Id: Ib5d7c936b5f21359657af4f27f78fb1eca1d14e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518763Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#824571}
-
Gary Tong authored
Bug: 1144980 Change-Id: I892abaaf83429269c325b4bf27d836fe29f49f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517990Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#824570}
-
Gavin Williams authored
When selected in the select dialog, 'My files' returns the path "/home/chronos/u-..../MyFiles" and Google Drive 'My Drive' returns the path "/media/fuse/drivefs-..../root". When either of these two directories are selected, return the preferred display name to the UI. Bug: 1059779 Change-Id: Ic67a666d5c8948b0ffa30eef25fad39712d96ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511209Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
Bug: None Change-Id: Iab090de501e3589e93b05c08a7d07bd4356ad4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520381 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824568}
-
Francois Doray authored
This CL adds a UKM which counts "pageloads" by type for each top-level. document. This will be used to diagnose changes to the "total pageloads" shown on stability dashboard. UKM review: https://docs.google.com/document/d/1Nd5sKBdsq_sBqZ03OaWVBEloo4RGA00k_msYatkiV_0/edit?usp=sharing Bug: 1075553 Change-Id: Ieadcd6b92eee371a695ebf9af1c8f0bce371d68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508441 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#824567}
-
Elly Fong-Jones authored
Per the waterfall launch plan for this feature. Bug: 1138688 Change-Id: I9a8bacae2ebc6d45aa243835e4124c41c4271117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521099 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#824566}
-
Stephen McGruer authored
Bug: 1124430 Change-Id: I69b3f9de37b1331feb8e4bf0462c22e9b2b2a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521204Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#824565}
-
Xing Liu authored
This CL sets up the class structure for bookmark bottom sheet. Details will be added in following CLs. A instrumentation test is also added, which only contains a simple test to check the bottom sheet opened with a title text view. Bug: 1128074,1133496 Change-Id: I02d7a488ffa46e9ee4f6993003dfade8e7fbb3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473078 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#824564}
-
Sigurdur Asgeirsson authored
This moves users of ScopedObserver to either base::ScopedObservation or base::ScopedMultiSourceObservation in the performance_manager. Bug: 1145565 Change-Id: Ide766fc0139134ebc6f9cdfff58864fccb1b78f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520246 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#824563}
-
Samuel Huang authored
Previously, generate_commit_size_analysis.py takes: * --apk-name for SuperSize "main file" input (.apk or .minimal.apks). * --mapping-name for "mapping file" input. This worked fine for Monochrome. However, for Trichrome, the SuperSize "main file" is now an .ssargs file that specifies 3 "container files", which for Monochrome, coincided with the "main file". To centralize the specification of all these files from BUILD files, we define "size config JSON" file to specify the following: * Mapping files (as a list). * Arguments to be passed to resource_sizes.py (which already supports Trichrome). * Supersize main file, which can be {.apk, .minimal.apks, .ssargs}. * Version numeric string (for late ruse). This CL adds size config JSON support. Details: * Add GN template "android_resource_size_config" to specify size config JSON files. Files are generated during "gn gen", and written to config/ under Chromium output dir. * Add GN targets to generate size config JSON files for Monochrome and Trichrome * resource_size_config_monochrome_public_minimal_apks -> config/MonochromePublic_size_config.json * resource_size_config_trichrome -> config/Trichrome_size_config.json * In generate_commit_size_analysis.py: * Add --size-config-json to specify size config JSON path. * If specified, the file is copied to the staging dir. * If the "main file" is .ssargs, then it's also copied to the staging dir. * Add Trichrome support to call resource_sizes.py * In trybot_commit_size_checker.py: * Add --size-config-json-name to specify size config JSON *filename*, which will be searched in {before, after} dirs. * If specified, "mapping files" are directly extracted from the size config JSON files for "ForTest" symbol extraction. * This will replace the --apk-name argument. With this CL, size config JSON files and supports are available but unused. Usages will be added in follow-up work. Bug: 1040645 Change-Id: Ie3328ac413af3a15cd1cbb0957881da7d2d1f839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518126 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Andrew Xu authored
This CL does two things: (1) Ignore the MenuItemView instance in accessibility events handling. Then we can customize accessibility behaviors of the multipaste menu in ClipboardHistoryItemView class. (2) When the delete button gets the pseudo focus, the accessibility side is notified. Bug: 1145773 Change-Id: Ibd73b04637b89cc8200ca2f74721a10a44e857c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513502Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824561}
-
Chan Li authored
Re-enable the experiment on try builders, because: - led issue (crbug.com/1141272) has been fixed - web test runner/sink integration makes blink_web_tests on win builders slow issue (crbug.com/1141606) has been worked around - now blink_web_tests are handled be result_adapter. Bug: 1108016 Change-Id: I9cacc5da63f4197ce6c22d9fa3181ee65375e14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521834Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824560}
-
Victor Costan authored
Before this CL, AppCacheServiceImpl owned (as much as a ref-counted class can be owned) AppCacheQuotaClient directly, via a scoped_refptr. This introduces the following complexity: * AppCacheQuotaClient (a complex class) is constructed on the UI thread, and accessed later on the IO thread. * AppCacheStorageImpl and AppCacheStorageImpl (two complex classes) live on the UI thread, but are responsible for thread-hopping to the IO thread when accessing AppCacheQuotaClient. * The owning reference for AppCacheQuotaClient lives in the UI thread, which forces AppCacheQuotaClient to inherit from RefCountedThreadSafe. This is the main reason why QuotaClient is ref-counted. This CL introduces a QuotaClientHolder class that's internal to AppCacheServiceImpl. This class lives on the UI thread, and takes on the responsibility for all thread-hopping needed to access AppCacheQuotaClient exclusively on the IO thread. Changing QuotaClient's ownership model away from ref-counting is left for future CLs, in the interest of keeping this CL manageable. This CL does not introduce any behavior changes. Bug: 1016065 Change-Id: I46d7029d054a674c9252fe4b975fef17cabde010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519742Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824559}
-
Gayane Petrosyan authored
Bug: 1145890 Change-Id: I6c8cc8b063640dd4bcb4b388515bc391cee68966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521046Reviewed-by:
-
Charlene Yan authored
Flake portal shows it regularly flakes on Win10 and it has failed on the Mac10.15 builder. TBR=smcgruer@chromium.org Bug: 1146083 Change-Id: Ic9caa365766bc4d3752eeebc95975ff4bb24cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521350Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824557}
-
Antonio Gomes authored
This CL ensures that the WL client (Chromium/Wayland, Lacros) tells the WL server (Exo) the higher Aura Shell protocol version it supports, instead of the lower. With this in place, code is safe against similar crashes observed in bugs 1145642 and 1145695, where the Client (Lacros) was telling the server (Exo) it supports a version higher than it actually does. BUG=1145642, 1145695 Change-Id: Ia471748f0f3066eea901c189c06da3c1137c1cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518443 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#824556}
-
Robert Ogden authored
Mostly adds testing to ensure the UA header is set correctly, and uses the content API for the UA string instead. Change-Id: Id54ec973dc6837b92aa19cde3149e1097423374d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521351 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#824555}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604577537-33195dde368ac3649b204ac4f693c7d7b8d917b5.profdata to chrome-linux-master-1604599166-2d84463f431e41489c0f9ff841daf3c0f07e3415.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If6a68ec0817d5c2d8373285e90dcc41dd3ae5383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824554}
-
Nick Burris authored
Add documentation with tips for debugging and reproducing flaky Gtests. Bug: 1127370 Change-Id: I6b47b31cd109fe1e7bafc3b828221012a9ec95ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508298Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604577537-36e0dad6a87a9c5b37b85a7b6521b35cfbf49108.profdata to chrome-mac-master-1604599166-f98e71683e0c124b3da263294d166e72d717216d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1fa7b4d9b6ad1310cbe6ecee10f59680fcdf3bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521773Reviewed-by:
-
Matthew Mourgos authored
This CL adds fade in/out animation for showing/hiding the clipboard nudge. The nudge scales down when fading in and scales up in size when fading out. Bug: 1143809 Change-Id: I4c299c9c6264efcefdc6b9d35fd7a1563f8cb0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511350 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5081a2b12d65..59917fa054ac 2020-11-05 jegarc@microsoft.com Check that block sections exists before add a blank style rule 2020-11-05 jacktfranklin@chromium.org New DataGrid component. 2020-11-05 aerotwist@chromium.org Support fake connections to the backend 2020-11-05 tvanderlippe@chromium.org Use TypeScript-authored files in accessibility/ 2020-11-05 aerotwist@chromium.org Fix WebAudioModel 2020-11-05 tvanderlippe@chromium.org Typecheck accessibility/AccessibilitySubPane.js with TypeScript 2020-11-05 jacktfranklin@chromium.org Wrap scrubber in overflow wrapper on animation timeline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125966,chromium:1142611 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25a9a9b7ac77a7c715d1d60a22f1e009fddc2821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521038Reviewed-by:
-
manukh authored
Currently, bookmark suggestions are limited to title & URL matches. E.g the input 'planets jupiter' won't suggest a bookmark titled 'jupiter' in a directory 'planets'. This is the 4th of 5 CLs implementing bookmark-paths which will allow inputs to match bookmark paths (without contributing to the bookmark suggestion's score). This CL updates TitledUrlIndex::GetResultsMatching to (optionally) include bookmarks that match the path. This won't include bookmarks that *only* match the path. E.g., this would allow the bookmark 'path/title' to match the query 'path title' but not the query 'path'. Bug: 1129524 Change-Id: I745009139dde14c49e7a958ff5a105d0b39bdeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441153 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Product images should sit on top of a light gray background. Before this CL, we only supported this for images with a transparent background. This CL adds support for images with a white background by: - Placing the image in a white box, - Making the image and the box slightly transparent, and - Placing the box on top of a dark gray background. The colors and transparency are chosen such that the white box and the dark gray background mix to the same light gray we showed for images with transparent backgrounds before. See crbug/1145763 for screenshots. Fixed: 1145763 Change-Id: Ib07bfd99b6a0d30192113e1ceb1a542d076138a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520319 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824548}
-
Thomas Tellier authored
Bug: 889595 Change-Id: If3fb95f74b9582c14c574a5cf7f46658ba4d0661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519977Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#824547}
-
