GitLab

Change-Id: I25a939d855620ce60fd0cec9e2503d717019f23b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860096Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705624}

Bug: 805160
Change-Id: Ic15b71f86c68bb3ffad5d2a08996637aa9a93729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849269Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705623}

Bug: 980716
Change-Id: I45df011bf61cd4030b3a7f360d90f096026fdedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857041Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#705622}

This is CL 1/2 which moves the construction of RequestAction from
RulesetManager to RulesetMatcher. This is done in order to attribute
RequestActions to the matched rule it was constructed from.

Bug: 1009887
Change-Id: Ife65eec7b9a81b589753eeac7b4a712a300ff262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834561
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705621}

This CL fixes the check for the message center being visible.
Also adding a unit test to cover the case that caused the crash.

Change-Id: I37b82b4d3cd08c6c8823dab0b7ddd9342a3c7673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857378Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705620}

Add original owners from content/renderer/media/webrtc to
the new directories in Blink.

Bug: 787254
Change-Id: I8981c3e171f47191223bc16872d7ba85fb635b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860027
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705619}

The test is flaky on all desktop platforms, not just Linux/ChromeOS.

TBR=dgozman@chromium.org

Bug: 1000654
Change-Id: I63893e3835fad57b6983798a999b64902e7aeb60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860324Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705618}

Similar to copyBetweenWindowsDriveToUsb, copyBetweenWindowsLocalToUsb
and other related tests are also flaky. Disable them all, but this time
only in debug builds.

TBR=austinct@chromium.org,noel@chromium.org

Bug: 1008909
Change-Id: I11f621367dd981787296544e30b8b532633cfdac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860501Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705617}

This reverts commit e4dc12db.

Reason for revert: Broke the tree:

https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/55541

Original change's description:
> Add disable_secure_dns support to net/quic, net/http, and net/spdy.
> 
> This change is a no-op. It puts into place the needed support in the
> net/quic, net/http, and net/spdy directories for disabling DoH. A follow-
> up cl will add a similar field to URLRequest.
> 
> Change-Id: I598cc5da88061e04bd234fa70e7f4c306817fd5d
> Bug: 1012268
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842220
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Katharine Daly <dalyk@google.com>
> Cr-Commit-Position: refs/heads/master@{#705610}

TBR=mmenke@chromium.org,dalyk@google.com

Change-Id: I123d6d067d010e1710dd20a87f5accd54192b5b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860685Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705616}

Using wpt-import in Chromium d232f656.
With Chromium commits locally applied on WPT:
2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests."
d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests."
6386d9d8 "Update service_worker_unregister_and_register()"
f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading."
0583f458 "Fetch Metadata: split up `document` destination."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I883a822ec3c70a2c07ca1e187fd6d601db185f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859840Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705615}

Bug: 1010568
Change-Id: I34de7b8c34964dc46cd9f5e925ee31f2f7c7f4d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856730
Auto-Submit: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705614}

Support for the current |best_fourcc| value of kCVPixelFormatType_422YpCbCr8
by FourCCToChromiumPixelFormat was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1732895.
This change updates the |best_fourcc| to a supported format.

Bug: 1012204
Bug: 988538
Change-Id: I4cbff3bdf495806f7290bd2edf2c33cee5d67925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853864
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705613}

This CL adds gesture handling to the GMC dialog to allow users on touch
devices to dismiss sessions by swiping.

Bug: 1008905
Change-Id: I115a21ca37af7d128478139d25a1bc0dae4c0c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829671
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705612}

Blink must not report back memory changes during Scavenge (==
non-tracing GC) as those could trigger (or finalize) full garbage
collections. GC while GC is not supported and we have to delay the
reporting in those scenarios.

Bug: 1014078
Change-Id: I24ecbfa93639b67f54bbfd103c7b7753ef9e52aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859973
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705611}

This change is a no-op. It puts into place the needed support in the
net/quic, net/http, and net/spdy directories for disabling DoH. A follow-
up cl will add a similar field to URLRequest.

Change-Id: I598cc5da88061e04bd234fa70e7f4c306817fd5d
Bug: 1012268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842220Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#705610}

On devices, since iOS 13.1, the page needs time to stabalize. Without
this wait, getting the location of the element will be incorrect.

Bug: 1012326
Change-Id: Iae60e2db1e2a6c438c3ab5541f9d8fa7c2b0199c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852024
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705609}

- Change based on accessibility review

Bug: 1012450,952425
Change-Id: I0eb9deef8e5d731a59a421ffbc42b40e2fc938c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857600
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705608}

This reverts commit 5d17f9ea.

Reason for revert: breaks builds when looking for ../../chrome/app/theme/google_chrome/BRANDING

Original change's description:
> Add is_chrome_branded to kythe codesearch builds
>
> Bug: b/140589523
> Change-Id: I01e015551729dc440187735fd689486eaabd6cf8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838053
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Anthony Polito <apolito@google.com>
> Cr-Commit-Position: refs/heads/master@{#704808}


# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=agable@chromium.org

Bug: b/140589523
Change-Id: Iba284db236c97c0400adb8d0371182135227b947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857518Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705607}

This feature flag is still being used.

Bug: 959883
Change-Id: I7d1595454a271c6beba854f3a0565e40c1bc7928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857862Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705606}

When a permission prompt is shown, the user should have the URL bar
visible so that they can make an informed decision before accepting or
denying the request. This change exits fullscreen mode, which would hide
the URL bar, when a permission prompt is shown.

BUG=1007038

Change-Id: I6d2b600390b0297d0711de48b76fa492f16a71b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854789Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705605}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5abb9b7c5d0c..033004652faf

git log 5abb9b7c5d0c..033004652faf --date=short --no-merges --format='%ad %ae %s'
2019-10-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@033004652faf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I515a23dcecbce587b996c1b4482fdfe7baf7be54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860495Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705604}

I can't remember why I originally moved this to NeverFixTests, but I
don't think it's necessary anymore.

Bug: 984818
Change-Id: Id28508ca3e034bfb06c0f671ababc6abfb691ca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858344
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705603}

Bug: chromium:992979, chromium:1009074
Change-Id: I7c0a1e5a3bfcea05314db3ab57de518b7acaf5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855628
Auto-Submit: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Kuang-che Wu <kcwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705602}

'Manage accessibility features' system settings.

This CL replaces the 'Captions' link in ChromeOS browser settings with a deep link
to the 'Manage accessibility features' system settings page, which already contains
a link to the caption settings page.

Bug: 971264
Change-Id: I426e69af92176ba8b11fa937014b36a6482654f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850800Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#705601}

As of 10.15, the system seems to try to activate every app shortly
after the app starts up. This causes windows the app creates early
in its lifecycle to be given key status by appkit, even if they were
created without being given key status. In order to avoid that, tests
that depend on this behavior need to wait for the system activation
to happen before creating their windows. This change adds a mechanism
for those tests to do so, and adds appropriate uses of it.

Bug: 988868
Change-Id: I219c926a8f716ad938e0f5279c04b9f94dba1c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853107Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705600}

Bug: chromium:1012202
Change-Id: I47f1a5a8f49f685264a6f963d9043aff6d1cd42c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858426Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#705599}

It's been fixed by CL:1849452.

Bug: 985032
Change-Id: I0496e4fd0eb7ab523510d102b09612a82be9ff54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859634
Auto-Submit: Jiajie Hu <jiajie.hu@intel.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705598}

Bug: 1013545
Change-Id: I3780efe1bdddcf02bf0c9cfa880a36b4cf67b067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856802Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705597}

As of CL 1838592, -webkit-mask-image now uses CORS-enabled loading,
blocking chrome:// pages from using chrome://theme resources as mask
images. This only applies to OOBE and the WebUI tab strip currently.

Change-Id: I10f8a0e68ff2de4603a7bbb816c1f1c4a42b76e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855182Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705596}

FuchsiaVideoDecoder::ReleaseInputBuffers() was clearing
in_flight_input_packets_ before destroying input packets, which was
resulting in DCHECK failure. This change updates ReleaseInputBuffers()
to destroy input buffers before dropping the packets.

Bug: 1013919
Change-Id: I7288c1c47ab400877e5e4ec629083963b8e90a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857712
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705595}

HasEntry and GetUrlForEntry were already removed from the native
DomDistillerService, and only had stub impls in ..Android.

Bug: 1007942
Change-Id: I6793ae036671c7e648c19300181d574944363938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857320
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705594}

This reverts commit 575c09b1.

Reason for revert: Broke the tree, see:

https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20%28dbg%29%2832%29/123424

Original change's description:
> Roll sysroots
> 
> Also needed is [1] in webrtc, which fixes some build warnings. Could
> land in parallel.
> 
> [1] https://webrtc-review.googlesource.com/c/src/+/156980
> 
> BUG=1012850
> 
> Change-Id: Ia24e490db5e71cf1add0e10f4c1264aefb69143c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859935
> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705589}

TBR=dpranke@chromium.org,thomasanderson@chromium.org

Change-Id: Ie1db662441a263452dfe433169b5aa900500744a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860141Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705593}

In Python 3 keys() returns an iterable instead of a list. It's necessary to explicitly convert when you want to use as a list.
Still works with Python 2.

Fixed errors:
Traceback (most recent call last):
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 204, in <module>
    sys.exit(main())
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 199, in main
    generate_cpp_file(infile, outfile)
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 174, in generate_cpp_file
    if _is_log_once_or_currently_qualified(log):
  File "../../components/certificate_transparency/tools/make_ct_known_logs_list.py", line 161, in _is_log_once_or_currently_qualified
    return log.get("state").keys()[0] not in ("pending", "rejected")
TypeError: 'dict_keys' object is not subscriptable

Traceback (most recent call last):
  File "C:\Google\chromium\src\components\certificate_transparency\tools\make_ct_known_logs_list_unittest.py", line 238, in testSortingAndFilteringDisqualifiedLogs
    disqualified_logs = make_ct_known_logs_list._sorted_disqualified_logs(logs)
  File "C:\Google\chromium\src\components\certificate_transparency\tools\make_ct_known_logs_list.py", line 147, in _sorted_disqualified_logs
    return sorted(
  File "C:\Google\chromium\src\components\certificate_transparency\tools\make_ct_known_logs_list.py", line 87, in _is_log_disqualified
    log_state = log.get("state").keys()[0]
TypeError: 'dict_keys' object is not subscriptable

Bug: 941669
Change-Id: Iff905a290c3dc2581e1a0ff7ad8a8282ce9c050e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857121Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#705592}

[sheriff] This is a reland of bf1742a3
to disable a flaky test until adithyas@ can take another look.


Original change's description:
> Portals: Disable TouchInputTransferAcrossReactivation
>
> Test fails flakily on all aura platforms.
>
> Bug: 1010675
> Change-Id: Ic1906b0421dab41ddc14f36462aff459867afc33
> Tbr: lfg@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836007
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702230}

Bug: 1010675
Tbr: lfg@chromium.org
Change-Id: Icbddd9cb318b1bf25678b4e812a62382e953a937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860297Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705591}

https://boringssl.googlesource.com/boringssl/+log/6a2609dae219e4300dfc62b2a37f10b5c845547b..bc4c09df6416a3a0d0cf321c6c13023c77e2fec4

The following commits have Chromium bugs associated:
  bc4c09df6 Add a function to derive an EC key from some input secret.

Bug: 1010968
Change-Id: I84d0b5bac83df17a747f64f94c24d1368f36c7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857519
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705590}

Also needed is [1] in webrtc, which fixes some build warnings. Could
land in parallel.

[1] https://webrtc-review.googlesource.com/c/src/+/156980

BUG=1012850

Change-Id: Ia24e490db5e71cf1add0e10f4c1264aefb69143c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859935
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705589}

This was a workaround for a toolchain problem we no longer have --
lld-link has thin static libraries and this is a no-op for it for that
reason already.

Bug: 857060
Change-Id: I98002cf0dbf70e9cfffb880d9c24984bed2ff51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860034
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705588}

This patch ensures the open and close events are only called a single
time for the tests in BottomSheetObserver.

Change-Id: I98b1dce25be5aa7e55cdcbead90518954b8747d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857543
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705587}

The SysInfo class will provide Chrome OS version from parsing the
LSB_RELEASE file, so call it on Chrome OS too.

Bug: chromium:1012048
Test: Manual
Change-Id: Iba0e3a6d85005a1429f96c0a2d56eea11f8c465f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848503Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705586}

To avoid too long filenames on Windows.

TBR=johnchen@chromium.org

Bug: 1014132
Change-Id: I062d56c0e75a34f6ce65ae4dffd84a7531e6716e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860499Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705585}