GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/86a890b..30421b4

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1092543002

Cr-Commit-Position: refs/heads/master@{#325402}

As part of this CL, the dependency of //components/user_prefs
on //content is removed.

TBR=rlp, estade

Review URL: https://codereview.chromium.org/1062083003

Cr-Commit-Position: refs/heads/master@{#325401}

BUG=37273
TEST=manual test

Review URL: https://codereview.chromium.org/1089683003

Cr-Commit-Position: refs/heads/master@{#325400}

Previously we haven't generated thumbnails if an error had happened to avoid showing (and caching) wrongly rotated thubmanil (crbug.com/463384).
This CL changes to generate thumbnail even an error had happend.
However, IO error is an exception since IO error may not happen in the next try.

BUG=475251
TEST=manually tested.

Review URL: https://codereview.chromium.org/1093433003

Cr-Commit-Position: refs/heads/master@{#325399}

Cr-Commit-Position: refs/heads/master@{#325398}

BUG=469061
TEST=run newly added test

Review URL: https://codereview.chromium.org/1089543005

Cr-Commit-Position: refs/heads/master@{#325397}

BUG=477180
TEST=manual test

Review URL: https://codereview.chromium.org/1088413002

Cr-Commit-Position: refs/heads/master@{#325396}

This method returns a list of installed providing extensions with extra flags
saying whether the extension handles configuring or adding new mount points
via an event.

TEST=Not yet, they will be added in a follow up CL once all is wired up.
BUG=474146

Review URL: https://codereview.chromium.org/1089193002

Cr-Commit-Position: refs/heads/master@{#325395}

BUG=460638

Review URL: https://codereview.chromium.org/1082393003

Cr-Commit-Position: refs/heads/master@{#325394}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/639a828..6983f66

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1076963003

Cr-Commit-Position: refs/heads/master@{#325393}

This patch contains some style cleanups I found recently.

Review URL: https://codereview.chromium.org/1053203006

Cr-Commit-Position: refs/heads/master@{#325392}

BUG=475994

Review URL: https://codereview.chromium.org/1091603003

Cr-Commit-Position: refs/heads/master@{#325391}

BUG=394135

Review URL: https://codereview.chromium.org/1068123002

Cr-Commit-Position: refs/heads/master@{#325390}

setWindowShape now checks that the window is frameless, which it isn't on Mac.
Ideally, we would tie this check to the frameless state directly, rather than
duplicating the platformIsMac check, but there's no API for that.

BUG=b/20270661

Review URL: https://codereview.chromium.org/1086223003

Cr-Commit-Position: refs/heads/master@{#325389}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dceaf644..67b98f43

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1088403002

Cr-Commit-Position: refs/heads/master@{#325388}

Code Cleanup for extension_prefs, as AddDisableReasons() is not required same behavior can be achieved by AddDisableReason().

BUG=475911

Review URL: https://codereview.chromium.org/1073153002

Cr-Commit-Position: refs/heads/master@{#325387}

This applies to situations where we are opening a new window or failing
to draw content in time during tab-switch.

Make the RenderWidgetHostViewMac and its layers be transparent, instead
of being the view's background color and white, respectively.

For the RenderWidgetHostViewMac it was in error to set the layer's color
to be the color specified by SetBackgroundColor -- the color specified
by that method will go down to the renderer, and the renderer will
produce frames with the appropriate background color.

The theme color will come from the TabContentsContainerView. Update the
computation of the resulting color to use mostly SkColor operations.

BUG=470669

Review URL: https://codereview.chromium.org/1082143002

Cr-Commit-Position: refs/heads/master@{#325386}

Instead of TestSimpleTaskRunner, which DCHECKs when posting message
from worker thread, use MessageLoop and set a timeout that is
equivalent to CompositorLock's timemout.

BUG=473507
TEST=run w/ --ui-enable-impl-side-painting

Review URL: https://codereview.chromium.org/1081223002

Cr-Commit-Position: refs/heads/master@{#325385}

Review URL: https://codereview.chromium.org/1091683003

Cr-Commit-Position: refs/heads/master@{#325384}

This adds browser tests that verify console message logged when a
promise passed to waitUntil() or respondWith() is rejected.

These tests are here because console outputs from SWs aren't testable
with layout tests (crbug.com/456708).

BUG=359423

Review URL: https://codereview.chromium.org/1081953004

Cr-Commit-Position: refs/heads/master@{#325383}

BUG=431057,442173

Review URL: https://codereview.chromium.org/1008473006

Cr-Commit-Position: refs/heads/master@{#325382}

Please take a look at first part of this review

and also at this conversation

https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/xiuyMB5AiNY

BUG=

Review URL: https://codereview.chromium.org/1087883005

Cr-Commit-Position: refs/heads/master@{#325381}

Currently if the form changes in any way between parsing and form submission
any server overrides for the form will be ignored. Relax the matching to only
take into account name and action for the form and name for the field. This
is similar to how Autofill matches.

BUG=476092

Review URL: https://codereview.chromium.org/1088973003

Cr-Commit-Position: refs/heads/master@{#325380}

According to the newest mocks, the file systems will be managable from Files
app. In order to do that, both of the events are required.

TEST=None.
BUG=474146
R=benwells@chromium.org

Review URL: https://codereview.chromium.org/1088883002

Cr-Commit-Position: refs/heads/master@{#325379}

Add some new owners to make sure it gets some security attention

BUG=none
TBR=cbentzel (already reviewed)

Review URL: https://codereview.chromium.org/1090643003

Cr-Commit-Position: refs/heads/master@{#325378}

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1082323004

Cr-Commit-Position: refs/heads/master@{#325377}

If one of the tools/mb files changes, mb analyze may not produce
correct results (since the configs might change), so we should
just build everything.

Also, fix a dangling target for the android_gn trybot.

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1092523002

Cr-Commit-Position: refs/heads/master@{#325376}

This flag causes unused argument errors when using LTO (or Clang's integrated
assembler), and is not needed to disable executable stacks, as we are already
passing -Wl,-z,noexecstack at link time, which is how executable stacks are
already getting disabled on other platforms.

BUG=407544
R=thakis@chromium.org
TEST=Built libchromeshell.so with default GYP_DEFINES with and without this change, verified that binaries are equivalent

Review URL: https://codereview.chromium.org/1091463002

Cr-Commit-Position: refs/heads/master@{#325375}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4127337..86a890b

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089323002

Cr-Commit-Position: refs/heads/master@{#325374}

This also includes several fixes for the plugin logic on Windows:
- The banned directory check normalizes path separators.
- The banned directory check now returns true for files that are
  considered system headers.
- Diagnostics from the plugin are always reported as warnings.

BUG=467287
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20

Committed: https://chromium.googlesource.com/chromium/src/+/5b5d1269ade9eeb50875b20570ef3e0d8c5d95fb

Review URL: https://codereview.chromium.org/1072203002

Cr-Commit-Position: refs/heads/master@{#325373}

This basically brings back the original implementation of InputMethodGtk long time ago, which covered most of cases that haven't been covered by the current implementation (e.g. generate keypress event for the accent/dead keys).

Due to limitations of Aura framework, it is hard to get the native window (e.g. XWindow). Therefore, gtk_im_context_set_cursor_position cannot be called at the appropriate time. The current InputMethodAuraLinux implementation workarounds it to leverage the key event, which carries the information about native window, and call set_client_window in DispatchKeyEvent(). The basic scenarios work but some special scenario cannot work. For example, iBus Pinyin IME tries to show the status-bar-UI at the cursor position without typing any keys.
This cl keep the current logics for that and won't fix the issue.

And this cl removes the keyup of 229 keycode, which is unnecessary. Therefore, for 229 keycode, the IMF will not try to pair the keydown and keyup.

This cl adds some tests to avoid future regressions on basic scenarios which consider sync/async modes, ibus hacky behaviors, dead keys, multi-commits, etc.
Note that the tests don't cover all possible scenarios as the worldwide IMEs with different IM modules (xim, ibus, etc.).

TBR=sky@chromium.org
BUG=463491,474828,125161,458179
TEST=Verified on local linux workstation.

Review URL: https://codereview.chromium.org/1068093002

Cr-Commit-Position: refs/heads/master@{#325372}

Revert of Build the Clang plugin on Windows. (patchset #7 id:120001 of https://codereview.chromium.org/1072203002/)

Reason for revert:
Rebase went horribly wrong...

Original issue's description:
> Build the Clang plugin on Windows.
>
> This also includes several fixes for the plugin logic on Windows:
> - The banned directory check normalizes path separators.
> - The banned directory check now returns true for files that are
>   considered system headers.
> - Diagnostics from the plugin are always reported as warnings.
>
> BUG=467287
> R=thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5b5d1269ade9eeb50875b20570ef3e0d8c5d95fb

TBR=hans@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467287

Review URL: https://codereview.chromium.org/1087423003

Cr-Commit-Position: refs/heads/master@{#325371}

These test aggregating 20 surfaces with 100 quads and resources each. Opacity < 1 in one test prevents the Surfaces from all being merged into 1 renderpass.

Review URL: https://codereview.chromium.org/1082103003

Cr-Commit-Position: refs/heads/master@{#325370}

This will allow the DisplayScheduler to differentiate between
a frame without any resources and one that should not be drawn.

Some tests use frames without any resources and the DisplayScheduler
was missinterpreting that as the Browser locking resources.

BUG=467750, 476544

Review URL: https://codereview.chromium.org/1084313002

Cr-Commit-Position: refs/heads/master@{#325369}

Convert downloads_page.css to downloads_page_style.html. See http://goo.gl/vIGSCO for more information.

BUG=477154

Review URL: https://codereview.chromium.org/1089703002

Cr-Commit-Position: refs/heads/master@{#325368}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1059753007

Cr-Commit-Position: refs/heads/master@{#325367}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/221360a..639a828

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1085393002

Cr-Commit-Position: refs/heads/master@{#325366}

This also includes several fixes for the plugin logic on Windows:
- The banned directory check normalizes path separators.
- The banned directory check now returns true for files that are
  considered system headers.
- Diagnostics from the plugin are always reported as warnings.

BUG=467287
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20

Review URL: https://codereview.chromium.org/1072203002

Cr-Commit-Position: refs/heads/master@{#325365}

BUG=

Review URL: https://codereview.chromium.org/1091683002

Cr-Commit-Position: refs/heads/master@{#325364}

BUG=468567

Review URL: https://codereview.chromium.org/1070253002

Cr-Commit-Position: refs/heads/master@{#325363}