GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8985aa3f68b..ddd9b6c95806

$ git log a8985aa3f..ddd9b6c95 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I01bf6e61030b2e484fb7cef72ab10947054d915e
Reviewed-on: https://chromium-review.googlesource.com/963286
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543208}

EncodedFormData::SizeInBytes doesn't support all possible types (in
particular it DCHECKs on kDataPipe), so by swapping the order of checks
we make sure things actually work correctly.

On of several changes towards making uploading blobs with network service work.

Bug: 821878
Change-Id: I64313bcc390756de6ad0be091d0ab32e9b78ae44
Reviewed-on: https://chromium-review.googlesource.com/962833Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543207}

Change-Id: I58d9c9025e238c0ff6824f0e5b39e299a7a86272
Reviewed-on: https://chromium-review.googlesource.com/961789
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543206}

This reverts commit e50412fb.

Reason for revert: crbug.com/821999 enabled test now failing on chromeos

Original change's description:
> cros: Convert switch to feature for new overview ui.
> 
> Convert to feature which is enabled by default.
> 
> Test: manual
> Bug: 821608
> Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616
> Reviewed-on: https://chromium-review.googlesource.com/961721
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543139}

TBR=sky@chromium.org,sammiequon@chromium.org

Change-Id: I92ce3f93cb88cef92e242fbbd6338cbdac528cdd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821608
Reviewed-on: https://chromium-review.googlesource.com/962837Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543205}

Main interfaces added:

1. Add methods in CastContentWindow and CastContentWindow.Delegate for Cast Activity and WebApplication

2. Add methods in CastContentWindowAndroid for JNI calls between Java and C++

3. Add some methods and intent types in CastWebContentComponent for calling between CastContentWindowAndroid and CastWebContentComponent, and between CastWebContentComponent and CastWebContentsFragment

4. Add some intent types for calling between CastWebContentComponent/CastWebContentsFragment and external activity.

Design doc: go/cast-to-android

Test: cast_shell_junit_tests browsertests

Bug: b/65100261 b/72227153 b/72436346 b/72237087 b/72912957 b/72436104 b/72712171

Change-Id: I09056f6fe78341e545c5e1342640a4dfddff28f4
Reviewed-on: https://chromium-review.googlesource.com/940809
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543204}

I'm not up to date on this component :)

While editing the file, adding jhawkins and jlklein

Bug: None
Change-Id: I900241c6348eb7ba4f8392a9d348a343f2266fe5
Reviewed-on: https://chromium-review.googlesource.com/963300Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543203}

If the style of a node was changed right before a call to
DOM.getBoundingBox, it might return stale metrics.

Change-Id: I046ecd214c964935f5912ed6f570c9cc4552ad29
Reviewed-on: https://chromium-review.googlesource.com/963302Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543202}

For
  descendant->Parent() == ancestor_clip &&
  descendant->LocalTransformSpace() == ancestor_transform
we can return the clip rect of |descendant| directly to avoid the more
complex logic.

This also reduces the number of entries in the clip cache, which can
speed-up cache lookup.

Premilinary stats show that the fast path is used for about half of all
calls to the function.

Bug: 803867
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8c390e17cbc7c5e225716e6e90ac8be4dfa615d8
Reviewed-on: https://chromium-review.googlesource.com/963012Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543201}

These two bots run iOS tests. ios-simulator is CQ bot.
ios-simulator-full-configs is main waterfall bot. Expand the swarming pool
size for it.

Bug: 795980
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iad52add5c29c24a212ec69c8918dd8f809086e39
Reviewed-on: https://chromium-review.googlesource.com/961726Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543200}

0816757e fixed a real issue which might be the source
of the flake here.

Bug: 810302
Change-Id: I38630563e11944deec2dcd71dc89a01eabdfdd74
Reviewed-on: https://chromium-review.googlesource.com/957806Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543199}

This UI surface is non-CrOS only and the ScreenLock functionality is
only function for CrOS, so this is essentially dead code.

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: If612764c9e668c225d8d83062fe495186cbdeb61
Reviewed-on: https://chromium-review.googlesource.com/962667
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543198}

This CL adds two extra EDIDs (namely an eve and an HP z32x)
for the edid_parser_fuzzer test.

Bug: 821393
Change-Id: Ia3242cd6df142a789e074ddaa6b4df8162adbd5d
Reviewed-on: https://chromium-review.googlesource.com/963222Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543197}

This includes a handful of minor layout fixes after close examination of
the network settings UI.

* Spacing issue introduced with paper button changes:
  https://chromium-review.googlesource.com/907856
* Alignment issue introdiced when fixing click targets:
  https://chromium-review.googlesource.com/952033
* ip-config JS console error causing details page to be incorrect
  initially (old issue, but probably exposed with recent refactoring)
* Network security icon bug in detail page that has existed since 64
  (no bug filed that I could find)

Only the security icon bug impacts 66 and it's confusing but minor.

Bug: 821733, 821720
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I877aeb93a232f6c656d73ac7c345f63e00cbf125
Reviewed-on: https://chromium-review.googlesource.com/963303Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543196}

In the following change I broke the size of the voice search icon
https://chromium-review.googlesource.com/c/chromium/src/+/958221

The problem is that I reused a button class that automatically resized
the icon to the wrong value. With this change, I've made it possible to
customize this scale factor so that users of this button class can have
larger or smaller icons as required.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icbf29e348ff0b507524532c2f58dfd4d8d82bb64
Reviewed-on: https://chromium-review.googlesource.com/962936Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543195}

This CL enables changing user type. If user_id token suggests that
user type has changed (so that it is possible for Regular <-> Child
transition only because of the API), |User| type will be updated
immediately, |Profile| child flag will be changed in
InitProfileUserPrefs(), and profile entry will be removed from
profile_info cache to ensure cache is fully reinitialized.

Bug: 811541
Change-Id: Icc0719d66058d951697937e9b36dcb4155b95908
Reviewed-on: https://chromium-review.googlesource.com/959743
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543194}

Previously a transform was issued for SPv1 to translate the painting
space from the current paint offset based space to the space in which
WebPluginContainerImpl::FrameRect() resides.

Now pass the translation into WebPluginContainerImpl::Paint() and
output the translate as a paint command for SPv175.

This might not be a long-term solutio. Need to refactor the coordinate
system of EmbeddedContentView to simplify the logic.

Bug: 821486
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I40837bbbdd5b09e6a0d585cb594165c4db48b881
Reviewed-on: https://chromium-review.googlesource.com/961861
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543193}

Since we now send a PDF from print preview, the offsets aren't computed
in PrintRenderFrameHelper. They should be the printable area offsets,
not the content area. The content area offsets reflect the margins set
in Print Preview, which are no longer relevant since the generated PDF
already includes these margins.

Bug: 821485
Change-Id: I5ba009408bb7bb0251cdd85b3ed7b6e10e293826
Reviewed-on: https://chromium-review.googlesource.com/962878
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543192}

https://chromium.googlesource.com/catapult.git/+log/b1242f4c6f85..fb4a44ab53c4

$ git log b1242f4c6..fb4a44ab5 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 perezju Reland "[Telemetry] Use correct WebView apk for --browser android-webview"
2018-03-12 dtu [pinpoint] Retry job.put() on ndb error.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Iea0e198660e78e9447b37c141942edc46660c2c7
Reviewed-on: https://chromium-review.googlesource.com/962830Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543191}

Generate synthetic clicks and dispatch them via the window service.
Add the remote event dispatcher interface to a new "accessibility"
capability, available only to trusted apps.

Bug: 821471, 628665
Test: Use autoclick on multiple displays with different scale factors
Change-Id: I61352a0849a96a2bc0ae14d0b8afcca051ba67e2
Reviewed-on: https://chromium-review.googlesource.com/961668Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543190}

This CL reverts part of CL/952669 until a better fix is found for showing
the tab switch button (which stopped displaying with CL/952669).

Bug: None
Change-Id: Ia5896087c644f6998350a06d783d7dd58c3f919a
Reviewed-on: https://chromium-review.googlesource.com/961734Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543189}

On of several changes towards making uploading blobs with network service work.

Tested in a separate CL because multiple unrelated bugfixes are needed to make this
all work and testable (https://chromium-review.googlesource.com/c/chromium/src/+/963008).

Bug: 821878
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I33812ac556029066196b3fcbdb54d6bdbc041a86
Reviewed-on: https://chromium-review.googlesource.com/963007Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543188}

As per anicolao@'s advice, this CL converts surface invariants violations dumps
into an optional feature whereas we always report UMA. This allows us to ship
with invariants violations that do not impact the user experience.

Bug: 814690, 672962
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I206bc32d30afcccc8dd0e0200601961c72943a1f
Reviewed-on: https://chromium-review.googlesource.com/962929Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543187}

The first fix is to get the CookieManager from the render process' StoragePartition, instead of
using GetDefaultStoragePartition. The second fix is to not use the StoragePartition's CookieManager
(which is used for web requests) when ContentBrowserClient::OverrideRequestContextForURL returns a
different store (e.g. for chrome-extension scheme).

Bug: 769401

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id61abda2cd38957867fb3848d06b1b18d9e89b79
Reviewed-on: https://chromium-review.googlesource.com/957554Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543186}

If the pen device is disabled while the pen is near the screen it leads
to infinite recursion. This is because we make a call to disable palm
suppression, which revalidates device enablement. Post a task instead
of disabling inline to fix this.

The same thing happens if we lose events since Reinitialize() gained
a call to ReleaseButtons() when pen support was added, which calls
ReportEvents(), which can again call Reinitialize(). To fix that one,
kill ReleaseButtons() as ReleaseTouches() should be sufficient.

BUG=814071
TEST=powerd_dbus_suspend with pen touching screen

Change-Id: I8bb66feddc7961f1fa28d062133671ad1c46948c
Reviewed-on: https://chromium-review.googlesource.com/961386Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543185}

Bug: 539022
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e8f9b364e380b8c3200f6674b0ecea859adba01
Reviewed-on: https://chromium-review.googlesource.com/951854
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543184}

https://pdfium.googlesource.com/pdfium.git/+log/2c3cfa734d03..40c223e4ed41

$ git log 2c3cfa734..40c223e4e --date=short --no-merges --format='%ad %ae %s'
2018-03-14 thestig Fix bad return value in WideString::Compare().

Created with:
  roll-dep src/third_party/pdfium
BUG=821454


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I686ce1083770018cbe352bbfe6e902a9fd48f0c2
Reviewed-on: https://chromium-review.googlesource.com/963014Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543183}

Moving enable-ui-devtools flag to the browser, so now DevTools
won't carry any host specific information.

Bug: 816802
Change-Id: I9830227660d31803226d8ec469f75f2ce6007712
Reviewed-on: https://chromium-review.googlesource.com/962360Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#543182}

This CL moved DownloadFile and DownloadFileImpl to components/download
There are no functional changes.

Bug: 803135
Change-Id: I3c40ce2ac56251a3fec9d0eb75acb12ce0c0b0d3
Reviewed-on: https://chromium-review.googlesource.com/957845
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543181}

This reverts commit cf978e37.

Reason for revert: not more flaky than the other ones. https://bugs.chromium.org/p/chromium/issues/detail?id=821697#c17

Original change's description:
> Disable flaky testSafeBrowsingOnSafeBrowsingHitProceed
> 
> TBR=ntfschr
> 
> Bug: 821697
> Change-Id: I61515e735a542cf94dcb00c50263ea512d66fcea
> Reviewed-on: https://chromium-review.googlesource.com/963081
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543146}

TBR=crouleau@chromium.org,ntfschr@chromium.org

Change-Id: I141561d5448a77c0dc12a91032850c9dd2dc2e1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821697
Reviewed-on: https://chromium-review.googlesource.com/963230Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543180}

Adds an observer interface for CastWebView. This allows multiple
components to track the CastWebView lifecycle (similar to
WebContentsObserver APIs).

Bug: None
Test: cast_shell
Change-Id: I37f45b896c1696c9fe91d9706cbddf0b2e46d2cc
Reviewed-on: https://chromium-review.googlesource.com/961588Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543179}

Linux distros like Gentoo have a philosophy of not statically-linking
dependencies.  The reason is not necessarily to save disk space, but
because they like to compile with their own flags and patches applied.
This CL fixes the zlib unbundle for them.

BUG=800977

Change-Id: I129d95a5a4b6c4183666f712609b2e3f0509526e
Reviewed-on: https://chromium-review.googlesource.com/947464
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543178}

As requested by bettes@, reduce default padding to 8px

Bug: 820619
Change-Id: Idb708763cfc3e5b1dcee456e7429d0ce28ced4b1
Reviewed-on: https://chromium-review.googlesource.com/958087
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543177}

VPX_CODEC_DISABLE_COMPAT has been removed for years.

The headers are guarded internally with extern "C" {}.

Sort order is no longer critical for vp8[c|d]x.h and
vpx_[en|de]coder.h.

BUG=webm:649

Change-Id: I957f4d81adc51bacc6d66457053bad98c761e257
Reviewed-on: https://chromium-review.googlesource.com/959455Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#543176}

1. Disable search extension.
2. Do not show search prompt in the Network log
3. Hide serch type selection when there's no meaningful choice.

Bug: 468416
Change-Id: I461b84719a804da7bf53c94a3392d8123f9d15c5
Reviewed-on: https://chromium-review.googlesource.com/962662Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543175}

TBR=iannucci@chromium.org

No-Try: true
Change-Id: Idbcf63650aac281cd3a98aed4a8c6cd453d78c72
Reviewed-on: https://chromium-review.googlesource.com/963293Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543174}

This is unused for Chromebooks and removing this has the added benefit
of removing an incorrect dependency on ash.

Bug: 723873
Test: none
Change-Id: I417f2030851438ce7ebb23f3394ed0772bf7514e
Reviewed-on: https://chromium-review.googlesource.com/961730
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543173}

https://webrtc.googlesource.com/src.git/+log/31791e7e2c2c..2ce1e749a898

$ git log 31791e7e2..2ce1e749a --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1998bb70f242251c08115a6b50c6959ee632fe67
Reviewed-on: https://chromium-review.googlesource.com/963011Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543172}

In ONC, if a policy provided network configuration does not explicitly
list a property as 'Recommended', the user is not able to set the
property.

In Google's OpenVPN policy configuration (and potentially others),
UserAuthenticationType is not explicitly set, and OTP is not included
in the Recommended list, even though it needs to be provided by the
user.

To work around this technically incorrect policy configuration (and not
break existing policies with the new UI), when UserAuthenticationType
is not explicitly set in the policy, this change adds Password and
OTP to the Recommended list so that they can be provided by the UI.

This also adds a test that catches the failure case and passes with
the new changes.

Bug: 817617
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If22f34e8943a2b82cf8becc93f257413c3cdcf92
Reviewed-on: https://chromium-review.googlesource.com/961365
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543171}

- If a browser window becomes key while a dialog is up and the web
  content is first responder, give focus to the dialog.

- If the web content *loses* first responder while the dialog is key,
  make the browser window key. This makes sure that clicking the omnibox
  or typing ⌘L, for instance, focuses the browser window.

The final version of this change is incomplete: The separation between
"focused" ("the web content is focused within its window") and "active" ("the
web content's window is the active window") is mostly an illusion because it
only exists on Mac and I kept running into cases where it breaks down (e.g.
setting "focused" implicitly sets "active" deep inside WebViewImpl). A bunch of
tests also check that certain functions and IPCs happen in a certain order, so
fiddling with anything just breaks a bunch of tests in ways that don't map to
real-world behavior. Now isn't the right time to mess with that, especially in
Cocoa code, so this leaves one case unfixed:

- If a dialog becomes key some other way, make sure that the web content
  is first responder in its parent window (so that focus returns to the
  web content on dismissing the dialog, and no other views have first
  responder appearance).

I filed https://crbug.com/821931 to track it.

Bug: 658405
Change-Id: I7ec11568d860e7371f552baa44a0d6b45db6dc22
Reviewed-on: https://chromium-review.googlesource.com/935424
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543170}

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I783fa50b6a6e36f1cf7ca9c3cd85c4948486199a
Reviewed-on: https://chromium-review.googlesource.com/961650Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543169}