GitLab

BUG=653701
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2396223002
Cr-Commit-Position: refs/heads/master@{#423719}

[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS device into Slave OOBE process.

In order to enhance the security and avoid the Bluetooth in-middle attach between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is today:
  - The ChromeOS device will put itself in Bluetooth discoverable mode in the first
    OOBE screen (HID detection screen) and accpet the incoming connection request
    from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
  - The ChromeOS device will have Bluetooth disabled by default as in normal OOBE flow
  - Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE screen
    (Network screen): the device will put itself in Bluetooth discoveralbe mode and
    accept the incoming connection request from the Bootstrapping app.

BUG=652003

Review-Url: https://codereview.chromium.org/2383953002
Cr-Commit-Position: refs/heads/master@{#423718}

This method is never used and is unimplemented on most platforms.

BUG=599570

Review-Url: https://codereview.chromium.org/2399993002
Cr-Commit-Position: refs/heads/master@{#423717}

Use short version in RelaunchAppWithHelper() instead of
[[NSRunningApplication currentApplication] isActive]

BUG=650854

Review-Url: https://codereview.chromium.org/2398943002
Cr-Commit-Position: refs/heads/master@{#423716}

1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text

BUG=609747

Review-Url: https://codereview.chromium.org/2393813002
Cr-Commit-Position: refs/heads/master@{#423715}

BUG=653609
TBR=qinmin@chromium.org

Review-Url: https://codereview.chromium.org/2402533002
Cr-Commit-Position: refs/heads/master@{#423714}

We should not do anything for the spanner placeholder but just walk the
spanner directly.

Out-of-flow positioned descendants of a multicol spanner need to be
specially handled because their container may be not their ancestor in
the order of PrePaintTreeWalk.

This fixes the following layout tests for slimmingPaintInvalidation:
fast/multicol/dynamic/*spanner*.html
fast/multicol/span/*.html
(except for fast/multicol/dynamic/abspos-multicol-with-spanner-becomes-spanner.html
which is still failing because of some other reason.)

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2388723004
Cr-Commit-Position: refs/heads/master@{#423713}

R=thakis@chromium.org
BUG=563793

Review-Url: https://codereview.chromium.org/2396433006
Cr-Commit-Position: refs/heads/master@{#423712}

BUG=647441
TEST=manual

Review-Url: https://codereview.chromium.org/2338173005
Cr-Commit-Position: refs/heads/master@{#423711}

12 kb may be too small for a 64-bit machine. This allows enough
breathing space for the thread local storage teardown later on.

BUG=590907

Review-Url: https://codereview.chromium.org/2395303002
Cr-Commit-Position: refs/heads/master@{#423710}

BUG=653685
TBR=carlosk@chromium.org, dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2397573008
Cr-Commit-Position: refs/heads/master@{#423709}

Also drop an unused include of ReferenceFilterBuilder.h.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2400663002
Cr-Commit-Position: refs/heads/master@{#423708}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fecd39cfc57157898353120c65b5d3e054451cb8 Remove "Precise" from chromium.fyi builder names (jeffcarp@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=652691

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2401773002
Cr-Commit-Position: refs/heads/master@{#423707}

This is only used in URLRequestFtpJob.

R=mmenke@chromium.org
BUG=529319

Review-Url: https://codereview.chromium.org/2398153002
Cr-Commit-Position: refs/heads/master@{#423706}

This is a work-around for flickering in CCT for M54. Increasing the
max number of saved frames for high-end devices (>= 3.5 GB memory)
will prevent a flash that comes from bringing a background tab into
the foreground whose frame has been evicted.

BUG=653249

Review-Url: https://codereview.chromium.org/2394113003
Cr-Commit-Position: refs/heads/master@{#423705}

This test fails consistently on low-end Android devices.
Return early instead of running the test.

BUG=653637
TBR=eseckler@chromium.org, dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2395863004
Cr-Commit-Position: refs/heads/master@{#423704}

BUG=569557

Review-Url: https://codereview.chromium.org/2392553003
Cr-Commit-Position: refs/heads/master@{#423703}

Before this CL, user's statistics about language detection from the CLD3
library were not accessible to Chrome.

This CL introduces a new keyed service called LanguageModel that
collects such statistics and builds a simple model on top of that. This
allows other parts of Chrome to see top languages in which the user
consumes web content.

A design doc:
https://docs.google.com/a/google.com/document/d/1FBD79CEBUKkMtSJKk3fnF1xnlrXd23z2fHgIGQUFOE8/edit?usp=sharing

BUG=653058

Review-Url: https://codereview.chromium.org/2396783002
Cr-Commit-Position: refs/heads/master@{#423702}

BUG=652496

Review-Url: https://codereview.chromium.org/2399633002
Cr-Commit-Position: refs/heads/master@{#423701}

BUG=505516

Review-Url: https://codereview.chromium.org/2400723002
Cr-Commit-Position: refs/heads/master@{#423700}

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com

Review-Url: https://codereview.chromium.org/2391373002
Cr-Commit-Position: refs/heads/master@{#423699}

set_defined_from() isn't called in some tests (e.g. those using TestWithScope),
thus calling defined_from() will only yield garbage, likely leading to a crash.

BUG=

Review-Url: https://codereview.chromium.org/2394323002
Cr-Commit-Position: refs/heads/master@{#423698}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a2738b13731a..f7d080135d03

$ git log a2738b137..f7d080135 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 zhenw Update systrace and profile_chrome's default agent behavior

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2395083004
Cr-Commit-Position: refs/heads/master@{#423697}

BUG=563793
R=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2400783002
Cr-Commit-Position: refs/heads/master@{#423696}

This also involves moving the important sites util into a location
visible to the durable storage permission context.

BUG=595433

Review-Url: https://codereview.chromium.org/2393103002
Cr-Commit-Position: refs/heads/master@{#423695}

It's flaky, with more failures than not, because of new checks added in
a CL from earlier today. Disabling for now, to be fixed for real
tomorrow.

BUG=653654

Review-Url: https://codereview.chromium.org/2398273002
Cr-Commit-Position: refs/heads/master@{#423694}

This is a followup to https://codereview.chromium.org/2372323003/.

BUG=590068

Review-Url: https://codereview.chromium.org/2398223003
Cr-Commit-Position: refs/heads/master@{#423693}

Motivation:
Allow the It2me host to delegates signaling messages sending/receiving
via native messaging.

Summary of changes:
- Add a new flag useSignalingProxy on the connect message for
  com.google.chrome.remote_assistance.
- Move delegating_signal_strategy from the plugin directory to the
  signaling directory so that it can be shared by the client and the
  host
- Change the threading behavior of delegating_signal_strategy so that
  the delegate and the listener can be run on two different threads.

Review-Url: https://codereview.chromium.org/2384063008
Cr-Commit-Position: refs/heads/master@{#423692}

Other animated image formats should have the same aggressive purge
behavior.

So move it out of the GIF decoder and into ImageDecoder.

BUG=651666

Review-Url: https://codereview.chromium.org/2376033005
Cr-Commit-Position: refs/heads/master@{#423691}

BUG=648281

Review-Url: https://codereview.chromium.org/2365263006
Cr-Commit-Position: refs/heads/master@{#423690}

Also fix the appearance of the "Show All" button on the download shelf when using custom themes (this regressed at some point in M55, as it works properly in my M54 build).

BUG=647047

Review-Url: https://codereview.chromium.org/2400563004
Cr-Commit-Position: refs/heads/master@{#423689}

When the coded size of the video frame is different from the visible
rect, SkCanvasVideoRenderer::Paint tries to scale the video while it
must ignore the pixels outside visible rect. This is addressed by
clipping the SkImage object created from VideoFrame prior to painting
the frame on the canvas.

BUG=611330

Review-Url: https://codereview.chromium.org/2369093002
Cr-Commit-Position: refs/heads/master@{#423688}

Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ )

Reason for revert:
This broke the chromium build archive crbug.com/653406

Original issue's description:
> DevTools: archive content shell
>
> Creates an archive of the content shell for each desktop platform.
> This will enable external contributors to use a precompiled
> content shell to run devtools layout tests (and possibly others).
>
> I manually verified these files are needed to run devtools layout tests
> with the content shell.
>
> BUG=none
>
> Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf
> Cr-Commit-Position: refs/heads/master@{#423195}

TBR=kerz@chromium.org,kerz@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2399173002
Cr-Commit-Position: refs/heads/master@{#423687}

This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks" (d7e42ebb)
2. Make "All Bookmarks" to be controlled by feature" (b8a3ebb9)
3. "Add an about flag to toggle the visibility of "All bookmarks"" (d37c3af1)
4. "Revert "Remove all bookmark section from bookmark manager"" (837a30e5)

BUG=605614
R=dfalcantara@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/2394273002 .

Cr-Commit-Position: refs/heads/master@{#423686}

Revert of Use FileDescriptorWatcher in AlarmTimer. (patchset #2 id:20001 of https://codereview.chromium.org/2398753003/ )

Reason for revert:
This CL is causing a memory leak in the unit tests:

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16728

failures:
AlarmTimerTest.RetainNonRepeatIsRunning
AlarmTimerTest.MessageLoopShutdown
AlarmTimerTest.NonRepeatIsRunning
AlarmTimerTest.RetainRepeatIsRunning

Sample report:
Direct leak of 152 byte(s) in 1 object(s) allocated from:
    #0 0xab8ebb in operator new(unsigned long) (/b/swarm_slave/w/irlnnUGq/out/Release/components_unittests+0xab8ebb)
    #1 0x9eba8fd in MakeUnique<base::FileDescriptorWatcher::Controller::Watcher, base::WeakPtr<base::FileDescriptorWatcher::Controller>, base::MessageLoopForIO::Mode &, int &> base/memory/ptr_util.h:56:29
    #2 0x9eba8fd in base::FileDescriptorWatcher::Controller::Controller(base::MessageLoopForIO::Mode, int, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/files/file_descriptor_watcher_posix.cc:159
    #3 0x9ebb293 in base::FileDescriptorWatcher::WatchReadable(int, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/files/file_descriptor_watcher_posix.cc:198:25
    #4 0xe0016a3 in timers::AlarmTimer::Reset() components/timers/alarm_timer_chromeos.cc:103:25
    #5 0x515b488 in timers::AlarmTimerTest_RetainRepeatIsRunning_Test::TestBody() components/timers/alarm_timer_unittest.cc:310:9

Original issue's description:
> Use FileDescriptorWatcher in AlarmTimer.
>
> FileDescriptorWatcher is a new API that replaces
> MessageLoopForIO::WatchFileDescriptor.
>
> This CL also gets rid of the base::Thread created in the anonymous
> namespace of alarm_timer_chromeos.cc. The FileDescriptorWatcher
> API is supported by every TaskScheduler thread. Very soon, most
> tasks in Chrome will run in TaskScheduler. Therefore, there is no
> reason to create a base::Thread to allow AlarmTimer to be used from
> threads that don't support the FileDescriptorWatcher API.
>
> BUG=645114
>
> Committed: https://crrev.com/8e17d7e9031b7e2e58473fe66a399943051357f0
> Cr-Commit-Position: refs/heads/master@{#423617}

TBR=chirantan@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645114

Review-Url: https://codereview.chromium.org/2394333002
Cr-Commit-Position: refs/heads/master@{#423685}

https://chromium.googlesource.com/chromium/src/+/bd1529c0d

BUG=649760
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2396203002 .

Cr-Commit-Position: refs/heads/master@{#423684}

https://pdfium.googlesource.com/pdfium.git/+log/ca03f7a1c654..3a0a808ff546

$ git log ca03f7a1c..3a0a808ff --date=short --no-merges --format='%ad %ae %s'
2016-10-06 kcwu Fix assertion failure when decoding malform G4 fax image
2016-10-06 kcwu Reject JBig2 Huffman table with too large shift value
2016-10-06 npm Split m_InstalledTTFonts into two vectors to avoid sketchy logic.
2016-10-06 caryclark switch to new skia blend mode enum class

BUG=653044

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2395263002
Cr-Commit-Position: refs/heads/master@{#423683}

This reverts commit ea63767b, which
represents a feature that was disabled in M54 via field trial.

BUG=620535
TBR=isherman@chromium.org

Review-Url: https://codereview.chromium.org/2393993005
Cr-Commit-Position: refs/heads/master@{#423682}

That event will contain ExecutionMode/SequenceToken and TaskPriority.

It would be better to tack an optional extra arg to the main task event but
tracing doesn't currently allow this (http://crbug.com/652692).

BUG=649084

Review-Url: https://codereview.chromium.org/2392903002
Cr-Commit-Position: refs/heads/master@{#423681}

Add an ApplyAutoMargin function in ng_length_utils and use that from
ng_block_layout_algorithm.

I did not add it to computeMargins because not all callers should take
margin: auto into account. In particular, a child's width: auto computation
needs to treat margin: auto as zero (and, at any rate, does not have a fragment
available yet).

R=glebl@chromium.org,eae@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2399963002
Cr-Commit-Position: refs/heads/master@{#423680}