GitLab

This CL implements a WebRTC Desktop Capturer that captures from
the Aura Shell root window.

The capturer is used by the It2MeHost on Chrome OS.
|DesktopCaptureDeviceAura| cannot be re-used in our scenario
because is timer-driven as opposed to caller driven, which is
required by WebRTC.

The current implementation uses the layer API

desktop_window_->layer()->RequestCopyOfOutput(request.Pass())

to request the layer and its subtree to be rendered to a
|SkiaBitmap|.  It then copies the pixels to a WebRTC |DesktopFrame|.

BUG=411530

Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c
Cr-Commit-Position: refs/heads/master@{#295187}

Review URL: https://codereview.chromium.org/543243003

Cr-Commit-Position: refs/heads/master@{#295214}

unit_tests failing on bots even though they passed the CQ.

This reverts commit d117e910.

BUG=413967
TBR=noelutz@chromium.org

Review URL: https://codereview.chromium.org/555373005

Cr-Commit-Position: refs/heads/master@{#295213}

Currently, ObjectProxy::CallMethodAndBlock() returns NULL on
failure but the D-Bus error details are not passed to the caller.

Added a method that would return the D-Bus error information
to the caller and switched ObjectProxy::CallMethodAndBlock()
to use the new method instead.

BUG=chromium:414838
TEST=Build Chrome
TEST=ninja -C out/Debug dbus_unittests && out/Debug/dbus_unittests

Review URL: https://codereview.chromium.org/563763004

Cr-Commit-Position: refs/heads/master@{#295212}

Review URL: https://codereview.chromium.org/571463003

Cr-Commit-Position: refs/heads/master@{#295211}

* Handling RenderProcessGone in CastWindowAndroid
* Using CastBrowserProcess instead of passing the browser context
* A few style nits

R=byungchul@chromium.org,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/566963003

Cr-Commit-Position: refs/heads/master@{#295210}

Disable high DPI assets for ui scaling. This will be removed in 39, after this change is landed.

BUG=413368

Review URL: https://codereview.chromium.org/578553002

Cr-Commit-Position: refs/heads/master@{#295209}

BUG=414956
TEST=manual

Review URL: https://codereview.chromium.org/551373009

Cr-Commit-Position: refs/heads/master@{#295208}

BUG=None

Review URL: https://codereview.chromium.org/552983003

Cr-Commit-Position: refs/heads/master@{#295207}

BUG=

Review URL: https://codereview.chromium.org/575923002

Cr-Commit-Position: refs/heads/master@{#295206}

Revert of Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/573573003/)

Reason for revert:
Revert the revert since the bot is still red after the revert.

Original issue's description:
> Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/556003005/)
>
> Reason for revert:
> It looks like the moto E perf bots are broken due to this change.
>
> BUG=414267
>
> Original issue's description:
> > Introduce GetBackendFromContextId to avoid using list index.
> >
> > BUG=398467
> > TEST=ExtensionTest
> >
> > Committed: https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc
> > Cr-Commit-Position: refs/heads/master@{#294455}
>
> TBR=tbarzic@chromium.org,achuith@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=398467
>
> Committed: https://crrev.com/c8fad04c1e2119f9e8efc68f32d5268161d044d3
> Cr-Commit-Position: refs/heads/master@{#295136}

TBR=tbarzic@chromium.org,achuith@chromium.org,tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414267

Review URL: https://codereview.chromium.org/578693002

Cr-Commit-Position: refs/heads/master@{#295205}

Add ContextualSearchParams constructor to be called when content is passed via HTTP header and not CGI params.

BUG=376007

Review URL: https://codereview.chromium.org/573063002

Cr-Commit-Position: refs/heads/master@{#295204}

Renamed datadeps to data_deps for consistency.

Renamed direct_dependent_configs to public_configs for consistency with the public deps. This is also easier to understand and hopefully will encourage people to do this instead of use all_dependent_configs.

Now that there are so many types of deps, added a DepsIterator that allows easy iterating over all of them (or only the linked ones). This simplified some code.

This simplified the header checker significantly since it had complicated logic to find direct_dependent_configs and prefer paths with those forwarded.

Removed a bunch of weird group special-casing. Groups no longer have their deps copied into the target, but are dependents like everything else. For now, unless you explicitly specify public_deps, all group deps will default to public. I'd like to change this in a future pass.

Added a bool return value to the target generator functions that fill values. Since I originally did that, I've started both returning a bool and setting an Err, which makes checking for the error and early-returning easier to remember. I did this because I found yet another case of forgetting to check err, which gives very strange results.

Review URL: https://codereview.chromium.org/561273003

Cr-Commit-Position: refs/heads/master@{#295203}

Revert of Add public API generation with cr.makePublic() and handle it in compiler pass (patchset #10 id:180001 of https://codereview.chromium.org/557633002/)

Reason for revert:
Likely culprit for OOBE WebUI test breakage.

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1974/steps/browser_tests/logs/stdio

Original issue's description:
> Add public API generation with cr.makePublic() and handle it in compiler pass
>
> R=dbeam@chromium.org,tbreisacher@chromium.org
> BUG=393873
> TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md
>
> Committed: https://crrev.com/730652530d108372ef14f62b89665197628f7880
> Cr-Commit-Position: refs/heads/master@{#295173}

TBR=dbeam@chromium.org,tbreisacher@chromium.org,vitalyp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393873

Review URL: https://codereview.chromium.org/577843003

Cr-Commit-Position: refs/heads/master@{#295202}

Fix some more for= usage.

Also fix some controlled settings indicators.

BUG=409938
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/572853007

Cr-Commit-Position: refs/heads/master@{#295201}

With current autofill implementaion for credit card number field on a secure form that splits up the credit card number across multiple fields fails to fill all fields, and instead it just fills first of the credit card number field.

With this patch it solves the problem by book-keeping spilt information to hold the credit card number grouping.

BUG=90280

Review URL: https://codereview.chromium.org/381613005

Cr-Commit-Position: refs/heads/master@{#295200}

This CL adds the components_browsertests target to android, linux,
mac and windows platforms.

BUG=311270

Review URL: https://codereview.chromium.org/578653003

Cr-Commit-Position: refs/heads/master@{#295199}

Since Chrome 8, invoking <input type="file"> in a browser action popup
on OSX would show, then immediately close the sheet (and the popup).

This CL fixes it by ignoring loss of key status on the bubble window
when it has an attached sheet. Loss of key status (or clicks) on windows
that are sheets themselves are also ignored, otherwise dismissing the
sheet would close the bubble as well, since it's already lost its "sheet
attached" status by that stage.

BUG=61632

Review URL: https://codereview.chromium.org/576643002

Cr-Commit-Position: refs/heads/master@{#295198}

This test verifies that the "Chrome-Proxy: block-once" directive for
bypassing the data reduction proxy for just the current request works as
expected.

BUG=404053

Review URL: https://codereview.chromium.org/558743003

Cr-Commit-Position: refs/heads/master@{#295197}

Revert of Remote Assistance on Chrome OS Part I - Aura Desktop Capturer (patchset #11 id:220001 of https://codereview.chromium.org/543243003/)

Reason for revert:
This patch appears to cause a Chrome OS bot to break.

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71945

Original issue's description:
> Remote Assistance on Chrome OS - Aura Desktop Capturer
>
> This CL implements a WebRTC Desktop Capturer that captures from
> the Aura Shell root window.
>
> The capturer is used by the It2MeHost on Chrome OS.
> |DesktopCaptureDeviceAura| cannot be re-used in our scenario
> because is timer-driven as opposed to caller driven, which is
> required by WebRTC.
>
> The current implementation uses the layer API
>
> desktop_window_->layer()->RequestCopyOfOutput(request.Pass())
>
> to request the layer and its subtree to be rendered to a
> |SkiaBitmap|.  It then copies the pixels to a WebRTC |DesktopFrame|.
>
> BUG=411530
>
> Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c
> Cr-Commit-Position: refs/heads/master@{#295187}

TBR=sergeyu@chromium.org,dcaiafa@chromium.org,darin@chromium.org,wez@chromium.org,jamescook@chromium.org,reed@google.com,danakj@chromium.org,sky@chromium.org,kelvinp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411530

Review URL: https://codereview.chromium.org/579583003

Cr-Commit-Position: refs/heads/master@{#295196}

These checks were lost in refs/heads/master@{#294801}: https://codereview.chromium.org/541763002.

BUG=382975
TEST=Compiling does not warn about an unused result.

Review URL: https://codereview.chromium.org/573963007

Cr-Commit-Position: refs/heads/master@{#295195}

This allows custom launcher pages to be torn down in response to this
notification in the same way that regular packaged app windows are.
Currently these WebContents are torn down later, by
Widget::CloseAllSecondaryWidgets(), but this relies on the WebContents
lifetime being tied to a Widget.

Observing NOTIFICATION_APP_TERMINATING also allows us to explore
decoupling the AppListViewDelegate from the AppListView lifetime, and
remove some special code on Mac to deal with updating the profile
switcher (since the AppListViewDelegate is owned by a leaky singleton
there).

BUG=403647

Review URL: https://codereview.chromium.org/559823002

Cr-Commit-Position: refs/heads/master@{#295194}

BUG=414820

Review URL: https://codereview.chromium.org/581433002

Cr-Commit-Position: refs/heads/master@{#295193}

CodeGen's only dependency on ErrorCode was one MakeInstruction()
overload, which can be removed by making the caller responsible for
converting the ErrorCode to a BPF_RET'able value. Fortunately, there
are only two uses of this function:

1. SandboxBPF::RetExpression() which is easily fixed by simply calling
ErrorCode::err() to get the ErrorCode's error value.

2. codegen_unittest.cc which is merely testing the BPF code generator,
and so any return values will do: no need to be seccomp-bpf return
values... so just replace them with simple integer values.  (While
here, change a few bare "BPF_RET" arguments to "BPF_RET + BPF_K" just
to be consistent.)

After this CL, CodeGen focuses solely on assembling programs for the
abstract BPF machine, while higher-level abstractions (primarily
SandboxBPF) are responsible for using it in a way that's semantically
meaningful for seccomp-bpf.

BUG=414363

Review URL: https://codereview.chromium.org/576673003

Cr-Commit-Position: refs/heads/master@{#295192}

Sending is controlled by a finch experiment.

The verdict from the server is ignored for now.

BUG=413967

Review URL: https://codereview.chromium.org/512513002

Cr-Commit-Position: refs/heads/master@{#295191}

I've also added the WTF namespace, which we still use.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/574473002

Cr-Commit-Position: refs/heads/master@{#295190}

BUG=None

(inherit from the original issue)
TBR=stevenjb@chromium.org

Orignial issue description:

>  Minor cleanup in EasyUnlockClient
>
>  * arg names in GenerateEcP256KeyPairCallback typedef were reversed
>  * Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead
>  of having long list of arguments)
>
>  BUG=None
>  TEST=existing unittests
>
>  Review URL: https://codereview.chromium.org/569813002
>
>  Cr-Commit-Position: refs/heads/master@{#294954}

Review URL: https://codereview.chromium.org/581463002

Cr-Commit-Position: refs/heads/master@{#295189}

This makes EasyUnlockService pure virtual base class and introduces
separate implementations for regular and signin profiles. Common code
for both service types is kept in EasyUnlockService class.

EasyunlockService for signin profile is left empty.

BUG=401634

Review URL: https://codereview.chromium.org/577683002

Cr-Commit-Position: refs/heads/master@{#295188}

This CL implements a WebRTC Desktop Capturer that captures from
the Aura Shell root window.

The capturer is used by the It2MeHost on Chrome OS.
|DesktopCaptureDeviceAura| cannot be re-used in our scenario
because is timer-driven as opposed to caller driven, which is
required by WebRTC.

The current implementation uses the layer API

desktop_window_->layer()->RequestCopyOfOutput(request.Pass())

to request the layer and its subtree to be rendered to a
|SkiaBitmap|.  It then copies the pixels to a WebRTC |DesktopFrame|.

BUG=411530

Review URL: https://codereview.chromium.org/543243003

Cr-Commit-Position: refs/heads/master@{#295187}

BUG=354046

Review URL: https://codereview.chromium.org/441553002

Cr-Commit-Position: refs/heads/master@{#295186}

- Use bundled binutils by adding to cflags -B
- Enables dwarf-fission based on bundling (maybe correct?)
- Makes differ normalize -B paths so they can be compared between gyp/gn.

R=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/568613002

Cr-Commit-Position: refs/heads/master@{#295185}

For each bound UDP socket, the Pepper layer in the plugin process maintains a
buffer to store received packets, and informs the browser process of available
buffer slots. The browser process does recvfrom and pushes the results to the
plugin process when there are available slots.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/563073002

Cr-Commit-Position: refs/heads/master@{#295184}

the code that checks that sockets API is available was checking that
chrome.socket.secure is defined without verifying that chrome.socket
is defined. As result the app would not connect.

BUG=414366

Review URL: https://codereview.chromium.org/567293005

Cr-Commit-Position: refs/heads/master@{#295183}

This creates a basic clipboard interface and uses it from
html_viewer. This is a minimal implementation and does not actually
interact with the system clipboard.

BUG=411039
First Committed: https://crrev.com/757286d8a2c778fe4622890140c9b9d2afd21063

Review URL: https://codereview.chromium.org/562483002

Cr-Commit-Position: refs/heads/master@{#295182}

Fix GN build for ozone and official.

TBR=cmasone@chromium.org

Review URL: https://codereview.chromium.org/552983004

Cr-Commit-Position: refs/heads/master@{#295181}

TBR=hclam

Review URL: https://codereview.chromium.org/576873002

Cr-Commit-Position: refs/heads/master@{#295180}

We need to show an empty bar for the user to drag extension actions into for
overflow when there are none currently overflowed. Obviously, this empty bar
should only be displayed when the user is dragging an extension action.

BUG=414386

Review URL: https://codereview.chromium.org/556293003

Cr-Commit-Position: refs/heads/master@{#295179}

Revert of Remove deprecated cursor event filter for Ozone (patchset #2 id:20001 of https://codereview.chromium.org/580553002/)

Reason for revert:
This appears to be causing ImmersiveFullscreenControllerTest.MouseEventsVerticalDisplayLayout to fail on Chromium OS Ozone bots.
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Ozone%20Tests%20%281%29&number=3404
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/3405

Original issue's description:
> Remove deprecated cursor event filter for Ozone
>
> Removes the old filter in favor of the new one which is enabled
> by default on non-Ozone CrOS builds.
>
> BUG=none
> TESTS=ran ash_unittests --gtest_filter=MouseCursorEventFilterTest.* on an Ozone build and manually tested on link_freon
>
> Committed: https://crrev.com/cee48a5ba8c24eb8b8ea7f789e3025ac79549a4d
> Cr-Commit-Position: refs/heads/master@{#295169}

TBR=oshima@chromium.org,dnicoara@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/567413003

Cr-Commit-Position: refs/heads/master@{#295178}

This patch adds a field to the BufferedFileStreamReader constructor, which says
how much bytes in total are going to be requested. This information is used for
an efficient buffering strategy.

TEST=unit_tests: *BufferingFileStreamReader*
BUG=398338

Review URL: https://codereview.chromium.org/470323003

Cr-Commit-Position: refs/heads/master@{#295177}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/569173006

Cr-Commit-Position: refs/heads/master@{#295176}

Added at https://codereview.chromium.org/306753003 but not included into
the GN build.

R=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/581483002

Cr-Commit-Position: refs/heads/master@{#295175}