- 29 Oct, 2020 40 commits
-
-
Yunke Zhou authored
In RTL case, the coordinate system is from right to left and the origin is the right upper corner. The coordinates for everything on the lock screen should be the same in both LTR and RTL cases and therefor mirroring is not needed. The misplacement is due to doing mirroring in `ConvertPointToTarget` when finding the position of the bubble. We need to remove the mirroring effect in order to find the correct position for login bubble. Bug: 937245 Change-Id: I4c4ce54ab7617a5c4c56e861afb7a103b045ef8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505869 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#822175}
-
cfredric authored
Study. Bug: 973801, 1137081 Change-Id: Ieab55af5ac66aa23f2e3c2392e80da6c80404507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492601 Auto-Submit: Chris Fredrickson <cfredric@google.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#822174}
-
Fredrik Söderqvist authored
Rather than passing three bools, pass a SVGContainerLayoutInfo struct as argument. Makes some of the callsites slightly more readable. Change-Id: Ic71bb7d863de047bf8e20dfec02e30fee02a8d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505754Reviewed-by:
-
Dan McArdle authored
Bug: 1052476 Change-Id: I0c8a0280fe121b82e17e602098732895ac9100f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507451Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#822172}
-
Sébastien Séguin-Gagnon authored
Bug: 1136043 Change-Id: Icb3d8aa472ec1f6fb932369ce7e80ba69470fedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506044 Auto-Submit: sebsg <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#822171}
-
Ramin Halavati authored
Profiles that are scheduled for deletion cannot be used to create new browser windows. Bug: 1141551, 1125474 Change-Id: I0239b4b51c09be7dc0ff2c3189972dfa75a2ca00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497446 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#822170}
-
Tomasz Wiszkowski authored
Bug: 1112385 Change-Id: Id75f093fde39d3abf1fc06481771015c5062eda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506351Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#822169}
-
Domenic Denicola authored
URLs which are secure contexts can use the origin isolation feature, even if they're not HTTPS. The most important example of this is http://localhost. Fixed: 1142894 Change-Id: I0c8d1c73465c2c289ae2996695f0c42f78cf100c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503849Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822168}
-
Caleb Raitto authored
Change-Id: I4134461984fff33f9e6470cb7b4982ba51802dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505581Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822167}
-
Mohamed Adel authored
The purpose of this subclass is to move all specific API calls to their appropriate subclass. This is being done as UNUserNotificationCenter is going to be added to the XPC service so it needs to be able to support both. Bug: 1142497 Change-Id: I123fc0144f507c18ca30ae66c75129ab1410b7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498594Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#822166}
-
Mohamed Heikal authored
needed in preparation to moving the chime DFM definition downstream. followup cl downstream crrev.com/i/3364724 Bug: 1142775 Change-Id: I2b07234fdba5dc2fa49632d5710f5ebedf48439f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501667 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822165}
-
RJ Ascani authored
This reverts commit cca7402b. Reason for revert: This made the FuchsiaCdmManager tests flaky. See crbug.com/1143067 Original change's description: > [Fuchsia] Move CDM data file i/o off main thread > > The FuchsiaCdmManager needs to create directories for each origin to > pass to the platform CDM services to fulfill EME origin isolation > requirements. The FuchsiaCdmManager runs on the main thread and the > calls to CreateDirectoryAndGetError are potentially blocking. This CL > moves the directory creation step to a background task. > > Bug: 1140655 > Change-Id: I060edc909976e7b5a493afc3bc9a2a26e26994be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500532 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: RJ Ascani <rjascani@google.com> > Cr-Commit-Position: refs/heads/master@{#821353} TBR=wez@chromium.org,rjascani@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140655, 1143067 Change-Id: I06955764f82f32f3aa96443f91ffd566aede3b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505977Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#822164}
-
Aya ElAttar authored
- Added source for drag-and-drop data the same as clipboard data to be able to apply the rules of data leak prevention policy. Bug: 1139886 Change-Id: I321c9ab7527cb1b16561973b1e57420e5a4b9e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489634Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#822163}
-
Eric Orth authored
Targeting draft-ietf-dnsop-svcb-httpssvc-03. Bug: 1138620 Change-Id: I5198bb2aebff3d4aebfbc4e457965b0021991787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503490Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#822162}
-
Ramin Halavati authored
System profiles create a primary off-the-record profile. |IsIncognitoProfile| function is updated to return false for this OTR profile. Bug: 1143077, 1125474 Change-Id: Ib0763eabb154556c96fb47add3b738372edf8555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504231Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#822161}
-
Dominique Fauteux-Chapleau authored
All references to functions using those prots were already removed, so this just cleans up the remaining dead code. Bug: 1103390 Change-Id: I6e2c6c70eb52144cedc7f8ab390c3b6d89a02e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505943 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#822160}
-
Rune Lillesveen authored
Test is flaky on multiple platforms, not only Windows. TBR=acolwell@chromium.org Bug: 980446 Change-Id: I8a26aefa4beaf53c501f922e2bbc6021cd86b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506578Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822159}
-
Rune Lillesveen authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/50702 TBR=joedow@google.com Bug: 1143671 Change-Id: I16cd36a9f8edaad8b02a78d2170b30107e878800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506442Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603929441-de7c595584c292110f839d1296c0369f387aa3ca.profdata to chrome-linux-master-1603972752-7774997975c1fc77dd139039f32c4c5217a4f93d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic282a849c64d5c002ad89721610ccaf6f3041aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822157}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3cd384a5b039..83c38a8fd6b1 2020-10-29 robertphillips@google.com Allow uniqueKey invalidation messages to reach the thread safe cache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: jcgregorio@google.com Change-Id: Idb0a174358821cab5a88813281489834555cb206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507100Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603929441-b6b34c1c4b0f9e2ddac4473f28fe820beebad5c9.profdata to chrome-mac-master-1603972752-eb96abf6b462a9960649372890eeb96e7f549740.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic97d3d026cc93a3c50aba27168869779dd53df5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507105Reviewed-by:
-
Hajime Hoshi authored
Before this CL, |BackForwardCacheMetrics:: browsing_instance_not_swapped_reason_| is not reset at navigation and might be recorded in non-related navigations unexpectedly. This CL fixes this by resetting it every navigation. Bug: 1134847 Change-Id: Ib9e00f6937c5425c82cd2e40bdb47cb1fb740d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501546Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822154}
-
Sergey Ulanov authored
SnapshotAuraTest.FullScreenWindow was using action_max_timeout() on Linux, but not on Fuchsia. Now it's timing out on Fuchsia periodically. Increase the timeout on Fuchsia as well. Bug: 1143031, 1142521 Change-Id: Iaddd417af60a127273b965e1e0646674f8af10e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503347 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822153}
-
Jakob Ivarsson authored
Tests using callAndExpectResolution falsely assume that the captured resolution is always sent. The sent resolution is dependent on bandwidth estimation so any changes to that can make these tests fail. This is blocking landing of: https://webrtc-review.googlesource.com/c/src/+/190143 Bug: webrtc:6762 Change-Id: I69c226ca146db7cd03dd90c073aa84cc0d064d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506433Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#822152}
-
Reda Tawfik authored
This CL disables "Use other password" button on low level security sites Bug: 1129026, 1104132 Change-Id: I7bb85d2179933420f8c13b3e1dce7d30d81ffb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470658Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#822151}
-
Rayan Kanso authored
This reverts commit 9d31a5ee. Reason for revert: Android test bots failing Looks like the test is causing a segfault. Sample run: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/623 Bug: 1143642 Original change's description: > Add fetch uploading big arraybuffer test in LoaderBrowserTest. > > This CL adds fetch uploading 150Mbytes arraybuffer test. > > Since similar layouttest was so slow, I decided to test it in browser > test. > > Bug: 919361 > Change-Id: I693e67666e71b999276f25cfe0c0ff56436c4369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490964 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821648} TBR=mmenke@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 919361 Change-Id: Id415f1e404bc9bb53ae8e04a9556238314593f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506181Reviewed-by:
-
Will Cohen authored
This patch modifies the constants used to simulate achromatopsia (grayscale). The paper referenced in the patch's inline comments suggests that the constants being used by Chromium are only correct when converting from the NTSC color space. The new constants here are proposed in the paper for conversion from sRGB. R=mathias@chromium.org Bug: chromium:1143044 Change-Id: I4c20b61a067ba4842e846c8dc03d0f3b61ee8fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504809Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#822149}
-
Trent Apted authored
This reverts commit bae24cf6. Reason for revert: https://crbug.com/1141271 refers to content_browsertests, but CheckHistograms runs in unit_tests I suspect the red herring came from https://crrev.com/c/2489020 which was reverted at a similar time and shows up in the flakiness dashboard. Original change's description: > [sheriff] Disable the flaky test on linux. > > AboutFlagsHistogramTest.CheckHistograms is flaky on linux. > > TBR=asvitkine@chromium.org,ellyjones@chromium.org > > Bug: 1141271 > Change-Id: Ifbda96854d6b9658dd27c5d1f90f92e39347fd4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491701 > Commit-Queue: Hayato Ito <hayato@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819699} TBR=ellyjones@chromium.org,asvitkine@chromium.org,hayato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id01d2b1ca4ef59f4d0d41d7495fec7d2d2413493 Fixed: 1141271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507229 Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#822148}
-
Yifan Luo authored
Add Document and DocumentFragment as inputs on both sanitize and sanitizeToString methods. Bug: 1116418 Change-Id: I06cd10dde9a5ca637140f7c4a71a302faa77abc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487085Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#822147}
-
Fredrik Söderqvist authored
Call IntrinsicSize() rather than intrinsicWidth()+intrinsicHeight(). Change-Id: Ia9711584d470bd1930dfd25984ad1ddd25976e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506436 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#822146}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2505897 Bug: chromium:1011811 Change-Id: Id701ec57b88468df4134956635b143a78fe8e7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505987Reviewed-by:
-
Lily Chen authored
This extends the expiry of same-site-by-default-cookies and cookies-without-same-site-must-be-secure to M90, to be consistent with the other SameSite cookie flags. Bug: None Change-Id: I815c359576b38320789563d0c5efe73d27ace655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506299 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#822144}
-
Yusuf Sengul authored
Bug: 1143303 Change-Id: I5cc320683d9580f81f5eb6aeb6e0eda9e1b82d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506569 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Geoff Lang authored
After https://chromium-review.googlesource.com/c/angle/angle/+/2135926 the Pixel2 bots started generating OUT_OF_MEMORY errors in the conformance/rendering/draw-arrays-out-of-bounds.html test. TBR=zmo@chromium.org NOTRY=true Bug: chromium:1143323 Change-Id: Id157ea17caf40008764d759b727375c398afa75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507392Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822142}
-
Illia Klimov authored
As part of http://crbug.com/1064647 this CL removes PluginsAllowedForUrls, PluginsBlockedForUrls, AllowOutdatedPlugins policies. Bug: 1083496 Change-Id: I48dd8c7c32715a7c75fa91c0d3a986367f8fb097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502692 Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#822141}
-
Esmael El-Moslimany authored
Small change that is included in CL: moving shopping task above recipes on the NTP. Bug: 1138011 Change-Id: I1f30287540fe8f631fffbd003d78ac59b6bc2c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487721 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#822140}
-
Richard Townsend authored
Corrects a build error resulting from a mismatching GUID for this component. Bug: 1143261 Change-Id: Id179d0a0927a6e85c1053d4a44475635c3dc93f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507290 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Bug: none Change-Id: I3961c70baed54dbe945906a62089719a2d0d8b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506437 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822138}
-
Mustaq Ahmed authored
We encountered use-cases where the user hits the Esc key to release a PointerLock then expects to request another lock soon afterwards. If the second request comes within 2secs of the Esc keypress, we have been deliberately ignoring the second request to suppress abusive uses of requestPointerLock (e.g. to prevent users from exiting the locked state, see crbug.com/1084618). To address the above problem while also preventing abusive uses, this CL reduces the delay to 1.25sec as a trade-off. Fixed: 1127223 Change-Id: I37a5e8e16e8387ac4717fc90fecf946257199575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505911Reviewed-by:
-
Luciano Pacheco authored
Nits addressed: - Add type check. - Remove "#export" markup. - Use Object.assign() to export test functions to global scope. Files updated: - command_test.m.js - event_target_test.m.js - cr_test.m.js (removed as it's redundant with //test/data/webui/js/cr_test.js) Bug: 1133198 Change-Id: I808675afb4419a97252fe355ed7f7b2c6f0705fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505700 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#822136}
-
