- 11 Sep, 2018 20 commits
-
-
Eugene But authored
Bug: 881876 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id32427383dc90c986bb6ddf3cf07b0e1fc3f5282 Reviewed-on: https://chromium-review.googlesource.com/1214756Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590139}
-
Koji Ishii authored
When the scrollbar is on left and the box is narrower than the scrollbar, the scrollbar overflows to left. LayoutBox::AddLayoutOverflow() expects the overflow adjusted by the amount the scrollbar overflows. This affects a jQuery plugin that detects RTL scroll type[1]. [1] https://github.com/othree/jquery.rtl-scroll-type Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I70e7b1ecc20857ff10687afd7d5e3b7d70afb2dc Reviewed-on: https://chromium-review.googlesource.com/1215365Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#590138}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/cb6ec4b1f91a..385a05c3d606 git log cb6ec4b1f91a..385a05c3d606 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 hinoka@chromium.org Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""" Created with: gclient setdep -r src/native_client@385a05c3d606 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: Ie08297a4b5f3a345d2d06b43149694096174f5e1 Reviewed-on: https://chromium-review.googlesource.com/1217804Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590137}
-
Yuki Awano authored
- Update window properties and detach ax child tree when user switches back to TalkBack. ]. Confirm that TalkBack works well. Bug: 881695 Test: Open any android app with spoken feedback and press Search+A then Change-Id: I2b5db2d77e49e674e98c1b3cfbb18b2567d69388 Reviewed-on: https://chromium-review.googlesource.com/1212210Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590136}
-
Ben Pastene authored
Blocked on adding more bots to the pool: http://crrev.com/i/676080 Bug: 646404 Change-Id: I46021d3173e430287afffde7b9da77bddb6c5487 Reviewed-on: https://chromium-review.googlesource.com/1217037Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#590135}
-
dpapad authored
There are 2 separate fixes (but they can't land separately). 1) In Shadow DOM v1 the 'close' events from <dialog> no longer bubbles by default. Therefore it needs to be caught and re-fired. 2) The failing test was checking that after closing the action menu, the previously focused bookmark-item regains focus. This relied on some intricate timing, which was assuming that the browser has finished processing focus by the time the 'close' listener executes (which is no longer the case after the re-fire of 'close'). Instead, listening explicitly for the 'focus' event on the bookmark-item that is supposed to be focused fixes the problem. Bug: 875472 Change-Id: I74a6061f0967d994a2a5558c3508acbc0652c689 Reviewed-on: https://chromium-review.googlesource.com/1213872Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590134}
-
Charles Zhao authored
(1) Add HourAppLaunchPredictor with unit test. (2) Add SerializationTesterAppLaunchPredictor for testing AppSearchResultRanker materialization logic. (3) Extend AppLaunchPredictor interface to support more functions. Bug: 871674 Change-Id: I38bbc0b7efd1ed3576c4c3d170c553ec80dcec93 Reviewed-on: https://chromium-review.googlesource.com/1189506 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590133}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8e9d23405644..63aa0e5b7001 git log 8e9d23405644..63aa0e5b7001 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 wfh@chromium.org Fix 64-bit -> 32-bit implicit conversions in libangle. Created with: gclient setdep -r src/third_party/angle@63aa0e5b7001 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879657 TBR=ynovikov@chromium.org Change-Id: Ia03df51b8f891829159e37a52cd2c77b408a28e5 Reviewed-on: https://chromium-review.googlesource.com/1217806Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590132}
-
Victor Costan authored
LEVELDB_EXPORT is defined in include/leveldb/export.h, and depends on the definition of LEVELDB_SHARED_LIBRARY. In order for LEVELDB_EXPORT to be defined consistently, LEVELDB_SHARED_LIBRARY must have the same definition in leveldb and all targets using it. Previously, LEVELDB_SHARED_LIBRARY was only defined for component builds in the //third_party/leveldatabase target. This CL makes the definition apply to //third_party/leveldatabase dependencies as well. This CL also renames the //third_party/leveldb target to //third_party/leveldb_static, to clarify its purpose. The CL is associated with Bug 823071 because it blocks https://crrev.com/c/1201856 from landing, which is relevant to that bug. Bug: 823071 Change-Id: I4216fa52b5f7ed9540ec63be7c16dc7150e9c766 Reviewed-on: https://chromium-review.googlesource.com/1203876 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#590131}
-
Gabriel Charette authored
R=isherman@chromium.org Bug: 633389 Change-Id: I8cf75c421c4872e86a3e3e66ae950c0c3cdbf8d1 Reviewed-on: https://chromium-review.googlesource.com/1216462Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590130}
-
Lei Zhang authored
FILE_PATH_LITERAL() should take a literal and not a variable. In these cases, it does not matter either way, since the code only runs on POSIX, where FILE_PATH_LITERAL() is a no-op. Change-Id: Ie8069761f15e30a3319571927336010fc1710818 Reviewed-on: https://chromium-review.googlesource.com/1217507Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590129}
-
Bailey Berro authored
- After switching to cr-searchable-drop-down, mountUrl_ was undefined, this switches it to being explicitly initialized to an empty string so the Add button is correctly disabled. Bug: chromium:882590 Change-Id: I38dcc3a17b9406f2d633b90154114ad20876fa91 Reviewed-on: https://chromium-review.googlesource.com/1217514 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590128}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b3b8b5883ce2..b9b825ec0c30 git log b3b8b5883ce2..b9b825ec0c30 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 simonhatch@chromium.org Pinpoint - Let isolate handler use oauth or ip whitelist. 2018-09-10 brucedawson@chromium.org Display cswitch header version on errors Created with: gclient setdep -r src/third_party/catapult@b9b825ec0c30 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878976 TBR=sullivan@chromium.org Change-Id: I03d031e0322217a27db3909dc5105430b1c289a5 Reviewed-on: https://chromium-review.googlesource.com/1217807Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590127}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/303e83e6b3c8..3c4d533d8ebd git log 303e83e6b3c8..3c4d533d8ebd --date=short --no-merges --format='%ad %ae %s' 2018-09-10 herb@google.com Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig 2018-09-10 brianosman@google.com Add fast path to SkColorSpaceXformSteps 2018-09-10 reed@google.com Revert "add SkPath::shrinkToFit" 2018-09-10 allanmac@google.com Selected a much better HotSort "shape" for NVIDIA. 2018-09-10 reed@google.com add SkPath::shrinkToFit 2018-09-10 brianosman@google.com Revert "increase Builder's prealloc size after colorspace change" 2018-09-10 caryclark@skia.org Revert "Simplify plots to always be 512x512 and simplify GrDrawOpAtlasConfig" Created with: gclient setdep -r src/third_party/skia@3c4d533d8ebd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4a7e36b9aa13c00f15561af6f245b4aae911f3f7 Reviewed-on: https://chromium-review.googlesource.com/1217922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590126}
-
Aga Wronska authored
Manuall check that fingerprint UI shows during user sign in. Run wizard_controller_browser_tests. Bug: 882487 Test: Manuall check that fingerprint UI does not show in Demo Mode. Change-Id: I2b3e25f53b66194aca5a76285e8bbd4c6c7c2879 Reviewed-on: https://chromium-review.googlesource.com/1216808Reviewed-by:Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#590125}
-
Ted Choc authored
Uses that drop shadow for the navigation popup used for long press. Fixes a small bug where the "Show all history" item in the navigation popup was showing chrome://history because it was using the wrong constructor param ordering (added a test). BUG=800033 Change-Id: I84f60d0e7d67e86aa473b435ee63ededc5ee09f7 Reviewed-on: https://chromium-review.googlesource.com/1217362 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#590124}
-
Varun Khaneja authored
Corresponding changes in CLs at: - https://crrev.com/i/668738 - https://crrev.com/i/675169 Bug: 747428 Change-Id: I23b5bde4d134c86c26d18d21576bc822d0bc2ffb Reviewed-on: https://chromium-review.googlesource.com/1200410 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#590123}
-
Jialiu Lin authored
Add experiment to fieldtrial_testing_config that enables AdvancedProtectionStatus feature by default in tests. Bug: 866620 Change-Id: Ia8a85921b5cd5ee52ee49af3590ef36770fabe71 Reviewed-on: https://chromium-review.googlesource.com/1217349Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590122}
-
Pavel Yatsuk authored
Current server doesn't not support this feature. Removing it from about:flags so that clients stop sending traffic to the endpoint. R=pnoland@chromium.org Change-Id: Iaac8ecbb874ba9ed5bf534c0e3726535bb1bca07 Reviewed-on: https://chromium-review.googlesource.com/1205803 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#590121}
-
Wez authored
Bug: 726484, 881333 Change-Id: I9b779a087d20dda8f3f0a58ffb70fbbea1e6e601 Reviewed-on: https://chromium-review.googlesource.com/1210382Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#590120}
-
- 10 Sep, 2018 20 commits
-
-
Yuly Novikov authored
This reverts commit 40a87fcf. Reason for revert: Breaks "compile" in Debug and "compile confirm no-op" in Release Original change's description: > [ozone/wayland] Refactor IME deps for ozone platform > > Refactor base/ime components and dependencies for ozone > plaform integration to avoid cyclic dependencies. > > - Groups ui/base/ime common types into their own GN component > (ime_types) to break a dependency cycle that ozone ime context > integration would cause on ChromeOS. > - Groups some of ui/base/ime/linux interfaces into their own GN > component (ime_linux) to break a dependency cycle that ozone > ime context integration would cause on ChromeOS. > - Move chromeos source files under is_chromeos flag to avoid > depending them when chromeos is not used, but ime is needed > (kudos to msisov@igalia.com). > > Bug: 791920 > Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475 > Reviewed-on: https://chromium-review.googlesource.com/1193871 > Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590072} TBR=shuchen@chromium.org,yhanada@chromium.org,tonikitoo@igalia.com,msisov@igalia.com,jani.hautakangas@lge.com Change-Id: I5b032277b66ff9d5f6daca34425c5464736db77e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791920 Reviewed-on: https://chromium-review.googlesource.com/1217849Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#590119}
-
Karan Bhatia authored
This fixes an existing TODO in url_pattern_index to implement case-insensitive matching. To do so: - Lower case the stored n grams. These n grams are used to find prospective matches for a particular url. - Modify URLPattern to handle case-insensitive matching. This involves lower-casing the url pattern and the url, before comparing them. BUG=767605 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I1377c216d61392c508280141d0d947a47a3ee494 Reviewed-on: https://chromium-review.googlesource.com/1212183Reviewed-by:Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590118}
-
Kevin Strohbehn authored
Bug: 882643 Change-Id: I6681f064e8a21ac5557c4c2adb4633af248e0119 Reviewed-on: https://chromium-review.googlesource.com/1217756Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#590117}
-
Jia Meng authored
This reverts commit a609f4ac. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "[On-device adaptive brightness] Implement an AlsReader to ambient light." > > > Original change's description: > > Revert "[On-device adaptive brightness] Implement an AlsReader to ambient light." > > > > This reverts commit ea692f36. > > > > Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744) > > > > Original change's description: > > > [On-device adaptive brightness] Implement an AlsReader to ambient light. > > > > > > > > > Bug: 881215 > > > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe > > > Reviewed-on: https://chromium-review.googlesource.com/1209000 > > > Reviewed-by: Michael Martis <martis@chromium.org> > > > Reviewed-by: Dan Erat <derat@chromium.org> > > > Commit-Queue: Jia Meng <jiameng@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#589843} > > > > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org > > > > Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 881215 > > Reviewed-on: https://chromium-review.googlesource.com/1215603 > > Reviewed-by: Jia Meng <jiameng@chromium.org> > > Commit-Queue: Jia Meng <jiameng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589850} > > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org > > Change-Id: I8f170731509b2b23d469519fd45d5876175111d5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 881215 > Reviewed-on: https://chromium-review.googlesource.com/1217962 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590115} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: Idc8436b6fcf1140e5c30912d4c0727e867c2cb9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1217982Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590116}
-
Jia Meng authored
Original change's description: > Revert "[On-device adaptive brightness] Implement an AlsReader to ambient light." > > This reverts commit ea692f36. > > Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744) > > Original change's description: > > [On-device adaptive brightness] Implement an AlsReader to ambient light. > > > > > > Bug: 881215 > > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe > > Reviewed-on: https://chromium-review.googlesource.com/1209000 > > Reviewed-by: Michael Martis <martis@chromium.org> > > Reviewed-by: Dan Erat <derat@chromium.org> > > Commit-Queue: Jia Meng <jiameng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589843} > > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org > > Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 881215 > Reviewed-on: https://chromium-review.googlesource.com/1215603 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589850} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: I8f170731509b2b23d469519fd45d5876175111d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1217962Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590115}
-
Tien-Ren Chen authored
This reverts commit bb7972c1. Reason for revert: crbug.com/882642 Original change's description: > [Blink/SPv175+] Change DCHECK(chunk clip escaped layer clip) to a DLOG > > The PaintChunkToCcLayer algorithm was originally designed for > SPv2 compositor, and it was expected the layerization algorithm should > never assign a chunk to a excessively clipped layer, thus the DCHECK. > > Later this algorithm was adopted in SPv175 to be used with the > SPv1 compositor. There is a known bug that in certain corner case we > can fail to escape clip, and the bug is difficult to fix in the > legacy architecture. The DCHECK is expected to be a "soft" one that > we have a fail-safe path to recover in a sane way. > > This CL converts the DCHECK to a DLOG in SPv1 mode, and it should still > trap in SPv2 mode. In addition, it reverts a workaround to a nullptr > bug in the fail-safe path, and add a test for the fail-safe. > > BUG=881788,853357 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I4606acf4885f3344bb45a901bb2e8e46dbcda49a > Reviewed-on: https://chromium-review.googlesource.com/1213952 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590052} TBR=vmpstr@chromium.org,trchen@chromium.org,pdr@chromium.org Change-Id: I8f669d48422eb2cc3bb21db2d4866857710c3fbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881788, 853357 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1217712Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590114}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/11bc3991530d..727453b25672 git log 11bc3991530d..727453b25672 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@727453b25672 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b4e94b73d0df09893bc6cea5cfb4afe37cb1f80 Reviewed-on: https://chromium-review.googlesource.com/1217805Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590113}
-
Dmitry Gozman authored
This reworks restricted sessions to have granular control over specific permissions: target discovery, browser target, etc. Target handler can now operate in autoAttachOnly mode which is used for extensions. Previously we just banned target handler from extension sessions, which broke OOPIF debugging for them. Bug: 870314 Change-Id: I0c3e8860aca547bb631e2a9615e58ac33465d88e Reviewed-on: https://chromium-review.googlesource.com/1212089Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590112}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03c80a36415d..b3b8b5883ce2 git log 03c80a36415d..b3b8b5883ce2 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 bsheedy@chromium.org Refactor quests to support instrumentation and browser tests Created with: gclient setdep -r src/third_party/catapult@b3b8b5883ce2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:881017 TBR=sullivan@chromium.org Change-Id: Iafff24fea5d1f61b8e9c36f61cd1885cd34ade72 Reviewed-on: https://chromium-review.googlesource.com/1217802Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590111}
-
Varun Khaneja authored
GCL: http://cl/212327439 Bug: 74747428 Change-Id: Ia53e4451e9119bee0efd052c710563239de8ae2b Reviewed-on: https://chromium-review.googlesource.com/1217511Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#590110}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52fd68762ae4..303e83e6b3c8 git log 52fd68762ae4..303e83e6b3c8 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 egdaniel@google.com Let unbudgeted, unique keyed resources stay in gpu ResourceCache. 2018-09-10 jvanverth@google.com Consolidate more shadow generation code. Created with: gclient setdep -r src/third_party/skia@303e83e6b3c8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4e5859559b506dcfd52fba9471699079a76eff51 Reviewed-on: https://chromium-review.googlesource.com/1217482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590109}
-
Dmitry Gozman authored
Bug: 775132 Change-Id: Ib31b7e9e5ef031abd47b4608bec5accb9181311e Reviewed-on: https://chromium-review.googlesource.com/1217592Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590108}
-
Sky Malice authored
Bug: 866126 Change-Id: I4c300a57b7fbb9041419f9806eb0e656a22f1fbd Reviewed-on: https://chromium-review.googlesource.com/1197791 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#590107}
-
Gang Wu authored
Implement commit Journal operations for Journal storage on C++ side. Bug:879855 Change-Id: I8bf9d38571a4c83f7110be2d0043a8471171ba8c Reviewed-on: https://chromium-review.googlesource.com/1200943 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#590106}
-
liberato@chromium.org authored
When setting the visible rect properly, the coded size was inadvertently also changed to be the visible rect. This CL puts it back. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0b041b495bbc5a12095868ac0e6391826a445f77 Reviewed-on: https://chromium-review.googlesource.com/1217753Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#590105}
-
Dominic Mazzoni authored
This is a follow-up to http://crrev.com/c/1150824 - instead of having Document keep track of its AXContexts, let the garbage collector do the work for us. Each AXContext owns a Persistent<AXObjectCache>, and the associated Document has a WeakPersistent<AXObjectCache>. That way when the last AXContext goes out of scope, the AXObjectCache will be cleaned up automatically. This requires a few changes due to assumptions that AXObjectCache couldn't outlive its corresponding document. Bug: 867324 Change-Id: Id0479f59c9a9652b2cb321ed14369e8996748d8a Reviewed-on: https://chromium-review.googlesource.com/1162743 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#590104}
-
Lei Zhang authored
Also adjust FileEnumerator's build rules. Change-Id: I4a151782f35518f720296c1e5ed3e14910dccfc5 Reviewed-on: https://chromium-review.googlesource.com/1215045Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590103}
-
Stephen Martinis authored
merge_results.py outputs a log line for every file that it 'merges'. Some of these files are only 'merging' one file. This makes the step log on buildbot be incredibly verbose, since there are thousands of artifacts generated by webkit_layout_tests. This CL changes the behavior to only log something if it's doing a non-trivial merge. 'Merges' which only merge one file aren't logged. Change-Id: I6e5bf7316a2f1ab41f8997582b12368c23456378 Reviewed-on: https://chromium-review.googlesource.com/1217594Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#590102}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d476f83e. With Chromium commits locally applied on WPT: d7762551 "Consistently use single quotes in Background Fetch WPTs." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24517 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ericwilligers@chromium.org: external/wpt/css/motion meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I4ad93e94f176e1809a9004d6cd2ebef266c703e2 Reviewed-on: https://chromium-review.googlesource.com/1217508 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590101}
-
Kenneth Russell authored
This workaround appears to mostly be necessary for compositing and rasterization contexts, and has a performance cost when used with WebGL. Disable it there. Bug: 882317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7dc89d11b2818f3af029d0dfb62d1a6e6fabfef3 Reviewed-on: https://chromium-review.googlesource.com/1217586Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590100}
-