GitLab

This patch exposes the limiting feature to providing extensions.

TEST=browser_tests: *FileSystemProvider*ReadFile*
BUG=445125
R=benwells@chromium.org, yawano@chromium.org

Review URL: https://codereview.chromium.org/824753003

Cr-Commit-Position: refs/heads/master@{#310740}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8f3519a..e34d6bd

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/819173004

Cr-Commit-Position: refs/heads/master@{#310739}

BUG=none

Review URL: https://codereview.chromium.org/802613004

Cr-Commit-Position: refs/heads/master@{#310738}

This requires that previously-used textures be returned to the browser compositor before a commit, so they can be uploaded to. This saves memory by reducing the number of textures that need to be created.

Also avoid releasing old textures from renderers on SubmitFrame, as that can be unnecessarily expensive if both the old and new frames reference the same textures.

BUG=446588,446417,446414

Review URL: https://codereview.chromium.org/843633003

Cr-Commit-Position: refs/heads/master@{#310737}

This finally adds a end-to-end WebRTC audio quality test which includes
getUserMedia and the capture path (except, obviously, the os-specific
code which actually interacts with the capture device etc).

This patch also makes the audio input device generic. It will now
convert its input .wav file to suit the audio bus. I had to do this
because the PESQ tests require files to be mono, 16-bit and so on.

BUG=446859

Review URL: https://codereview.chromium.org/831693004

Cr-Commit-Position: refs/heads/master@{#310736}

This is workaround for crbug.com/442217.

BUG=442217
TEST=None

Review URL: https://codereview.chromium.org/844903003

Cr-Commit-Position: refs/heads/master@{#310735}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8a288b5..f819761

TBR=jsbell@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/845683002

Cr-Commit-Position: refs/heads/master@{#310734}

Cr-Commit-Position: refs/heads/master@{#310733}

The testserver attempts to inherit from StoppableHTTPServer, but then
overrides the stoppable functionality. Instead of overriding serve_forever, override handle_request, to maintain stoppability.

BUG=

Review URL: https://codereview.chromium.org/797253003

Cr-Commit-Position: refs/heads/master@{#310732}

interactive_ui_tests was recently ported to gn in r310072 (all good wrt
MacViews).  Now is a good opportunity to make things a bit neater, and
get things closer to flipping toolkit_views=1 on Mac

This collapses the `sources!` filter for Mac+toolkit_views into
chrome_interactive_ui_test_views_non_mac_sources which now follows the
pattern that is already used in chrome_browser_ui.gypi. That is,
chrome_browser_ui_views_non_mac_sources and friends.

This does move a few more views test files out of interactive_ui_tests
on MacViews. These were compiling and linking, but had failing tests.
E.g. they do stuff like static_cast<BrowserView*>(browser->window())
which won't work while the browser is still Cocoa-based.

BUG=402679

Review URL: https://codereview.chromium.org/793663006

Cr-Commit-Position: refs/heads/master@{#310731}

Regressed in r309924. NativeWidgetMac just needs to check for a null
bridge_ to handle calls to {Set,Get}NativeWindowProperty during
asynchronous close calls.

BUG=378134

Review URL: https://codereview.chromium.org/826083003

Cr-Commit-Position: refs/heads/master@{#310730}

Previously ThumbnailLoader refers both metadata.thumbnail.url and
meatadata.external.thumbnailUrl. Thus it loads external thumbnail even if the
file is cached locally.

The CL fixes the logic and stop to use drive thumbnail for image files that are
cached. Note that if the file is not an image, use drive thumbnail always
because Files.app does not have logic to generate thumbnail from non-image
files.

BUG=446827
TEST=Added

Review URL: https://codereview.chromium.org/831833004

Cr-Commit-Position: refs/heads/master@{#310729}

To avoid having a lot of -Wunused-private-field warnings when using "=delete" to implement DISALLOW_COPY_AND_ASSIGN.

BUG=447445

Review URL: https://codereview.chromium.org/790793008

Cr-Commit-Position: refs/heads/master@{#310728}

We can't enable on the ref build because SW doesn't work on M37.
And also we disable on XP because of test flakiness.

BUG=442752

Review URL: https://codereview.chromium.org/828063005

Cr-Commit-Position: refs/heads/master@{#310727}

This migration was added in Aug 2013, M30: https://chromiumcodereview.appspot.com/20087002 .
According to UMA stats, it is triggered now for very few users/devices and can be removed.

BUG=447211

Review URL: https://codereview.chromium.org/845533002

Cr-Commit-Position: refs/heads/master@{#310726}

This is in preparation for sharing these lists with the GN build.

There should be no functional change as a result of this.

TBR=dpranke

Review URL: https://codereview.chromium.org/842803002

Cr-Commit-Position: refs/heads/master@{#310725}

Don't show existing wallet cards in the UI when this flag is NOT passed.

BUG=none

Review URL: https://codereview.chromium.org/810763008

Cr-Commit-Position: refs/heads/master@{#310724}

BUG=none

Review URL: https://codereview.chromium.org/791053009

Cr-Commit-Position: refs/heads/master@{#310723}

BUG=384667

Review URL: https://codereview.chromium.org/819443003

Cr-Commit-Position: refs/heads/master@{#310722}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/81e4b76..8a288b5

TBR=jsbell@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/835483004

Cr-Commit-Position: refs/heads/master@{#310721}

These icons are displayed inside captive portal blocking page.

BUG=384667

Review URL: https://codereview.chromium.org/791083003

Cr-Commit-Position: refs/heads/master@{#310720}

1.When we add new page or new folder after selecting some page bookmarked entry
in Bookmark manager, then new item should be added immediately below the
selected item.
2.when we add new page or new folder after selecting some folder bookmarked entry
in Bookmark manager, then new item should be added as last item inside selected
folder.
3.when we add new page or new folder without selecting any bookmarked entry
in Bookmark manager, then new item should be added in the last of already existing
bookmarked entries.

Added code in addPage() and newFolder() in main.js for getting the index of new node to be added so that it will be at proper location.

BUG=409816

Review URL: https://codereview.chromium.org/795483004

Cr-Commit-Position: refs/heads/master@{#310719}

BUG=447462

Review URL: https://codereview.chromium.org/838383002

Cr-Commit-Position: refs/heads/master@{#310718}

This patch adds a limit for number of opened files at once. The reason for that
is that provided file systems may not support multiple opened files per once due
to performance reasons. Enqueuing files is on the extension side is complicated
as extensions are event pages, and state may get lost after a suspend.

Note, that this CL only adds the C++ side. The opened_files_limit option is not
exposed via File System Provider API yet. This will be done separately.

Finally, the Queue class will be reused for enqueuing watcher events, which are
currently not safe (there are TODO about adding a queue). This will be also done
separately.

TEST=unit_tests: *FileSystemProviderQueue*, *FileSystemProviderThrottled*
BUG=445125

Review URL: https://codereview.chromium.org/829553002

Cr-Commit-Position: refs/heads/master@{#310717}

Revert of Add print and getSelectedText functions to the OOP PDF scripting API (patchset #3 id:40001 of https://codereview.chromium.org/843463002/)

Reason for revert:
Win7 Tests fail the test PDFExtensionTest.BasicPlugin.

API Test Error in testGetSelectedText

http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7823/steps/browser_tests/logs/BasicPlugin

Original issue's description:
> Add print and getSelectedText functions to the OOP PDF scripting API
>
> These are needed by some internal users (see the bug for more details).
> A test is added for selectAll/getSelectedText.
>
> BUG=415858
>
> Committed: https://crrev.com/7b1df224a957da8376e0ae71ab2d53dabf658b0a
> Cr-Commit-Position: refs/heads/master@{#310663}

TBR=sammc@chromium.org,raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415858

Review URL: https://codereview.chromium.org/843923002

Cr-Commit-Position: refs/heads/master@{#310716}

Because some trybots such as linux chromeos ozone use old linux
header files, use this flag to workaround chromium:446088 issue
to skip those trybots. So we can re-submit
https://codereview.chromium.org/826663002/. After 446088 is
fixed, this CL should be reverted.

BUG=445016
TEST=build squawks with this flag

Review URL: https://codereview.chromium.org/799543005

Cr-Commit-Position: refs/heads/master@{#310715}

When we selected some text that spreads in multiple pages then content of
pages should be separated by new line as happening in the Adobe Reader.
code added for checking selection in newpage, then add a newline char.

BUG=84387

Review URL: https://codereview.chromium.org/824363002

Cr-Commit-Position: refs/heads/master@{#310714}

This CL fixes the logic for detecting if a file was correctly opened in the
fsp::FileStreamReader and fsp::FileStreamWriter classes.

TEST=browser_test: *FileSystemProvider*, unit_test: *FileSystemProvider*FileStream*
BUG=447448

Review URL: https://codereview.chromium.org/814113007

Cr-Commit-Position: refs/heads/master@{#310713}

These unused members were found by locally changing DISALLOW_COPY_AND_ASSIGN to use "= delete"
so that the compiler can be sure these members are not used in the copy ctor and operator=.

BUG=447445
TEST=build

Review URL: https://codereview.chromium.org/838203002

Cr-Commit-Position: refs/heads/master@{#310712}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c38b182..81e4b76

TBR=jsbell@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/840193002

Cr-Commit-Position: refs/heads/master@{#310711}

These were broken in https://codereview.chromium.org/786023002

BUG=303849

Review URL: https://codereview.chromium.org/832373003

Cr-Commit-Position: refs/heads/master@{#310710}

The condition for NOT_FOUND was wrong. It worked, because another error exists
in the reader (crbug.com/447448).

TEST=browser_tests: *FileSystemProvider*Evil*
BUG=None

Review URL: https://codereview.chromium.org/838373002

Cr-Commit-Position: refs/heads/master@{#310709}

When browser want to do update(defined in sepc as [[Soft Update]]), the
update should not stop a installing worker.

For example, a controlled page navigation will trigger update after 1
second, if it also register a new version before this update, the new
worker might become redundant.

BUG=443046,404111

Review URL: https://codereview.chromium.org/822293003

Cr-Commit-Position: refs/heads/master@{#310708}

BUG=447461
NOTRY=true
TBR=bnc@chromium.org

Review URL: https://codereview.chromium.org/816553004

Cr-Commit-Position: refs/heads/master@{#310707}

Right clicking outside of a selected area should deselect text and bring up the correct context menu.

on right clink selection was not getting cleared,due to that
wrong context menu is coming.
Changes done so that when right click on the selected area then
selection will stay and proper context menu will come.
And when right click have been done outside selection then
selection will clear and correct context menu will come.

BUG=92800

Review URL: https://codereview.chromium.org/689083002

Cr-Commit-Position: refs/heads/master@{#310706}

Set up a FieldTrial which could disable this flag (via finch).

When the flag is enabled, chrome sends TCID parameter in CHLO message.
It is set to 0.

Added ??ByteConnectionId unittests to end_to_end_test.cc (found while
comparing the chromium code with internal source tree).

R=rch@chromium.org

Review URL: https://codereview.chromium.org/804813010

Cr-Commit-Position: refs/heads/master@{#310705}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb23524..c38b182

TBR=jsbell@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/821583003

Cr-Commit-Position: refs/heads/master@{#310704}

BUG=441448
TEST=run browser_tests

Review URL: https://codereview.chromium.org/831833003

Cr-Commit-Position: refs/heads/master@{#310703}

BUG=428729

Review URL: https://codereview.chromium.org/840033004

Cr-Commit-Position: refs/heads/master@{#310702}

Dynamic load v4l-utils related libraries in unittest.

BUG=405861
TEST=use video_encode_accelerator_unittest to make sure
v4l2_open and plugin_init is called. Related shared libraries are from
chromeos. When use_v4lplugin=0, unittest doesn't open v4l2 libraries.

Review URL: https://codereview.chromium.org/700383004

Cr-Commit-Position: refs/heads/master@{#310701}