GitLab

- TimeTicks in place of Time
- remove unnecessary member var running_
- etc.

BUG=none

Review URL: https://codereview.chromium.org/1103903003

Cr-Commit-Position: refs/heads/master@{#327073}

BUG=466848

Review URL: https://codereview.chromium.org/1092223006

Cr-Commit-Position: refs/heads/master@{#327072}

The condition was being misinterpreted because of missing braces.

Review URL: https://codereview.chromium.org/1104263002

Cr-Commit-Position: refs/heads/master@{#327071}

This moves the platform-specific OCSP stapling code out of SSLClientSocket,
which enables OCSP stapling on the chimera build. It'll also make it easier to
support OCSP stapling on OS X, where a stapled OCSP response is a property of
the certificate verification (as it should be) and not the certificate.

BUG=430714,479034

Review URL: https://codereview.chromium.org/1081913003

Cr-Commit-Position: refs/heads/master@{#327070}

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/605/steps/compile/logs/stdio

This fixes the following kind or warnings:

warning(clang): [chromium-style] Complex constructor has an inline body.
warning(clang): [chromium-style] Complex destructor has an inline body.
warning(clang): [chromium-style] complex class/struct needs an explicit out-of-line constructor.
warning(clang): [chromium-style] complex class/struct needs an explicit out-of-line destructor.

BUG=467287
R=thakis@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1106203002

Cr-Commit-Position: refs/heads/master@{#327069}

One current use for this is to ensure that cross-domain access error
messages (see https://crbug.com/478254) show the latest origin for
RemoteFrames.

BUG=426512, 478254

Review URL: https://codereview.chromium.org/1098763003

Cr-Commit-Position: refs/heads/master@{#327068}

This patch modifies all tests to have a more realistic threading set-up by either:

  a) adding a TestBrowserThreadBundle
  b) constructing any existing TestBrowserThreadBundle earlier or
  c) adding a MessageLoop as appropriate.

This makes it possible to later migrate base/ from MessageLoopProxy over to
ThreadTaskRunnerHandle, which requires an active task runner on the current thread.

BUG=465354

Review URL: https://codereview.chromium.org/1086733002

Cr-Commit-Position: refs/heads/master@{#327067}

A follow-up will unvirtual and disentangle the other virtual functions there.
Have SSLClientSocket implement ALPN-related methods internally using
GetNextProto rather than rely on SSLConnectJob to do it.

The SPDY-related bit is removed and moved up to callers. Also clean up the
MockSSLClientSocket overrides of these functions now that the setters are never
called outside of the SSLClientSocket implementation. Instead,
SSLSocketDataProvider supplies the input to MockSSLClientSocket::GetNextProto
and then the usual logic computes everything else from there.

BUG=477847

Review URL: https://codereview.chromium.org/1097773003

Cr-Commit-Position: refs/heads/master@{#327066}

The first attempt to land this CL failed because there weas a missing import in
device/BUILD.gn.

> mac: Weakly link against the CoreBluetooth framework.
>
> In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously,
> it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX
> 10.10, the top level CoreBluetooth framework must be weakly linked.
>
> BUG=463170
> Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8
> Cr-Commit-Position: refs/heads/master@{#326705}

BUG=463170
TBR=rsesek@chromium.org, keybuk@chromium.org

Review URL: https://codereview.chromium.org/1056313004

Cr-Commit-Position: refs/heads/master@{#327065}

BUG=470869

Review URL: https://codereview.chromium.org/1109823002

Cr-Commit-Position: refs/heads/master@{#327064}

When the bisect output text gets added to the perf dashboard, the <> characters shouldn't be there.

Ideally the perf dashboard should probably escape these characters before adding it to the quick-logger, but it's also easy to just remove them here.

Review URL: https://codereview.chromium.org/1087683002

Cr-Commit-Position: refs/heads/master@{#327063}

Check to make sure at the time that didNavigateMainFrame occurs that
the WebView is not destroyed (in which case skip registering the
visual state listener callback for onPageCommitVisible).

BUG=481534

Review URL: https://codereview.chromium.org/1109833002

Cr-Commit-Position: refs/heads/master@{#327062}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cf28480..12b6467

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1105103004

Cr-Commit-Position: refs/heads/master@{#327061}

Keyboard event rewriting has some special cases keyed on the device
name (Apple keyboards) or USB VID/PID (Hotrod remote), which had been
handled by special-case device inspection under X11, and not handled
at all under Ozone. This moves the properties to ui::DeviceDataManager
and makes the use in chromeos::EventRewriter platform-independent.

BUG=471753

Committed: https://crrev.com/711f2fc883c05bb10466fb65fdaf9bc10c909b23
Cr-Commit-Position: refs/heads/master@{#325660}

Review URL: https://codereview.chromium.org/1073573002

Cr-Commit-Position: refs/heads/master@{#327060}

In-flight CLs that landed downstream during the upstreaming of these
files resulted in drift; this re-syncs the files to the latest
versions.

BUG=464810

Review URL: https://codereview.chromium.org/1106963003

Cr-Commit-Position: refs/heads/master@{#327059}

This is to align the attributes used by memory allocator dump with
telemetry values [1] introducing types and units as attributes args.
Follow up patches will clean up the C++ interface to match the new
model.

This also rolls src/third_party/trace-viewer bd416ea:ba605a2 to pick up
the corresponding trace-viewer UI changes.

Summary of changes available at:
https://chromium.googlesource.com/external/trace-viewer/+log/bd416ea..ba605a2

BUG=466141

Review URL: https://codereview.chromium.org/1106943002

Cr-Commit-Position: refs/heads/master@{#327058}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/567ff2f..6393c06

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1103253002

Cr-Commit-Position: refs/heads/master@{#327057}

This allows URL(s) sent as args to be passed to the window manager. Also send --override-use-gl-with-osmesa-for-tests since it's listed on the sites page.

Review URL: https://codereview.chromium.org/1108023002

Cr-Commit-Position: refs/heads/master@{#327056}

This change moves any code related to JavaScript and HTML generation
in dom distiller to a superclass that all platforms can use.

BUG=472797

Review URL: https://codereview.chromium.org/1101993003

Cr-Commit-Position: refs/heads/master@{#327055}

This is a mechanical change.

The idea here is that we want to simplify the directory tree of
the component updater files and easily see what compilation unit has
tests and which one does not.

This change includes some whitespace changes due to running git cl format.

BUG=479904

Review URL: https://codereview.chromium.org/1102103002

Cr-Commit-Position: refs/heads/master@{#327054}

Currently the shared code is located in desktop_viewport.js, which means
that this file needs to be included by the AppRemoting builds. But
including that file also brings in a bunch of DesktopRemoting stuff as
well.

This cl extracts out the shared code into viewport.js (and moves the
unittests as well) so that we can more easily exclude the desktop
code from the AppRemoting code in a following cl.

BUG=

Review URL: https://codereview.chromium.org/1109453005

Cr-Commit-Position: refs/heads/master@{#327053}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0aae7c8..cf28480

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1104203003

Cr-Commit-Position: refs/heads/master@{#327052}

This reverts commit 45a0dc0b.
> Intercept base::File Open/Close
>
> When a file descriptor is opened by the base::File, all calls to close(3) from
> the same dynamic library will hit a CHECK unless they are made from a
> whitelist of callsites belonging to base::File.
>
> There is a handy protect_file_posix.gypi introduced to make it easy to enable
> on Chrome-for-Android.
>
> This 'linker magic' is somewhat crazy, so:
> 1. it will be *removed *when crbug.com/424562 is fixed
> 2. it should only be used by a whitelist of binaries/libraries (in the
>    opensource part: libchromeshell only)
>
> BUG=424562
>
> Review URL: https://codereview.chromium.org/676873004
>
> Cr-Commit-Position: refs/heads/master@{#304592}

Reason: crashes are not numerous, not much sense to fix, some explanations found
elsewhere.

BUG=424562

Review URL: https://codereview.chromium.org/1101723004

Cr-Commit-Position: refs/heads/master@{#327051}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6a307ba..567ff2f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1103223002

Cr-Commit-Position: refs/heads/master@{#327050}

This CL moves ScreenlockBridge to components/proximity_auth.

It also moves the usage of profile out of ScreenLockBridge as this
dependency is forbidden in //components.

TBR=rogerta,antrim,rdevlin.cronin,tengs

BUG=479670

Review URL: https://codereview.chromium.org/1096293003

Cr-Commit-Position: refs/heads/master@{#327049}

The problem was that ShowWindow that was eventually called through PlatformViewportWin::Show wasn't working because it was using the default from STARTUPINFO which was false.

Review URL: https://codereview.chromium.org/1106133002

Cr-Commit-Position: refs/heads/master@{#327048}

Previous reverted CL is here (https://codereview.chromium.org/1080723002/) and the first patch set also corresponds to it.

The problem for revert was in profile_io_data.cc file because of initiating two preferences for Android. The kMetricsReportingEnabled was introduced for future consolidation of two preferences. I have removed the initialization for kMetricsReportingEnabled which shouldn't change the behavior as the metrics service is still using kCrashReportingEnabled and Android side updates both preferences.

Rest of the code is not changed and corresponds to the version that was LGTM-ed before.

BUG=455847

TBR=dfalcantara@chromium.org,nyquist@chromium.org

Review URL: https://codereview.chromium.org/1058433007

Cr-Commit-Position: refs/heads/master@{#327047}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/778f653..0aae7c8

TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1109783002

Cr-Commit-Position: refs/heads/master@{#327046}

BUG=

Review URL: https://codereview.chromium.org/1110553002

Cr-Commit-Position: refs/heads/master@{#327045}

Upon a FrameTreeNode destruction a speculative RenderFrameHost might
be swapped-out instead of being destroyed along with the node. This
behavior differs from the current navigation implementation and was
causing a leak of a RenderFrameProxyHost.

This change adds a CHECK to stop the leak the same way
RenderFrameHostManager::SwapOutOldFrame does.

BUG=439423

Review URL: https://codereview.chromium.org/1066823004

Cr-Commit-Position: refs/heads/master@{#327044}

-Fixed Enterprise Enrollment window size
-Added autocomplete option to the offline login
-Added default domain "gmail.com" on offline login when user do not enter domain
-gaia-core-icon-button does not have box-shadow when it is hovered

BUG=480449,479128,478453,478452

Review URL: https://codereview.chromium.org/1110493002

Cr-Commit-Position: refs/heads/master@{#327043}

resources in installer gyp files.

Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001

for details

BUG=

Review URL: https://codereview.chromium.org/1109523002

Cr-Commit-Position: refs/heads/master@{#327042}

BUG=481127

Review URL: https://codereview.chromium.org/1106173002

Cr-Commit-Position: refs/heads/master@{#327041}

BUG=481029
R=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/1105123002

Cr-Commit-Position: refs/heads/master@{#327040}

https://chromium.googlesource.com/angle/angle/+log/ad0a486b..2cb7b835

BUG=None

Review URL: https://codereview.chromium.org/1106053002

Cr-Commit-Position: refs/heads/master@{#327039}

Rename methods and members and const variables from "alternate protocol" to
"alternative service":

* alternate_protocol_probability_threshold_ to
  alternative_service_probability_threshold_ in HttpServerPropertiesImpl,
* switches::kAlternateProtocolProbabilityThreshold to
  switches::kAlternativeServiceProbabilityThreshold,
* test names in IOThreadTest,
* SetAlternateProtocolProbabilityThreshold() to
  SetAlternativeServiceProbabilityThreshold(),
* GetAlternateProtocolProbabilityThreshold() to
  GetAlternativeServiceProbabilityThreshold(),
* remove obsolete force-alt-protocols from comments in io_thread.cc,
* "Alternate Protocol" to "Alternative Service" in NetInternals user facing
  QUIC page,
* alternate_protocol_probability_threshold to
  alternative_service_probability_threshold in IOThread::Globals and
  HttpNetworkSession::Params.

BUG=392575

Review URL: https://codereview.chromium.org/1091283007

Cr-Commit-Position: refs/heads/master@{#327038}

This patch enables the code injection for
<webview>.addContentScript/removeContentScript API.

This is the third patch in a series of patches:
1) Implement <webview>.addContentScript/removeContentScript API [1] (https://codereview.chromium.org/959413003)
2) Implement <webview>.addContentScript/removeContentScript API [2] (https://codereview.chromium.org/1056533002)
3) Implement <webview>.addContentScript/removeContentScript API [3] (https://codereview.chromium.org/1058113002)

BUG=461052

Review URL: https://codereview.chromium.org/1058113002

Cr-Commit-Position: refs/heads/master@{#327037}

BUG=479246

Review URL: https://codereview.chromium.org/1093923005

Cr-Commit-Position: refs/heads/master@{#327036}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1899651..6a307ba

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1104133003

Cr-Commit-Position: refs/heads/master@{#327035}

We now pull it via WebLayerTreeView::layerTreeId.

BUG=480980
TBR=kbr

Review URL: https://codereview.chromium.org/1110543002

Cr-Commit-Position: refs/heads/master@{#327034}