GitLab

Classes will use ExtensionRegistrar to enable and disable extensions, as
well as add, remove, reload, and terminate them (later CLs).

Currently Chrome's ExtensionService does this, among many other things.
A standalone class for this is preferred because:
* Code outside //chrome uses similar steps to run extensions, so we
  should share this code in //extensions
* ExtensionService already does too much and is very complex

This CL adds EnableExtension() and DisableExtension() to
ExtensionRegistrar. ExtensionService still does some Chrome-specific
work, but later we'll factor that out into a delegate.

Later CLs will add the other extension lifecycle methods, so eventually
ExtensionRegistrar is the only class allowed to change the
ExtensionRegistry (thus the name). We'll also update calls to
ExtensionService methods to use ExtensionRegistrar directly when it
makes sense.


Design doc: https://goo.gl/trZKep (Google-internal).

Bug: 762642
Test: extensions_unittests: ExtensionRegistrarTest
Change-Id: I2910a76f873122fbc405b7cc76c766b00a8b216f
Reviewed-on: https://chromium-review.googlesource.com/671206
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505206}

Previously the boundary check was incorrect when detecting items
were being deleted from the front of a circular_deque. This caused
it to fall through to the slow case where all items were shifted
over, breaking the promise of amoritized O(1) time.

Since this is an optimization (the existing code was correct, just
slower than necessary), there are no unit tests for this.

Bug: 769812
Change-Id: I8d78be8185741baaca5f2e36413f615102fd68db
Reviewed-on: https://chromium-review.googlesource.com/690976
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505205}

No change to production logic.

Since colors are internally represented as integers for Safe Browsing
tests, they appear in logs as negative numbers, which doesn't obviously
correlate to the RGB values.

This adds a helper method (colorToString) to compare string values
instead of integer values, so that failed asserts are more readable.

Change-Id: Idc075645cf8fd65e4ad4175f2eeef577d69aa1a0
Reviewed-on: https://chromium-review.googlesource.com/685817Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505204}

Bug: 767888
Change-Id: Ib78c85028834b58510ad3f52189afcf0aa9fe30b
Reviewed-on: https://chromium-review.googlesource.com/691074Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505203}

Chrome OS feedback reports often have missing sections, but it is
difficult to understand why because errors in fetching those sections
are logged in the chrome user logs, but those logs may be connected
before the failures occur.  This change forces the chrome user logs
to be collected after all the other logs.
    
BUG=chromium:753398
TEST=enabled feedbacks by adding these gn args:
TEST=is_official_build=true is_chrome_branded=true
TEST=then sent a report, and verified that it arrived with all files.

Change-Id: Ib08c3bfa5b89dd3afd050abaf52bcf231a5ba79d
Reviewed-on: https://chromium-review.googlesource.com/683336
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505202}

Previously this was disabled because a change made immersive mode the
default for windows in tablet mode. This creates an extra widget whose
parent is also default_container(), which messed up some of the indexes
used in this test. This cl allows this test to run in mash again.

Test: WorkspaceLayoutManagerBackdropTest.BackdropForSplitScreenTest
Bug: 764577
Change-Id: Ic36b6252ad543843ab0d71060605674426cf7437
Reviewed-on: https://chromium-review.googlesource.com/688799Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505201}

https://boringssl.googlesource.com/boringssl/+log/42e93b6cf5e0a5c958b6b59cf4842b3dc275561a..e9c7b1c8ae85e5625e9d24d9e20ccedeaaeb0d0a

BUG=none

Change-Id: I9ecae8f64a063214c536dcb150c687db31357d5e
Reviewed-on: https://chromium-review.googlesource.com/690398
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505200}

https://skia.googlesource.com/skia.git/+log/097900648b0b..8b059bd946d9

$ git log 097900648..8b059bd94 --date=short --no-merges --format='%ad %ae %s'
2017-09-28 egdaniel Revert "Update GrBitmapTextureMaker for handling mipped requests"
2017-09-28 geofflang Always read half-float textures as GL_HALF_FLOAT in ES3.
2017-09-28 herb Reorganize blur filter to insert new implementation
2017-09-28 scroggo Avoid uninitialized memory in readByteArrayAsData
2017-09-28 jvanverth Miscellaneous dynamic atlas fixes.
2017-09-28 egdaniel Update GrBitmapTextureMaker for handling mipped requests
2017-09-28 csmartdalton Remove tolerance form SkClassifyCubic
2017-09-28 csmartdalton CCPR: Handle very large paths
2017-09-28 csmartdalton Add svg support to pathfinder tool
2017-09-27 mtklein Move context types into STAGE() macros.
2017-09-28 cblume Remove unused param to SkGIFFrameContext ctor
2017-09-28 brianosman Revert "Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation"""
2017-09-27 mtklein Always zero vectors in start_pipeline().
2017-09-28 benjaminwagner Fix job name in PRESUBMIT.py.
2017-09-28 brianosman Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation""
2017-09-28 mtklein Also mask t itself in mask_2pt_conical_degenerates.

Created with:
  roll-dep src/third_party/skia
BUG=765953


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Idc039c79f9de9af429654c315f8742fb4e1e4013
Reviewed-on: https://chromium-review.googlesource.com/691076Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505199}

This change prepares the display stack to associate multiple touch input
devices with a given display. It updates the display preferences to
persist this associations and calibration data.

Adds and updates tests

This patch now preserves the legacy data for touch calibration. The patch
deprecates the legacy methods while still allowing the system to use any
data that has been stored via the legacy system. This allows devices that
cannot update their touch calibration data to the new model to still
function as expected without any external input.

BUG=599985
COMPONENT=Display, Display Manager, Touch Calibrator, Preference

Change-Id: If9a0af74a35e5ca723c8e6be29518cb1520bb5ef
Reviewed-on: https://chromium-review.googlesource.com/669980Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505198}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=dgozman@chromium.org

Bug: 666525
Change-Id: I280a42f5038e26cefd16f01dc656ba96b7b96828
Reviewed-on: https://chromium-review.googlesource.com/689120Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505197}

Bug: 739713
Change-Id: I394a40bf1044fde1656796efa94af0702ddf808d
Reviewed-on: https://chromium-review.googlesource.com/678730
Commit-Queue: Daria Iakovleva <yakovleva@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505196}

There's only one mode (split desktops). The uninitialized state isn't
needed anymore.  It was added a long time ago as an optimization to
avoid looking up flag values and those flags no longer exist.

Bug: none
Test: unit_tests, browser_tests, manually test teleporting windows between user sessions and verify avatar icons appear in the frames
Change-Id: Icc660ca2af047b39066ae501a5c6dc6a28f7aa8f
Reviewed-on: https://chromium-review.googlesource.com/687986Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505195}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=finnur@chromium.org

Bug: 666525
Change-Id: I465d93e5c5a36a062f536e7981fd0c9d93bc0313
Reviewed-on: https://chromium-review.googlesource.com/689097Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505194}

This makes these swarming tasks easier to search and track.

BUG=769238
R=justincohen@chromium.org,jbudorick@chromium.org

Change-Id: Ib70e13681caf5f4db284d81765547828a11fac41
Reviewed-on: https://chromium-review.googlesource.com/688765Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505193}

Bug: 764224
Change-Id: I7ea1dffdbde10ba03880c6ea88cfd721f30af57d
Reviewed-on: https://chromium-review.googlesource.com/677902Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505192}

An off-by-one error could leave an empty spot for a cell at the end of
each row in a section's grid_. The 14 existing callers of
section->NumCols(row) all had null checks that effectively ignored
empty cells via one of the methods below.

section->OriginatingCellAt(r,c)
section->GridCellAt(r,c).PrimaryCell()
section->GridCellAt(r,c).HasCells()

I suspect the column collapsing code that exposed this is also buggy
but I'll follow that up in a future patch.

Bug: 761192
Change-Id: Ifac74a0189ad50f1bcfc44343fd644d3baa12c44
Reviewed-on: https://chromium-review.googlesource.com/688752Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505191}

This CL adds the logic to download HTTP error response body in content.

Doc: go/chrome-download-non-successful-server-response

Bug: 765778
Change-Id: I367a9678502de8aace3208776b0dcca51e26c764
Reviewed-on: https://chromium-review.googlesource.com/669300Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505190}

This CL omits tests for directories where dependencies aren't checked:
PRESUBMIT test mocks is missing support for FileSourceFilter. This will
be added to test mocks along with the missing tests in a followup CL.

Bug: 763980
Change-Id: Ibf9265911f32d24f446e690d9ec05ddb7a61f198
Reviewed-on: https://chromium-review.googlesource.com/671812Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505189}

Ideally //build/config/features.gni would be empty (or, at least,
would only reference features defined inside of //build).

This CL moves the `enable_nacl` flag out of that file, and into
its own dedicated file, so that it has a much smaller scope and
we can help ensure that it is not referenced or needed by other
projects that are using //build but aren't building Chromium.

This work will be useful as part of the work we're doing to
make NaCl something that can be disabled directly in DEPS
(without needing to depend on GYP_DEFINES to do so).

TBR=bradnelson@chromium.org

R: brettw@chromium.org, bradleynelson@chromium.org, dschuff@chromium.org, phajdan.jr@chromium.org
Bug: 756688
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3af65646803912db67d421d35b4dfe9c2e0b703e
Reviewed-on: https://chromium-review.googlesource.com/688314
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505188}

Bug: None
Change-Id: Ie3cb99fe2ab577e549282ee4076a38ff2ba5472e
Reviewed-on: https://chromium-review.googlesource.com/689959Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505187}

Previous change reverted because it was commited at the same time as
https://chromium-review.googlesource.com/673124 that caused conflict.

TBR=lpz@chromium.org

Bug: 761114
Change-Id: If9031596189dff08fec6ec3f0ef2db82544767ca
Reviewed-on: https://chromium-review.googlesource.com/690596Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505186}

Bug: 761757
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If685f23266acb72202ab46674692685c4dccdc76
Reviewed-on: https://chromium-review.googlesource.com/690015Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505185}

 - Add a method for reading a payload as another NtlmBufferReader
   with a subset range.

BUG=chromium:22532

Change-Id: I6f2f16f88b864fefbc46d93f2eab5aa780ec7506
Reviewed-on: https://chromium-review.googlesource.com/656137
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505184}

This is the first step in moving from using gconf to dconf.

Bug: 768027
Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
Reviewed-on: https://chromium-review.googlesource.com/691097
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505183}

Sometimes it is necessary to delay or skip the processing of certain
files (perhaps because it is still being written). Filtering gives
these options to the call site.

Moving all the "source" parameters into a single structure and passing
that allows for more fields to be added in the future with default
values so they don't have to be specified by callers that don't need
to change them.

Bug: 696721
Change-Id: I3bbfcc3a05ceba9d37e32ae86406599328554b9e
Reviewed-on: https://chromium-review.googlesource.com/678453
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505182}

Suppress failure of
paint/invalidation/video-paint-invalidation.html

This seems likely to be related to the recent change in the main failure
suppression file:
https://chromium-review.googlesource.com/c/chromium/src/+/690624

BUG=729849
TBR=jam@chromium.org

Change-Id: I656f6f318b4b850c21682bfaf52a299e6346dd4f
Reviewed-on: https://chromium-review.googlesource.com/691066Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505181}

Bug: 769872
Change-Id: I035a4726466cca03a7e66c7d4c0562300286881a
Reviewed-on: https://chromium-review.googlesource.com/691015Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505180}

This change sequentially attempts MSE fuzzing for both enabled and
disabled feature media::kMseBufferByPts for the same input.

BUG=718641

Change-Id: Id93677cde3c464b740465e4dfe9cfb202395813f
Reviewed-on: https://chromium-review.googlesource.com/664092Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505179}

This reverts commit 8505818b.

Reason for revert: This CL is causing CookieStoreIOSTest.SameValueDoesNotCallHook to fail on iPhone 7, iOS 11 devices.

Original change's description:
> Convert SystemCookieStore to Async.
> 
> * Converts SystemCookieStore to Async
> * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous
> functions.
> * Move creation time management to systemCookieStore.
> * Update cookie_store_ios_presistent_unittest & 
> cookie_store_ios_unittests to account for SystemCookieStore changes 
> * (As CookieStoreIOS is using systemCookieStore internally).
> 
> Another CL is in progress to add WKSystemCookieStore & unit_tests for 
> systemCookieStore (to handle async methods) with template for both 
> NSHTTP & WK systemCookieStore.
> 
> Bug: 759229, 759227, 767948
> Change-Id: I1c24c82540f4781a0bec77ebfa4a861ca7433391
> Reviewed-on: https://chromium-review.googlesource.com/675804
> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505033}

TBR=mmenke@chromium.org,eugenebut@chromium.org,mrefaat@chromium.org

Change-Id: I43c71a95910d14f4717111a66f0fb0556a91fb8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 759229, 759227, 767948
Reviewed-on: https://chromium-review.googlesource.com/691037Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505178}

No-Try: true
No-Presubmit: true
Bug: 769881
Change-Id: Idde5c87b8e5d49383cb2fa615a072880720228f1
Reviewed-on: https://chromium-review.googlesource.com/691139
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505177}

Enforce a maximum message limit for extensions of a 64MB string (from
the JSON-ified object passed to the API call). We enforce a 128 MB limit
on IPC messages, but even that should be excessively large for our needs.
Also add metrics to see what average messages look like - 64MB is *huge*
(and we have to serialize/deserialize the object multiple times, so
message size can have a pretty big performance impact), so we may be
able to reduce this furter.

Add a test for the new behavior.

Bug: 766713

Change-Id: Ic72b2c6c3ea3ca68a42fcd8061c9e006bc6f1795
Reviewed-on: https://chromium-review.googlesource.com/688674Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505176}

Change-Id: I5e4103cb8b6c5125d1f886da038ebc0fe4a953ff
Reviewed-on: https://chromium-review.googlesource.com/688823Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505175}

https://chromium.googlesource.com/angle/angle.git/+log/1f9d684..db34227

BUG=765953

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I8d37a0c02d9b31b6598b5acdbc296ecfb518dc14
Reviewed-on: https://chromium-review.googlesource.com/690520Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505174}

This was accidentally removed in a previous CL.

Bug: 769571
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I659501f2b184a475b3beea054283d260a73ca4aa
Reviewed-on: https://chromium-review.googlesource.com/689862Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505173}

Finnur is actively working on this with assistance from the
Windows team, so let's not require rubberstamps on trivial CLs.

BUG=

Change-Id: Ifec1874490eb4e368e5e6fcff2298fd995ff6c6f
Reviewed-on: https://chromium-review.googlesource.com/690081Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505172}

TBR=kkhorimoto@chromium.org

Bug: None
Change-Id: I33ea8d591bdbe1ef6add67d2a8a9ef43a5da0ddf
Reviewed-on: https://chromium-review.googlesource.com/691078Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505171}

This CL moves inline UIColors into RemotingTheme.

Bug: 767121
Change-Id: Iffca58686eca9095389f7480b5ebda73e96ea12c
Reviewed-on: https://chromium-review.googlesource.com/688478
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505170}

Bug: None
Change-Id: Ic4fc38a5486083030354ad6f2a7fac219380f3dc
Reviewed-on: https://chromium-review.googlesource.com/687396Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505169}

- Move menu bar locking into ScopedMenuBarLock to get a stronger
  guarantee that the menu bar is left unlocked on exiting fullscreen.

- Use a different test for whether there should be a tracking area.

- Lock and unlock the menu bar from -[FullscreenToolbarMouseTracker
  mouseEntered:] and -mouseExited: directly. Also don't remove the
  tracking area in mouseExited:, this caused a case where the tracking
  area got removed while the menu bar was still visible.

- Remove a couple of unit tests which mostly repeated existing tests but
  also tested assumptions that are no longer valid. It might be good to
  add an interactive UI test in the future, or a unit test for
  FullscreenToolbarMouseTracker.

Background
----------

The menu bar and toolbar would get stuck if you enter fullscreen and
either:

1. Move the mouse to the top of the screen, then move it down over the
   toolbar, then back up to the top of the screen, then down to the
   middle of the screen. Cause: the tracking was incorrectly removed in
   mouseExited:.

2. Move the mouse to the top of the screen, then open a menu, move the
   mouse down to the middle of the screen, and click to close the menu.
   Cause: The menu bar overlaps the window when it drops down. Moving
   the mouse over the menu bar fired mouseExited:, but the old code used
   -mouseInsideTrackingArea, which still returned YES because the mouse
   was technically inside the tracking area even though mouseExited: had
   already fired and wouldn't fire again.

Bug: 762160
Change-Id: Ia15228be8d62e16a66a712f78bd1c8fe62dbef26
Reviewed-on: https://chromium-review.googlesource.com/688414Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505168}

Bug: 764514

Original CL: https://chromium-review.googlesource.com/679619

R=dpranke@chromium.org

Change-Id: I412ac11cbe2c73de9e7b724e2689a97144aad47e
Reviewed-on: https://chromium-review.googlesource.com/688029Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505167}