- 30 Aug, 2019 40 commits
-
-
Ryan Hamilton authored
ProcessAlternativeServices which is used by HttpStreamFactory and SpdySession. Change-Id: I3df00e4ec0bc1b55015e7ba0e1d9af913d7b161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776735 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692161}
-
Jose Dapena Paz authored
blink::TransferableMessage was failing to build, as it had its move operator and assignment operators set as noexcept, but their default implementation depended on mojo::UserActivationSnapshotPtr to have noexcept too. This missed it because its type was mojom::InlinedStructPtr, that was missing noexcept. Bug: 819294 Change-Id: I0aaaf179a9f5240c4706cca5128568df45c0de25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768516Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#692160}
-
Adam Langley authored
This change adds byte (as opposed to std::string) based functions to save callers some copies and casts. Change-Id: Ib3306c6abf14c8ff849009e1752284bc693da44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776793 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#692159}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBCallbacks interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I14aa9ac688dc657b7303b5c04ad50c98e92eda31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774440 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#692158}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee8d9ce83d7c..17016be940ad git log ee8d9ce83d7c..17016be940ad --date=short --no-merges --format='%ad %ae %s' 2019-08-30 maruel@chromium.org README.git-cl.md: Remove reference to Rietveld Created with: gclient setdep -r src/third_party/depot_tools@17016be940ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:770408 Change-Id: Ic3d241d53f363f0df8ec91095f2899a969b31851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692157}
-
rbpotter authored
Autogenerate Polymer 3 version of cr-drawer, as well as tests for the Polymer 3 version. Update the demo page to include a drawer. Bug: 965770 Change-Id: I6df30fdcbe819a94ad1745425619e8df7a5d1b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776610 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#692156}
-
Suzy Li authored
This CL changes the behavior of cancel() as a no-op because the request cannot be cancelled once sent to gmscore since gmscore does not support request cancellation yet. Bug: 999095 Change-Id: I8d6172386191534855ddbd374555c13e088b2561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777050Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#692155}
-
Hector Carmona authored
Bug: 993611 Change-Id: I58a9e4ed71bdbd29663f24942f6e00bfe5068532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764565 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#692154}
-
rbpotter authored
- Autogenerate Polymer 3 version of cr-radio-group - Add to the Polymer 3 demo page - Add an autogenerated JS module version of event tracker, since this is used by cr-radio-group - Autogenerate cr-radio-group v3 automated test. Bug: 965770 Change-Id: I41034878bb76a769da0c10b37fcf8a698a8f421d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775582 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Eric Stevenson authored
This is in our style guide, but not enforced: https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#curly-braces Still allowed: if (someConditional) return false; for (int i = 0; i < 10; ++i) callThing(i); Now prohibited: if (someConditional) return false; Bug: 999554 Change-Id: I58906bace6dd9aa3754cf7a9503d6c8703764a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778809Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#692152}
-
Adam Langley authored
When the WebAuthenticationPhoneSupport feature is enabled, a random key is generated by |AuthenticatorCommon| and fed into the discovery factory and into the UI. This allows caBLE to be used without an extension. Change-Id: I30e07a7dc21ef44a7cb8c6b9d63068faeffab64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776792Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#692151}
-
Yutaka Hirano authored
In the past we wanted to separate IPC stuff from other parts and that's why WebSocketHandle[Impl] was created, but with mojo we don't need the separation. Bug: 977912 Change-Id: I35dd04c17ef4df8e0122ac0490696c255b5c1192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773010 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#692150}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc61f5424733..d70702fad6d1 Created with: gclient setdep -r src-internal@d70702fad6d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I04d11fc1ae812662a41e184bfa1d49b543a472b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692149}
-
Vadym Doroshenko authored
This is the first CL for clean-up the old parser. Bug: 949519 Change-Id: I962a4f7c437fc42b761612de1289e2dec43c17e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768457 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#692148}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 972476 Change-Id: I0c42df15da53b361602e64ae6891ee9c45a9ab9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777448 Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#692147}
-
Andrew Grieve authored
Two fixes: 1) Move static getters to a separate LibraryLoaderConfig.java * Required because of the non-trivial class initializer in LibraryLoader preventing inlining. 2) Change JNI proguard rules to not -keep natives when the linker is not used. TBR=agrieve # Renames Change-Id: I0f4a40af6168cbe7243f462c24d230d277e642ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703155 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#692146}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3865.18-1566209693-benchmark-78.0.3888.0-r1 to 78-3877.0-1566814872-benchmark-78.0.3893.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I0edb8963b3737db6db270b5f17bb27aa19601b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778644Reviewed-by:
-
Sammie Quon authored
DCHECK in OverviewGrid::AddDropTargetForDraggingFromOverview can be hit if long-press two items at the same time with different fingers. One test was flaky on mash. Test: none Bug: 941048 Change-Id: I6a1f1884ecec53714d915cf4a671c621c18d7793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776592 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 552274 Change-Id: Ieaef52c738965861b31fde06ee9b2d5c9a95f967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777120Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#692143}
-
Ahmed Fakhry authored
When a mini_view is removed, it outlives its desk, but ChromeVox may try to get the accessible node data at this point when `desk_` is nullptr. BUG=999595 TEST=Manual Change-Id: I62ebc62f4dee67e03da6fb5d588520451f9e85ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779184Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#692142}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2aa85df8e782..8d7245686774 git log 2aa85df8e782..8d7245686774 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 reed@google.com add bot to test savelayer legacy flag 2019-08-30 csmartdalton@google.com Don't assert mips actually need resolve during texResolveRenderTask Created with: gclient setdep -r src/third_party/skia@8d7245686774 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: If237cd83bc731bdf25904ae6a82b4c4dab6f9352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779089Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/69ffc317eb39..f0033328dd22 git log 69ffc317eb39..f0033328dd22 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 capn@google.com Fix version script renames 2019-08-30 capn@google.com Canonicalize Vulkan ICD library names 2019-08-30 jmadill@chromium.org Support Windows builds and ANGLE integration. Created with: gclient setdep -r src/third_party/swiftshader@f0033328dd22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696,chromium:b/139189696,chromium:b/140251624 Change-Id: I8c76611307a102df7d853c26fbc2b0ec0d6aa86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779081Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14ad3f97..8a1c4425 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If5c5e21b2b1464328fb49fffaa7daeb8581a2a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692139}
-
Natalie Chouinard authored
Because this settings screen has preference changes that occur quickly (but asynchronously) as the fragment loaded, the animations appeared janky. Tracking bug to find a better solution to this class of issues: https://crbug.com/986401 Bug: 995668 Change-Id: Ic2cc2acffc94d67d0b9dffeea5a0e0d6deaff925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776595 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692138}
-
Takashi Toyoshima authored
This patch just fixes a syntax error in the document for developers. Change-Id: Id128a69bde993c93d8550c6d0d45e14c7ebc0481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776150 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#692137}
-
yilkal authored
This CL records the number of frames present in web contents. The records will help us better predict the cost of improving SupervisedUserNavigationThrottle to filter at the iframe level. They will help us predict the following two information: 1. By how much will the requests for the kids management servers to classify urls will increase as a result of iframe filtering. 2. By how much will we delay the overall page load time? Bug: 850328 Change-Id: I38ff0786c9b9c162367ea0513b54f47c80a8b758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752339 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#692136}
-
Jeevan Shikaram authored
This CL adds an optional icon to the settings subpage title. Bug: 979531 Change-Id: Id60b78850e038f2f0576dc1e6871588d8d947759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776151 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692135}
-
Maksim Ivanov authored
Update the Ash UI for the challenge-response authentication (a.k.a. smart card login) according to the newest UI mocks (see https://crbug.com/993788 ) : * The smart card icon and the "Sign in with smart card" label are NOT clickable anymore; * A separate "->" arrow button is added. Tapping it starts the authentication. Implementation-wise, additionally the existing user password input field was wrapped into another wrapper, to allow hiding it WITHOUT continuing to consume the screen space. This was done, as the UI mocks require the challenge-response "->" button to be drawn exactly in the place where the password input field is normally shown. Bug: 983103 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, log in using a SAML account that uses smart card authentication, lock the Chromebook, check that an arrow button, a smart card icon and "Sign in with smart card" appears, click the arrow button, check that the PIN keyboard appears, enter the smart card PIN, check that the user session gets unlocked Change-Id: Ie210d47409e9f8a1fdd44a70ebb2efd37ca1311b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776540 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#692134}
-
Aran Gilman authored
Bug: 982354 Change-Id: Ia10914a769bda850027bd8c5206f477aac2141ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775099Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#692133}
-
Jeremy Roman authored
Bug: 999597 Change-Id: I09d60471bcd5e95f0fed839f7f61e02225ff768e Tbr: csharrison@chromium.org,mmenke@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778575Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#692132}
-
Bryan Clark authored
Swap out the video decoder library needed by libcast_media_1.0_avsync when building for cast desktop. Currently it is a lightweight wrapper around null_video, plus the CastMediaShlib methods that are not implemented by the default avsync lib. Bug: b/139810309 Test: Local Change-Id: I3ee0971efd15ee023a1548005cc68f697033c42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777062Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#692131}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba5eedd3. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" c906513f "[WPT/common/security-features] Rename source context names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If863b0f38b364c4aaf91ab3a5c091ed08ad2052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778662Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692130}
-
Mia Glaese authored
Design here: https://drive.google.com/open?id=1qYxeX6dmNYP-wIV4Sw0btz8hD3PHMcMO Bug: 990600 Change-Id: I54ebd8a186c4f9b729c4425363771b9261209c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744334Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#692129}
-
Andrew Grieve authored
To support parameterized tests, our test runner does not use the default test listing logic, and instead requests that tests be run, and relies on BaseJUnit4ClassRunner to no-op them all when in this mode. This scheme works only if tests actually use BaseJUnit4ClassRunner (or a subclass). The consequence of not using this runner is that the tests will run during test listing. This changes our test runner to enforce that all tests use BaseJUnit4ClassRunner so that we never have tests mistakenly being run during test listing. Bug: 999007 Change-Id: I226fe55b5716c713d47a6027c088ca6774ae0c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777089Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692128}
-
Michael Spang authored
Since 7c48a707 ("Compression of IDR_SECURITY_INTERSTITIAL_HTML and modified compression function.") cast devices fail to boot in a crash loop since CastContentClient::GetDataResourceBytes was removed incorrectly. Add it back. Bug: b/139161866 Test: boot Change-Id: Iaaa5ac6a66823fbe0bc7df0132d56d66f0983712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776725Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692127}
-
Sophie Chang authored
Previously, the ECT was passed back to PreviewsDecider but to allow for slow page prediction to happen in one call and for LPR to leverage that slow page prediction, we need to allow for PreviewsOptimizationGuide to make that justification. Basically, the OptGuide will handle its own slow page prediction checks (initially ECT but to evolve). I will clean up the actual eligibility reasons later and consolidate HOST_*LISTED_BY_SERVER to NOT_ALLOWED_BY_OPTIMIZATION_HINTS Bug: 969558 Change-Id: I532461410f3c92473cce5d3b15fce93fbdab99fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774978 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#692126}
-
Dominik Röttsches authored
Temporarily disable Chinese characters in test1.html printing test until 15s+ subsetting delay when subsetting Microsoft Jhenghei and Microsoft Jhenghei UI is addressed. Preparation for relanding always-on API based fallback. Bug: 996185, 976737 Change-Id: I8f669c118a651a7584615bdcbb60d2686a7a8baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778484 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692125}
-
Patrick Monette authored
This CL gets rid of the "closed" state of SharedWorkerHost. This is done by deleting the host instance when it needs to be terminated. Adds a TestSharedWorkerServiceImpl that allows tests to keep track of running remote shared workers. Change-Id: I4abe3a72f2c208014e0d406f12210da74a3f1971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758981 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#692124}
-
Jun Cai authored
This CL replaces the current infobars if there are existing ones by removing them. Bug: 999222 Change-Id: Id3d84ca24a935c6c3420dfeb8194d0610278a631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775213 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#692123}
-
Andrew Grieve authored
On my machine, this sped up the test listing step by 50% according to the timestamps from bin/run_chrome_public_test_apk_incremental -v. While this is a heuristic, I tested that it finds all tests for chrome_public_test_apk, and if it does ever miss some tests, it won't affect bots, so the error will happen only locally. Change-Id: If227a3b08963d8899839bd6d661f0f392ff1cd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777092Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692122}
-
