- 26 Aug, 2019 13 commits
-
-
Nico Weber authored
The line `os.path.normpath(self.PathJoin(build_dir, f))` had two problems on Windows: 1. Since `build_dir` was something like `//out/Release`, on Windows normpath wouldn't resolve '..' against it, so `//out/Release/../../net/data` would become `\\out\Release\net\data` 2. The slash flipping for `path` made the `path.startswith(build_dir)` always fail. Just remove `path` completely and check if `f` starts with '../../' to find directories that are not in the build dir instead. Also mixing stderr and stdout on Windows produced strange output, so print the error message to stdout instead. The Windows build doesn't have any additional violations, so no new whitelist entries are needed. Bug: 912946 Change-Id: I4db9850103751b4736e5990caddddc9dd223786d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769205Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690259}
-
Leon Han authored
The java object NfcHost is for tracking the Activity for a given WebContents on behalf of NFCImpl (Impl of the NFC interface), previously it's created per-WebContentsImpl, due to navigations happening on the given WebContentsImpl it may end up in a state serving multiple NFCImpls because NFCImpl exists per-Document, which breaks the assumption that one NfcHost can only serve one client otherwise it can not work well with WindowEventObserverManager of the WebContentsImpl. This CL starts to create multiple NfcHosts for navigations on the same WebContentsImpl rather than reusing just one instance of it. BUG=520391 Change-Id: Ice15b70d5df705be0165620579586f1ff597af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747859 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#690258}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d48c288c0553..d5163953610a git log d48c288c0553..d5163953610a --date=short --no-merges --format='%ad %ae %s' 2019-08-26 vapier@chromium.org boolparse_lib: drop unused lib 2019-08-26 vapier@chromium.org replace basestring/unicode with six string/text types 2019-08-26 vapier@chromium.org lint: fix protected-access warnings Created with: gclient setdep -r src/third_party/chromite@d5163953610a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie341081f9006456626b128d0c04d2257e0965838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690257}
-
Julie Jeongeun Kim authored
This CL converts CustomProxyConfigClientPtr and CustomProxyConfigClientRequest to new Mojo types. Bug: 955171, 978694 Change-Id: Id536279553dd930ee68ef5d1642c06d39712cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767291Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#690256}
-
Miyoung Shin authored
This CL converts WebLaunchServiceAssociatedPtr in chrome and WebLaunchServiceAssociatedRequest in blink to the new Mojo types. Bug: 955171, 978694 Change-Id: Ic73752fe3f3525c631d9665cbc7cb967ce8c39ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767446Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#690255}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed485e199407..31f187e5c0d7 git log ed485e199407..31f187e5c0d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org pylint: add myself as an owner Created with: gclient setdep -r src/third_party/depot_tools@31f187e5c0d7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Ibe685b665bc81c611c885f41f3077898e67e3262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690254}
-
Sam Maier authored
Change-Id: I1aea40512deb6d258332b998f2c89cec11f779ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768937 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#690253}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92b33354ddac..27afcf5d12c0 git log 92b33354ddac..27afcf5d12c0 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@27afcf5d12c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ie6d562732de72c3ab6ab67920293f6df06bca6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690252}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/93e8ffa4bf05..d48c288c0553 git log 93e8ffa4bf05..d48c288c0553 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org stop using exceptions module Created with: gclient setdep -r src/third_party/chromite@d48c288c0553 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1787753709ba4a5cf767cb99a95711369474f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690251}
-
Steven Bennetts authored
Bug: 853953 Change-Id: I67129d3d0c68f750b4d907f8d37c8ef052dd9324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758591 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15a8c5705ef5..cee7bf091f42 Created with: gclient setdep -r src-internal@cee7bf091f42 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I278df5cb6e38d4686bcb53ea939456c6ba32b96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770734Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690249}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b4699f36. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I48ebe6703421bb0ce015e3580c0eab2f1e3a5e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770482Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690248}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4016d1b393a1..ed485e199407 git log 4016d1b393a1..ed485e199407 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org pylintrc: disable score reports Created with: gclient setdep -r src/third_party/depot_tools@ed485e199407 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:866772 Change-Id: I50f2dde35f31a1a6182d82a4eb97420636ab2d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690247}
-
- 25 Aug, 2019 27 commits
-
-
Sanket Joshi authored
This reverts commit 27e98258. Reason for revert: One of the added tests is failing MSAN validation (https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN) Original change's description: > Add keyboard based navigation for visual color picker > > This change adds functionality to move the color selection ring > through the color well and hue slider via keyboard input. The user > can press the up/down/right/left arrows to move the ring in the > corresponding direction. The user can also press ctrl+[arrow key] > to perform an accelerated movement. The accelerated movement is > particularly useful for the color well as it takes time to navigate > from one end of the color well to the other with just the standard > keyboard movement. > > Bug: 994437 > Change-Id: Idfef70adf443f8576f83dc9e6c9347a0d320b768 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757159 > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690076} TBR=chrishtr@chromium.org,tkent@chromium.org,masonfreed@chromium.org,sajos@microsoft.com Change-Id: Ic44c8b15bd96270baa86b53a4750083788d1d4b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 994437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770000Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#690246}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75f7b8d20d80..93e8ffa4bf05 git log 75f7b8d20d80..93e8ffa4bf05 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org rework division handling Created with: gclient setdep -r src/third_party/chromite@93e8ffa4bf05 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I37dfaf87e650e0866ceda31b71a5afdd07c69e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690245}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf05e0b2d3f4..15a8c5705ef5 Created with: gclient setdep -r src-internal@15a8c5705ef5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0cae8d2a704029682ed4898763553c81386f0658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770727Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690244}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4f3d482ab708f1ca29677a3c8f22f2105861bdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/765375356dc5..75f7b8d20d80 git log 765375356dc5..75f7b8d20d80 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 vapier@chromium.org use six.reraise Created with: gclient setdep -r src/third_party/chromite@75f7b8d20d80 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I00f69d94b4d97742d740e397a4fe971ee781dbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690242}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/216afbb2995c..cf05e0b2d3f4 Created with: gclient setdep -r src-internal@cf05e0b2d3f4 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iabea5a1b01b0bc6a35562facd6433e1978fdfdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770886Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690241}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/3367690414ae..8e49d0a2b160 git log 3367690414ae..8e49d0a2b160 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 dneto@google.com Remove extra semi-colons (#790) Created with: gclient setdep -r src/third_party/shaderc/src@8e49d0a2b160 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I93b894c799f3ff57d259b9554d6ccb1a6175126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690240}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62d93b5f3261..216afbb2995c Created with: gclient setdep -r src-internal@216afbb2995c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I77927980fbc02e277bac06b8b75df94e5d95a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770723Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690239}
-
Steven Bennetts authored
This CL: * Introduces <network-property-list-mojo> * Uses the mojo element and mojo properties in <network-apnlist> Follow-up CLs will use <network-property-list-mojo> more broadly. Bug: 853953 Change-Id: I25ed760ecb8bfaa88936cbf88271c6c74525f41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758490 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690238}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4cd502d0b1c9523a82f394e8a538db3c947316c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690237}
-
Dominik Röttsches authored
Speculative fix for issue 980094. Ensure that the read protobuf memory has a size and is not a nullptr before trying to have the ProtoBuf library parse it. Bug: 980094 Change-Id: Idaf47884e82eff8c0850a6ec27fc8d452c10e622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768762 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690236}
-
Nico Weber authored
`data` entries that are directories are fine for directories in the source tree, but in the build tree they cause incorrect incremental builds: Consider a build step that copies a bunch of files into the build out dir. At a later revision, it copies fewer files. Incremental bots will still have the now-removed file sitting around, and due to the listed directory, the stale file will be zipped up and sent to swarming. For now, enable this check only on non-cros non-msan linux, on fuchsia, and on iOS. Add temporary whitelist entries for existing violations. (See patch set 17 for how some of them can be removed, but I'd like to land those in separate CLs.) Bug: 912946 Change-Id: Ia01d8e43f0256e3fcae39cb3e1529084d587bb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764392 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#690235}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a02f9aa1faa2..62d93b5f3261 Created with: gclient setdep -r src-internal@62d93b5f3261 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If7db091fc34ba2e9dfad3f3b0d23ec520c4f83f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770784Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690234}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f221fe5e. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I44ae3ab7f80554a8b1b69c56a8978d35ea4d87bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770481Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690233}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4f1cd644aa9..92b33354ddac git log e4f1cd644aa9..92b33354ddac --date=short --no-merges --format='%ad %ae %s' 2019-08-25 reed@google.com more rect api simplifications Created with: gclient setdep -r src/third_party/skia@92b33354ddac The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I2e59a85dcae4e296b2ebdac820b9a1ef046d9f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690232}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f4f153d..40ba72e3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I303095ee1fde2cd1eeb89913a9d38f74e189892f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770480Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690231}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/248746b6017f..a02f9aa1faa2 Created with: gclient setdep -r src-internal@a02f9aa1faa2 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6fde379ab49ebbda1f662fea509bfc9d7aca1f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769668Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690230}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d221a276180a..1191e18ffa29 git log d221a276180a..1191e18ffa29 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 primiano@google.com Revert "Upgrade to protobuf v3.9.0" Created with: gclient setdep -r src/third_party/perfetto@1191e18ffa29 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I1706c35e5a0a5ce8c09a6b10d9c51eff92091f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690229}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2572be1a. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4021511ed6880a02b073087e30d2aa28aa5ad460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770479Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/46129a94cdf7..e4f1cd644aa9 git log 46129a94cdf7..e4f1cd644aa9 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@e4f1cd644aa9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: If53b91647b7171903559c7047cb53a00023085d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690227}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3f85e2672e22d5ac0fa7d62785364b4183962652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770409Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690226}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c7e1b9e2. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8197104dff0cc9501c40c99bbcc4cd7247465858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770478Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690225}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba86c467abe8..248746b6017f Created with: gclient setdep -r src-internal@248746b6017f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I81375fd6c7a89faac4f83686044e02bf98f88b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770078Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690224}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87b57d083321..46129a94cdf7 git log 87b57d083321..46129a94cdf7 --date=short --no-merges --format='%ad %ae %s' 2019-08-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@46129a94cdf7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I31389a2d786aade128c92800eff051fdeaf7ca10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690223}
-
Alexandre Courbot authored
The V4L2 queue can inform us on its actual memory type, so use this instead of making assumptions. Bug: None Test: VDA unittest passes on Minnie. Change-Id: I697545036808645d5bd689529c5b270550885827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768477 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#690222}
-
Victor Costan authored
The type and constants are only used in browser code. Tbr: falken Bug: 965735 Change-Id: I798c2a848d3a9d9bc62cd192a0d6aefe21e5c46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770512Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690221}
-
Alexandre Courbot authored
Requested picture buffers should be about the buffers we will output, i.e. the GL buffers, which are not necessarily the ones used by the decoder (if we use an IP). Fix this mistake in CreateOutputBuffers(). Bug: None Test: VDA unittest passes on Minnie. Change-Id: Icf76f6c96ff54d881783509722193f299f9bff2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768476 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#690220}
-