GitLab

This depends on WebKit patch at https://bugs.webkit.org/show_bug.cgi?id=88406.


BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10542025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141193 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan


Review URL: https://chromiumcodereview.appspot.com/10543075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141191 0039d316-1c4b-4281-b951-d872f2087c98

This was fixed upstream in webkit r119620 so we can remove the
suppression.  Since the bot only runs a subset of the layout tests
each run, it may be a while before I can verify on the bots.

BUG=131351
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10543060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141190 0039d316-1c4b-4281-b951-d872f2087c98

This changes the current overlay so that input is possible (selecting which keyboard shortcut to use). It also suspends current Chrome keyboard handling (Views only), while capturing the shortcut, so that you can press ie. Ctrl-F without Chrome eating your keyboard assignment and instead showing the Find box. 

NOTE: This does not persist the user's choice (future changelist).

BUG=121420
TEST=With a keybinding Extension installed, open chrome://extensions, click on Configure Commands, and notice that the shortcuts are listed in text boxes that are clickable and accept keyboard input.
Review URL: https://chromiumcodereview.appspot.com/10514003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141189 0039d316-1c4b-4281-b951-d872f2087c98

Previously it has been taking a file system name and relative file.
Now the API takes a FileEntry which is much nicer to use, and is
transformed into a file system name and relative file path for the
implementation via a custom binding.

BUG=130452
TEST=The existing automated test has been updated


Review URL: https://chromiumcodereview.appspot.com/10544069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141186 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=unit tests pass.
TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10539045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131505
TEST=unit_tests --gtest_filter="GData*"

Review URL: https://chromiumcodereview.appspot.com/10533042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131295
TEST=manual; successfully copied 3GB file in Chromeos filebrowser


Review URL: https://chromiumcodereview.appspot.com/10536062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141181 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10534055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141180 0039d316-1c4b-4281-b951-d872f2087c98

Instead of magic numbers for the correct total item count in menus, check
for the existence and absence of the items we do and don't want.

BUG=None
TEST=Covered by existing tests


Review URL: https://chromiumcodereview.appspot.com/10539060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141179 0039d316-1c4b-4281-b951-d872f2087c98

Convert path to UTF8 using the file_path routine AsUTF8Unsafe, instead of leaving as-is for all OS's except windows where conversion was UTF16ToUTF8. Using the file_path routine is safer, despite its name.

This will potentially still have some problems on weird POSIX systems, but should be more robust that the previous #if version.

BUG=None
TEST=Covered by existing tests


Review URL: https://chromiumcodereview.appspot.com/10543070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141178 0039d316-1c4b-4281-b951-d872f2087c98

Instead of an explicit "platform_app": true manifest keys, platform apps are now
defined by the presence of the "background" section inside "app" (since platform
apps require background pages). The top-level "background" section is not
supported for platform apps.

R=miket@chromium.org
BUG=131394


Review URL: https://chromiumcodereview.appspot.com/10544059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123160
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10533041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131313
TEST=apply patch from crbug.com/131315, run checkdeps.
TBR=tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10543071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141175 0039d316-1c4b-4281-b951-d872f2087c98

These new assets are from the zip file attached to issue 131658.

Four of those images were renamed for consistency:
  theme_default_active.png => theme_frame_default_active.png
  theme_default_inactive.png => theme_frame_default_inactive.png
  incognito-switch-off.png => incognito_switch_off.png
  incognito-switch-on.png => incognito_switch_on.png

Five of them are new:
  otr_icon.png
  otr_icon_fullscreen.png
  incognito_background.png
  incognito_switch_off.png
  incognito_switch_on.png

In a separate CL I will update the GRD file to point to the first of these (currently it points to the version in touch_100_percent). The other four do not have resource IDs yet and the GRD file will not be updated yet.

TBR=ben@chromium.org
BUG=131658
TEST=Compare old and new images and check that they all look similar to each other

Review URL: https://chromiumcodereview.appspot.com/10546063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141174 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none (probably we should add one)


Review URL: https://chromiumcodereview.appspot.com/10535072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141173 0039d316-1c4b-4281-b951-d872f2087c98

The CL adds to ShellUtil and ShellIntegration and adjusts invocations of the latter whenever necessary.
R=grt@chromium.org, sky@chromium.org
BUG=113326, 129232
TEST=N/A

Review URL: https://chromiumcodereview.appspot.com/10453041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129507
TEST=gmerge passes,manually done


Review URL: https://chromiumcodereview.appspot.com/10537022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141171 0039d316-1c4b-4281-b951-d872f2087c98

I'll add test for this when I add multiple root window support, which should be soon.

BUG=123160
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10545058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141170 0039d316-1c4b-4281-b951-d872f2087c98

Current behavior:

* Windows: Cannot use all browser shortcuts.
* Mac: Can use all browser shortcuts.
* Chrome OS (-M20): Cannot use all browser shortcuts. Can use Ash shortcuts.
* Chrome OS (M21): Cannot use all browser shortcuts. Cannot use Ash shortcuts (crbug.com/130131).

New behavior:

* All platforms: Can use all browser shortcuts. Can also use Ash shortcuts if the platform supports Ash.

BUG=130131
TEST=Confirmed C-n, C-t, C-w, and C-f worked as expected

Review URL: https://chromiumcodereview.appspot.com/10459044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141169 0039d316-1c4b-4281-b951-d872f2087c98

Following https://chromiumcodereview.appspot.com/10310046/
The index for pexpect.TIMEOUT is wrong.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10545055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128954
TEST=No need. This patch doesn't change behavior.


Review URL: https://chromiumcodereview.appspot.com/10534037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141167 0039d316-1c4b-4281-b951-d872f2087c98

Based on the discussion on crbug.com/120499, we'd better to set the "hover"
status to the launcher items when focused.  This CL keeps the dotted rectangle too.

R=zork@chromium.org,davemoore@chromium.org
BUG=120499
TEST=manually verified


Review URL: https://chromiumcodereview.appspot.com/10449077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131026
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10535045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141165 0039d316-1c4b-4281-b951-d872f2087c98

canary users.
BUG=114549

Review URL: https://chromiumcodereview.appspot.com/10541019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141164 0039d316-1c4b-4281-b951-d872f2087c98

We do not yet support the test server in android land.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10537068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10541066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141161 0039d316-1c4b-4281-b951-d872f2087c98

If an active (begin<now<end) promotion arrives after the initial
launch sequence, the promo resource service will notify clients
immediately AND schedule a notification at the end of promotion.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10541054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141158 0039d316-1c4b-4281-b951-d872f2087c98

The TemplateFetcher class is now called TemplateDataSource. TemplateDataSource
works with Handlebar.

The Server now keeps a cache of Instances used to render pages (as suggested in
the previous CL).

Part 2: http://codereview.chromium.org/10500004/

BUG=131095

Review URL: https://chromiumcodereview.appspot.com/10545043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141157 0039d316-1c4b-4281-b951-d872f2087c98

Most of these are disabled in C++ anyway, but this layer of protection was leaky.
It allowed, for example, Window.prototype.find.apply(window, ['string']);

BUG=130835
TEST=PlatformAppBrowserTest.Restrictions

Review URL: https://chromiumcodereview.appspot.com/10545070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141156 0039d316-1c4b-4281-b951-d872f2087c98

Explicitly test bit 30 in the system call number to distinguish between the new x32 API and older Intel APIs.

Also, extend the system call range from 0..512 to 0..1024. This covers the extra system calls added with x32.

As x32 isn't widely available yet, we don't add any other code to support it (e.g. we don't build a version of
demo.cc that runs in x32). But by explicitly blocking it for i386 and x86-64 we ensure that a "default allow"
policy is going to do the right thing.

TEST=make && demo32 && demo64
BUG=130662

Review URL: https://chromiumcodereview.appspot.com/10542028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141155 0039d316-1c4b-4281-b951-d872f2087c98

Re-enable gtalk test. Wait until mole content loads before trying to disable extension. Test was occasionally hitting errors when disabling the extension because it could not get the window.
BUG=128563

Review URL: https://chromiumcodereview.appspot.com/10535022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131270
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10535070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10544050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manuel

Review URL: https://chromiumcodereview.appspot.com/10546066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141150 0039d316-1c4b-4281-b951-d872f2087c98

Removing png that were added by mistake: 2  This was too big to upload with other CL, hence separate CL.

TBR=sky@chromiunm.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10545079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141149 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=none
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/10539058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141148 0039d316-1c4b-4281-b951-d872f2087c98