1. 27 Oct, 2014 40 commits
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 02542c99
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=pkasting@chromium.org
      
      Review URL: https://codereview.chromium.org/680053003
      
      Cr-Commit-Position: refs/heads/master@{#301466}
      02542c99
    • tiago.vignatti's avatar
      ozone: evdev: Handle mouse events · e6e890a7
      tiago.vignatti authored
      This CL renames KeyEventConverterEvdev to EventConverterEvdevImpl, adding mouse
      support there. It adds converter for mouse events that handles move and button
      events. This is useful for simple mouse testing and also systems that don't
      want the complexity of gestures library.
      
      I don't have a multipurpose input device just like described in
      crbug.com/412996, but I believe this benefits the needed changes towards that
      goal as well.
      
      BUG=412996
      TEST=Run chrome target on DRI platform on non-CrOS.
      
      Review URL: https://codereview.chromium.org/677113002
      
      Cr-Commit-Position: refs/heads/master@{#301465}
      e6e890a7
    • Antoine Labour's avatar
      Revert "Don't initialize Ozone platform if running unit tests with OSMesa" · cc39bb88
      Antoine Labour authored
      This reverts commit b1dfa83e.
      
      Broke Linux ChromiumOS Ozone Tests:
      http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/5338/steps/interactive_ui_tests/logs/stdio
      
      TBR=gusfernandez@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/682853002
      
      Cr-Commit-Position: refs/heads/master@{#301464}
      cc39bb88
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 75520f4e
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      Several formatting edits by clang-format were manually reverted, due to
      mangling of some of the more complicate IPC macros.
      
      BUG=417463
      R=jianli@chromium.org
      
      Review URL: https://codereview.chromium.org/684543002
      
      Cr-Commit-Position: refs/heads/master@{#301463}
      75520f4e
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 2dcbdb93
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=wolenetz@chromium.org
      
      Review URL: https://codereview.chromium.org/661163004
      
      Cr-Commit-Position: refs/heads/master@{#301462}
      2dcbdb93
    • scheib's avatar
      Listen to Off The Record profiles in ContentSettingsHandler. · cc12a6ab
      scheib authored
      ContentSettingsHandler is now made aware of Off The Record profiles
      and will observe them as well, correcting bugs where changes from the
      settings webUI would function incorrectly.
      
      This is a rework of a previously landed fix [fix] which was reverted due to
      a crash bug [crash] when OTR profiles already existed before settings
      were opened.
      
      [fix] https://codereview.chromium.org/585953003
      [crash] https://code.google.com/p/chromium/issues/detail?id=417597
      
      BUG=425079, 418931
      
      Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c
      Cr-Commit-Position: refs/heads/master@{#301273}
      
      Review URL: https://codereview.chromium.org/676083003
      
      Cr-Commit-Position: refs/heads/master@{#301461}
      cc12a6ab
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit dbee270:bdffb34 (svn 184467:184473) · 38a057db
      blink-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/chromium/blink/+log/dbee270..bdffb34
      
      TBR=leviw@chromium.org,yurys@chromium.org
      
      Review URL: https://codereview.chromium.org/678083002
      
      Cr-Commit-Position: refs/heads/master@{#301460}
      38a057db
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 10bc1554
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/661033006
      
      Cr-Commit-Position: refs/heads/master@{#301459}
      10bc1554
    • gunsch's avatar
      Chromecast: use variable internal GYP variable consistently. · 5a3959f4
      gunsch authored
      R=lcwu@chromium.org
      BUG=None
      
      Review URL: https://codereview.chromium.org/673883004
      
      Cr-Commit-Position: refs/heads/master@{#301458}
      5a3959f4
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · ff0bb8c4
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=rch@chromium.org
      
      Review URL: https://codereview.chromium.org/678073004
      
      Cr-Commit-Position: refs/heads/master@{#301457}
      ff0bb8c4
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 0a5ed8fe
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=msw@chromium.org
      
      Review URL: https://codereview.chromium.org/680023003
      
      Cr-Commit-Position: refs/heads/master@{#301456}
      0a5ed8fe
    • danakj's avatar
      Revert of Optimize QuadF's PointIsInTriangle function (patchset #3 id:40001 of... · 9ab9844c
      danakj authored
      Revert of Optimize QuadF's PointIsInTriangle function (patchset #3 id:40001 of https://codereview.chromium.org/458173002/)
      
      Reason for revert:
      Caused perf regressions: https://code.google.com/p/chromium/issues/detail?id=404968
      
      Original issue's description:
      > Optimize QuadF's PointIsInTriangle function
      >
      > PointIsInTriangle() is still the hotspot of many CSS animation cases.Take Nexus10 with latest chromium build for example:
      > 4.0%  case: poster-circle.html
      > 1.5%  case: morphing-cubes.html
      >
      > This patch changes the algorithm of testing "Point In Triangle".
      > 1. Using double-precision float point.
      > 2. A much readable algorithm.
      > 3. Better performance due to remove 2 div operation
      >
      > R=danakj@chromium.org
      >
      > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290290
      
      TBR=kui.zheng@arm.com
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/682793003
      
      Cr-Commit-Position: refs/heads/master@{#301455}
      9ab9844c
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 62e71797
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=sievers@chromium.org
      
      Review URL: https://codereview.chromium.org/682743002
      
      Cr-Commit-Position: refs/heads/master@{#301454}
      62e71797
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 578ab408
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=yoz@chromium.org
      
      Review URL: https://codereview.chromium.org/667153007
      
      Cr-Commit-Position: refs/heads/master@{#301453}
      578ab408
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 67be2b1f
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=pauljensen@chromium.org
      
      Review URL: https://codereview.chromium.org/663043004
      
      Cr-Commit-Position: refs/heads/master@{#301452}
      67be2b1f
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · acfeaee6
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=thestig@chromium.org
      
      Review URL: https://codereview.chromium.org/672413003
      
      Cr-Commit-Position: refs/heads/master@{#301451}
      acfeaee6
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · f9afb370
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=jyasskin@chromium.org
      
      Review URL: https://codereview.chromium.org/685503002
      
      Cr-Commit-Position: refs/heads/master@{#301450}
      f9afb370
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 1d5884e1
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=sky@chromium.org
      
      Review URL: https://codereview.chromium.org/679233002
      
      Cr-Commit-Position: refs/heads/master@{#301449}
      1d5884e1
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · b0373167
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=avi@chromium.org
      
      Review URL: https://codereview.chromium.org/678073003
      
      Cr-Commit-Position: refs/heads/master@{#301448}
      b0373167
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · a74e3540
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=avi@chromium.org
      
      Review URL: https://codereview.chromium.org/681873003
      
      Cr-Commit-Position: refs/heads/master@{#301447}
      a74e3540
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · f6ae4499
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/686493002
      
      Cr-Commit-Position: refs/heads/master@{#301446}
      f6ae4499
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 410cbb36
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=ben@chromium.org
      
      Review URL: https://codereview.chromium.org/677563004
      
      Cr-Commit-Position: refs/heads/master@{#301445}
      410cbb36
    • prasadv's avatar
      Make bisect tool check for new V8 roll description, "based on <git-hash>" · 467ac172
      prasadv authored
      BUG=419297
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/676403005
      
      Cr-Commit-Position: refs/heads/master@{#301444}
      467ac172
    • skia-deps-roller's avatar
      Roll src/third_party/skia 13f701a:5f6094a · 36165702
      skia-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/skia/+log/13f701a..5f6094a
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=hcm@google.com
      
      Review URL: https://codereview.chromium.org/679973004
      
      Cr-Commit-Position: refs/heads/master@{#301443}
      36165702
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · a0dee61a
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=avi@chromium.org
      
      Review URL: https://codereview.chromium.org/677413004
      
      Cr-Commit-Position: refs/heads/master@{#301442}
      a0dee61a
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · a9a66b6c
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/681753004
      
      Cr-Commit-Position: refs/heads/master@{#301441}
      a9a66b6c
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 5bdeb6b3
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/684483002
      
      Cr-Commit-Position: refs/heads/master@{#301440}
      5bdeb6b3
    • ananta's avatar
      Ensure that the main window does not render as deactivated when the link... · 5d4c9226
      ananta authored
      Ensure that the main window does not render as deactivated when the link disambiguation bubble is displayed.
      
      This uses the existing framework in the BubbleDelegate to disable inactive rendering in the active
      widget when the bubble is displayed, etc. Inactive rendering is enabled when the bubble is dismissed.
      
      Changes in this patch are to pass the active widget to the LinkDisambiguationPopup class when it is
      created to display the bubble. This class then passes the contents view to the actual bubble.
      
      BUG=421020
      
      Review URL: https://codereview.chromium.org/680643002
      
      Cr-Commit-Position: refs/heads/master@{#301439}
      5d4c9226
    • afakhry's avatar
      Athena AppActivities should open maximized unless they specify otherwise. · 63a5975c
      afakhry authored
      Selecting an app window from the overview mode maximizes the window only if it's maximizable.
      
      A change proposal to fix the below 2 bugs: - crbug.com/424710 - crbug.com/424708
      
      R=oshima@chromium.org
      BUG=424710,424708
      TEST=Manual & athena_unittests @ OnSelectWindow
      
      Review URL: https://codereview.chromium.org/668513003
      
      Cr-Commit-Position: refs/heads/master@{#301438}
      63a5975c
    • xiyuan's avatar
      kiosk: Support update url for enterprise. · 3642e122
      xiyuan authored
      - Bring back kiosk update url in device local account policy;
      - Use the update url from policy to initialize kiosk cache;
      
      BUG=345123
      TEST=KioskEnterpriseTest.PrivateStore
      
      Review URL: https://codereview.chromium.org/676913002
      
      Cr-Commit-Position: refs/heads/master@{#301437}
      3642e122
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit 433f657:dbee270 (svn 184463:184467) · a487ebcd
      blink-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/chromium/blink/+log/433f657..dbee270
      
      TBR=leviw@chromium.org,yurys@chromium.org
      
      Review URL: https://codereview.chromium.org/682723002
      
      Cr-Commit-Position: refs/heads/master@{#301436}
      a487ebcd
    • egdaniel's avatar
      Add skia bindings for VertexAttrib[1f,2fv,3fv]. · b33a8bc8
      egdaniel authored
      BUG=
      
      Review URL: https://codereview.chromium.org/680903002
      
      Cr-Commit-Position: refs/heads/master@{#301435}
      b33a8bc8
    • vmpstr's avatar
      cc: Make picture pile base thread safe. · e1601613
      vmpstr authored
      This patch ensures that picture pile base is thread safe, since it is
      not guaranteed that the ref is always adjusted on the same thread. In
      particular, the worker thread (which refs picture pile on the cc thread)
      might deref it (and delete it) on the worker thread.
      
      R=reveman
      
      Review URL: https://codereview.chromium.org/683543002
      
      Cr-Commit-Position: refs/heads/master@{#301434}
      e1601613
    • reveman's avatar
      cc: Move GpuMemoryBuffer allocation to worker threads. · 2b6d4cba
      reveman authored
      Allocation of GpuMemoryBuffers requires a round-trip to the browser
      process and by moving this to worker threads it is no longer on
      the critical path on the compositor.
      
      The LockForWrite mechanism in the ResourceProvider has been
      adjusted to properly support worker thread allocation of
      resources.
      
      BUG=418553
      
      Review URL: https://codereview.chromium.org/645943002
      
      Cr-Commit-Position: refs/heads/master@{#301433}
      2b6d4cba
    • danakj's avatar
      cc: Always keep the PictureLayerImpl::twin_layer_ pointer valid. · 7b08e286
      danakj authored
      We currently null the twin_layer_ pointer when pushing to the active
      tree and then using hashmap lookups to find the recycled twin, and
      reconnecting the pointers in DoPostCommitInitializationIfNeeded().
      
      Instead, we can leave the pointers always valid and use Getter methods
      that check what tree the twin is on to decide if we should consider it
      a pending twin or a recycle twin.
      
      This means that during commit the pending layer will be able to find
      its active twin when it updates its picture pile, so that it can share
      tiles that are not invalidated. (Previously it wouldn't know about its
      twin until after commit, when we set it up and then did SyncTilings.)
      This allows us to have a more straightforward flow of data, setting up
      the pending tilings when we give it a pile from the main thread
      instead of doing it at some hazy future time (usually inside
      UpdateDrawProperties).
      
      R=enne, vmpstr
      BUG=407418,387116,427213
      
      Committed: https://crrev.com/11f13546fd3ee3d53921c23861bf970bd2bb6428
      Cr-Commit-Position: refs/heads/master@{#301155}
      
      Review URL: https://codereview.chromium.org/676953003
      
      Cr-Commit-Position: refs/heads/master@{#301432}
      7b08e286
    • rogerta's avatar
      Badge icons in windows task bar with avatar icon. · 9e6e5fb1
      rogerta authored
      BUG=412383
      
      Review URL: https://codereview.chromium.org/678553002
      
      Cr-Commit-Position: refs/heads/master@{#301431}
      9e6e5fb1
    • estade's avatar
      Retry dbec51e8: Autofill: Fix recognition of Walmart ZIP code. · f49c1238
      estade authored
      Was reverted due to an in-flight conflict. Now includes update to Macy's test case.
      
      TBR=isherman@chromium.org
      BUG=426958
      
      Review URL: https://codereview.chromium.org/686473002
      
      Cr-Commit-Position: refs/heads/master@{#301430}
      f49c1238
    • estade's avatar
      Autofill heuristics - Add test case for peapod checkout. · af8701e5
      estade authored
      TBR=isherman@chromium.org
      BUG=427603
      
      Review URL: https://codereview.chromium.org/680633004
      
      Cr-Commit-Position: refs/heads/master@{#301429}
      af8701e5
    • morrita's avatar
      ChannelMojo: Replace hand written messsages with mojo. · f8f92dcd
      morrita authored
      This change introduces client_channel.mojom to define
      internal messages for ChannelMojo. Hand-written HelloMessage
      routines are no longer needed.
      
      This is a preparation for coming fix which needs additional
      internal messages.
      
      TEST=ipc_mojo_unittest
      R=viettrungluu@chromium.org
      BUG=377980
      
      Review URL: https://codereview.chromium.org/679453002
      
      Cr-Commit-Position: refs/heads/master@{#301428}
      f8f92dcd
    • gusfernandez's avatar
      Don't initialize Ozone platform if running unit tests with OSMesa · b1dfa83e
      gusfernandez authored
      If Unit tests are compiled with Ozone enabled by default, the
      Ozone platform may be initialized twice leading to CHECK failures.
      
      BUG=427299
      
      Review URL: https://codereview.chromium.org/676043003
      
      Cr-Commit-Position: refs/heads/master@{#301427}
      b1dfa83e