GitLab

In order to allow the tab thumbnails to be up to date when the thumb
strip is visible, the grid's collection view needs to be updated even
when other view controllers are obscuring it. When selecting a new item
from the collection view (blue highlight around the thumbnail), the item
that is currently selected needs to be deselected to prevent multiple
simultaneous selection.

Bug: 1127604
Change-Id: Ice919b9b7c068d381d667b0ac0ad82c41abfed35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426590
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Cr-Commit-Position: refs/heads/master@{#811968}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0d81cd72..f7bee82a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ifc76c8d67b160491a504ea97b925c760ca333774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438635Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811967}

HoldingSpace.Downloads.Action.All
- Records action taken on downloads button in holding space UI.

HoldingSpace.Item.Action.All
- Records action taken by user on items in holding space UI.

HoldingSpace.Item.Action.Copy
HoldingSpace.Item.Action.Drag
HoldingSpace.Item.Action.Launch
HoldingSpace.Item.Action.Pin
HoldingSpace.Item.Action.ShowInFolder
HoldingSpace.Item.Action.Unpin
- Records type of item in holding space UI for which action was taken.

HoldingSpace.Item.Count.All
- Records count of all visible items in holding space UI at launch.

HoldingSpace.Item.Count.Download
HoldingSpace.Item.Count.PinnedFile
HoldingSpace.Item.Count.Screenshot
- Records count of all visible items of a given type in holding space
  UI at launch.

HoldingSpace.Pod.Action.All
- Records action taken on holding space pod in shelf.

Bug: 1131266
Change-Id: Ib91e74b49ce131d718aa768f8eed3d6f31c39122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429978
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811966}

The original CL for this change stored the value of the feature in
VariationIdsProvider. However, the provider lives only in the browser
process. Thus, when the renderer process checks the value of the
feature via the provider in variations_http_headers.cc, the value is
always seen as false.

The fix is to check the FeatureList, which lives in both processes.

I locally reproduced the failure using the failing builders gn args:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/91893?

I confirm that the fix passes with these gn args, too.

This is a reland of b622082c

Original change's description:
> Prevent deadlock by checking kRestrictGoogleWebVisibility sooner.
>
> More specifically, check the feature's state after field trials have
> been created from the variations seed and before the variations
> header is updated.
>
> Checking the state for the first time in
> VariationsIdsProvider::GenerateBase64EncodedProto() could cause a
> deadlock.
>
> Bug: 1094303
> Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556
> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811566}

Bug: 1094303
Change-Id: I7f73c1cb089635d4084b37646307561d235b6a25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436766
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811965}

Support multi-keyword syntax for display but only for MathML.
Specifically "inline math", "math inline" will be parsed and
serialized as "math", and "block math", "math block" will
be serialized as "block math".
Existing support for "inline-math" is removed since instead the
multi-keyword syntax was chosen [1].

[1] https://github.com/w3c/csswg-drafts/issues/5385#issuecomment-690462275

Bug: 6606, 1127222, 995106

Change-Id: Ibc9193dc8a2b09f4463f06c3de31e500ef45b1d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421598
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#811964}

iframeReady promise is needed to be sure that iframe is ready for
incoming messages. Otherwise postMessage to the iframe will be failed.

Bug: b:158566609

Change-Id: I65cdb7fb23bdda49b931500ab12d45eddba2ca65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424318Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Cr-Commit-Position: refs/heads/master@{#811963}

This functions is only used by the SVG layout tree dumper, so move it
there as part of deconstructing SVGPaintServer and related classes.

Make SVGPaintDescription strictly an implement detail now that it's not
exposed.

Bug: 109212
Change-Id: I924603534154de84e0726cb4b9164ad558b0f157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435191Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#811962}

Text field inputs in LayoutNG might not use a subclass of
LayoutTextControlSingleLine. We should avoid operations on it.

LayoutTextControlSingleLineTest doesn't need to use
LayoutTextControlSingleLine, and LayoutBox is enough.

This CL has no behavior changes.

Bug: 1040826
Change-Id: Ica5a0acbf532b5a781b515d0ce9de1c4262abac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437721
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811961}

This adds two new fields to NGPhysicalBoxFragment. The calculated
LayoutOverflow, and the bounds of any inflow children.

LayoutOverflow is placed first in the flexible object as it is accessed
more frequently, and will always be present if there is borders
present.

InflowBounds is placed last as it is only accessed when recalculating
layout-overflow for a fragment.

There should be no behaviour change.

Bug: 1066616
Change-Id: I42a08d28d2c5ac5b93aa36c137868a901a848822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412694
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811960}

TL:DR; install and activate at the version number we use for releases.
See also CL:2435128. Comment only change.

Bug: 1132695
No-try: true
Change-Id: I8974c9aacae9d8e9455f225725d1855a66b1d096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438552Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811959}

On releasing our allocated .memory, reset this.memory back to 0. Minor
closure fix: remove @struct from PixeLoader, since that class does not
have any |this| properties by-design.

Bug: 1132695
No-try: true
Change-Id: Icb2d9f7cf6fcfdb0d89c2dd1c69c89958987fbc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437316
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811958}

Introduce missing battery charge routine to getAvailableRoutines.

Bug: b:162051831
Change-Id: I761175fe72d87d477e9e030696f44e624a6f5d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436738Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Commit-Queue: Laurențiu Olteanu <lolteanu@google.com>
Cr-Commit-Position: refs/heads/master@{#811957}

- In content browser tests, clusterfuzz, and ASAN, crash immediately and
do not attempt to recover/reset.
- In crashes, provide the collected error information as a crash key.

Note: these crash stacks are only now consistently correct as a result
of CL:2432760 which disabled code folding in the fatal error handling.
This will help get to the bottom of our serialization errors.

NOTRY, in order to get past last timed out build due to clogged CQ.

NOTRY: true
Bug: 1094848,1131848
Change-Id: Ie46722a69b21baf3f5e638ffee074ca63a06a639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435810
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811956}

This reverts commit 78399a99.

Reason for revert: Looks like this was not the culprit.

Original change's description:
> Skip VideoCaptureDeviceTest.OpenInvalidDevice on macOS.
>
> Speculative disable these tests since the failure seems similar
> to crbug.com/1069608 on ChromeOS.
>
> Bug: 1129807, 1128470
> Change-Id: I33eb4db810b57ddb46f1c6982ced26b45f59fcb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429263
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810279}

TBR=guidou@chromium.org,mbonadei@chromium.org,handellm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

No-Try: True
Bug: 1129807
Bug: 1128470
Change-Id: I03f1449fb0be73a30d9c0017bb36c75d65d9ec62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431947
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811955}

Before this cl if you wanted a callback to trigger when any of a list of
events happened, you'd have to add multiple interactions. Supporting
multiple events allows for a more compact proto with less duplication
in those cases.

Bug: b/168195199
Change-Id: I5614fc741ab83801a1102e1e4c2b99a4add04e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435639
Commit-Queue: Luca Hunkeler <hluca@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#811954}

Test time reduced from 38143ms to 1521ms.

Bug: 989569
Change-Id: Ibe0b271138bcfcc3095d216d2af91013b412e84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439476
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811953}

Bug: 1132807
Change-Id: I96aebad4dce77d1e9ae5dde8675e79eac83da108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437949
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811952}

- Added a mapping from the url matching conditions
IDs of sources and destinations to Rules IDs so URL
matching will work properly when multiple patterns
are configured in one rule.

Bug: 1132804
Change-Id: Idfb04bbf1887fbbdf14804e48363212a41d215e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435643
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811951}

This removes the code for unmounting the FUSEs (filesystem in userspace)
on suspend. Instead of unmounting to resolve the FUSE/freeze on suspend
race condition, we will be using powerd code that orders freeze using
freezer cgroups.

Crostini still has some work left to do before this can be done for it,
so unmount on suspend for its FUSE, sshfs, will be done in a later
patch.

Test: "suspend_stress_test -c 2500" on device
Bug: b/134792837
Change-Id: Icb8f9e309f6780e6f935be550c6c4e048a44b1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336869
Commit-Queue: Derek Basehore <dbasehore@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#811950}

Bug: 989569
Change-Id: If9f2bf207142253262bca092ca7dad6975893322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437026
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811949}

Roll Chrome Linux PGO profile from chrome-linux-master-1601402113-7fdca9625e1fa7a11789090d4f40670ef10ac97f.profdata to chrome-linux-master-1601423519-160c1675b60a0784f3486044879abd6ac9140863.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: Ia1373c59db738d843c959dc60aed7d3baad46b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438046Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811948}

Same implementation as crrev.com/c/2427524.
Adding another empty text view to load Google Sans that used for FRE buttons.

More context in the original bug.

Bug: 1119990
Change-Id: Ic4820db06b635237ece07d1780d7188aaeb85796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437369
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811947}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I27e07b274a6031b927d0f210fcc493842ed51fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439701Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811946}

The session chooser was previously hardcoded to call /etc/X11/Xsession.
However, it turns out that file is Debian specific, so this change
introduces an Xsession script in the CRD directory and updates the
session chooser to call that. On Debian, this file just delegates to
/etc/X11/Xsession, but it makes it possible to install CRD on other
distros by swapping in an appropriate replacement.

Change-Id: I50c9599c929b1875798ba04043762358024607f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436624
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811945}

Roll Chrome Mac PGO profile from chrome-mac-master-1601402113-90af030cdb9e3c62fe724fde5c9a9eda66c16b0e.profdata to chrome-mac-master-1601423519-0313967a598efe443ce9d62f0d47f5b337e79203.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I66a40d8b21f4ee9d3536f81651b090c3eccb407c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439698Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811944}

Previously, there was only one snapshot cache so the image did
not need to be moved during drag and drop. Recently, there
was a change to have a snapshot cache per browser.

This CL moves the snapshot image from the source cache to the
destination cache when the corresponding WebState is moved.

Bug: 1132306
Change-Id: I30599d17e33f9610adc7d715675bcbf829eadf8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438312
Commit-Queue: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811943}

This CL adds a collection view layout class for creating the tabstrip
viewcontroller.

Bug: 1128249,1130488.
Change-Id: Ie9faa75720fb0da8de3174887af945a4ee945bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421648Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#811942}

SharedContextState could be released before releasing all
WrappedSkImage backings. To avoid this problem, by holding a ref of
SharedContextState.

Bug: None
Change-Id: I2ebe99a18b939f77894ee24049b23d5e0cc6764e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438189
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811941}

UX feedback to add back the label.
However, the functionality seems obscure so adding metrics to gauge
usage.

View: http://screen/6VCZQPfziWwa4kk

Note: Restart now and Restart later in enum has never been used, it was
added due to earlier designs.

Bug: 1113439, 1133061
Change-Id: Ia33cb71b3bd22133faaecec60f80cb302b16f349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437581
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811940}

Roll ChromeOS Orderfiles from 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I081997ef57d966f33509dccb0a7340c358b37246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439703Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811939}

Undo-Close-All is only valid when the tab grid is empty.
This CL disables the undo action when a tab is added.

Bug: 1112759
Change-Id: I41e407068a227fc87b53be12db8f35329cff52a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438233
Commit-Queue: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811938}

Bug: 989569
Change-Id: Iccfbc60f2e3d2c7026c5e310ab94dd2076ea3713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438473
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811937}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We rewrite below tests
fast/scroll-behavior/main-frame-interrupted-scroll.html,
fast/scroll-behavior/overflow-interrupted-scroll.html and
fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
because we cannot guarantee that the scroll arrives before the animation
completes.

TBR=bokan@chromium.org

Bug: 1047176
Change-Id: I59bb34a98326892380d748a2a4691ea4664cad26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438652Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811936}

The empty implementation will be used when the read later feature is
disabled. So we won't hit the actual backend.

TBR=dtrainor@chromium.org

Bug: 1128074
Change-Id: I5c2bed4b2136d758a6c504eabf6a77547650f69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438484
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811935}

This reverts commit c14fae86.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 811926 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2MxNGZhZTg2Y2M0MzIyMDcyN2Q2NzNmYjJjMDRiNDJhZTI4YTI3NTQM

Sample Failed Build: https://ci.chromium.org/b/8867766288975154688

Sample Failed Step: compile

Original change's description:
> [fuchsia][a11y] Refactors convert node ID logic.
> 
> This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID.
> 
> It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID.
> 
> R=yangsharon
> 
> TEST: web_engine_unittests
> Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Sharon Yang <yangsharon@chromium.org>
> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com>
> Cr-Commit-Position: refs/heads/master@{#811926}


Change-Id: Ide2c5fe9720fffc79de88a7b462906a4edc93d2c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439702
Cr-Commit-Position: refs/heads/master@{#811934}

This is a reland of 6a3c229f

Original change's description:
> [CrOS PhoneHub] Add setter functions to various manager classes
>
> The added setters are going to be used by a future Cl that implements
> the PhoneStatusProcessor class.
>
> Bug: 1106937
> Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346
> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810084}

Bug: 1106937
Change-Id: I0278e9221eac360ac6f6000fa1400bf83d0d6437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439014Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811933}

Feedback provided in a different CL (2375597: dpwas: Add
window-controls-overlay as a new display mode |
https://chromium-review.googlesource.com/c/chromium/src/+/2375597)
and in https://github.com/w3c/manifest/pull/932 is that we need a
way to say new display modes are allowed in display_override but
not display.

The plan is to introduce a new enum EnhancedDisplayMode, and
display_override should be:
  sequence<DisplayModeType or EnhancedDisplayModeType>.

To support that, this CL deprecates the existing display_override field,
and renames it. Renaming here should be fine, as long as we don't use
JSON serialization. Once the new field has landed, we will remove
this field, and mark it reserved so that future users don't reuse
the field.

Explainer: https://github.com/WICG/display-override/blob/master/explainer.md
Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing
I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion
Manifest w3c PR: https://github.com/w3c/manifest/pull/932

Bug: 1092667
Change-Id: Ifbc0160a88263d4994d138f99921371ceea2bcb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436417
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811932}

Add virtual tests for default dark mode behavior for images. This will
help check and correct default behavior for images.

Bug: 1116914
Change-Id: Ifcd6db9df15b5616511fdc50125f277071341976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434023Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Cr-Commit-Position: refs/heads/master@{#811931}

This change adds new application classes for Chrome/Monochrome which can
be used with isolated splits to load the logic from the real application
classes from the chrome split in the browser process. In child
processes, only the necessary initialization will be done, and the
chrome split will never be loaded.

Application methods which have logic in ChromeApplication or
MonochromeApplication have been moved an inner implementation class,
which will then be called from the SplitCompatApplication superclass.

Fonts were moved to the base module because they were conflicting with
resources from the elements aar.

Unfortunately, there is an Android bug with how services are loaded from
isolated splits (b/169196314). I'll fix this in a follow up.

Bug: 1126301
Change-Id: Icafe93a8c6fb560315c3022839544faaa0327fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425404
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811930}

Currently, when running the unit test
WorkerMainScriptLoaderTest.ResponseWithFailureThenOnComplete locally,
the result reports all tests passed:

[1/1] WorkerMainScriptLoaderTest.ResponseWithFailureThenOnComplete (12 ms)
SUCCESS: all tests passed.

but actually, there is an error reported:

Actual function call count doesn't match
EXPECT_CALL(*mock_observer, DidReceiveResponse(_, _, _, _, _))
Expected: to be called once
Actual: never called - unsatisfied and active

The root cause is that we must execute a forced GC in order to finalize
objects depending on the mock object before the test finished, and
the test begins to fail consistently after executing a GC in the dtor.
Meanwhile, we should call ResourceLoadObserver's DidReceiveResponsei()
method before stopping loading the main script by WorkerMainScriptLoader.

The WorkerMainScriptLoader class is designed to load the main script
for workers, which is pre-requested in browser process and passed to
renderer process through WorkerMainScriptLoadParams, and when the http
status code indicates a failure, we should notify the
|resource_load_observer_| by invoking its DidReceiveResponse() method,
thus the devtools could be aware of this response.

This patch implements that behavior to make the test runs successfully.

Change-Id: I03f062276abad2253b35ebfa4ed8b4f58eddab4f
Bug: 1132634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433631
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811929}