GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271082 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13168: (mseaborn) Non-SFI NaCl: Enable running more tests with nonsfi_loader
r13169: (dyen) Make toolchain build upload linux 64 bit hosted toolchain.
r13170: (dschuff) Add bot selectors for new PNaCl mac and windows bots
r13171: (dyen) Removed old toolchain management files.
r13172: (mseaborn) PNaCl: Remove unnecessary use of "-Ttext" option when doing bitcode linking
r13173: (petarj) [MIPS] Switch to newer versions of the tools
r13174: (noelallen) Create GROUPS for trusted and untrusted targets to avoid using default toolchain...
r13175: (noelallen) Pin latest bionic version number.
r13176: (jvoung) Remove deprecated NaClDescIoDescMakeFromHandle.
r13177: (jvoung) Add more detailed perf markers to clarify perf of NaCl ELF file load.
r13178: (petarj) [MIPS] Fix incorrect use of assembly macro in the test
r13179: (bradnelson) Use SO_EXCLUSIVEADDRUSE on Windows instead of SO_REUSEADDR.
r13180: (mseaborn) command_tester.py: Don't write output file if the test failed
r13181: (mseaborn) readlink() syscall: Add missing test and fix to work on larger buffer sizes

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/286033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271081 0039d316-1c4b-4281-b951-d872f2087c98

Fix the "gn check" header errors.

Remove the extra "gles2_utils" target which "gn check" flags as an error. This target is actually inseparable from "command_buffer_common" but exists this way to prevent cycles in GYP files (but not GYP targets). GN doesn't have this problem, so I merged them.

Moved the GPU targets out into build files closer to their files (gpu/command_buffer/client and .../common). This leaves a BUILD.gn file in gpu/ with a comment listing the forwarding locations, since that's where people will look for a BUILD.gn file first.

Delete the duplicate gfx_unittests target, leave a comment for where it is in case somebody does a search for that name.

Make webp compile on Windows

Make ui/gfx compile on Windows. There were some duplicate symbols for ozone. I changed some of the filtering around to do += instead of exclusion. I think in these cases it's easier to follow and maintain.

BUG=
R=piman@chromium.org, urvang@google.com

Review URL: https://codereview.chromium.org/288033016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271080 0039d316-1c4b-4281-b951-d872f2087c98

Adds a meta-target "//base/allocator" that forwards to tcmallor or nothing depending on the build configuration.

Write tcmalloc target definition.

Write base unit tests prefs, and some support targets from base.gypi.

Fix a bunch of added files in the base target that were exposed by linking the unit tests.

Removes toolkit_uses_gtk which was removed from the GYP build.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/288203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271079 0039d316-1c4b-4281-b951-d872f2087c98

This adds special handling for variables that begin with underscores, which is inspired by Dart. Such variables are not imported when doing an import, which gives .gni files a way to have intermediate private variables that won't pollute the scopes of the files that include them.

This also applies to the root build config, which can have private values now.

Adds some missing unused variable checks. This was disabled because processing imports would mean all imported variables were unused, and files not using all of them would get unused variable errors. This adds the option to mark merged values on a scope as used, which is used for imported values.

BUG=341738
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/287693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271078 0039d316-1c4b-4281-b951-d872f2087c98

- Window manager provided window borders
- Custom shapes specified via views::Widget::SetShape()

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/289143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371087

Review URL: https://codereview.chromium.org/274453010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271076 0039d316-1c4b-4281-b951-d872f2087c98

Initial sets of fixes for themes to work well with HiDPI Windows. More changes coming in a separate CL.

oshima, Please review everything.
sky : For owners review.

1. Removed the PlatformScaleImage function from the ResourceBundle class and the corresponding
   code to scale images. With automatic scaling support in ImageSkia this is no longer needed.

2. The other change is in the NewTabButton class to use floating point scales everywhere instead
   of converting from scale factor to scale using different functions which causes problems.

BUG=362979
R=oshima,sky

Review URL: https://codereview.chromium.org/283383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271075 0039d316-1c4b-4281-b951-d872f2087c98

This would let us link it to the inspected page in DevTools, as we already
do with other events coming from LTHI.

BUG=361045

Review URL: https://codereview.chromium.org/290083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271074 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/287143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/274573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271071 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271070 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=369680

Review URL: https://codereview.chromium.org/290143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271069 0039d316-1c4b-4281-b951-d872f2087c98

undo https://codereview.chromium.org/288033020

R=mallinath@chromium.org, tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/289003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350233

Review URL: https://codereview.chromium.org/275373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271066 0039d316-1c4b-4281-b951-d872f2087c98

For privacy reasons, we want Domain Reliability uploads to be
cookieless. Add a unit test for this.

BUG=356791

Review URL: https://codereview.chromium.org/290093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271065 0039d316-1c4b-4281-b951-d872f2087c98

Few changes involved:

1) Using TestBookmarkClient to create BookmarkModel.
2) Removes unnecessary TestBrowserThreadBundle
3) With the above changes TestingProfile and BookmarkModelFactory
goes away.

BUG=367834
TEST=components_unittests --gtest_filter=BookmarkModel*
R=blundell@chromium.org, sdefresne@chromium.org

Review URL: https://codereview.chromium.org/291503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271064 0039d316-1c4b-4281-b951-d872f2087c98

Impl side posts callbacks for releasing resources on
SingleThreadProxy::Stop, and there is no reason to have these be real
post tasks.

BUG=344087

Review URL: https://codereview.chromium.org/284233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271063 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271062 0039d316-1c4b-4281-b951-d872f2087c98

Add arm64-specific build rules
https://codereview.chromium.org/290653003

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/288033020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271061 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/290003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374305
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/289163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271059 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271058 0039d316-1c4b-4281-b951-d872f2087c98

that only surfaces when using dynamic CLD.

Dynamic CLD is not currently enabled on any platforms, making
this a no-op on all platforms at present.

For more information, see CLD2 issue 14:
https://code.google.com/p/cld2/issues/detail?id=14

BUG=367239

Review URL: https://codereview.chromium.org/282133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271057 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/266893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271056 0039d316-1c4b-4281-b951-d872f2087c98

Currently, UdpTransport.SendAndReceive hangs forever if the hardcoded port it tries to use is occupied.
This change makes it use a free local port instead.

Review URL: https://codereview.chromium.org/283233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271055 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add instrumentation help figure out why the client ID is sometimes (https://codereview.chromium.org/275213003/)

Reason for revert:
We've collected enough data, so this instrumentation can now go.

Original issue's description:
> Add instrumentation help figure out why the client ID is sometimes
> missing from uploaded crashes.
> 
> BUG=371817
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269715

TBR=rsesek@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371817

Review URL: https://codereview.chromium.org/287173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271054 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True
NOTREECHECKS=True

BUG=373812

Review URL: https://codereview.chromium.org/282383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271053 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/278953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271052 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271051 0039d316-1c4b-4281-b951-d872f2087c98

Includes the deps2git roll to remove special cased ffmpeg setup.

BUG=329002
TEST=gclient sync works
R=mmoss@chromium.org

Review URL: https://codereview.chromium.org/191553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271050 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271049 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=1&start=14757
TBR=
BUG=

Review URL: https://codereview.chromium.org/287063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271048 0039d316-1c4b-4281-b951-d872f2087c98

The underlying rule is now "long" by default.
Mechanical change:
   git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
Relands crrev.com/270750 (reverted by 270849)

BUG=317523
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/288223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271047 0039d316-1c4b-4281-b951-d872f2087c98

This also cleans up the main VLOG in renderer_accessibility_complete so
that it uses the new function in ui to convert an AXEvent to a string,
and removes the NDEBUG since this is quite useful logging in release builds.

Instead of the old switch, use --vmodule="*accessibility*=0" to log
accessibility messages that are normally suppressed, possibly combined
with --enable-logging=stderr to send them right to your terminal and
--log-level=2 to optionally suppress most other log messages.

BUG=350457
R=aboxhall@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/284203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271046 0039d316-1c4b-4281-b951-d872f2087c98

Don't waste space including resources with empty beacons and 0 counters
in uploads.

BUG=356791

Review URL: https://codereview.chromium.org/284283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271045 0039d316-1c4b-4281-b951-d872f2087c98

Make some methods take Node/View* instead of NodeId/ViewId. These
functions needs the Nodes anyway, so no point in converting to id,
then back to node multiple times.

Also remove TODOs that aren't going to happen.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/284113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271044 0039d316-1c4b-4281-b951-d872f2087c98

We'd grown a couple of copies of code to create various test objects.
Deduplicate them into test_util and call them there.

BUG=356791

Review URL: https://codereview.chromium.org/291493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271043 0039d316-1c4b-4281-b951-d872f2087c98

Chrome treats the user ID passed in via chromeos::switches::kLoginUser as
if someone had authenticated against GAIA using this ID. During GAIA
authentication, the user ID is canonicalized. If authentication is
short-circuited using this switch, the user ID should thus be
canonicalized as well.

BUG=367847
TEST=None

TBR=stevenjb (chrome/browser/extensions/api/networking_private/networking_private_apitest.cc)

Review URL: https://codereview.chromium.org/290123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:373548
TEST=the warnings are gone.

Review URL: https://codereview.chromium.org/288903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271041 0039d316-1c4b-4281-b951-d872f2087c98