- 22 Nov, 2018 33 commits
-
-
Wei Lee authored
This CL fix the issue that Camera App don't launch when Play Store ToS dialog is shown. Now GCA will only be launched when it is ready. Otherwise, just fallback to launch CCA. BUG=b/119152926 TEST=Tested by enabling/disabling Google Play Store in Settings App and it works as expectation. Change-Id: I51c0a80a3eb6160429b98d40adaf5c56e28d6b61 Reviewed-on: https://chromium-review.googlesource.com/c/1339089Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610300}
-
Hayato Ito authored
Chromium sheriff. TBR=wez@chromium.org Bug: 907717 Change-Id: Id0a5bb81ed623572e87f19b9229048febdd3ff2c Reviewed-on: https://chromium-review.googlesource.com/c/1347642Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#610299}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I1967c870d9f1f81f7629295a9481da8a2aedc359 Reviewed-on: https://chromium-review.googlesource.com/c/1347314Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#610298}
-
Eric Roman authored
Bug: 907673 Change-Id: I71a9bf1433ca7afce1d7482791e008ed809dc04e Reviewed-on: https://chromium-review.googlesource.com/c/1347771Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#610297}
-
Shu Chen authored
Bug: 907403 Change-Id: Id300fd5dda6024fcb28d488a32dc13d44924b371 Reviewed-on: https://chromium-review.googlesource.com/c/1347637Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610296}
-
Takashi Toyoshima authored
Currently ServiceWorkerBrowserTest.CrossOriginFetchWithSaveData checks if CORS-preflight requests have "Save-Data" header. This is existing behavior, but new CORS stack does not add the "Save-Data" header for the CORS-preflight. In terms of the fetch spec, it will be better not to have the header in the preflight request. Bug: 907389 Change-Id: Ic6906f5a9ce270a403b7be6f48274f78d2fce546 Reviewed-on: https://chromium-review.googlesource.com/c/1345685Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#610295}
-
Jia authored
1. MetricsReporter records daily count of user screen brightness adjustments. It uses local state prefs. 2. This CL also changes the histograms we record: - Previously we record total number of user adjustments, split into those with and without prior model adjustments. - In this CL, we change the reporting so that we record daily counts only. Also, we only record three types of histograms. - Note, we are reusing the enum class, but for different histograms, and the old histograms and its associated enum entry (in enums.xml) are removed. Bug: 881215 Change-Id: I5d5b37af18b1a365f64bd33b61f9f29bbb411962 Reviewed-on: https://chromium-review.googlesource.com/c/1338592 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#610294}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifab9496a837c590c6ca525402d0c24eed4aa0f9c Reviewed-on: https://chromium-review.googlesource.com/c/1347081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610293}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe39a6f342f6..981763ec74fc git log fe39a6f342f6..981763ec74fc --date=short --no-merges --format='%ad %ae %s' 2018-11-21 zoddicus@users.noreply.github.com Ensure correct Addressing and Memory model set for WebGPU (#2093) 2018-11-21 afdx@google.com Initial commit for spirv-reduce. (#2056) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@981763ec74fc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I976c6dea5c97685247a4021e0814939fd5dc3810 Reviewed-on: https://chromium-review.googlesource.com/c/1347517Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5eae1d994e20..e4cccae29941 git log 5eae1d994e20..e4cccae29941 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 benwright@webrtc.org Removed ability to set CryptoOptions through PeerConnectionFactory from bindings. 2018-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 92f8c5b2..5825fead (609994:610108) Created with: gclient setdep -r src/third_party/webrtc@e4cccae29941 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91443a26276d8cd8aaf0e840c59b84cdc17856fd Reviewed-on: https://chromium-review.googlesource.com/c/1347516Reviewed-by:
-
Alexey Baskakov authored
Icon generation and resizing is covered in web_app_icon_generator_unittest.cc. Bug: 901226 Change-Id: Ib6be6e5653792a18ef76daf63df70a81df9b7e3c Reviewed-on: https://chromium-review.googlesource.com/c/1345698Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#610290}
-
iOS Autoroller authored
TBR=smut Change-Id: I4b97610a59ffe4202f75b2673cf8247ed6bcc31c Reviewed-on: https://chromium-review.googlesource.com/c/1347731Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#610289}
-
Aiden Benner authored
To save space in release, instead of using org.chromium.base.natives.GEN_JNI use a short package/class name, J.N. Proguard won't do this for us because we can't obfuscate any class that contains native methods. Bug: 898261 Change-Id: I84ad6914912b5b0e0d390d53a88dbcf41633edbf Reviewed-on: https://chromium-review.googlesource.com/c/1347034Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610288}
-
Abhishek Arya authored
strip_path_prefix is needed for Predator to work on ClusterFuzz. R=ochang@chromium.org CC=metzman@chromium.org Change-Id: Ib800a54c5f95176ef4acd292f935d6405529cf8f Reviewed-on: https://chromium-review.googlesource.com/c/1345570Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610287}
-
Weidong Guo authored
Changes: If the first available position for the newly installed app does not exist when we are inserting between an app and a page break item with the same position, we use the next available position. Bug: 907637 Test: AppListSyncableServiceTest.InvalidFirstAvailablePosition Change-Id: I8f1a7abad58ea838b452ac8a270c4a030df57a1e Reviewed-on: https://chromium-review.googlesource.com/c/1347208 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
Jazz Xu authored
Change-Id: I26e660eb8146a9f4aa856ba2f972b715ca25ce3a Reviewed-on: https://chromium-review.googlesource.com/c/1347572 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610285}
-
Nico Weber authored
The string is used to replace things in a json-encoded string, so it needs to be json-encoded. TBR=hans Bug: 899438 Change-Id: Iababe77ed7f8c2dafd0d0443f28f480082bc72d0 Reviewed-on: https://chromium-review.googlesource.com/c/1347312Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610284}
-
Alex Danilo authored
Context menu 'New Folder' selection was causing the menu to jump up and down (easier seen on captured video on the bug). This was caused by a 'change' event fired that updated the state of the context menu tasks-separator bar to visible despite there being no items above it (which in turn, makes the menu taller temporarily). That happened mid-animation of the menu and the bar is reset to hidden after more event processing. Removing the fake data that was passed into the updateContextMenuTaskItems_() method stops it happening. offending code to visually check fix works. Ran test on desktop and real device to confirm. Bug: 698176 Test: Ran all FilesApp browser tests. Single-stepped through the Change-Id: Icd7a2c41ad85bf93e30fe90632d83a8890b294bf Reviewed-on: https://chromium-review.googlesource.com/c/1347631Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#610283}
-
Sam McNally authored
File changes (e.g. file creation) within the current directory would trigger a rescan. This causes file changes to disable "New folder". This causes flickering of the new folder menu item and button for multi-file operations in the current directory. Avoid this by allowing new folder while scanning. Bug: 618002 Change-Id: I5943deeb0186ab425824eeb70ed69414e702da42 Reviewed-on: https://chromium-review.googlesource.com/c/1347633Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610282}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie237b994b8e871b1d3b6a999341847ad975a25a9 Reviewed-on: https://chromium-review.googlesource.com/c/1343581Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#610281}
-
Jakob Gruber authored
This moves logic to handle LSAN leak warnings into ~BlinkFuzzerTestSupport. Two related call sites are updated. Bug: chromium:906425 Change-Id: I2b7c6d5145e67a3d9d919e5f17e51a28eacee7bc Reviewed-on: https://chromium-review.googlesource.com/c/1341522Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610280}
-
Robert Ogden authored
Bug: 907665 Change-Id: I07737f4e4dee8c28741dc63016eb376604c21723 Reviewed-on: https://chromium-review.googlesource.com/c/1346996Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Eric Roman authored
The previous implementation was effectively: getaddrinfo(gethostname()) The new approach uses a similar strategy to Firefox, by first prioritizing the default local address used for connecting to the internet, followed by various fallbacks including testing routes to private IPs. This also deletes the ChromeOS specific implementation, as the generic one addresses the original problem it was fixing. Bug: 735637, 827533 Change-Id: I31a5d1a58af48398afad787aefc1edd6cc4510ac Reviewed-on: https://chromium-review.googlesource.com/c/1336063 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610278}
-
Joel Hockey authored
Check #gear-menu select-all for disabled rather than hidden. Change messages to make exact point of failure clear. Change-Id: Ie114bdcba79ca0b939d0ea54865961ea1a39b7cd Reviewed-on: https://chromium-review.googlesource.com/c/1347632 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610277}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: Ic3c52165f48b66c4c5fe7047d3f909ea1ab53464 Reviewed-on: https://chromium-review.googlesource.com/c/1344061 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610276}
-
Stuart Langley authored
Replace the exiting data that was being recorded using GA with UMA for long hash calculate and search by hash results. GA was disabled some time back so this data has not been being recorded for some time. We'll switch to UMA for the time being and then make a decision on either keeping or removing these metrics altogether at a later date. Bug: 847729 Change-Id: I6b2fac50a3275b1cd3684ef3b438f26d147ea64c Reviewed-on: https://chromium-review.googlesource.com/c/1341434 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#610275}
-
Noel Gordon authored
Closure JS compiler type annotations for this unit test were added in CL:1345690: enable them and auto-generate the unit test code. Remove import_history_unittest.html - make file_manager_jstest.cc auto-generate the unit test code BUILD file: enable Closure compiler - update js_library(import_history) deps for Closure compiler - add js_unittest(import_history_unittest) auto-generate rule import_history_unittest.js: remove unused Drive sync leftovers - Drive sync moved to its own unittest rule in the past so ... - chrome.fileManagerPrivate.onFileTransfersUpdated > /dev/null - chrome.syncFileSystem, TestSyncFileEntryProvider > /dev/null Bug: 905934 Change-Id: I16b93e755c3a4a00378b426616cf030afc6a325f Reviewed-on: https://chromium-review.googlesource.com/c/1346430Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Roger Tawa authored
Bug: 907614 Change-Id: Ic8383f2e9d04a202296ff3e25fb64e7093d7818f Reviewed-on: https://chromium-review.googlesource.com/c/1347582Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#610273}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: If80e780ce6f0b976be03ced6af121dd47ebd4a34 Reviewed-on: https://chromium-review.googlesource.com/c/1347789Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#610272}
-
Max Moroz authored
Bug: 906129, 870331 Change-Id: I19b7ceb187cfd1e6a28a808005606311bc4c96cc Reviewed-on: https://chromium-review.googlesource.com/c/1347691 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d69ae20edf94..aa21a922d4a8 git log d69ae20edf94..aa21a922d4a8 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 eroman@chromium.org Use ts_proxy_server on Chrome OS (remote) the same as on other platforms. 2018-11-21 lwsong@google.com Show hover text for transparent values and fixed hide Y Axis 2018-11-21 kris.selden@gmail.com Fix crashes on performance.measure name parsing. 2018-11-21 cbruni@chromium.org [pinpoint] Show bot, benchmark and story if no job title is provided Created with: gclient setdep -r src/third_party/catapult@aa21a922d4a8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:652385 TBR=sullivan@chromium.org Change-Id: I69efa2ee8a2fc49535873d7eb0cb427e31e5d6cb Reviewed-on: https://chromium-review.googlesource.com/c/1347522Reviewed-by:
-
Maksim Ivanov authored
Add unit tests for the DiagnosticsdBridge class - specifically, for the Mojo bootstrapping via a D-Bus call and the related retry logic. BUG=chromium:869377 TEST=unit_tests --gtest_filter=DiagnosticsdBridge* Change-Id: I4979bacef872bbbd250e5778df1a85707520768a Reviewed-on: https://chromium-review.googlesource.com/c/1337613 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610269}
-
Sergey Ulanov authored
GetScanoutFormats() isn't used anywhere, so it can be removed. Change-Id: I7ae437f4800df649d727e18e3810aa5e890dcf44 Reviewed-on: https://chromium-review.googlesource.com/c/1347590Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610268}
-
- 21 Nov, 2018 7 commits
-
-
Katie Dillon authored
This test has workers sending different realistic payloads back and forth from the parent context to the worker. Change-Id: I656df3737d037593c9ce54d2739b58cebcde198b Reviewed-on: https://chromium-review.googlesource.com/c/1323559Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
-
Aiden Benner authored
- Move golden/javap files to jni_generator/golden/ - Make method capitalization more consistent with jni_generator py files - Split proxy native tests to a different test suite - Decouple utility functions from TestGenerator into a base test class - Fix bug where tests would fail if ran from a different directory - Adds tests for enable/disable/require mock flags Bug: 898261 Change-Id: Ieae930c73539b00653dfcf32c89d9a79a3ceecf6 Reviewed-on: https://chromium-review.googlesource.com/c/1345239 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
-
Alice Boxhall authored
Bug: 906310 Change-Id: I62438e397d3551c7cc0787df4ff5faa985fb3f56 Reviewed-on: https://chromium-review.googlesource.com/c/1345714 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#610265}
-
Ken Buchanan authored
This is a speculative fix to flakiness on SitePerProcessBrowserTest.CrossProcessInertSubframe, yielding the UI thread after navigation but before sending the script to test for inertness. This should ensure the inertness bit propagates to the new frame before the script is sent for execution. Bug: 792477 Change-Id: Iee370a863003045399730ba4a49831051d20316c Reviewed-on: https://chromium-review.googlesource.com/c/1347617Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610264}
-
Aiden Benner authored
Adds the REQUIRE_MOCKS flag to GEN_JNI. If both the REQUIRE_MOCKS and TESTING_ENABLED flags are set, calls to native implementations must have had a mock instance set first through TEST_HOOKS, otherwise an UnsupportedOperationException will be thrown. If only TESTING_ENABLED is set, calls to the native implementation will use a test mock if it is provided, and otherwise fallback to the native implementation. This is used for instrumentation tests that may want to mock out some native implementations but not all. In the annotation processor version of GEN_JNI both these flags are mutable and so they can be set by a JNI test rule for unit tests. Instrumentation tests that want to mock a native implementation can pass flags to JNI registration generator to set the corresponding GEN_JNI flags. Bug: 898261 Change-Id: I6a90e91a29368df692d458f35c9ea92f8898064b Reviewed-on: https://chromium-review.googlesource.com/c/1344554 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
-
Alexei Svitkine authored
On a recent review [1], I wasn't happy with the exact comment that was being used and requested changes, but turns out the author had used the sample comment we have in the header file. Update that comment to improve it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1337297 Bug: None Change-Id: I49bc65b64824839a5ffe112a6e1bc5ae6447e75e Reviewed-on: https://chromium-review.googlesource.com/c/1346732Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610262}
-
Stephen McGruer authored
Upstream, the spec has changed to remove 'auto' as a value for ScrollDirection. TBR=majidvp@chromium.org Bug: None Change-Id: I5fa47e0f31c5229b5d734dc39d0717973936543e Reviewed-on: https://chromium-review.googlesource.com/c/1347033Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610261}
-
