- 20 Aug, 2018 40 commits
-
-
Justin Cohen authored
Bug: 843244 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie47a226f37869f26b99b35f6cb2fedb194f53ae1 Reviewed-on: https://chromium-review.googlesource.com/1181461Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584527}
-
Balazs Engedy authored
Also, fix the plumbing of |rp_id| out of FidoRequestHandlers into TransportAvailabilityInfo, and add unittests to verify correctness. Bug: 866601, 849323 Change-Id: I0e8c1250208c52306501fab7b9c55a2b1a34bbd1 Reviewed-on: https://chromium-review.googlesource.com/1181265 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584526}
-
Maks Orlovich authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I719e604e78dcbd9e20e9569e99f3255684f368e9 Reviewed-on: https://chromium-review.googlesource.com/1172924 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Francois Doray authored
The comment for the existing thread priority test suggested that it verified that the priority of a thread could be toggled multiple times, but that wasn't the case. The new test verifies that every possible priority transition works as expected on a single thread. Bug: 872820 Change-Id: I04efe8c50579553962f0d99a5e8e87a54fe268a3 Reviewed-on: https://chromium-review.googlesource.com/1171187 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#584524}
-
Jérôme Lebel authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia43213fbfd037e2b055143401381637c199e68d8 Reviewed-on: https://chromium-review.googlesource.com/1181129 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#584523}
-
Oksana Zhuravlova authored
Bug: 861902 Change-Id: If47deffcc898d0d1faac8c75c76660815cb91b6b Reviewed-on: https://chromium-review.googlesource.com/1180093Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#584522}
-
Min Chen authored
The size of dragging window used to be different depending on how dragging started. It was bigger when you drag from the top compared to when you drag from overview items. This CL consolidate two into the same size, to the size used when dragged from overview items. see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiNThBNU1sbVRTRUgyZmRUNUpxdVI2WVRsSHBj/view?usp=sharing Bug: 872528 Change-Id: I778fdb871556ec960b4d8fdffd1f608c19a01148 Reviewed-on: https://chromium-review.googlesource.com/1173158Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#584521}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/ca37ab7fb9b7..ea660b57d65d $ git log ca37ab7fb..ea660b57d --date=short --no-merges --format='%ad %ae %s' 2018-08-17 costan Fix unused private field warning in NDEBUG builds. 2018-08-16 costan C++11 guarantees <cstddef> and <cstdint>. 2018-08-16 costan Remove GCC on OSX from the Travis CI matrix. 2018-08-09 costan Move pshufb_fill_patterns from snappy-internal.h to snappy.cc. 2018-08-08 costan Fix Visual Studio build. 2018-08-07 jefflim Improve performance of zippy decompression to IOVecs by up to almost 50% 2018-08-06 costan Update Travis CI configuration. 2018-03-27 atdt Test for SSE3 suppport before using pshufb. 2018-03-26 atdt Avoid store-forwarding stalls in Zippy's IncrementalCopy 2018-03-09 costan Update CI configurations. Created with: roll-dep src/third_party/snappy/src Change-Id: Ia9acb557d876d0e9c5298c13cfdb05cc80d26233 Reviewed-on: https://chromium-review.googlesource.com/1170351Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584520}
-
Xiyuan Xia authored
Gesture recognizer handles touches in two phases: event pre-dispatch and post-dispatch. Closing MenuHost during dispatching skips the post-dispatch phase because target (MenuHost) is destroyed. As a result, the touch is never acked and gesture recognizer stops generating any further gestures. The above problem could be resolved either by asynchronously closing the menu, or manually ack the touch event. The next problem is that MenuController could not mark the touch event as handled. Otherwise, gesture recognizer cancels the current sequence without GESTURE_END event and breaks the owner's expectation. If MenuController does not mark the touch as handled, gesture recognizer would then translate the 2nd touch pressed into a two-finger tap and causing the menu to flash because it is shown again. Given all that, a reasonable fix would be make MenuController to skip touch events handling when the owner wants the current gesture sequence. The problems would not happen if MenuHost is not closed in middle of touch events dispatching. Side effect is that menu is no longer closed on the 2nd figure down and could only be closed after all figures are lifted, which is probably okay. Bug: 874215 Test: MenuControllerTest.NoTouchCloseWhenSendingGesturesToOwner Change-Id: I1818b6c35c80006c999f96ddbea38fd1f79948c3 Reviewed-on: https://chromium-review.googlesource.com/1179250Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584519}
-
Cole Winstanley authored
This change adds the end-to-end tests for the client replay component of ChromeDriver to the ChromeDriver waterfall by incorporating them into the existing run_all_tests.py. This will extend the waterfall coverage to include the ChromeDriver log-replay component. Bug: chromedriver:2501 Change-Id: I6e35675d2598a2a33c67340e0ee73e05201c3439 Reviewed-on: https://chromium-review.googlesource.com/1174894 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584518}
-
Mike Dougherty authored
Bug: 875620 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3ae27d80eb08915ae57a83d3c50b14cf4551874b Reviewed-on: https://chromium-review.googlesource.com/1181687Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584517}
-
edchin authored
Previously, the empty state was showing for a split second, then animating off. If there are items in the grid, the empty state should just not show, rather than animating off. Bug: 870267 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6de30daaf0fb7ee5b1fe0ffe3f2da78ac95c7a83 Reviewed-on: https://chromium-review.googlesource.com/1176647 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584516}
-
Henrique Nakashima authored
Add or remove pages from the viewer in response to these events. Bug: pdfium:401,chromium:872903,chromium:867135 Change-Id: Iddc88c5a90370213619a0f3f2587f215d0dafbc8 Reviewed-on: https://chromium-review.googlesource.com/1169691 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584515}
-
Peter Wen authored
- instantapps to 16.0.0 - cast and cast-framework to 16.0.1 See https://developers.google.com/android/guides/releases +39,376 bytes normalized apk size These are not shipped in downstream Binary-Size: GMS Core library upgrade Bug: 869935 Change-Id: I3df519347455dd79ba99ddec8dbc9e5adb183816 Reviewed-on: https://chromium-review.googlesource.com/1181180Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584514}
-
Scott Haseley authored
This CL cleans up a few items in FrameSchedulerImpl from migrating to frame-level scheduling and using FrameTaskQueueController: 1) Rename variables methods to reflect the possibility of multiple throttleable task queues. 2) Separate updating throttling state from updating throttleable task queues (to remove second iteration over task queues). 3) Call UpdateQueuePolicy for newly created task queues which will set voter enabled (including frozen) and task queue priority. 4) Fix ref count churn in UpdateQueuePolicy(). Also, a few misc cleanup items: 1) Fix typo in components/scheduling_metrics/OWNERS 2) Remove a file from BUILD that no longer exists. Bug: 859963 Change-Id: Ia10613f92f1a91abb463f560ead1cbb5e91971d7 Reviewed-on: https://chromium-review.googlesource.com/1178964 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584513}
-
apacible authored
This reverts commit b6219921. Reason for revert: memory.leak_detection failing on chromium.linux/Leak Detection Linux Builders failed on: - Leak Detection Linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux Original change's description: > Introduce sharding in memory.leak_detection > > This CL expands the page_set of memory.leak_detection to 200 and introduces sharding. > > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: I6d562fcc80df8089887236363c7d5b0fdf2b879e > Reviewed-on: https://chromium-review.googlesource.com/1180788 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#584476} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,yuzus@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Ie42a59433e4d133b5cc467cafd694224bd114391 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Reviewed-on: https://chromium-review.googlesource.com/1181961Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584512}
-
Jennifer Apacible authored
NOTRY=true (disabling test) TBR: lfg@chromium.org Bug: 875908 Change-Id: I39e833a40ecf50884088cb5de84a9921bec0c06a Reviewed-on: https://chromium-review.googlesource.com/1181775Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e8964a2cd375..ba76717a8d18 git log e8964a2cd375..ba76717a8d18 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 simonhatch@chromium.org Dashboard - Push HistogramSet processing into the backend 2018-08-20 wangge@google.com Add Retry if We Cannot Get Battery Info 2018-08-20 vollick@chromium.org Update branch parsing Created with: gclient setdep -r src/third_party/catapult@ba76717a8d18 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:874856,chromium:871748 TBR=sullivan@chromium.org Change-Id: I3b691c48ea47b72c0b284a1bbd855817c07f2e50 Reviewed-on: https://chromium-review.googlesource.com/1181541Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584510}
-
Dan Harrington authored
Shows thumbnails on the net error page, but UI in this CL is a placeholder. Bug: 852872 Change-Id: I4710058e835318fca3f84eb52752c261ba2fcc36 Reviewed-on: https://chromium-review.googlesource.com/1157265Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#584509}
-
Tom Finegan authored
Spec: https://aomediacodec.github.io/av1-isobmff/ BUG=875499 Change-Id: I97a966acd0eb40dd10ff3f154ca396e8e7b2ab6e Reviewed-on: https://chromium-review.googlesource.com/1180244 Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584508}
-
Steven Bennetts authored
I discovered this class while looking at keyboard::KeyboardUI. It has the comment: // KeyboardUI wraps the appropriate keyboard ui depending upon whether // ash is running in mus or non-mus. KeyboardUIMash is unused, and there is no longer mus/mash differentiation, so the class seems unnecessary. It is also super confusing since there is also keyboard::KeyboardUI which is effectively unrelated. It's functionality can easily be directly integrated with the callers. Bug: 843332 Change-Id: Ib082a0f6f9bede2cef766c006e003dbe512be561 Reviewed-on: https://chromium-review.googlesource.com/1180255 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584507}
-
Cathy Li authored
Bug: 875397 Change-Id: I81cb4f819916dfd0dfd6e3e6e51e7293a7d62951 Reviewed-on: https://chromium-review.googlesource.com/1180618Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#584506}
-
Scott Violet authored
This ensures the right Env is obtained. BUG=847992 TEST=none Change-Id: I5119cc7187c27fc6b5a38911777c974f12e3c093 Reviewed-on: https://chromium-review.googlesource.com/1181536Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584505}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c42e01cedb9..8d744124a6f8 git log 7c42e01cedb9..8d744124a6f8 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 kjlubick@google.com Fix upload_dm_results Created with: gclient setdep -r src/third_party/skia@8d744124a6f8 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Iee11bd8910894fbbfb739eae9807fc545048355e Reviewed-on: https://chromium-review.googlesource.com/1181542Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584504}
-
Sammie Quon authored
The spec is here: https://mccanny.users.x20web.corp.google.com/www/wm-motion/index.html#project-homecher-transition. This cl adds the overview slide in/out part of the spec. The launcher window animations will be added in a later cl. On entering overview, check if home launcher is enabled and if all windows are minimized, then slide overview in, otherwise use normal transition. On exit overview, check if home launcher is enabled and if all windows are minimized, then slide overview out, otherwise use normal transition. If home launcher button is explicitly pressed while in overview, minimized all windows without animation and create mirror windows for them in overview, then slide those out. We could also slide the original windows on exit, but then we would have to worry about minimizing after animation and other stuff, so I think this way is simpler. Test: manual Bug: 873394 Change-Id: I1deaa58334ce41c28907af60c137ebc2d147c3c9 Reviewed-on: https://chromium-review.googlesource.com/1176346 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#584503}
-
Arthur Sonzogni authored
The browser process is the sole responsible for shutting down its renderer processes. Surprisingly, there was some logic in the renderer process to request self shutdown. There were race conditions. For instance: 1) The renderer process requests to shutdown itself. 2) The browser process accepts the request, but don't update any of its internal state. 3) The browser process reuse that process. 4) The renderer process shutdown itself. The CL removes the capability for a renderer process to shutdown itself. This CL is part of https://crbug.com/609963. This CL may also fix bug https://crbug.com/873541. Bug: 873541, 609963, 535246 Change-Id: Idd498497acc6106fe8c87e994239bbde9b3453c3 Reviewed-on: https://chromium-review.googlesource.com/1174713 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#584502}
-
Maciej Pawlowski authored
mojo::core::Init() should be called once per process, not once per test. run_all_unittests.cc happens to already define a test launcher that calls mojo::core::Init(), so if we use that instead of the base launcher, we can get rid of re-initialization in test fixtures. Bug: 869281 Change-Id: Ieb96cbe580f5f1750d7f61693c288bb578cb63b0 Reviewed-on: https://chromium-review.googlesource.com/1155595 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#584501}
-
Eric Orth authored
Adding include_canonical_name and loopback_only to the optional parameters struct. These will be equivalent to HOST_RESOLVER_CANONNAME and HOST_RESOLVER_LOOPBACK_ONLY from the old API. And at least for now, they'll be implemented by converting to the old flags for simple compatibility with the current implementation of HostCache::Key. Added canonical name support to the mojo AddressList as it was missing. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7ff288f05d6a13e1c6c3c293d9f7a1064f011380 Reviewed-on: https://chromium-review.googlesource.com/1179996 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584500}
-
Ben Kelly authored
This implements step 4.2.3 of the BatchCacheOperations algorithm: https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm Its currently behind the experimental web features flag until web compatibility can be assessed. Bug: 720919 Change-Id: Id35b6f45ab4c02b9e2225d740a257ea5a4fe6739 Reviewed-on: https://chromium-review.googlesource.com/1179943 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584499}
-
Ryan Hansberry authored
These strings were incorrectly changed in https://chromium-review.googlesource.com/c/chromium/src/+/1112742. Bug: 872982 Change-Id: Ic05ddce4d00ea20b7a6ef5bbef3a01c70766bf48 Reviewed-on: https://chromium-review.googlesource.com/1180477Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#584498}
-
Becca Hughes authored
As part of s18n we should move AudioFocusType to the Media Session service and make it a mojo enum. BUG=870418 Change-Id: I838419b3759c5eae14a44ad639035ecac81dd04e Reviewed-on: https://chromium-review.googlesource.com/1180178 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Christian Biesinger authored
This code previously skipped NG layout objects for performance reasons (https://codereview.chromium.org/2666663002 and https://chromium-review.googlesource.com/1073408). However, we do need to prelayout orthogonal roots if their containing block is legacy so that we can correctly compute the intrinsic widths of such containing blocks. This should not cause double layouts because nothing will mark the NG object as needing layout in this case. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I63f8384170fe815780c79510b96e436014c39797 Reviewed-on: https://chromium-review.googlesource.com/1180714Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584496}
-
Maks Orlovich authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16776c61094689602525122d2c70a08481093443 Reviewed-on: https://chromium-review.googlesource.com/1148470 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584495}
-
Lukasz Anforowicz authored
r584254 removed differences between waterfall/cq and official bots (by removing testing/variations/fieldtrial_testing_config.json entries related to site-per-process and making site-per-process the default even in absence of field trials). This makes it possible to remove the |#if defined(OFFICIAL_BUILD)|-related expectations from WebDriverSitePerProcessPolicyBrowserTest. r581059 removed the not_site_per_process_browser_tests step from the bots. This makes it possible to remove the kDisableSiteIsolationTrials-related expectations from WebDriverSitePerProcessPolicyBrowserTest Bug: 874998 Tbr: pastarmovj@chromium.org Change-Id: I87988884dfe945f16e10680637b26fb4efcf3f2c Reviewed-on: https://chromium-review.googlesource.com/1181526 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Bug: 842236 Change-Id: Iba7afb45322ea3e446203274b2fe87bd6c80e9f9 Reviewed-on: https://chromium-review.googlesource.com/1178621Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584493}
-
Jennifer Apacible authored
TBR=xiyuan@chromium.org NOTRY=true (disabling tests) Bug: 875920 Change-Id: I59417725ab57ef2306671470ac78ae25d9a74ebc Reviewed-on: https://chromium-review.googlesource.com/1181650Reviewed-by:
-
Ryan Daum authored
Cleans up some more remnants from our fork of TtsController/Platform from Chrome. - Remove VoicesChangedDelegate support, as we don't use this or need it. - Remove 'copied from chrome' comment as we are pretty thoroughly forked now. - Remove more code related to the tts_extension pieces we don't support - Remove a chromeos only test that was never compiled anyways. Bug: none Test: unit test and manual Change-Id: I410603b58dac41772442af31597be7dda78be898 Reviewed-on: https://chromium-review.googlesource.com/1181174Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#584491}
-
David Black authored
We expect the lifecycle of a query to be: - Pend: occurs on interaction start - Commit: occurs on query finalize - Activate: occurs on query response received When LibAssistant error'd out, due to connectivity loss for example, the order of events delivered caused us to miss stages in the query lifecycle. Now, we will maintain the expected lifecycle and show an error message to the user when this occcurs. Bug: b:112600782, b:112056476 Change-Id: Ib01860564d88326110db285e09d15470bed58598 Reviewed-on: https://chromium-review.googlesource.com/1176976 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584490}
-
Farah Charab authored
Follow up patch for comment on line 215 in sequence_manager_processor.h for https://chromium-review.googlesource.com/c/chromium/src/+/1165145/4. We move some interfaces from SequenceManagerFuzzerProcessor to ThreadData to hide member variables of ThreadData. Change-Id: I4793fe7d7514a4730d1bfc08deba8b92b68667a1 Reviewed-on: https://chromium-review.googlesource.com/1176087 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Ted Choc authored
This CL: https://chromium-review.googlesource.com/1162674 Introduced adding a space when refining queries, and that breaks the same as typed check. The fix is to just trim the typed text before the comparison. BUG=875756 Change-Id: Ie7d55d6a0322d7be4fb6d62cd146eeaa79d34a03 Reviewed-on: https://chromium-review.googlesource.com/1181501Reviewed-by:
-
