- 01 Dec, 2019 27 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/487dd6fe1154..4c615f527533 Created with: gclient setdep -r src-internal@4c615f527533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib78c85b249e3e45e387b31935cabf7665abd83c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720358}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6b12640aaa12422197b463b67b9d4f3e1eec4db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945477Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720357}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/877dd541e6bc..487dd6fe1154 Created with: gclient setdep -r src-internal@487dd6fe1154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2f71e7b2975a6468d66a0d497bdd6a9f6007d082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945521Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 477 478 479 480 481 482 483 487 488 879 lines were removed and 130 lines were deflaked by consecutive results since 474. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ie9fb740f80e6b988f551fbcbbda92bcc9beb98d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943772Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720355}
-
Mia Glaese authored
Bug: 982018 Change-Id: Id688ee3656a57e1853715dda09273b3bebc94b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932476 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#720354}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75b70f1566b6..877dd541e6bc Created with: gclient setdep -r src-internal@877dd541e6bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I88985121952442180debd95647ce8d14a7f78a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945515Reviewed-by:
-
Liquan (Max) Gu authored
This CL is to implement the PaymentHandler toolbar's close button. Given the fact that the sheet_tab_toolbar layout has added a close button, PaymentHandler UI who implements the layout should implement the button as well. Q: Why does the mediator of the PaymentHandlerUI observe the toolbar UI? A: The mediator is in charge of observing the components external to the PH UI itself, so it should observe the toolbar UI. Bug: 999196 Change-Id: Ic82053a38fc5a08924d764ef349b33b7af77f90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944609Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720352}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/485d5e9b4f96..75b70f1566b6 Created with: gclient setdep -r src-internal@75b70f1566b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I02783093dcfd39c07ddee56b355b63ce3323184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945513Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Iafd000269b6a31ac9d398625f485cb7646b495be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943345Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f68831184db..485d5e9b4f96 Created with: gclient setdep -r src-internal@485d5e9b4f96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I198e86ef03f1f1fa877fa3f3b4c2721b3cf97536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945512Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40d34e36512a..fd0c2574518c git log 40d34e36512a..fd0c2574518c --date=short --first-parent --format='%ad %ae %s' 2019-12-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@fd0c2574518c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Ic0cb02b42cba5902875b37ff7f41d2c963dd2d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a9764098e30..9f68831184db Created with: gclient setdep -r src-internal@9f68831184db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I57f9c5586f05c29cb668e9210e3e26d06ce955f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943315Reviewed-by:
-
Reilly Grant authored
Bug: 1007633 Change-Id: I91945e13761da0dcd237ce0667d5a72054f2e498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934524 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720346}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a763d19e5fe..0a9764098e30 Created with: gclient setdep -r src-internal@0a9764098e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icfe1ca35687b4517ea22dcba3cdd31195f20a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945371Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGTSpanElement>(element) in place of IsSVGTSpanElement(element) Bug: 891908 Change-Id: Idae91831dfddadf9fe83ff26ce4689a336dac05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936624 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720344}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGFEDiffuseLightingElement> as new downcast helper 2. Use IsA<SVGFEDiffuseLightingElement>(element) in place of IsSVGFEDiffuseLightingElement(element) Bug: 891908 Change-Id: I49b225ca6095376c1c72352569a845f02987e5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936574 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720343}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGSymbolElement>(element) in place of IsSVGSymbolElement(element) Bug: 891908 Change-Id: Ib5a0ea84c79388daca85cd8af541ba42522f92cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936623 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGTextElement>(element) in place of IsSVGTextElement(element) Bug: 891908 Change-Id: Ie5f192bb485ee66fcc7ba9b0d13082cbcb6b572c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936625 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I49e8b0e6808435a5a37851703fe164ec1d3727ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944274Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720340}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/38b4db48f98c..83af46951202 git log 38b4db48f98c..83af46951202 --date=short --first-parent --format='%ad %ae %s' 2019-12-01 johnkslang@users.noreply.github.com Merge pull request #2001 from mbechard/master Created with: gclient setdep -r src/third_party/glslang/src@83af46951202 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: If427d485b9bb63d3cb4ef2e246cd4fa564f3fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943626Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I95307d1388ac5a066c917cb58a5e3cfef2c4f797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944764Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35bd9761af60..0a763d19e5fe Created with: gclient setdep -r src-internal@0a763d19e5fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ibf2e07dd6331666b6b36bc76dae29e986038c0cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943625Reviewed-by:
-
David Bokan authored
Sticky constraints should use layout units like the rest of the layout system. They should only be converted to float when passed to the compositor. Bug: 882075,1010961a Change-Id: I34f54702c0918238171981fcd97a621dbe9bbdef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943339 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38426734d3b6..35bd9761af60 Created with: gclient setdep -r src-internal@35bd9761af60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Iaeffa47a2ddc5e5915dec4c973d3c9fbd7cfbe6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944465Reviewed-by:
-
Christopher Cameron authored
PWA app shims can become sad zombies that sit around and can't be opened. I think we've plugged the holes through app shims can forget to be deleted, but this can still happen if the user manually deletes their user data dir, among other uncontrollable things. Should we find that the shim provided is not for an app installed on any profile, then open the URL specified in the shim in a browser window, preferring the profile specified in the shim (if one is specified and it exists), and then falling back to the last active profile. Also LOG(ERROR) the reason for failure in the app shim process (not seeing this has made debugging hard in the past). Bug: 1001213 Change-Id: I6fa396686525f3e3efbfd5b115b6439c714101ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940495 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#720334}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6e2ff45fa936..b64fbfec4dcd git log 6e2ff45fa936..b64fbfec4dcd --date=short --first-parent --format='%ad %ae %s' 2019-11-30 bclayton@google.com VkPipeline: Replace spirv-opt list with RegisterPerformancePasses() Created with: gclient setdep -r src/third_party/swiftshader@b64fbfec4dcd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/144832356 Tbr: swiftshader-team+autoroll@google.com Change-Id: I2c5b7c94a5b7cdc084f19a8a0afab2f3aa0f0301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943551Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 35f8ccbb. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic8490286f1e55245ef8b868546e3d8d67a53e82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944380Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720332}
-
- 30 Nov, 2019 13 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a08d73e60823..38426734d3b6 Created with: gclient setdep -r src-internal@38426734d3b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I26c9d6dc9563149b8d90b30ebeabf7e34b043e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944760Reviewed-by:
-
David Bokan authored
The RootScroller selection process sets various invalidations and cached bits on the LayoutObject of the effective and global root scrollers. These bits are later used to special case properties for the root scroller. In particular, whether we force generating and compositing a scroll node for the root scroller. However, currently, we didn't expect that the layout object might be replaced without the root scroller being demoted. This can happen when the layout tree is reattached, as happens when we enter `document.designMode`. When we get to root scroller selection, the element is unchanged so we assume there's nothing to be done, which leaves the layout object in a bad state for paint property building. The solution is simple, only skip root scroller selection if the element is unchanged *and* the layout object has the cached bit set. Bug: 1029129 Change-Id: Iff2845ea06b73349f3e980bffa6b216592cbfa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941065Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720330}
-
Bettina authored
Depend on an saved password with domain experiment flag for initializing the compromised credentials table. Bug: 1026006 Change-Id: I56b45d911a21ef675a9af1b0bc618123f86919ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943231 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720329}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Id3e75ee7807ffce7916293833d97b98ade494d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944379Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f79aeb870d07..a08d73e60823 Created with: gclient setdep -r src-internal@a08d73e60823 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I55e215710b4a55bfbf760d1ebbc791480becf4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944757Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGTextFragmentPainter<Cursor>::Paint()| to pass valid text to |PaintDocumentMarkers()| to avoid hit |DCHECK()| in |NGFragmentItem:: InlinePositionForOffset()|. Bug: 982194 Change-Id: I95ec067ef8d77ca44d48076f49404a57132c9fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942590 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a129bb05ed85..f79aeb870d07 Created with: gclient setdep -r src-internal@f79aeb870d07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2311b2951b210bef68b65ad125d36898c469b8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943392Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a91619ae. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I012eef78487d9999be46233ca588bff89dc68321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944378Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/076da640b64c..a129bb05ed85 Created with: gclient setdep -r src-internal@a129bb05ed85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I859efcdd77e53f91d836579df6a5b0bae50c633c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943390Reviewed-by:
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py 5190cf8ffd9a7878d79fd92a5e682891f0693377`. Binary-Size: crbug.com/1029574, 64 KB growth due to afdo; paid for by 70 KB reduction in last roll. Bug: 1028108 Change-Id: Ib82979b21a525b119e72fa494bfe6b5fb768e110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943232Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#720322}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6fdbeeb8. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie4f196768d3ab5d10db0d9185cb631296707e50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944377Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fdba28172fd..076da640b64c Created with: gclient setdep -r src-internal@076da640b64c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib374f2c304e42757e0be1b70ea0e1ce7985848a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944464Reviewed-by:
-
Jacobo Aragunde Pérez authored
Identifies and removes usage of static Create() for those classes defined in //third_party/blink/renderer/core/animation/css. One note about the Create() method of CSSAnimation and CSSTransition, it contained the following check: DCHECK(timeline && timeline->IsDocumentTimeline()); This is deemed unnecessary and has not been copied inline. The only uses of these Create() methods were obtaining the Timeline object from element->GetDocument().Timeline(). This implies that timeline exists as long as the Document exists (which would trigger a different error) and it is of type DocumentTimeline, because it was instantiated like that in the Document constructor: https://chromium.googlesource.com/chromium/src/+/5bfed55ceed4a194fd934ab81e47e213dd815fe7/third_party/blink/renderer/core/dom/document.cc#1136 Finally, CompositorKeyframeValueFactory is STATIC_ONLY so its Create method will not be modified. Bug: 939691 Change-Id: I9ffcd0688edf7cbab5cc10892254b3384ec2cbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943237Reviewed-by:
Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#720319}
-
