GitLab

BUG=NONE

Review URL: https://codereview.chromium.org/147033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247903 0039d316-1c4b-4281-b951-d872f2087c98

Android Chrome needs to learn whether or not WebContentsObserver::DidFinishLoad() has been called on the prerendered WebContents during the call to CoreTabHelperDelegate::SwapTabContents() here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/prerender/prerender_manager.cc&l=634&q=prerendermanager&type=cs&sq=package:chromium

BUG=335479

Review URL: https://codereview.chromium.org/143463012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247902 0039d316-1c4b-4281-b951-d872f2087c98

[chromedriver] Write command line file to both /data/local and /data/local/tmp for Chrome on Android.

This supports the new feature where setting chrome as the debug app
causes Chrome to look for the command line file in tmp.

BUG=chromedriver:665
TEST=None

Review URL: https://codereview.chromium.org/138873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/149543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324859

Review URL: https://codereview.chromium.org/139903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247899 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to r246358.

BUG=338341
R=avi@chromium.org
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/137833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307300

Review URL: https://codereview.chromium.org/145703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247897 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the build failure of the 'check_licenses' test in 'Android Builder (dbg)'.

Major changes:
- Modify the year in the copyright string in audio_player_scripts.js
- Put audio_player_scripts.js into the whitelist

BUG=none
TEST=manually run android_webview/tools/webview_licenses.py scan
TBR=boliu@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/150143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161119

Review URL: https://codereview.chromium.org/133463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247894 0039d316-1c4b-4281-b951-d872f2087c98

This call is on the startup path; we believe all regressions have been addressed, but would like data from the wild to see how this truly behaves in various user configurations.

BUG=330908

Review URL: https://codereview.chromium.org/149073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310328

Review URL: https://codereview.chromium.org/30593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331406
TEST=With the --new-profile-management flag, start Chrome. Sign in a profile, and
choose "View all people" from the avatar menu once that is complete. Close the
profile browser, then close the user manager window (you should have no windows open)
1. Clicking on the docked Chrome icon should open the user manager and 2. Command-N
(or Open New Window) form the docked Chrome icon should do the same.

Review URL: https://codereview.chromium.org/129333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247891 0039d316-1c4b-4281-b951-d872f2087c98

This type isn't used anywhere and doesn't need to be forward declared.

TBR=sky

Review URL: https://codereview.chromium.org/142713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247890 0039d316-1c4b-4281-b951-d872f2087c98

If the MDnsListener is listening for a record we care about, actively refresh
it.

BUG=336883
R=vitalybuka@chromium.org,szym@chromium.org

Review URL: https://codereview.chromium.org/132693025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/100173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247888 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247887 0039d316-1c4b-4281-b951-d872f2087c98

This:
- makes use of a funky downcast
- moves TestableAutofillDialogViews code out of the production binary
- makes it impossible to accidentally call testing code from production code

mac implementation by groby@chromium.org

BUG=306200

Review URL: https://codereview.chromium.org/135933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247886 0039d316-1c4b-4281-b951-d872f2087c98

Add the class to temporarily enable SyncFSV2 for testing.

BUG=331988
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/130913013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247885 0039d316-1c4b-4281-b951-d872f2087c98

Enable media android tests and make --disable-gesture-requirement-for-media-playback default for media measurement.

Android cases exclude 4k and 50fps content.

BUG=329691

Review URL: https://codereview.chromium.org/149793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247884 0039d316-1c4b-4281-b951-d872f2087c98

Previously FILE_ERROR_ABORT that is happened by user's cancel operations raises
the general error message.

BUG=339028
TEST=manually

Review URL: https://codereview.chromium.org/149243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247883 0039d316-1c4b-4281-b951-d872f2087c98

mtune was set to cortex-a8, which is a Nexus S-generation CPU.
Removing it allows for small speed improvements (~1%) for
warm page load times on top10 mobile sites on more recent devices.
Data: https://docs.google.com/spreadsheet/ccc?key=0Ao-xIDuezqMNdDc5OWpxbkk4NFJ0SF9Iemt0Tlg3RFE&usp=sharing
And it has virtually no effect on binary size.
BUG=334271

Review URL: https://codereview.chromium.org/145663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335900
R=ben@chromium.org

Review URL: https://codereview.chromium.org/150073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247881 0039d316-1c4b-4281-b951-d872f2087c98

R=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/149703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
R=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/147143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247879 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/26753005/ might have introduced crashes that
trace to SetContentViewCore.  That previous patch assumed that ContentViewCore
(CVC) always outlives its associated RenderWidgetHostView.  In this patch, we
are trying to ensure that the RWHVA pointer to CVC is nulled when CVC is
destroyed.

Note the following:
- WebContents owns ContentViewCore and WebContentsView.
- CVC and WebContentsView are implicitly destroyed (no direct call to clean-up
code).  So ContentViewCore cannot refer to WebContents or WebContentsView in
its destructor.

Therefore, we use the observer of when WebContents is destroyed to start the
clean up on CVC.


BUG=335165, 324341

Review URL: https://codereview.chromium.org/133073012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339327
R=kinuko@chromium.org, nhiroki@chromium.org

Review URL: https://codereview.chromium.org/149683008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333499
TEST=none
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/149513010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247876 0039d316-1c4b-4281-b951-d872f2087c98

The small icon is a 16x16 image in the bottom right of all notification
templates.  Currently it is not exposed to the JS API, but instead is used
only by internal API systems (starting with synced notifications.)

BUG=284592

Review URL: https://codereview.chromium.org/149433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247875 0039d316-1c4b-4281-b951-d872f2087c98

This adds traces to entry points in SingleThreadProxy that have
analogous trace events in the ThreadProxy. Also add trace points
along the critical CompositeImmediately -> CommitAndComposite ->
DoCommit/DoComposite code path.

R=enne
BUG=339248

Review URL: https://codereview.chromium.org/149053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247874 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=skuhne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/141133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553

Review URL: https://codereview.chromium.org/146703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247872 0039d316-1c4b-4281-b951-d872f2087c98

* Make StartMonitoringPowerAsync() synchronous in terms of starting the powermetrics process by waiting for output file to be created before returning.
* Handle parse errors in powermetrics output - empirically while I was able to quite easily get powermetrics into a state where it exited in the middle of writing a sample, I was completely unable to get it not write out at least one sample completely.
* Modify unit test to start/stop powermetrics faster than it's refresh rate to try to trigger malformed output - test fails without rest of this patch, passes with this patch.

BUG=338808

Review URL: https://codereview.chromium.org/145353012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247871 0039d316-1c4b-4281-b951-d872f2087c98

Many of the members from WebApplicationInfo were in place to support
crx-less hosted apps. Since crx-less apps have been removed, we can
clean up references to them and repurpose convert_web_app.cc to be
solely for generating bookmark apps.

Review URL: https://codereview.chromium.org/142993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247870 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly a cosmetic patch to change a boolean into an enum.

BUG=335289

Review URL: https://codereview.chromium.org/131683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247869 0039d316-1c4b-4281-b951-d872f2087c98

Crash would occur in resetting selection model. It was possible to
attempt to reset the selection model with an active index of -1, which
TabStripModel does not like.

BUG=338285
TEST=see bug
R=ben@chromium.org

Review URL: https://codereview.chromium.org/149393009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339271
TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/131003014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247867 0039d316-1c4b-4281-b951-d872f2087c98

The remaining pieces in ui/test/ are used only by a unittest in ui/gfx/,
so in this patch we move these files into ui/gfx. This fixes the TODO in
ui/gfx/DEPS that was assigned to Ben.

BUG=None
TEST=ui_unittests
R=tony@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/147803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247866 0039d316-1c4b-4281-b951-d872f2087c98

This cl is pure style-targeted refactoring. 
No functional changes were made. 

BUG=339176

Review URL: https://codereview.chromium.org/148663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247865 0039d316-1c4b-4281-b951-d872f2087c98

Remoting host on windows contains latest revision number so parts
of remoting are rebuilt every time revision number changes. Removed
dependency on LASTCHANGE to prevent ninja from rebuilding remoting
every time. The file is still used.

BUG=332679

Review URL: https://codereview.chromium.org/142713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/130803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247863 0039d316-1c4b-4281-b951-d872f2087c98