GitLab

This is a reland of 0c2015e1

TBR=eugenebut@chromium.org

Original change's description:
> Disable WebStateTest.MessageFromIFrame test.
>
> TBR=eugenebut@chromium.org
>
> Bug: 857129
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
> Reviewed-on: https://chromium-review.googlesource.com/1117300
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570882}

Bug: 857129
Change-Id: I62a341ccebb1ceef892a2f07eb0faae4d87476d7
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118685Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571159}

Android is not possible yet because we can't pass flags to the test executable.

BUG=angleproject:2635

Change-Id: I2c8247c9231895a729575229a820f1720d845c6f
Reviewed-on: https://chromium-review.googlesource.com/1117210Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571158}

kCanvas2DImageChromium [0] is a FeatureFlag enabled by default in
Mac and CrOS allowing for using GL CHROMIUM_image extension for HTML
Canvas Contexts.  This CL exposes this flag to chrome:flags so it
can be used for debugging e.g. crrev.com/c/1056168 etc.

In CrOs, the flag goes unused now [1], so nothing changes there.

[0] https://cs.chromium.org/chromium/src/content/public/common/content_features.cc?type=cs&q=kCanvas2DImageChromium&g=0&l=83
[1] https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?type=cs&q=enable_canvas_2d_image_chromium&g=0&l=156

Bug: 839970
Change-Id: I94a3646e996b996f6901d9414734801d1aa2bfab
Reviewed-on: https://chromium-review.googlesource.com/1117328
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571157}

This change implements initiating GATT connections for WinRT. While
currently no GATT discovery is attempted, this will be provided in a
future CL. GATT connections are created by obtaining an instance of
BluetoothLEDevice.

Bug: 821766
Change-Id: I7f20127a84b781859300af18b31da0e9ee24a32b
Reviewed-on: https://chromium-review.googlesource.com/1090217
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571156}

Including Windows.h causes namespace pollution and build-time costs due
to the heavy use of macros and the large size of the headers. This
removes a #include of Windows.h from range.h that is currently causing
problems.

Bug: 855717, 796644
Change-Id: I26abd068ed1c4a5ca65092258dd45ccd076c2b20
Reviewed-on: https://chromium-review.googlesource.com/1117739
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571155}

This is a reland of f824b3a3

Original change's description:
> variations: add client config for ViewsBrowserWindows
>
> Bug: 827247
> Change-Id: Ic09c38f7b658b1f6d79ecec8a6d0895aca44d797
> Reviewed-on: https://chromium-review.googlesource.com/1017460
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565782}

Relanding the CL.

Bug: 827247,851463
TBR: isherman@chromium.org
Change-Id: Ic3b23594fa74b24023924ad4107bf262e641bfb7
Reviewed-on: https://chromium-review.googlesource.com/1106498Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571154}

When migrating [1] formatting logic from ConsoleViewMessage.js to
BrowserConsole.js, we forgot to add the line that tries to show a
localizedFailDescription.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/920541

Bug: 816743
Change-Id: Ic3e6cc49b8634a12fe8667c19fdc4623780075db
Reviewed-on: https://chromium-review.googlesource.com/1115872Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571153}

Currently its using WebLayerTreeViewImplForTesting but it only uses
the cc::LayerTreeHost, not the WebViewImpl things, so it just needs
a LayerTreeHost itself. This helps us toward removing the
WebLayerTreeView interface.

R=chrishtr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia60ea4128ed029f09ee4abe012ee62f315633c88
Reviewed-on: https://chromium-review.googlesource.com/1117656
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571152}

Makes incremental builds of blink_core 31% faster in jumbo builds.
(Non-jumbo builds that use PCHs (i.e. not goma builds at the moment) already
got this speedup without this change.)

reviews.llvm.org/rL335466 made PCH files much more effective in component
builds on windows.  Regular (non-jumbo) component builds of blink_core now build 42%
faster.  In Jumbo builds, full builds are only a bit faster with PCHs enabled
after that change (26m52s instead of 27m33s with just jumbo; jumbo + PCH before
that change was 27m41s), but incremental build time goes from 32s to 22s for
touching one cc file and relinking blink_core.dll, which is a considerable
speed-up.

Reverts https://chromium-review.googlesource.com/c/chromium/src/+/962785

Bug: 809010
Change-Id: I985dd16dacaa9f655ae2a9329b33ad92229a1ab6
Reviewed-on: https://chromium-review.googlesource.com/1116901Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571151}

Events at the RewriteEvent() interface are in raw screen coordinates,
but TouchExplorationController internally uses DIP coordinates.
Some rewritten events were incorrectly generated using DIP coordinates.

Bug: b/73383411
Test: manual
Change-Id: Ib126692e51aaf034a95cd9b50b599e4bd76cbcac
Reviewed-on: https://chromium-review.googlesource.com/1117469
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571150}

Use cc::LayerTreeHost instead, as these tests just need to use cc
APIs for testing painting. They do not use the WebViewImpl etc layer.

NOTRY=true

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide21fc6acdbd4c1171987f964ea6b157e79789e0
Reviewed-on: https://chromium-review.googlesource.com/1117622
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571149}

TBR=jochen@chromium.org
NOTRY=true

Bug: 857488
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36166c547f9c5c5b9d69d01742a20f6673c8f15e
Reviewed-on: https://chromium-review.googlesource.com/1118534
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571148}

The code in FixupURL does not properly handle "about:blank" variants
where some letter in "blank" is uppercase. This CL fixes the issue by
returning "about:blank" when the lowercase of the input URL is
"about:blank".

Bug: 857201
Change-Id: Ia1ff719d142ae8f2a346cbca231e52a811e9b77c
Reviewed-on: https://chromium-review.googlesource.com/1117627Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571147}

Bug: None
Test: None
Change-Id: I5de8c272bb5d82c135e35a210f5c3948befd155f
Reviewed-on: https://chromium-review.googlesource.com/1117848Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571146}

Since cross-thread persistents may be included in the poisoning, but must not
be observed by another thread to be poisoned, the mutex must be held to prevent
them noticing before they are unpoisoned again.

The alternative which would narrow the critical section might be to store away
a copy of the cross-thread persistents and not poison them at all, but this is
consistent with the previous approach and thus seems less risky.

Bug: 857311
Change-Id: Ib0ddee582c6ceea98cce0c0b3844fb363aa3c5be
Reviewed-on: https://chromium-review.googlesource.com/1118286Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571145}

Add WebFeature UseCounters for when env() is used and for when
each safe area inset variable is used.

These should also be exposed to UKM so we can cross reference
with our UKM event.

BUG=855739

Change-Id: Ib5e4f26752a279c9696a050bd42dd5842fe28cb0
Reviewed-on: https://chromium-review.googlesource.com/1112698Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571144}

This is a re-land of an old CL, which was reverted in https://codereview.chromium.org/2977273002
due to a WebView issue. We believe the underlying issue may have been resolved, so should try
re-landing this.

Bug: 715699
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0da6ab6f55d0fb4ba0760378f182217e8c4546c1
Reviewed-on: https://chromium-review.googlesource.com/1112387Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571143}

Also avoid a hop to get own clock via the RealTimeDomain.

Bug: 857101
Change-Id: I0433f8442b061ff2b2f33f839eb08719fb76bc5d
Reviewed-on: https://chromium-review.googlesource.com/1118267Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571142}

The returned status string is only for debug UI (about:sync-internals),
there's no reason why the Java side would have to know of it (and
accordingly, it was unused).

Bug: none
Change-Id: I84c33d32c426e05f9ec04516ca93d6775354548d
Reviewed-on: https://chromium-review.googlesource.com/1116705Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571141}

This is needed as the TraceWriters we create and keep in TLS
keep a reference to the SharedMemoryArbiter object that the
ProducerClient keeps, and during shutdown may still be
used after the ProducerClient previously got deleted.

R=hjd@chromium.org
BUG=844379

Change-Id: Ib27b59b48ce50f88f954618e7eee4f046b3029b7
Reviewed-on: https://chromium-review.googlesource.com/1117776Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571140}

Recent table refactoring means we expose more layout tables. This is
generally a good thing.

It broke some accessibility in Hangouts, where there was a layout table
inside of an ARIA button and the accessible text of the button came from
inside the layout table. Previously the layout table was just exposed as
generic elements, and layout table roles should behave the same way with
regards to how text is exposed to ancestors.

Bug: 856277
Change-Id: I9b30931b306fda09a5408df4dc3b3dd1c54e619e
Reviewed-on: https://chromium-review.googlesource.com/1117628
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571139}

Bug: 836246
Change-Id: I6db06e859468e7ab4d19424a91d8a90bffa23a2e
Reviewed-on: https://chromium-review.googlesource.com/1070658
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571138}

Mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z

Bug: 827376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
Reviewed-on: https://chromium-review.googlesource.com/1100237
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571137}

Feature is landed in M66. Now we can remove the flag in M69.

Bug: 805046
Test: manual

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id98b066228f5f5b45d9d02d405bcc57d41fde20a
Reviewed-on: https://chromium-review.googlesource.com/1113097Reviewed-by: Mitsuru Oshima (OOO 6/27) <oshima@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#571136}

Move key_hit_test_cases into the rendering folder and refactor to
inherit from RenderingStory

Bug: 849392
Change-Id: Iecf8c273fb137b051ab51ee47f4020addef2548d
Reviewed-on: https://chromium-review.googlesource.com/1118279Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571135}

In pathological cases, such as those provided in the relevant bug,
Zucchini could exhibit O(n^2) behavior during seed selection. To remedy
this, this CL adds a quota to limit the total number of bytes covered
in seed selection search. However, as demonstrated in CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1115710
this is insufficient. haungs@ determined that if this is the only
limitation then the ExtendEquivalenceBackward method will perform a
linear time extension resulting in O(n) behvior which when applied
over O(n) offsets results in O(n^2) behavior again. To limit this he
proposed limiting the distance ExtendEquivalenceBackward can search
which is also implemented in this CL.

These parameters are tuned such that they have no noticeable impact
when patching chrome.7z for Windows. For the pathological testcases in
the bug the results are significantly better (refer to the bug for
exact improvements).

This solution results in linear time performance on the pathological
cases. We could get these numbers down even smaller by reducing the
limit on backward extension. However, this had a small, but noticeable
~5 kiB increase in patches for chrome.7z.

Bug: 849471
Change-Id: If7e857884b00daeeae7a4a29b1236c749f0b84e4
Reviewed-on: https://chromium-review.googlesource.com/1117273
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571134}

It shouldn't be used as an API method, use DelayTillNextTask
method instead. The are intercahngable for RealTimeDomain but
NextScheduledRunTime disreards any additional logic which
might be defined in a DelayTillNextTask override.
So this change also makes it more semantically correct.

Bug: 857101
Change-Id: Ie6170312d7840a2acfe32e592fb2d799e4eaf0a7
Reviewed-on: https://chromium-review.googlesource.com/1118224Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571133}

https://boringssl.googlesource.com/boringssl/+log/6ff2ba80b758025fdb137d9357dcbba0a9c04dbf..fec83fc78d489a8d444c3a99c51101fdf54d5b71

BUG=none

Change-Id: I01a78a1b5e1d2d6fe8d8170306b9ddaee812649c
Reviewed-on: https://chromium-review.googlesource.com/1117607
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571132}

The previous version of this helper function incorrectly assumed that
the number of planes and the number of FDs in a GbmBuffer are always
the same, but they are not necessarily so. Note that this bug did not
affect any production code; it was only a bug in the unit test.

Bug: 851343
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5db5a5d571fad24aa0fa0d73863f0157bf30f90f
Reviewed-on: https://chromium-review.googlesource.com/1116018
Commit-Queue: Sharif Elcott <selcott@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571131}

replace std::find() with base::containsValue()
at components/certificate_transparency and components/policy
and components/feature_engagement

Bug: 561800
Change-Id: I481fcc85d3d0043301991f08be47d1280a2585df
Reviewed-on: https://chromium-review.googlesource.com/1114406
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571130}

The PeerConnectionTracker logs events relating to an RTCPeerConnection
(APIs called, events firing, tracks added or removed) and lists them in
chrome://webrtc-internals.

Ever since the days of addStream()/removeStream(), the tracker has
listed a local or remote stream being added or removed as an event.
These APIs are no longer in the spec and are in fact implemented on top
of the spec-compliant addTrack()/removeTrack().

Prior to this CL, the tracker reported a stream being added by any means
as "addStream" and removed as "removeStream", which is misleading
because they may have been added through other APIs.

In preparation for Unified Plan, which expresses media sections in terms
of transceivers (sender-receiver pairs), the PeerConnectionTracker is
updated to more accurately express what is going on. In Unified Plan you
may for example add a transceiver that does not have a track yet or
receive a track by reusing an already existing transceiver. You may also
send the same track multiple times, or send/receive tracks that don't
belong to any stream or that belongs to multiple streams. This is all
described by the sender/receiver, not by any set of "local" or "remote
streams". In Unified Plan, because receiving tracks are created
alongside transceivers, often before being used if ever used, speaking
of tracks being "added" or "removed" is confusing.

Instead of "addStream"/"removeStream" we get
"[sender/receiver/transceiver][Added/Modified/Removed]".
The chrome://webrtc-internals log shows state of the sender or receiver
(TODO: or in Unified Plan, the transceiver) that was added, updated or
removed.

This will continue to make sense moving forward, and removes the
dependency on streams, which is a RTCRtpTransceiver blocker because
Unified Plan uses stream IDs, not streams.

Bug: 810708, 777617
Change-Id: I47dad2cb0b754c4ab8fb47ca5c7da3e0f33c6072
Reviewed-on: https://chromium-review.googlesource.com/1117063Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571129}

Using wpt-import in Chromium f67bbacc.
With Chromium commits locally applied on WPT:
ab4fb5ca "Update links to feature policy documentation."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20297

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I79984ede877feafd838921daa2af13167f4acde5
Reviewed-on: https://chromium-review.googlesource.com/1118015
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571128}

When this flag is specified (e.g. in tryjob retry without patch &
FindIt), the test runner doesn't fail if no tests are run (e.g. because
of an empty test list). Previously, the runner would still exit early
and produce no artifacts in such case. This CL changes the behaviour to
keep executing and produce valid empty (*) test result JSONs.

* Caveat: the JSONs aren't really empty; they still contain a list of
WONTFIX (and hence skipped) tests because of implementation details.

Bug: 851639
Change-Id: Idfc990263e130bc02dc441bc0d375a149e8b44d3
Reviewed-on: https://chromium-review.googlesource.com/1117623Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571127}

This CL increases CheckableImageView size specified in
checkable_image_view_widget.xml to match the size of standard checkbox
widget and fix alignment.

Bug: 857267
Change-Id: I6beb61a6d7d27092b3a491b3e8e2c9ee962f69ae
Reviewed-on: https://chromium-review.googlesource.com/1118272Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571126}

This reverts commit ccd4ec08.

Reason for revert: multiple tests failing on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)(32)/50984

UpdateServiceTest.UninstallExtensionWhileUpdating
PolicyUpdateServiceTest.PolicyCorruptedOnStartup
PolicyUpdateServiceTest.FailedUpdateRetries
UpdateServiceTest.TwoUpdateCheckErrors
UpdateServiceTest.UpdateCheckError
UpdateServiceTest.SuccessfulUpdate
ComponentUpdaterPolicyTest.EnabledComponentUpdates
PolicyUpdateServiceTest.Backoff
UpdateServiceTest.PolicyCorrupted
UpdateServiceTest.NoUpdate

[5637:5892:0628/072239.370548:FATAL:http_request_headers.cc(129)] "POST /pinghost/service/ping HTTP/1.1" is missing colon delimiter.
 


Original change's description:
> Migrate client_update::SendProtocolRequest to SimpleURLLoader
> 
> URLFetcher et al will stop working in the browser process with advent
> of Network Service, and SimpleURLLoader is the replacement API
> for most clients. CL migrates SendProtocolRequest to the new API.
> 
> Major remarks:
> 
> * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
> of the former is kept (are almost the same) in the later. This allows the extensive set of unit
> tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
> to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.
> 
> * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
> and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
> This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
> directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
> eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
> Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
> have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
> using EmbeddedTestServer in order to intercept URL loads.
> 
> Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
> some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
> so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
> It will be done in a follow up CL.
> 
> BUG=773295,844973
> 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
> Reviewed-on: https://chromium-review.googlesource.com/1097337
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571097}

TBR=droger@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,sorin@chromium.org,emaxx@chromium.org,tonikitoo@igalia.com,mxnguyen@chromium.org

Change-Id: I0974aeef814ac153bf7da86ebf3e2f09b410bdd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295, 844973
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118585Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571125}

Extensions may be whitelisted to suppress the zoom bubble when
performing an extension initiated zoom (e.g. the PDF viewer). However,
this also suppressed updates to the zoom bubble if it was already
being shown.

We now update the zoom bubble (if it exists) in this case.

Bug: 817278
Change-Id: Ia746f25de2760e8349a1ec3d3f4c899392d0fc81
Reviewed-on: https://chromium-review.googlesource.com/1086153Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571124}

So far, all instances of this missing selector crash linked in the bug have
come from 10.10.0, but my copy of 10.10 has it. This change checks
`respondsToSelector:`, instead of OS version, before calling SPI.

Bug: 856211
Change-Id: Ib2aa07e0e24b83f1766a2f6e16e19b2b123970a6
Reviewed-on: https://chromium-review.googlesource.com/1115781Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571123}

Bug: 753924
Change-Id: I4656a4f3d409bb6aada86654f675dc0e51cb93d2
Reviewed-on: https://chromium-review.googlesource.com/1117601Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571122}

A new Clang version caught this.

TBR=wangxianzhu

Bug: 857393
Change-Id: Ib3d9d7c0bd67d9b2deed699662de91e75ee47694
Reviewed-on: https://chromium-review.googlesource.com/1118380Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571121}

IdentityProvider currently has baked-in knowledge of OAuth2TokenService
for functionality that is shared between ProfileIdentityProvider and
DeviceIdentityProvider. However, as we will be converting
ProfileIdentityProvider to talk to IdentityManager rather than
OAuth2TokenService, this baked-in knowledge needs to be moved out of
IdentityProvider; ultimately, it will end up only in
DeviceIdentityProvider.

This CL takes a step along that path by moving the IdentityProvider
method implementations that interact with access tokens into the two
derived classes, making fetching and invalidating access tokens virtual
methods of IdentityProvider.

TBR=pastaramovj@chromium.org

Bug: 809452
Change-Id: I7b80f54d783dfa4de3236aec46c663bbfcb92422
Reviewed-on: https://chromium-review.googlesource.com/1114611
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571120}