GitLab

Review URL: https://chromiumcodereview.appspot.com/13652011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192672 0039d316-1c4b-4281-b951-d872f2087c98

The compositor should tick and finish animations even if it is not
drawing anything. It can not draw for various reasons:
1) The tab is backgrounded.
2) CanDraw() is false for any of its reasons.
3) PrepareToDraw() fails due to checkerboarding.
4) There is no damage on the screen to draw.

Currently the problems are:
- When backgrounded, the animations are ticked but their states are not updated.
- When CanDraw() is false, we don't draw, and animations just stop ticking.
- If we stop drawing when we damage the screen, we tick animations, but don't
  update animation state since this happens in DrawLayers().

To solve these problems, I've moved the animation control more explicitly out
of LayerTreeHostImpl. The proxy already calls Animate(). Now it will also call
UpdateAnimationState(). It always does this after calling Animate() regardless
if drawing or not.

Secondly, the missing UpdateAnimationState() call is added to the OnTimerTick
for background animation ticking.

We enable background ticking only when we change visibility, currently. But
when CanDraw() is false, we don't draw and thus don't tick animations. So
instead we add to LayerTreeHostImpl a UpdateBackgroundAnimateTicking() method.
We call this always after calling Animate() since that can remove animations -
it's something Animate() used to do. And we also call this:
a) After a commit - this could add new animations, or change visibility.
b) After changing CanDraw()'s state.

However, when PrepareToDraw() is false, we do not want to start new animations
so we let animations finish without starting new ones. This is verified by 
the LayerTreeHostAnimationTestCheckerboardDoesntStartAnimations test.

This is covered by adding single-thread mode to all the animation unit tests
(except those that call SetNeedsAnimate() which is not legal in single thread
mode). Also by new tests:
LayerTreeHostAnimationTestRunAnimationWhenNotCanDraw.RunSingleThread
LayerTreeHostAnimationTestRunAnimationWhenNotCanDraw.RunMultiThread
LayerTreeHostAnimationTestRunAnimationWhenNotVisible.RunSingleThread
LayerTreeHostAnimationTestRunAnimationWhenNotVisible.RunMultiThread
LayerTreeHostAnimationTestCheckerboardDoesntStartAnimations.RunMultiThread

Added scheduler tests:
SchedulerStateMachineTest.ReportIfNotDrawing
SchedulerStateMachineTest.ReportIfNotDrawingFromAcquiredTextures

R=ajuma@chromium.org
BUG=222915

Review URL: https://chromiumcodereview.appspot.com/13613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192671 0039d316-1c4b-4281-b951-d872f2087c98

Add tracing for capture timestamps.

BUG=225209


Review URL: https://chromiumcodereview.appspot.com/13554003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192670 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13004012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192669 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds --auto-reconnect as an option to the
provisioning script. This option is not being used.

BUG=164180


Review URL: https://chromiumcodereview.appspot.com/13649010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192668 0039d316-1c4b-4281-b951-d872f2087c98

issue somewhere (I'm sure).

R=sky@chromium.org
BUG=224259


Review URL: https://chromiumcodereview.appspot.com/13533021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192667 0039d316-1c4b-4281-b951-d872f2087c98

This change separates the tracking of what work needs to be done from
the decision of when to do it.  Prior to this change, SyncSessionJobs
were owned either by Closures posted to the sync thread's message loop,
or held temporarily in unscheduled_nudge_storage_, a member of the
SyncScheduler.  Following this change, there can be only two jobs in
existence, and they will be referenced only by the scoped_ptr members of
SyncScheduler named pending_nudge_job_ and pending_configure_job_.

This change, along with some previous changes to the way we schedule
tasks, makes it possible to simplify the job "saving" logic.  Jobs with
purpose == NUDGE are saved by assigning them to pending_nudge_job_ or
coalescing them with the existing pending_nudge_job_.  Jobs with purpose
== CONFIGURE are never coalesced, and can be saved in the
pending_configure_job_ member.  These changes allow us to make
SyncSessionJob::Clone() obsolete.

The logic in ScheduleNudgeImpl() has been updated to take advantage of
the fact that the pending job is much easier to find now.  It should now
be much better at coalescing its sources.  In other words, there will be
less scenarios where it can drop notification hints.  However, there are
still some cases in DecideOnJob() that may induce it to drop hints
unnecessarily.

The scheduling logic has been modified, too.  We've removed support for
the nudge while in an exponential backoff interval.  This makes it
possible to track the next wakeup time using a single timer, since the
wakeup event will be one of:
- The end of a throttled interval
- An end-of-backoff-interval retry
- A scheduled nudge
and these scenarios are now mutually exclusive.

BUG=175024

Review URL: https://chromiumcodereview.appspot.com/13422003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192666 0039d316-1c4b-4281-b951-d872f2087c98

Webkit has supported unprefixed box-shadow since December 2010:
http://peter.sh/2010/12/no-more-delete-unprefixed-box-shadows-and-a-have-happy-new-year/

BUG=


Review URL: https://chromiumcodereview.appspot.com/12842013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178469


Review URL: https://chromiumcodereview.appspot.com/13638012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192663 0039d316-1c4b-4281-b951-d872f2087c98

Currently, normal APKs and instrumentation APKs are both built using
java_apk.gypi (which includes all kinds of new hotness). Native
unittest APKs, though use apk_test.gypi and thus the complicated
native_test_apk.xml and Android's Ant build.xml. That is bad.

This change updates apk_test.gypi to include java_apk.gypi and so
brings these two ways of building APKs into alignment. It also very
slightly updates the configurability of java_apk.gypi and
apk-package.xml.

There are still a couple of targets in WebKit that use
generate_native_test.py and native_test_apk.xml directly that need to
be updated to use apk_test.gypi before those two scripts can be
simplified/removed.

BUG=158821


Review URL: https://chromiumcodereview.appspot.com/13564003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192662 0039d316-1c4b-4281-b951-d872f2087c98

Check that a draw occured, rather than just that it was scheduled. Verify that CompositorDelegate is not called if compositing is threaded.

BUG=173417
TEST=compositor_unittests --ui-enable-threaded-compositing


Review URL: https://chromiumcodereview.appspot.com/13555004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=196349
TEST=SecurityTest.NewOverflow and CallocOverflow should not fail as part of a long test run


Review URL: https://chromiumcodereview.appspot.com/13529020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192660 0039d316-1c4b-4281-b951-d872f2087c98

This makes ui::Layer use cc::Layer::SetPosition for setting
its position, instead of baking its position into the
transform that's set on the cc::Layer. This means that a
change to a ui::Layer's bounds no longer affects the
transform set on the cc::Layer, and hence bounds animations
no longer conflict with threaded transform animations.

BUG=170219,226326


Review URL: https://chromiumcodereview.appspot.com/13725015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192659 0039d316-1c4b-4281-b951-d872f2087c98

Context: https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-dev/1aTQc4fd-rk

BUG=

Review URL: https://chromiumcodereview.appspot.com/13529016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192658 0039d316-1c4b-4281-b951-d872f2087c98

See bug attached for screenshots

The CL does two things:
- Disables the resizer lock, so that UI bits can go ahead of content bits
- Janks (blocks) the UI thread until the compositor has flushed / finished
the pending commands.

This makes the mis-draw way less, up to one frame behind, which at my regular
mouse speed of 1.2 pixels / ms comes out to 20 pixels of whiteout.


BUG=177115
TEST=none
Review URL: https://codereview.chromium.org/13604007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138275

Review URL: https://codereview.chromium.org/13533022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225911
TEST=manual + browser test ExtensionApi.AutotestPrivate

Review URL: https://chromiumcodereview.appspot.com/13520005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192655 0039d316-1c4b-4281-b951-d872f2087c98

It should be crystal clear when, and why, pin validation is and is not
performed.

TEST=net_unittests; with an OFFICIAL_BUILD: can still connect to pinned
sites, and https://pinningtest.appspot.com fails with
net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN.


Review URL: https://chromiumcodereview.appspot.com/13466020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/13431003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192653 0039d316-1c4b-4281-b951-d872f2087c98

Currently we only get stats about missing plugins (including unregistered plugin and missing plugin file). It is also interesting to know how many plugin creation failed because it is disabled. User may forget that he/she disabled a particular plugin and he/she doesn't get an info bar in this case, which could cause confusion.

In this CL:

- Rename MissingPluginReporter to PluginUMAReporter.
- Add ReportPluginDisabled function.
- Call ReportPluginDisabled function if the plugin is disabled in CreatePlugin.
- Refactor PluginUMATest to remove duplicate code.

BUG=226107
TEST=Unittests pass.

Review URL: https://chromiumcodereview.appspot.com/13414007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192652 0039d316-1c4b-4281-b951-d872f2087c98

Support storing the VisibilityClient on windows other than the RootWindow. What this means is you can set an object implementing VisibilityClient on any window in the hierarchy and this impl will handle layer visibility changes for that subtree.

R=sky@chromium.org
Review URL: https://codereview.chromium.org/13638010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192651 0039d316-1c4b-4281-b951-d872f2087c98

This is effectively a revert of r184013 and r183849.

BUG=227057, 173295

Review URL: https://codereview.chromium.org/13674020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192650 0039d316-1c4b-4281-b951-d872f2087c98

Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The main reasons are that it makes content's embedder interfaces harder to change if they're reused by the embedder, and that its makes it confusing for embedder code when there are multiple ways to do the same thing.

BUG=227047
Review URL: https://codereview.chromium.org/13409003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192649 0039d316-1c4b-4281-b951-d872f2087c98

CID=105999
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/13358002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192648 0039d316-1c4b-4281-b951-d872f2087c98

Also, turn on support for EXT_draw_buffers on Windows. To make it easy for debugging ANGLE implementation bugs.

BUG=180397
TEST=gpu_unittests,content_unittests
Review URL: https://codereview.chromium.org/13730008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140316
Test=Updated WebViewTest.NewWindow

Review URL: https://chromiumcodereview.appspot.com/13032003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192646 0039d316-1c4b-4281-b951-d872f2087c98

With this CL we no longer commit instant suggest text when the
omnibox loses focus.

Also see the following discussion:
https://code.google.com/p/chromium/issues/detail?id=179981#c15

BUG=179981, 12664004
TEST=On Mac, ChromeOS, and Windows tested the following:
  - Typed "hello w"
  - clicked on the page and verified that suggest text remained
    uncommited
  - clicked back in the omnibox and pressed right arrow, verified
    that the suggest text was commited
Did the same test except instead of clicking on the page I clicked
into the find bar. Verified that this also worked.

Also tested switching tabs and verified that suggest text is not lost.

Review URL: https://chromiumcodereview.appspot.com/12792013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192645 0039d316-1c4b-4281-b951-d872f2087c98

On Canary, the user data directory is affected by
[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CrProductDirName"].
Unfortunately in app shims, [NSBundle mainBundle] refers to the app shim's
bundle, not Chrome's bundle. This patch parameterises the
user-data-directory-figuring-out code on the NSBundle, so that app shims can
pass an NSBundle for the real Chrome bundle.

R=thakis@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12663023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192644 0039d316-1c4b-4281-b951-d872f2087c98

Fixes all AutofillDialogControllerTest which were failing on Windows.

R=xhwang@chromium.org,jam@chromium.org
BUG=227221

Review URL: https://codereview.chromium.org/13533026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192643 0039d316-1c4b-4281-b951-d872f2087c98

Implementation based on existing methods in Histogram.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13469020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192636 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13640006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12255023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192631 0039d316-1c4b-4281-b951-d872f2087c98

pre-cursor to moving Chrome OS + Aura away from legacy GTK+X11 dibs. Now, we
have just:
- Windows style dibs
- POSIX style dibs
- Legacy GTK+X11 style dibs.

There's some ifdef hoops that will be removed in a follow-up CL when
Chrome OS + Aura will be moved away from legacy GTK+X11 dibs and on to POSIX
dibs.

BUG=147622
Review URL: https://codereview.chromium.org/13582008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192629 0039d316-1c4b-4281-b951-d872f2087c98

Managing size information via the platform view has undesirable side effects.

For instance in aura, calls to SetBounds cause the platform view to take
resize locks, which are not needed for something that is displayed indirectly.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13647006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192626 0039d316-1c4b-4281-b951-d872f2087c98

I don't think we want all of these histograms uploaded,
we just care about them on local runs. I switched them
to be non-UMA

This change also updates the RasterTimes histogram
to be in microseconds.


Review URL: https://chromiumcodereview.appspot.com/13575007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/13496006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192624 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for removing content::GetContentClient calls outside of content.

BUG=227047
Review URL: https://codereview.chromium.org/13488009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224948,227043
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13735002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192621 0039d316-1c4b-4281-b951-d872f2087c98

This check was removed due to misinterpretation of the spec, but it
seems it's needed for some streams.

BUG=225787
TEST=manual playback

Review URL: https://chromiumcodereview.appspot.com/13726007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192620 0039d316-1c4b-4281-b951-d872f2087c98

Sergiu's fix for crbug.com/224081 inadvertently broke the layout
on Android. This fixes the problem.

BUG=None
TEST=Open chrome://history and ensure that the 'x' buttons on the
right hand side of each entry are all aligned.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13724008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192619 0039d316-1c4b-4281-b951-d872f2087c98