GitLab

This test is timing out on the valgrind bots.

TBR=eugenis@chromium.org
NOTRY=true
BUG=430391

Review URL: https://codereview.chromium.org/701013003

Cr-Commit-Position: refs/heads/master@{#302772}

Review URL: https://codereview.chromium.org/699123004

Cr-Commit-Position: refs/heads/master@{#302771}

Method is used only for PdfMetafileSkia.

Review URL: https://codereview.chromium.org/697373004

Cr-Commit-Position: refs/heads/master@{#302770}

DCHECK can catch a potential driver bug.

Review URL: https://codereview.chromium.org/685003007

Cr-Commit-Position: refs/heads/master@{#302769}

BUG=430373
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/705713003

Cr-Commit-Position: refs/heads/master@{#302768}

BUG=397019

Review URL: https://codereview.chromium.org/676593003

Cr-Commit-Position: refs/heads/master@{#302767}

No functional changes.

BUG=133097
NOTRY=True
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/703753003

Cr-Commit-Position: refs/heads/master@{#302766}

Previously was missing switches to the shim.

BUG=430361

Review URL: https://codereview.chromium.org/702803002

Cr-Commit-Position: refs/heads/master@{#302765}

Cr-Commit-Position: refs/heads/master@{#302764}

Revert of Moving background animation ticking from LayerTreeHostImpl into the Scheduler. (patchset #9 id:460001 of https://codereview.chromium.org/595973002/)

Reason for revert:
Reverting because of failure here http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

Will investigate tomorrow.

Original issue's description:
> Moving background animation ticking from LayerTreeHostImpl into the Scheduler.
>
> Background ticking currently happens in the LayerTreeHostImpl, this makes it very hard to preserve the monotonicity guarantee needed by frame times. http://crrev.com/267783004 set up the scheduler to become the source of background ticks and this CL makes use of that functionality.
>
> BUG=345459
>
> Committed: https://crrev.com/4df3c4366015739a7c6b6c1539a8d7c9198e38ef
> Cr-Commit-Position: refs/heads/master@{#302757}

TBR=danakj@chromium.org,brianderson@chromium.org,skyostil@chromium.org,ajuma@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=345459

Review URL: https://codereview.chromium.org/698413002

Cr-Commit-Position: refs/heads/master@{#302763}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/705673005

Cr-Commit-Position: refs/heads/master@{#302762}

Blink roll 80d183d0f13494ea1c51686c688d0f4d4e81aa81:62ba796b1b0c462746e0362ccdf08d92f8ff1e34 (svn 184821:184849)

TBR=dcheng

Review URL: https://codereview.chromium.org/703843002

Cr-Commit-Position: refs/heads/master@{#302761}

* Move the connection mode into the LogToServer ctor, since it never changes.
* Parse log messages, since we don't have an explicit message for connection type.
* Save the most-recent connection type for any channel, and send it with stats logs (we only know how to parse one connection type field, so this seems like the best we're going to get).

Review URL: https://codereview.chromium.org/689473004

Cr-Commit-Position: refs/heads/master@{#302760}

These will be converted to Chromium style in a follow-on patch.

BUG=133097
NOTRY=True (this fails presubmit because of formatting errors)
R=aelias@chromium.org, boliu@chromium.org

Review URL: https://codereview.chromium.org/704603002

Cr-Commit-Position: refs/heads/master@{#302759}

R=sky@chromium.org

Review URL: https://codereview.chromium.org/705703002

Cr-Commit-Position: refs/heads/master@{#302758}

Background ticking currently happens in the LayerTreeHostImpl, this makes it very hard to preserve the monotonicity guarantee needed by frame times. http://crrev.com/267783004 set up the scheduler to become the source of background ticks and this CL makes use of that functionality.

BUG=345459

Review URL: https://codereview.chromium.org/595973002

Cr-Commit-Position: refs/heads/master@{#302757}

BUG=414571

Review URL: https://codereview.chromium.org/681503002

Cr-Commit-Position: refs/heads/master@{#302756}

Currently only works if --enable-apps-file-associations is on.

The Chrome app appears on the "Open with" menu and "Choose default
program" dialog for files of any type mentioned in the app's manifest.
If there is no existing app associated with the file type, the Chrome
app becomes the default handler.

Upon app installation, creates a copy of the app_shim executable to
serve as a portable and uniquely named way to run the app. Any file
types mentioned in the file_handlers section of the app manifest are
associated with the shim.

BUG=130455

Review URL: https://codereview.chromium.org/181493011

Cr-Commit-Position: refs/heads/master@{#302755}

This change adds an entry to about:flags to control the minimum TLS version as
requested by Darin. This will allow Android and ChromeOS users to reenable
SSLv3 in Chrome 40 if they need to.

Additionally, this gates the SSLv3 disabling with Finch. At the moment the
experiment doesn't actually exist and so will always return the empty string.
However, should we need to, we can define it and put everyone in the Enabled
group.

BUG=427671,419870

Review URL: https://codereview.chromium.org/693963003

Cr-Commit-Position: refs/heads/master@{#302754}

ActivityViewModel has the necessary information that should be displayed to the
user. So provide mechanism for it to be able to update the view when the relevant
information (e.g. title, icon, color) changes.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/694413005

Cr-Commit-Position: refs/heads/master@{#302753}

There were a number of ozone targets that had rusted or never
been implemented in the GN build for Chrome OS. Fix it!

R=cmasone
TBR=brettw
BUG=424334
TEST=build chrome with os=chromeos use_ozone=true use_clang=true

Review URL: https://codereview.chromium.org/705623004

Cr-Commit-Position: refs/heads/master@{#302752}

many-registration.html is failing due to out-of-memory error.

BUG=430232
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/704693002

Cr-Commit-Position: refs/heads/master@{#302751}

This method is identical to ThreadUtils.runOnUiThreadBlocking(), and
ThreadUtils has a variety of helpful variations.

BUG=430226

Review URL: https://codereview.chromium.org/700013002

Cr-Commit-Position: refs/heads/master@{#302750}

This is a small binary that runs Chrome with the given command-line
arguments. It is intended for use with Chrome apps, so that file types
can be associated with the shim, having a custom name (and in some
cases, icon) rather than simply the name of the Chrome binary.

BUG=130455

Review URL: https://codereview.chromium.org/179223003

Cr-Commit-Position: refs/heads/master@{#302749}

BUG=430252

Review URL: https://codereview.chromium.org/703703004

Cr-Commit-Position: refs/heads/master@{#302748}

BUG=430323
TEST=trybot and manual testing of tab casting
R=hclam@chromium.org
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/695643003

Cr-Commit-Position: refs/heads/master@{#302747}

Chrome announces that a DownloadManager is going down before it destroys
its items. This change makes the unit test behave more like chrome does
and makes the metadata manager handle this shutdown order properly.

BUG=389123, 386915, 389643
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/703463006

Cr-Commit-Position: refs/heads/master@{#302746}

The output format is:
vss1;rss1;addr1;symbol1
vss2;rss2;addr2;symbol2
...
The symbol is related to the addr. If the binary file has symbols, it just same as before:function@sourcefile.
Otherwise it will show the pathname the addr belongs to (mainly it's the library).
This new command could be helpful for lcation leaks.

R=kouhei@chromium.org
BUG=427393

Review URL: https://codereview.chromium.org/700773002

Cr-Commit-Position: refs/heads/master@{#302745}

Revert of Roll src/third_party/skia 7a10fb6:a30b2ee (patchset #1 id:1 of https://codereview.chromium.org/690283003/)

Reason for revert:
Likely broke fast/events/hit-test-counts.html layout test.

Original issue's description:
> Roll src/third_party/skia 7a10fb6:a30b2ee
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/7a10fb6..a30b2ee
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
> TBR=egdaniel@google.com
>
> Committed: https://crrev.com/365da31903bcebe7d6d49b802701f7c1a9e112f5
> Cr-Commit-Position: refs/heads/master@{#302662}

TBR=egdaniel@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/701003002

Cr-Commit-Position: refs/heads/master@{#302744}

Cleaned up WebsiteSettingsPopup::updatePageDetails in the PageInfo
dialog and fixed a crash from invalid URLs. When a malformed URL is
accessed, the PageInfo dialog will still display the URL, but won't
apply any custom coloring (this only applies to well-formed URLs).

TEST=Visit a malformed URL, such as 'data:html,foo<script', and open the
PageInfo dialog by long-pressing on the URL. The URL should be displayed
(but not colored), and Chrome should not crash.
BUG=427566

Review URL: https://codereview.chromium.org/690343003

Cr-Commit-Position: refs/heads/master@{#302743}

NOTRY=true
TBR=dtrainor@chromium.org
BUG=400904

Review URL: https://codereview.chromium.org/701983002

Cr-Commit-Position: refs/heads/master@{#302742}

RLZ is using a very convoluted and fragile way to check for
code running as NT/SYSTEM.

- It can fail, which causes a crash
- It is quite slow on domains
- It is incorrect because "SYSTEM" is not the string in some locales.

BUG=428944

Review URL: https://codereview.chromium.org/691913003

Cr-Commit-Position: refs/heads/master@{#302741}

R=cpu@chromium.org

Review URL: https://codereview.chromium.org/697053005

Cr-Commit-Position: refs/heads/master@{#302740}

Per Android media team, width/height is not always reliable. See:
https://github.com/google/ExoPlayer/blob/a7b88cd6a9bac4de5ef47b23e0d7fb50c570b3a6/library/src/main/java/com/google/android/exoplayer/MediaCodecVideoTrackRenderer.java#L319

R=qinmin@chromium.org
BUG=internal b/18224769

Review URL: https://codereview.chromium.org/698273003

Cr-Commit-Position: refs/heads/master@{#302739}

Revert of Implement getPermissionStatus in MockWebPushClient (patchset #3 id:40001 of https://codereview.chromium.org/677073002/)

Reason for revert:
Broke a layout test, push_messaging/push-messaging-api-surface.html.

Original issue's description:
> Implement getPermissionStatus in MockWebPushClient
>
> Required for hasPermission LayoutTests
>
> BUG=401424
>
> Committed: https://crrev.com/84b57b28f4766c4e411e6cc7125fc3400626a9f9
> Cr-Commit-Position: refs/heads/master@{#302722}

TBR=mvanouwerkerk@chromium.org,dcheng@chromium.org,miguelg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401424

Review URL: https://codereview.chromium.org/700993002

Cr-Commit-Position: refs/heads/master@{#302738}

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/699263002

Cr-Commit-Position: refs/heads/master@{#302737}

Set android_browser_finder.psutil to None in tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py to avoid flakiness

BUG=426604

Review URL: https://codereview.chromium.org/667423003

Cr-Commit-Position: refs/heads/master@{#302736}

BUG=425176

Review URL: https://codereview.chromium.org/698203005

Cr-Commit-Position: refs/heads/master@{#302735}

BUG=426561,408752
TEST=None

Review URL: https://codereview.chromium.org/693643004

Cr-Commit-Position: refs/heads/master@{#302734}

unit_tests do not have prefs, but branded builds on Chrome OS attempt to read
the brand code out of a null g_browser_process->local_state().

Instead, we now return an empty brand code in tests.

This reduces the number of crashing unit_tests on the official builders from
~300 to ~30.

BUG=430266

Review URL: https://codereview.chromium.org/703623005

Cr-Commit-Position: refs/heads/master@{#302733}