GitLab

TBR=fsamuel@chromium.org

BUG=none

Review URL: https://codereview.chromium.org/408893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284690 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to mock_color_chooser.

BUG=331299

Review URL: https://codereview.chromium.org/404373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284689 0039d316-1c4b-4281-b951-d872f2087c98

Enforce SafetyMode for YouTube if prefs::kForceSafeSearch is on, by modifying (or adding) YouTube's PrefCookie in the HTTP header.

This is essentially a followup to https://codereview.chromium.org/11186002/

Note: This is a fixed reland of crrev.com/282546 / https://codereview.chromium.org/354183002/ which was reverted due to a bug in ParseRequestCookieLine.

TBRing since it has already been reviewed in the first try.

TBR=erikwright@chromium.org

BUG=344815

Review URL: https://codereview.chromium.org/388823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284687 0039d316-1c4b-4281-b951-d872f2087c98

Add completion callback as a parameter of PromoteDemotedChanges.
This is mainly for tests to wait for the completion of the operation.

BUG=344769
TEST=unit_tests --gtest_filter='DriveBackendSyncTest.*'

Review URL: https://codereview.chromium.org/407073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284686 0039d316-1c4b-4281-b951-d872f2087c98

Improved gesture output.

Review URL: https://codereview.chromium.org/409563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284685 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/393693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284684 0039d316-1c4b-4281-b951-d872f2087c98

This CL extracts the GetLanguageList(), GetAcceptLanguageList and
GetLoginKeyboardLayouts() methods from NetworkScreenHandler to a helper
file. The methods will be reused by SigninScreenHandler to implement a
language and keyboard layout picker for public session pods.

BUG=214904,241790
TEST=Updated and extended unit tests

Review URL: https://codereview.chromium.org/397723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284683 0039d316-1c4b-4281-b951-d872f2087c98

Extracted LoginEventRecorder from BootTimesLoader to loose dependecies.

BUG=387613
R=nkostylev@chromium.org
TBR=bauerb@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/391373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284682 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This broke build:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/419

With error:
/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__dbg__2_/build/src/out/Debug/app_shell_browsertests: symbol lookup error: /mnt/data/b/build/slave/Linux_ChromiumOS_Tests__dbg__2_/build/src/out/Debug/lib/libmedia.so: undefined symbol: Ebml_Serialize

Original issue's description:
> Clean up. Experimental user avatars removed.
> 
> BUG=387738
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284666

TBR=scherkus@chromium.org,nkostylev@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=387738

Review URL: https://codereview.chromium.org/411523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318770
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/235953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284675 0039d316-1c4b-4281-b951-d872f2087c98

Ensures that buffer received from the java side are correctly aligned.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/405893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284672 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where the clipping window would get a focus event
when the SadTab was displayed causing the focus to be set to nothing,
disabling all keyboard shortcuts.

This is fixed by making the clipping window nonfocusable.

BUG=393119

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284177

Review URL: https://codereview.chromium.org/397493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284670 0039d316-1c4b-4281-b951-d872f2087c98

This fixes building "all" on non-ARM platforms.

TBR=ben@chromium.org
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/404353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284669 0039d316-1c4b-4281-b951-d872f2087c98

Since upgrading the builder to 10.8, it never failed again.

BUG=370551
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/401103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284668 0039d316-1c4b-4281-b951-d872f2087c98

The ProfileManager can call its callback (which points to CreateProfileHandler::OnProfileCreated) with a NULL profile (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/profiles/profile_manager.cc&l=397). This case was not handled in CreateProfileHandler::ShowProfileCreationError.

BUG=395558

Review URL: https://codereview.chromium.org/405883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387738

Review URL: https://codereview.chromium.org/395133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284666 0039d316-1c4b-4281-b951-d872f2087c98

It is flakey on win bots.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/15075
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30300

TBR=achuith@chromium.org
NOTRY=true
BUG=394454

Review URL: https://codereview.chromium.org/406233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284665 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This patch seems to make following browser_tests flakey

PPAPINaClNewlibTest.Graphics2D_FlushOffscreenUpdate
NetInternalsTest.netInternalsHSTSViewAddOverwrite
NetInternalsTest.netInternalsHSTSViewAddDelete
NetInternalsTest.netInternalsHSTSViewAddTwice

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34734
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32086
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/47545


Original issue's description:
> This is jamesr@ code I am landing.
> 
> On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it was buggy:
> 
> 1- A short task that was not followed by any other task will leave the systemwide timer pegged to 1ms
> 
> 2- After we decided to crank up the timer we would 'lease' the timer for 1 second, for no good reason.
> 
> Both issues are detrimental to battery power.
> 
> The source of both problems is that we tried to decide with incomplete information. This patch solves that by having 1 bit for each pending task that requires a high resolution timer and a sum of the number of tasks that require high res timers.
> 
> BUG=153139
> TEST=included here, also see the bug for manual testing.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284625

TBR=jamesr@chromium.org,darin@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=153139

Review URL: https://codereview.chromium.org/407073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284664 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284663 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/412433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284662 0039d316-1c4b-4281-b951-d872f2087c98

The blink roll contains a fix to the problem, but is stale at the moment.

BUG=395882
TBR=jochen@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/405413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/404913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284660 0039d316-1c4b-4281-b951-d872f2087c98

The format of dumpsys batterystats has changed. This CL updates the
parsing.

Review URL: https://codereview.chromium.org/402153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284659 0039d316-1c4b-4281-b951-d872f2087c98

VideoFrame based on StreamTexture is reused on many frames. However, clients (e.g.
compositor, WebGL) inserts a sync point every frame. So VideoFrame on Android
can keep several mega byte sync points unnecessarily.

This CL makes VideoFrame keep only one sync point. When a client set new sync point
to VideoFrame and VideoFrame already keeps the sync point of another client, VideoFrame
waits the previous sync point before inserting a new sync point. A client must provide
a VideoFrame::SyncPointProvider so that VideoFrame can insert or wait a sync point.

BUG=350925

Review URL: https://codereview.chromium.org/312803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284658 0039d316-1c4b-4281-b951-d872f2087c98

The sandbox policy is too restrictive.

BUG=395578
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/408813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389319

Review URL: https://codereview.chromium.org/404273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284655 0039d316-1c4b-4281-b951-d872f2087c98

In Gallery, the size of the slide image's canvas is scaled by
window.devicePixelRatio. For example, if the devicePixelRatio is 2, the doubled
size canvas is prepared and it is scaled to displaying size so that the pixels
of canvas fit to the device pixels.

Previously the canvas is scaled by using CSS transformation. Thus the element
position is calculated by the original canvas size, and then it is scaled. This
makes the position calculation of canvas complex, and it was regressed at the
crrev.com/398263002.

At this CL, canvas is scaled by using CSS width/height property instead of
bringing back the complex position calculation.

BUG=395062
TEST=manually

Review URL: https://codereview.chromium.org/402863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284654 0039d316-1c4b-4281-b951-d872f2087c98

The unit test failure indicates a serious Document leak, where all
WebCore::Document loaded in Chrome is leaking.
This CL adds warning comments to the baseline to avoid regressions.

BUG=392121
NOTRY=true

Review URL: https://codereview.chromium.org/393123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284653 0039d316-1c4b-4281-b951-d872f2087c98

Increase performance of RenderPass drawing in compositor and Video-WebGL copy.

BUG=375501

Review URL: https://codereview.chromium.org/371463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284652 0039d316-1c4b-4281-b951-d872f2087c98

In bot mode, test_launcher would normally retry tests up to 3 times.
This is sufficient to keep large test suites like browser_tests under
1% flakiness rate if the flakiness of individual tests is also within
1%. However, some tests especially in browser_tests are up to 33%
flaky, making the browser_tests suite 40% flaky.

Subsequent top-level retries effectively double the runtime of all
bots running these tests, and we need a solution to shorten the try
job runtime.

A longer-term solution is the ignorer bot (see the bug), but until
it's deployed, a quick hack is to increase the number of retries so
statistically we should see about 1% flakiness of browser_tests at the
expense of a slight runtime increase.

R=sergiyb@chromium.org
BUG=390600, 395189

Review URL: https://codereview.chromium.org/393283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284650 0039d316-1c4b-4281-b951-d872f2087c98

It currently just uses 1.0. Instead, fetch it with
ui::GetScaleFactorForNativeView and invalidate it when the scale factor
changes.

This is a small fix for a simple HiDPI bug, but eventually we will be
able to scrap CachedLabel: The performance improvement it offers will be
redundant with http://crbug.com/240037.

BUG=368493

Review URL: https://codereview.chromium.org/405373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284649 0039d316-1c4b-4281-b951-d872f2087c98

Originally, AppListDialogContentsView extended WidgetDelegate directly,
and was not being detected as a dialog correctly on some platforms.
Updated AppListDialogContentsView to now be a DialogDelegate.

BUG=388637

Review URL: https://codereview.chromium.org/405873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284648 0039d316-1c4b-4281-b951-d872f2087c98

This matches current definition in the design doc[1] and unifies phase name between Chromium and Blink. Telemetry already expects both "i" and "I" values [2].

It used to be "I" in Chromium but it was changed in https://chromiumcodereview.appspot.com/12252058/

[1] https://docs.google.com/a/chromium.org/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit#
[2] https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/timeline/trace_event_importer.py&q=%22elif%20phase%20==%20'I'%20or%20phase%20==%20'i':%22&sq=package:chromium&type=cs&l=252

BUG=None

Review URL: https://codereview.chromium.org/399423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284644 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284643 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/405313002/)

Reason for revert:
See https://code.google.com/p/chromium/issues/detail?id=395882

The reason for the test failures in blink has been fixed with the last blink roll.

Original issue's description:
> Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/407733005/)
> 
> Reason for revert:
> Seems to be causing xss-DENIED-method-with-iframe-proto.html to time out on multiple bots; see http://crbug.com/395882 .
> 
> Original issue's description:
> > Update V8 to version 3.28.30 (based on bleeding_edge revision r22489).
> > 
> > Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.
> > 
> > TBR=svenpanne@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284420
> 
> TBR=svenpanne@chromium.org,machenbach@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284572

TBR=svenpanne@chromium.org,pkasting@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/411453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284642 0039d316-1c4b-4281-b951-d872f2087c98

Also removes the unused tpm_token_name_ member from TPMTokenLoader.

BUG=NONE
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/408853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284641 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284640 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/409583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284639 0039d316-1c4b-4281-b951-d872f2087c98

When an X.509 certificate appears invalid because it is expired or not yet 
valid, but we have reason to believe the clock is wrong, help users find out 
how to fix their clock.

A future CL will run a check for the time at startup (and periodically
after?) and raise an infobar with similar functionality, as well.

BUG=349653

Review URL: https://codereview.chromium.org/397713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284638 0039d316-1c4b-4281-b951-d872f2087c98

The api will be used by Easy Unlock component app. Currently it contains
methods needed for establishing secure communication channel on top of
(unprotected) bluetooth.

BUG=390230

Review URL: https://codereview.chromium.org/391513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284637 0039d316-1c4b-4281-b951-d872f2087c98