- 13 Jul, 2019 4 commits
-
-
danakj authored
TBR=perezju@chromium.org Bug: 983326 Change-Id: I22be996f9054935f378a05b95f7f7924a9c5f63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699097Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#677130}
-
Alex Cooper authored
Per feedback on the spec and updates to the comments about what an origin actually is, the API method names and dictionary values were updated from localToFloorTransform to the more accurate floorOrigin. The current usage of these items actually matches the new name and therefore were previously improperly named. Bug: 979316 Change-Id: I9deedf9cf25e804135251b8e20a30d89f0eb6276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700176 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#677129}
-
Marijn Kruisselbrink authored
It probably would be nice to support more than just chrome's set of well known types, but this at least is better than nothing. Bug: 962306 Change-Id: Ie337742f4c105fd83b1a8cb30dedba9d47ce97e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700332 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#677128}
-
Brian Sheedy authored
Adds a small section to the GPU Skia Gold Markdown documentation explaining how to find a failed swarming task for a bad image in the rare case that a bad image is found without a link to the failed build. Bug: 965234 Change-Id: I257c95ed686f8b6902bd0739b9a1bb93054906f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700293Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#677127}
-
- 12 Jul, 2019 36 commits
-
-
Istiaque Ahmed authored
This CL exercises user gesture code with an actual API (management.uninstall) that requires user gesture. The test makes one extension uninstall another extension via management.uninstall API. The test runs as both event page and Service Worker based extension. Bug: 977629 Test: None, test only change to improve SW test coverage. Change-Id: I21b9fadd14d035909b6fbe4c310e94cd1e9e375e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696239Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#677126}
-
David Benjamin authored
It's not possible for &nested_connect_job_->connect_timing() to be null. This is a remnant of before the socket pools were flattened. Now SSLConnectJob always gets fresh transport sockets. Change-Id: Ib7a680af8ce72d86d1b6fd6e7e03e4bbd8a17e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696001 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#677125}
-
Mitsuru Oshima authored
Bug: 983397 Test: ash_ui_perftests passes without dcheck Change-Id: I8dd2bb38f010d340f9be520f9e208267622559a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700567Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#677124}
-
Yusuf Ozuysal authored
This adds a static call for SuspendedTab.isShowing similar to that of SadTab to make sure we don't call getUserData() on destroyed tabs. BUG=973625 Change-Id: Ib16f1991489bdf16129ac568293b0b895bb871ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700478 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#677123}
-
Antonio Gomes authored
CL [1] is moving content/renderer/media/stream/webmediaplayer_ms.cc to Blink. This means that gpu/command_buffer/client/shared_memory_limits.h will get indirectly included/built as part a Blink GN target, which has more strict compiler policies than some other modules of Chromium. For completeness, gpu/command_buffer/client/shared_memory_limits.h gets pulled in indirectly by webmediaplayer_ms.cc -> services/viz/public/cpp/gpu/context_provider_command_buffer.h -> gpu/command_buffer/client/shared_memory_limits.h This CL fixes a compilation triggered as part of the move above [2]. [1] https://crrev.com/c/1698170 [2] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8908110892227907632/+/steps/compile__with_patch_/0/stdout BUG=704136 Change-Id: I77d0716bc61fc94b314f4adc95a85624e3ee955d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698442 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#677122}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7ec4f5000381f247eca61741423799be155a0bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677121}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 786a9810. With Chromium commits locally applied on WPT: bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" 9c7e7252 "Add slotting for toast action buttons, alongside test scaffolding for future action testing." 19f78e3e "Reland: [shapedetection] Add some shapedetection tests" 2d2a3ba4 "Cross-scheme initiator should result in `Sec-Fetch-Site: cross-site`." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I4c1ccd3696d5e89689cb3217ba44a0f5d82f4e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700336Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677120}
-
Chris Lu authored
Moves delegate for InfobarBadgeTabHelper from LocationBarMediator to BadgeMediator. LocationBarViewController now implements the BadgeConsumer protocol to receive signals from BadgeMediator. LocationBarViewController's implementation of BadgeConsumer looks odd, because it still only supports one badge. Ultimately a separate view controller owned by BadgeCoordinator will be the BadgeMediator's consumer. Bug: 976901 Change-Id: Ifa0eec1796e0436188af25d06e73f0ba3e1eb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690719 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#677119}
-
Mario Sanchez Prada authored
Similarly to what has been done already for blink::InterfaceProvider[1] and service_manager::InterfaceProvider[2], in order to help with the transition to the new Mojo types, let's add three more templated methods to the class blink::InterfaceRegistry that enable calling the AddInterface() and the AddAssociatedInterface methods passing a Pending{Associated}Receiver<T> as parameter. This will be useful in cases relying on the InterfaceRegistry's API to add interface factories using the new Mojo types, as it's the case for instance for the FindInPage class (see [3]). [1]https://cs.chromium.org/chromium/src/third_party/blink/public/platform/interface_provider.h?l=28 [2]https://cs.chromium.org/chromium/src/services/service_manager/public/cpp/interface_provider.h?l=98 [3]https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/find_in_page.cc?l=55 Bug: 980151 Change-Id: I994d0d28c884f5500ac4f82a5592f16c824f8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697486 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#677118}
-
Ben Kelly authored
We saw a flake on fuschia where DelayedBackend.OpenEntryContinue() failed. The only way I can see this happening is if we get to disable the delayed mode before the OpenEntry() is actually called. This CL tries to avoid this condition by explicitly waiting for OpenEntry() to be called before proceeding with the rest of the test. Bug: 928368 Change-Id: I782fab81605524ee2bd7126fd78ebc4416825f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698131 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#677117}
-
Ben Kelly authored
Bug: 960012 Change-Id: I699994fc926123fb448dc73993bdd73b32561616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699703 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
John Chen authored
TBR=crouleau@chromium.org NOTRY=true Bug: 983728 Change-Id: Id54a27c11f87b8471a476f629f62d9e21098f39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700378 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#677115}
-
Kyle Milka authored
Bug: 937570 Change-Id: I03a33767498591dbe4c72594253766227659c809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700175 Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#677114}
-
Karan Bhatia authored
This CL resolves a race where multiple threads can access the default policy host restrictions. This can lead to crashes in the wild. Fix this by controlling access to the default policy host restictions via a global lock. BUG=978407 Change-Id: Ic5d5f4e42980017f4e0b4d56b1f4d9f79983223a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700323 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677113}
-
Kyle Milka authored
Increase the bottom margin by 9px. This prevents shifting of page contents in dark mode. before: http://screen/AF6E8KpyjxM.png after: http://screen/7RFWj2Qv87k.png Bug: 983457 Change-Id: I70d5cf81d2650829d1bc3121e5fbeb251a6420eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699687 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#677112}
-
Marijn Kruisselbrink authored
Exposes FrameTreeNode::HasTransientUserActivation to //chrome by adding a method for it to content::RenderFrameHost, and use that to make sure to only show permission prompts after user activation. Also duplicate the renderer-side user activation check for showing a file picker in the browser process just in case. Bug: 983656 Change-Id: I903a5d09409a7e995574bdf974012ffa1979988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699800Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#677111}
-
Darwin Huang authored
There were some broken/redirected links in comments, so just updating them. Comment-only change. Change-Id: I45765b558fd03e20381c7cd7b328e3bdc9ba12dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700470 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#677110}
-
Justin DeWitt authored
Previously the internals overrides only worked for ENABLED variant. Bug: NONE Change-Id: Ia0abff7a164318ccb9e06f89d5566e3d68f503fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700471Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#677109}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb59c3177b6c..587f1feeee31 git log cb59c3177b6c..587f1feeee31 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 debrian@google.com Fix Presubmit Infra Failure tests Created with: gclient setdep -r src/third_party/depot_tools@587f1feeee31 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If7cb6dd71256f27dcca1cd4b49a16ff082a6b292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700338Reviewed-by:
-
Mike Frysinger authored
We need to convert numeric strings ids into numbers, but the integer is too large for int() on Python 2. Add an alias for long=int so we can keep using long() in both environments. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Ied5c18f457e4ee499f5697f54621eb72fe15f7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700481 Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#677107}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/4bd052d7e8b0..53e280b56866 $ git log 4bd052d7e..53e280b56 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 cmumford Simplify unlocking in DeleteObsoleteFiles. 2019-06-12 cmumford Add "leveldb" subdirectory to public include paths. 2019-06-12 cmumford Ending sentences with periods in README.md. 2019-06-12 costan Align EnvPosix and EnvWindows. 2019-06-12 costan Disable exceptions and RTTI in CMake configuration. 2019-05-28 costan Replace "> >" with ">>" 2019-05-28 costan unsigned char -> uint8_t 2019-05-24 costan Use GCC 9 on Travis CI 2019-05-22 cmumford Add explicit typecasts to avoid compiler warning. 2019-05-15 cmumford Guard DBImpl::versions_ by mutex_. 2019-05-13 cmumford Converted two for-loops to while-loops. 2019-05-09 cmumford Switch to using C++ 11 override specifier. 2019-05-09 cmumford Added unit test for InternalKey::DecodeFrom with empty string. 2019-05-08 cmumford Using std::ostringstream in key DebugString. 2019-05-07 costan Fix EnvPosix tests on Travis CI. 2019-05-06 cmumford Formatting changes for prior O_CLOEXEC fix. 2019-05-06 costan Clean up util/coding.{h,cc}. 2019-05-06 cmumford Initialize Stats::start_ before first use in Stats::Start(). 2016-04-08 allangj1618 Add argument definition for void c functions. 2018-09-19 adam.azarchs Add O_CLOEXEC to open calls. 2017-03-10 18814092650 fix comment 2016-10-03 proller broken db: fix assertion in leveldb::InternalKey::Encode, mark base as corrupt 2016-06-21 sjingivan set const property 2016-06-20 sjingivan reduce lock's range in DeleteObsoleteFiles Created with: roll-dep src/third_party/leveldatabase/src Change-Id: Id15df59ee9c3acbf9430ef959e6d90fd7e48d1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700161 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#677106}
-
Ian Kilpatrick authored
Legacy/WebKit have a "interesting" behaviour for empty-inlines in that they determine the static position of any (inline-level) OOF-positioned nodes as if they were in the block-level context. Other browsers do the following (testcase): https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=7055 FF - all inline-level Safari/Legacy - all block-level Edge - block-level for default/block-level NG (prior to this change) - inline-level for default/inline-level. This change makes the "default" e.g. a node with just floats/OOFs as block-level to pick up this static position behaviour. This matches the EdgeHTML behaviour. Bug: 980908 Change-Id: Ifb92bf7e34ada669fa16a1ee5f9e9edaf4546768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696345 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#677105}
-
Kristi Park authored
Change height to an odd number in order to prevent zoom errors. Screencast: https://drive.google.com/open?id=19PQRefc1jZEeHMypMjKi0Ljo8VTMl6Af Bug: 983465 Change-Id: I3e917085be1a6dde79b4c937af848fabf3f99304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700382 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#677104}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/375ddfc5992d..6c90ebb078b8 git log 375ddfc5992d..6c90ebb078b8 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 geofflang@chromium.org glTexStorage3D: Disallow compressed formats on GL_TEXTURE_3D targets. 2019-07-12 courtneygo@google.com Vulkan: Upload packed depth-stencil Created with: gclient setdep -r src/third_party/angle@6c90ebb078b8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:983142 Change-Id: Iaf223d6c3a237d89dafc46d64337a7ed9449b78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700368Reviewed-by:
-
danakj authored
TBR=aboxhall@chromium.org Bug: 983709 Change-Id: Ic36b99daa624d37eb2a2cebc1d121015c6a7a1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700545Reviewed-by:
-
ssid authored
The unwinder uses module cache on Android to get module ids. Change-Id: Iec80ae7f77581ce45d96a9f2b5d5585c3d1a7bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699305 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#677101}
-
Robert Sesek authored
The API allows the creation of executable shared memory, which should be restricted to the sole client (NaCl) until it can be removed entirely. Bug: 982879 Change-Id: Ib89a34da7e20de0ac8e984f0ccf0e8109d6d8338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700114Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#677100}
-
Tatiana Buldina authored
Change-Id: I30357ac8aa6e59501da5280086e52c83a637b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700383Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/71b0b56a4914..9fad38a65ee5 git log 71b0b56a4914..9fad38a65ee5 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 chrome-bot@chromium.org Update config settings by config-updater. 2019-07-12 miahsanchez@google.com vm_unittest: tests for removing and creating directory. 2019-07-12 gbiv@google.com cbuildbot: add toolchain owners for toolchain bits Created with: gclient setdep -r src/third_party/chromite@9fad38a65ee5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ia3c3bf64bf79e288cfa492c82fa044ad403393e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700424Reviewed-by:
-
Bruce Long authored
This change implements native caret browsing. In caret browsing, a moveable cursor is placed on a web page, allowing a user to select and navigate through non-editable text with just a keyboard. The changes on the renderer process side are those needed to make the caret visible and moveable in non-editable text when caret browsing is enabled, move the focus when the caret moves into a focusable element such as an anchor, and move the caret to the active element on initiating navigation if not already there. For the initial landing of caret browsing, no UX is exposed to the user for toggling caret browsing on and off (using F7 as in other browsers e.g.), nor are there any means exposed on about:flags to enable the feature. Instead caret browsing is enabled on browser launch via a command line parameter, similar to the current behavior of the spatial navigation feature: chrome --enable-caret-browsing All new tabs created during the browser session will have caret browsing turned on. To fully land the feature in a later CL would require implementing the following UX elements as well: 1) Adding the F7 (or other appropriate key) as an accelerator to toggle caret browsing on and off. 2) Creating a caret browsing dialog confirming with the user that caret browsing should be toggled on or off. 3) Adding two new browser settings: one indicating if caret browsing is currently enabled, and another that indicates if pressing F7 should trigger a confirmation dialog or just enable/disable caret browsing without confirmation. 4) Plumbing a mechanism for passing the "caret browsing is enabled" setting from the browser process to renderer processes. 5) Adding a flag for this feature to "about:flags", exposing a means for the user to enable or disable the feature without a command line flag. Note that these UX elements were already implemented in earlier patchsets of this CL--see patchset 18 as the last patch before their removal. Separating the feature implementation into multiple CLs allows early experimentation of the renderer side changes and accounts for the possibility that different browsers may opt for a different UX. Bug: 977390 Change-Id: I1906165037c96079d7bec70683f3cc446580f56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666567 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#677097}
-
Bryan McQuade authored
This change removes the LayoutInstabilityMoveDistance runtime enabled feature flag, and updates the LayoutShiftTracker to incorporate move distance into the score calculation by default. Change-Id: I5c4e12ed5c3f4a0c710df1fe8c8ec4e73875fe47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694187Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#677096}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/214323b343e9..4d94b5d9ba73 git log 214323b343e9..4d94b5d9ba73 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 rmhasan@google.com Revert "Reland "[Telemetry] Integrate new test expectations format into telemetry benchmark runner"" 2019-07-12 rmhasan@google.com Reland "[Telemetry] Integrate new test expectations format into telemetry benchmark runner" 2019-07-12 brucedawson@chromium.org Improve system tracing failure error message 2019-07-12 dproy@chromium.org Add jpeg-js decoder third party Created with: gclient setdep -r src/third_party/catapult@4d94b5d9ba73 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:97396,chromium:97396,chromium:604301,chromium:980973 TBR=zhanliang@google.com Change-Id: I15fb108ef6c6cad378b4c852adc795b28ab54049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700433Reviewed-by:
-
Gabriel Charette authored
[ScopedTaskEnvironment] Fix UBSan issue calling a member method from ScopedTaskEnvironment's initializer list TBR=fdoray@chromium.org Bug: 946657, 983290 Change-Id: I3e83611141f364b1d7e3a42442d896bdf6956877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700269Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#677094}
-
Kristi Park authored
- Add aria-roles for the sidebar and submenus that indicate these are tab panels. - Use aria-pressed for shortcut options and aria-selected for sidebar buttons to indicate if they are currently selected. - Add aria-labels for submenu and shortcut elements. Bug: 953822 Change-Id: I0a0842378b0d164b5e8610a40d933d792073911f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696763Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/851f501318ec..cb26647b6851 Created with: gclient setdep -r src-internal@cb26647b6851 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: Ibcce9940385d3c0551f72c3ac30c59fb5e1af533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700367Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677092}
-
Mark Pearson authored
This reverts commit f1ddcc97. Reason for revert: The Mac10.13 Tests (dbg) bot been consistently failing webkit_layout_tests since this change/tests were submitted. The first run with the change is this run: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/13007 The failures are all deterministic timeouts to the tests * http/tests/virtual-scroller/find-element-62-10px.html * http/tests/virtual-scroller/find-element-63-10px.html * http/tests/virtual-scroller/find-element-64-0px.html * http/tests/virtual-scroller/find-element-64-10px.html * http/tests/virtual-scroller/find-element-65-10px.html * http/tests/virtual-scroller/find-element-66-10px.html https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/13007/webkit_layout_tests/layout-test-results/results.html Original change's description: > Add a virtual-content element that uses display locking to make content > low cost when off-screen. > > Exposes .mjs files as http-available files for web_tests. This required > adding .mjs to the mime config and various things in BUILD files. > > Add .mjs as javascript to the mime configs for webtest server. > > Delete old virtual-scroller code. > > Bug: 979108 > Change-Id: Idfde0bb23263b571fc3abf98845bb7d0327baf07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680170 > Commit-Queue: Fergal Daly <fergal@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676308} TBR=tkent@chromium.org,tikuta@chromium.org,domenic@chromium.org,fergal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979108 Change-Id: Ib3e2cd9e2deea6859fb716796e1919383915c9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700174Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#677091}
-
