- 07 Nov, 2018 40 commits
-
-
Charlie Harrison authored
Currently code on the UI thread checks to see if the RDH is available, then posts a task to it on the IO thread. By the time the IO task is posted, the RDH could be shut down or even destroyed. This CL makes some of the UI -> IO hops from RenderViewHost do all the shutdown checking on the IO thread. Bug: 901468 Change-Id: I5077e70200b0da2824d1d0c1128d5d0ac614cd66 Reviewed-on: https://chromium-review.googlesource.com/c/1323409Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#606120}
-
Sebastien Marchand authored
Change-Id: Idba500f31b9d3a0dc435ed8d55e31d05dec61cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1323569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#606119}
-
Rayan Kanso authored
Spec: https://wicg.github.io/background-fetch/#background-fetch-update-ui-event-update-ui Bug: 901909 Change-Id: Ia319cd03e41e65c5a6a1f5e61cde6f4ae7705a32 Reviewed-on: https://chromium-review.googlesource.com/c/1320330 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606118}
-
David Tseng authored
It is possible that, before performing an action, the ARC++ container crashed. Ensure that we don't also crash Chrome by dereferencing nullptr. Bug: 902107 Change-Id: I09de402a41dfead09cee4685bc610a227740f9a5 Reviewed-on: https://chromium-review.googlesource.com/c/1318740 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#606117}
-
Charlie Harrison authored
This CL does two major things: 1. Plumb information to //content about whether a navigation is an "opener navigation". That is, is the initiator navigating its opener. 2. Armed with the "opener_navigation" bit, we can apply a policy to navigations to tell them to disallow downloads for opener navigations. This entails changing a boolean "allow_downloads" in CommonNavigationParams to an enum, which enumerates out the reason why the download was blocked (opener, view source, interstitial, etc). In navigation logic, we can start logging some metrics to get a sense for how often opener navigations actually end up being downloads. Ideally, numbers will be low and we can deprecate this behavior. If numbers are still high, we can relax this restriction. Two possible relaxations: a. Allow navigations resulting in downloads if the initiator is same-origin with the opener. b. Allow navigations resulting in downloads if the initiator has a user gesture. For now, we merely collect some UMA to see how prevalent this case is, for evidence in a deprecation / intervention. Bug: 632514 Change-Id: I9231a071ef9362d038c59bbdf3469ce4e227605e Reviewed-on: https://chromium-review.googlesource.com/c/1316167 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
agrieve authored
This reverts commit 2fc9f6f2. Reason for revert: Test is still very flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_shell_test_apk&tests=org.chromium.content.browser.TracingControllerAndroidImplTest%23testBufferUsage Original change's description: > tracing: Address TracingControllerAndroid test failures. > > Fixes the flakiness of buffer usage / known categories tests by > resolving an accidental race condition. Also restricts disabling > the other two tests to <= kitkat devices since those seem to be > the only ones that show (inexplicable) flakiness. > > TBR=yfriedman@chromium.org > > Bug: 899894 > Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1307433 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604209} TBR=yfriedman@chromium.org,skyostil@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899894 Change-Id: Ie47cf56e05861069e1b0a767138b1802f1a2584f Reviewed-on: https://chromium-review.googlesource.com/c/1323894Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#606115}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/436c9f1a8887..28f76deac908 git log 436c9f1a8887..28f76deac908 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 tsepez@chromium.org Use --no-expose-wasm flag in PDFium tests. Created with: gclient setdep -r src/third_party/pdfium@28f76deac908 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If427ca2e93f37f6622935d5cc015b9695840cac9 Reviewed-on: https://chromium-review.googlesource.com/c/1323613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606114}
-
Daniel Bratell authored
The using namespace construct is disallowed in the code style guide. It also causes issues (compilation warnings turned into errors) in jumbo builds since they will be in a "header context" there which is explicitly blocked by our compiler settings. This patch also has a bit of a feature creep to remove a number of unnecessary static_casts that made the code hard to read, especially with the namespaces. Change-Id: Icaa4968695a6f033868aac681a9ebe08eee75c3e Reviewed-on: https://chromium-review.googlesource.com/c/1320131 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#606113}
-
Eric Roman authored
This aligns Chrome's behavior with the Windows and macOS proxy resolvers (but not Firefox). Concretely: * localhost names (as determined by net::IsLocalhost) now implicitly bypass the proxy * link-local IP addresses implicitly bypass the proxy The implicit rules are handled by ProxyBypassRules, and it is possible to override them when manually configuring proxy settings (but not when using PAC or auto-detect). This change also adds support for the "<-loopback>" proxy bypass rule, with similar semantics as it has on Windows (removes the implicit bypass rules for localhost and link-local). The compatibility risk of this change should be low as proxying through localhost was not universally supported. It is however an idiom used in testing (a number of our own tests had such a dependency). Impacted users can use the "<-loopback>" bypass rule as a workaround. Bug: 413511, 899126, 901896 Change-Id: I263ca21ef9f12d4759a20cb4751dc3261bda6ac0 Reviewed-on: https://chromium-review.googlesource.com/c/1303626 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#606112}
-
Pavol Marko authored
Ensure that the OobeWebViewDialog is the WebContentsDelegate for the WebContents used in views-based sign-in/OOBE. This fixes camera access by SAML providers on the sign-in screen, because the versions of CheckMediaAccessPermission/RequestMediaAccessPermission forwarding to MediaCaptureDevicesDispatcher are invoked again. Move focus/keyboard handling from OobeUIDialogDelegate to OobeWebViewDialog to make changing the delegate unnecessary. Background: WebDialogView usually acts as the WebContentsDelegate for the WebContents it embeds. CL:1178111 introduced the subclasss OobeWebDialogView which customizes the WebContentsDelegate handling to allow media requests. CL:1197785 then exchanged the WebContents' delegate altogether to implement keyboard/focus handling, orphaning the functions introduced in CL:1178111. This CL moves the keyboard/focus handling to the OobeWebDialogView and restores its function as WebContentsDelegate. Bug: 900323 Test: out/Default/browser_tests --gtest_filter=*SAMLPolicy*Test*TestLoginMedia* Change-Id: I6c12b8b08efaa71a9f9cbb93d674448cdccbdeaf Reviewed-on: https://chromium-review.googlesource.com/c/1323075 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#606111}
-
Dave Tapuska authored
Initially shipped in M65 this feature flag can be removed. BUG=650433 Change-Id: I2088238be14ec263e2bb81dc0cb9730438315cb2 Reviewed-on: https://chromium-review.googlesource.com/c/1323891Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606110}
-
Jun Choi authored
When Bluetooth security keys change state from non-pairing mode to pairing mode, Bluetooth device ID (and corresponding authenticator id) is changed for security reasons. Currently this is handled by the UI by removing the authenticator from the UI list and re-adding a authenticator with an updated id. This is not ideal, as this may cause UI to flicker. Introduce OnAuthenticatorIdChanged() to AuthenticatorListObserver so that authenticator id can be changed without invoking unnecessary UI changes. Bug: 877344 Change-Id: I9f3328c4b7121864e4e9adfe4567c4e134e3b5a4 Reviewed-on: https://chromium-review.googlesource.com/c/1319673 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#606109}
-
Katie Dillon authored
Change-Id: I4fa7924db8e6ba4e7642957399e0e47289027e97 Reviewed-on: https://chromium-review.googlesource.com/c/1318390Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#606108}
-
Eric Aleshire authored
1) I found in tapOnTarget, calling WebViewScrollElementToVisible then WebViewTapElement is fragile for some reason. Debugging seems to hint it's a race condition, where sometimes the window is not redrawn (despite reporting that the new element is on screen), causing an incorrect hitbox to be reported for the target element and misclicks to occur. Adding a 0.1s delay resolved those issues for me, and I will confirm it is stable on waterfall after landing. It is a little clumsy, but think it is plenty fine while investigating this further. 2) Not sure why, but target.getAttribute('placeholder') isn't working for me anymore. After inspecting the HTML source for some target sites, return target.placeholder; seemed to be a good fix. Change-Id: Idf0bf0aca31578fc6ef0b18daa869cfba4b0160b Reviewed-on: https://chromium-review.googlesource.com/c/1320751Reviewed-by:Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#606107}
-
Randy Rossi authored
Updates automation code to keep up to date with recent refactoring in chrome tree. Bug: None Test: Manual Change-Id: I56d77ce1a891b155d9374aed9b9690c2782159df Reviewed-on: https://chromium-review.googlesource.com/c/1315702Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606106}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c238958c1ca3..d5ee1c6aed6c git log c238958c1ca3..d5ee1c6aed6c --date=short --no-merges --format='%ad %ae %s' 2018-11-07 metzman@chromium.org cros_fuzz: Create helper script for fuzzer development 2018-11-07 derat@chromium.org portage_util: Set has_test for cros-go and tast-bundle. 2018-11-07 bpastene@chromium.org Roll third_party/gn_helpers forward. 2018-11-07 gwendal@chromium.org cros deploy: Fix --root /usr/local --deep invocation 2018-11-07 saklein@chromium.org run_chroot_version_hooks: cleanup vestigal method 2018-11-07 saklein@chromium.org security_test_image: port to chromite Created with: gclient setdep -r src/third_party/chromite@d5ee1c6aed6c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9d084e9fe6ac8400135bc33691a3d0edf95295fa Reviewed-on: https://chromium-review.googlesource.com/c/1323612Reviewed-by:
-
ssid authored
It is likely a cause of janks on UI thread on Android. Add a trace event to get metrics about the duration. BUG=902203 Change-Id: I4c4e9c2a20790264b982007ea7ee88ddfa7b972c Reviewed-on: https://chromium-review.googlesource.com/c/1319369Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#606104}
-
Jonathan Backer authored
SharedImage backend implementation is careful to restore GL state. The reason we need to MakeCurrent is to create the texture in the correct GPU process side share group. With virtual contexts, we are often current with a different surface. By skipping the unnecessary MakeCurrent, we avoid stalling GPU main thread waiting for vblank on Nvidia GPUs (where use_virtualized_gl_contexts is on by default). Bug: 894100 Change-Id: Ibaf66ffffbe228d5413a50873e1809d115b86e59 Reviewed-on: https://chromium-review.googlesource.com/c/1320591 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606103}
-
Andrew Grieve authored
Bug: 841628 Change-Id: I8bc446018bb19d6218c07f397fe96650e0a4ea4a Reviewed-on: https://chromium-review.googlesource.com/c/1322353Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#606102}
-
John Abd-El-Malek authored
Add an integration test for a URLLoaderThrottle changing a URL and ensuring that it's requested correctly. This is tested as part of PolicyTest.ForceGoogleSafeSearch after the fix in r605518, but we should have a test at the content-layer for URLLoaderThrottle's behavior. Bug: 902775 Change-Id: I9f9f4de201d55389709a4a7336c6bf581bb4bab3 Reviewed-on: https://chromium-review.googlesource.com/c/1323896Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#606101}
-
Moe Ahmadi authored
This CL moves ownership of payments::PaymentsClient and FormDataImporter to implementations of AutofillClient in order for these objects to live beyond the lifespan of AutofillManager. AutofillDriver and thus AutofillManager's lifespan is tied to the renderer frame which gets destroyed with cross-domain navigations on form submission and therefore creidt card save isn't offered. With this change these objects' lifespan will be tied to the tab. Bug: 892299 Change-Id: I1651e92ba032d04d047221d91bafbdfcc511296a Reviewed-on: https://chromium-review.googlesource.com/c/1320215 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#606100}
-
Makoto Shimazu authored
Previously we skipped to create non-network factories for subresource loading from a service worker as a performance optimization. It works on S13nServiceWorker because extensions are handled by a resource dispatcher host. However, NetworkService doesn't work well because those requests need to be routed to extensions before going to the NetworkService. This CL fixes by always creating non-network factories for subresource loads. Bug: 901443 Change-Id: Ia932dc11352c14be9f33c9e3448891cf66d699e0 Reviewed-on: https://chromium-review.googlesource.com/c/1322258Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
danakj authored
Rather than having content call blink code to call back into content in order to set visibility on the compositor, have content code do so directly. Historically, this would be an artifact of the compositor being an optional thing, and being a wrapper around different code for each port of WebKit. Now we can remove the method. RenderWidget already does SetVisible() to true during its creation/init phase when appropriate, so blink doesn't need to repeat that. Then, we change visibility on response to IPCs received in content, so it can control the compositor directly. This gives us more clarity around when the compositor will be visible or not, and thus more confidence that it will stay non-visible for a swapped out RenderWidget. LayoutTests demand the ability to set the page's visibility state directly from the TestRunner, with more options than just hidden or visible. So we expose the ability to set that on RenderViewImpl to the TestRunner, and share that code internally in RenderViewImpl to unify the two paths again, since they'd diverge otherwise with moving code up to RenderViewImpl from WebViewImpl. R=dcheng@chromium.org, piman@chromium.org Change-Id: I366e0f36923f8a690e4e1562e46e6d94e76f3e61 Bug: 896836, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1320191 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aced3af1656c..39f97da7dc62 Created with: gclient setdep -r src-internal@39f97da7dc62 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3e93246903f053b57dcc91642617b2a7cf96a362 Reviewed-on: https://chromium-review.googlesource.com/c/1323611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606097}
-
Mario Sanchez Prada authored
Remove all trace of SigninManager from SyncEngine, which also required some changes in clients and unit tests due to the removal of one parameter from the SyncEngine's constructor. Bug: 890798 Change-Id: I10596e61c46f7b86b8afb37c2dbfc401f5f651a8 Reviewed-on: https://chromium-review.googlesource.com/c/1297981 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606096}
-
Leszek Swirski authored
This reverts commit 31bcf8aa. Reason for revert: Canary crasher, Bug:902832 Original change's description: > Reland^3 "[blink] Control ScriptStreamer with ScriptResource" > > This is a reland of 5528336d, which > was a reland of dd9df78c, which was > a reland of 7bd91635. > > VR tests have been properly deflaked in https://crrev.com/c/1319715, this > is otherwise unchanged. > > Original change's description: > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > > > This reverts commit c564235f. > > > > No changes from the original, VR flakes are caused by issues with > > loadUrl and have been deflaked (see 894796 for details) > > > > Original change's description: > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > > > > > This reverts commit dd9df78c. > > > > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796) > > > > > > Original change's description: > > > > Reland "[blink] Control ScriptStreamer with ScriptResource" > > > > > > > > This is a reland of 7bd91635 > > > > > > > > No changes from the original, revert reason is fixed with > > > > https://chromium-review.googlesource.com/c/1283037 > > > > > > > > Original change's description: > > > > > [blink] Control ScriptStreamer with ScriptResource > > > > > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > > > > ScriptResource. In the future, this will allow us to start streaming > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on > > > > > preload. > > > > > > > > > > The ClassicPendingScript now only sends one "finished" callback, from > > > > > ScriptResource. This callback is either when the streaming completes, > > > > > or when there is no streaming and the ClassicPendingScript has told > > > > > the ScriptResource that it doesn't intend to start streaming. In the > > > > > long run, we want all scripts to go through the streaming interface, > > > > > and we want ScriptResource to control when streaming starts, so the > > > > > "no more streaming" call will disappear -- however it is necessary to > > > > > maintain the current behaviour, and be able to control it with a > > > > > runtime flag. > > > > > > > > > > Bug: chromium:865098 > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#599148} > > > > > > > > TBR=kouhei@chromium.org,kinuko@chromium.org > > > > > > > > Bug: chromium:865098 > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#601143} > > > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: chromium:865098 > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138 > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#602310} > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: chromium:865098 > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76 > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605295} > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org > > Bug: chromium:865098 > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1318923 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605815} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org Change-Id: I9a9337344d5a11fcc6b16aab1d8ad600ffef4e10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:865098 Reviewed-on: https://chromium-review.googlesource.com/c/1323655Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#606095}
-
Sébastien Marchand authored
This reverts commit 14754da5. Reason for revert: causing some crashes on Cross Bug: 902834 Original change's description: > RC: Encapsulate most of the singletons into ResourceCoordinatorParts > > There's several singletons / global instances in c/b/rc that are leaked > at shutdown, this is causing some issues in runs of unit_tests because > we end up re-using them between different test runs that should be > independent. This is currently preventing some feature to be enabled. > > This CL add a new ResourceCoordinatorParts class that encapsulate all > these objects that should be created only once, an instance of this > class is owned by the browser process. > > Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64 > Reviewed-on: https://chromium-review.googlesource.com/c/1290775 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606061} TBR=sky@chromium.org,chrisha@chromium.org,fdoray@chromium.org,sebmarchand@chromium.org Change-Id: I37bbcac05cceac6291874ad94d517cbdd4eeab2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1323623Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#606094}
-
Stephen Martinis authored
The bot is broken at the moment. NOTRY=true Bug: 902806 Change-Id: I1ee551c95617444e5ec4edbdb3d8d4fde6d7dc5f Reviewed-on: https://chromium-review.googlesource.com/c/1324090 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Maks Orlovich authored
(With partial resource being a 206, not a truncated one). Previously we would happily use a first chunk from cache, then fail in panic when validation of the second chunk failed; this was especially bad for servers whose validation fails to match for resources for which headers suggest it should. After this change, in this case, we force a validation of the first chunk, and if it fails re-fetch the entire resource. This is far from ideal, but we have limitations when it comes to converting a pre-existing 206 entry to a 200 one that make using somewhat-better-in-this-case If-Range really painful (and there is no multi-range support, that would be useful for these sorts of reconstructions, either). (Heavily affects the lazyload experiment) Bug: 888742 Change-Id: I7f3f3b40dc1e2a98dd093ac09c98fe43eee5f3bd Reviewed-on: https://chromium-review.googlesource.com/c/1291595Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#606092}
-
Becky Zhou authored
+ Use sentence case for buttons + Chanage filled button side padding to 24dp + Change text button side padding to 8dp + Change clear browsing data setting button to filled button Bug: 900760 Change-Id: Id9c01960464319c5b3ad974564b4637c8d9d0217 Reviewed-on: https://chromium-review.googlesource.com/c/1315214 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#606091}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=erik.corry@gmail.com Bug: 901709 Change-Id: I942c126cf68df4b242c7e49f05c2d7696e9d1b9e Reviewed-on: https://chromium-review.googlesource.com/c/1322175 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606090}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a7f77a7c05b5..50f60cb4b3a6 git log a7f77a7c05b5..50f60cb4b3a6 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 yujo@chromium.org Rename software codec classes and move them into api/ 2018-11-07 sprang@webrtc.org Remove non-default VideoEncoder::EncoderInfo() ctor 2018-11-07 sprang@webrtc.org Update MockVideoEncoder with correct methods. 2018-11-07 alessiob@webrtc.org Revert "Isolating APM API build target: making :api an actual target." Created with: gclient setdep -r src/third_party/webrtc@50f60cb4b3a6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2de05a4174f28cab6d6c5076cd250348776a8534 Reviewed-on: https://chromium-review.googlesource.com/c/1323229Reviewed-by:
-
Alexandr Ilin authored
Active cancellation of dns requests may lead to creation of too many background threads performing getaddrinfo. It happens because we can't cancel getaddrinfo, and the task runner will allocate a new thread even though a thread with the cancelled getaddrinfo is still alive. This reverts commit 512b3dda and applies new patches on top of this revert. Bug: 883806 Change-Id: Ie731783b86300a312de56b3e281a640fb23829fb Reviewed-on: https://chromium-review.googlesource.com/c/1307445Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606088}
-
Jared Saul authored
Bug: 884817 Change-Id: Iab61ac0b51d4541313f48263cadbfe2110fac543 Reviewed-on: https://chromium-review.googlesource.com/c/1321255Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#606087}
-
Nate Fischer authored
This disables the QUIC protocol in WebView for the NetworkService path. This protocol is not currently supported. R=jam@chromium.org Bug: 887538 Test: Manual - nothing seems drastically broken Change-Id: I0f88c257b3fd2928492888ecb09793aa3e3c45b1 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1322357Reviewed-by:
-
David Benjamin authored
This clears a few AdaptCallbackForRepeating instances in CrOS code. Change-Id: If9dcfdfca2eb571d4f2f8b93c27f913b41058aa6 Reviewed-on: https://chromium-review.googlesource.com/c/1316437Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#606085}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/dd412c428ad7c2a60ae4709dfbad6301e499dcb8..384d0eaf1930af1ebc47eda751f0c78dfcba1c03 Bug: none Change-Id: I68987a17316901349adf2d2da45b7e89f63d5d62 Reviewed-on: https://chromium-review.googlesource.com/c/1320969Reviewed-by:
-
Nate Fischer authored
This got fixed in http://crrev/c/1314133 and http://crrev/c/1319334. R=jam@chromium.org Bug: 893577 Bug: 887538 Test: N/A Change-Id: Ib012ff2f18e5e2b92ad6167d3de48154b4cd1b04 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1322354Reviewed-by:
-
Theresa authored
Notify the feature engagement system when a suggestion is clicked, opened in a new tab or downloaded using a single 'contextual_suggestion_taken' event. BUG=901915 Change-Id: Iaf5ed83f8a7e36b044541cfe96d3cc4a9fd34d4b Reviewed-on: https://chromium-review.googlesource.com/c/1321864Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#606082}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/273fa2f3bd0b..d282860c9472 git log 273fa2f3bd0b..d282860c9472 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 mtklein@google.com get rid of SkScalarDiv 2018-11-07 mtklein@google.com move third_party/gif deps to codec_srcs Created with: gclient setdep -r src/third_party/skia@d282860c9472 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id4bbf7969da8b7fb1a4a85a7e5cad51f4df5cf6f Reviewed-on: https://chromium-review.googlesource.com/c/1323230Reviewed-by:
-
