- 27 Nov, 2018 40 commits
-
-
Javier Ernesto Flores Robles authored
This CL also refactors KeyboardObserverHelperDelegate to KeyboardObserverHelperConsumer. Bug: 906017, 878388, 845472 Change-Id: If80e9b08cf72f7ffc65b064bffac71cecb7db3bd Reviewed-on: https://chromium-review.googlesource.com/c/1346390Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611139}
-
Tim Schumann authored
It's flaky on Win7 Tests Bug: 908861 TBR=miu@chromium.org Change-Id: I9a021bd617eae8bb7c8cf343d0fc5e6dcd51e8eb Reviewed-on: https://chromium-review.googlesource.com/c/1352316 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611138}
-
Steven Bennetts authored
Original CL: https://chromium-review.googlesource.com/c/1343524 FIX: Minor change to exo_unittests BUILD.gn file Add TestKeyboardControllerObserver for ash keyboard unit tests This also includes some cleanup of the BUILD.gn files. Currently TestKeyboardControllerObserver is only needed by AshKeyboardControllerUnitTests, but will be required by any tests affecting the keyboard with SingleProcessMash once enabled. TBR=sky@chromium.org Bug: 843332 Change-Id: Iaa937c9908196f2aa3ba7184bec79e722531e69c Reviewed-on: https://chromium-review.googlesource.com/c/1351457Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611137}
-
Mihai Sardarescu authored
The Activity & Interactions toggle that used to control user events was removed from settings and thus URL-keyed and Gaia-keyed user events are enabled iff history sync is active. This CL changes the personalized version of UrlKeyedDataCollectionConsentHelper to check whether history sync is enabled instead of checking the user events. Bug: 906031 Change-Id: I693474f21ced13c7a4bee634e9a92adcf7bb0cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1352150Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#611136}
-
Mihai Sardarescu authored
This CL clears the profile when it is loaded is the primary account is no longer allowed (e.g. profile was marked as a managed profile or the profile). As this is a very destructive action (the profile directory is removed from disk), the user is presented with a permanent browser modal dialog. Screenshots for each platform: Linux: https://drive.google.com/open?id=1HO693VkDnC0qjPxHJdFZr3CPqOs2Hidf Windows: https://drive.google.com/open?id=1gvmvt2wUsA42nmcVWTZCB1F5encHJRRH Design doc [Google internal only]: https://docs.google.com/document/d/1QqWoV1I7WgrzeHJwm9agG56ZqXD_Q2L3LB3K7Ck89GI/edit?usp=sharing Bug: 907474, 887756 Change-Id: Ib1187d79a45e0829b57768582c5d11126b0a5c46 Reviewed-on: https://chromium-review.googlesource.com/c/1288829 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611135}
-
Zhongyi Shi authored
This change will confirm if crbug.com/906005 is caused by memory correction. Bug: 906005 Change-Id: If9a6181bdf5b3591dec0cd340c66fafe77c2e2f5 Reviewed-on: https://chromium-review.googlesource.com/c/1347274 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#611134}
-
David Bokan authored
This reverts commit 0d1087c7. Reason for revert: Feature isn't approved to ship - was turned on to get some early data in Canary/Dev Original change's description: > Enable implicit root scroller in stable > > Bug: 798719 > Change-Id: I05c0bc89c3e842f005be57db2226b4188ee4da3b > Reviewed-on: https://chromium-review.googlesource.com/c/1320812 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606428} TBR=bokan@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 798719 Change-Id: I9fb19298e818fc21bfd42404253a5110a226246e Reviewed-on: https://chromium-review.googlesource.com/c/1351604Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611133}
-
Javier Ernesto Flores Robles authored
This change is made so the buttons keep the color on iPads when the popovers are presented. Bug: 845472 Change-Id: I7ce4d410bd66a5aa0dc1c1258914df493d3ac1db Reviewed-on: https://chromium-review.googlesource.com/c/1352154Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611132}
-
Mathias Carlen authored
Before this patch, shutdown of the controller was done in an unsafe way without making sure that script execution has completed (or was properly interrupted). This also holds for script precondition checks, since they also use the web_controller and devtools which require the web controller to outlive their execution. This resulted in crashes when autofill assistant was closed in the UI and a long running element check, where the element can not be found is still running. Shutting down the UI and the native controller without making sure a running script is finished resulted in a crash due to the action calling back into a no longer existing web_controller. This patch introduces a termination function in the script tracker which takes care of stopping a script being executed or a script check run. The controller retries after 2 seconds if it can not yet be cleanly deleted. The crash could no longer be reproduced. Bug: 806868 Change-Id: I5b70b57dfeca2ccb4f1dcc16641a847e36034f66 Reviewed-on: https://chromium-review.googlesource.com/c/1350965 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#611131}
-
arthursonzogni authored
Update chrome/browser/flag-metadata.json See https://sites.google.com/a/chromium.org/dev/flag-ownership This is about the flags: --disable-ipc-flooding-protection ownership. --disable-pushstate-throttle Some javascript functions called in an infinite loop can cause the browser process to be flooded by IPCs and become unresponsive. To prevent this, Chrome limits the number of same-document navigation a document can request. Currently 200 per 10 seconds. These flags are used to disable this protection. This is useful for automated tools like test runners. A chrome://flag is not really needed, the switches are enough. This CL deprecates the flag and mark them to be removed in Chrome M76. Bug: None Change-Id: Ifac50c5f6043b9ced25e63d6bc6552a6bb5c672c Reviewed-on: https://chromium-review.googlesource.com/c/1341526Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
agrieve authored
Change-Id: I67fac22fa506e1cd3bd46d003887621e08b146cd Reviewed-on: https://chromium-review.googlesource.com/c/1349502Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611129}
-
sebsg authored
This CL lands strings for upcoming changes to the dropdown which will better reflect the source of users' cards. See also (googlers only): https://docs.google.com/document/d/18oV-_0QfoWM7rgp-suzDn4WspFNHRPKxI-4epHDQZIg/edit?usp=sharing Tbr: ftirelo@chromium.org Bug: 908543 Change-Id: Idec6a806747ad0b49a41bbe4dc4493b13c67604e Reviewed-on: https://chromium-review.googlesource.com/c/1351498Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611128}
-
Javier Ernesto Flores Robles authored
Bug: 878388, 845272 Change-Id: I8f3ee338c35be7d39472b75289106bb563092e92 Reviewed-on: https://chromium-review.googlesource.com/c/1352249 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Filip Gorski authored
Changes the referrer value to: * https://www.googleapis.com/auth/chrome-content-suggestions for NTP Article Suggestions Bug: 903013 Change-Id: I62460e45d6134058d49c220c580e8a2f7834365d Reviewed-on: https://chromium-review.googlesource.com/c/1325214Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#611126}
-
Mike West authored
With the exception of generated directory listing pages, resources requested via FTP will be downloaded rather than rendered. Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eopgOoY1QLs Spec: https://github.com/whatwg/fetch/pull/839 Bug: 744499 Change-Id: Ic04f17986cbceb511a19d541f4dd4c67685df81a Reviewed-on: https://chromium-review.googlesource.com/c/1337338 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611125}
-
Friedrich Horschig authored
This CL changes the accessory bar's top shadow to a "Toolbar Shadow" as appropriate for a fixed piece of Chromium UI. This would have the weird side effect of putting the accessory sheet on the same perceived Z-level as the website. To prevent this, the scrolling shadow changes to a smaller shadow that resembles the planned "Modal shadow" which leverages the sheet above the website. Screenshots and visual aids for this problem: http://slides/1uto1gWimPsaU_3JVbNZqi7bk1tnsfVFV5Pgkck9cefM#slide=id.g482fab1c8c_0_265 Change-Id: I81451ac0605e601a4bd8ad6a511a2c2a050dc91c Reviewed-on: https://chromium-review.googlesource.com/c/1348062Reviewed-by:
-
Gauthier Ambard authored
When the user switch from a NTP which doesn't have a back/forward history to an open tab, the tab should be closed. Bug: 908010, 908409 Change-Id: Ie4c783bef4c43ddafa175ba5796bd2a0b05cc54c Reviewed-on: https://chromium-review.googlesource.com/c/1349264 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611123}
-
David Jean authored
Also allow them to be disabled to be used as message cells. Change-Id: I545a0849fa4656e1959c8f01ad456e2b0a52cd78 Reviewed-on: https://chromium-review.googlesource.com/c/1350618 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611122}
-
Benoît Lizé authored
Bug: 907489 Change-Id: Ia66d652b30fbaba67035e042a2144adc3727c582 Reviewed-on: https://chromium-review.googlesource.com/c/1347282 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#611121}
-
Stephen Kyle authored
Looks like some extra code was introduced to HeapTest.ShrinkVector in ee337661 that likely wasn't meant to be. Change-Id: Ief988a083881a95bf1bbcdf6cacba29aabf1c480 Reviewed-on: https://chromium-review.googlesource.com/c/1352155Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611120}
-
Anna Malova authored
because of failure. Bug: 908484 Change-Id: I19d7c285f679bcce3a25b06c883f978b5c4e95cb Reviewed-on: https://chromium-review.googlesource.com/c/1350978 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611119}
-
Pengcheng authored
By default SimpleURLLoader does not attach cookies while sending request, but for contextual suggestion service, the auth cookies are required, otherwise it responses empty result. Bug: 904742 Change-Id: I6d061c859cda9804fe7372634aae5c5d46916ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1333017 Commit-Queue: Pengcheng Xu <pengcheng@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611118}
-
Oleh Prypin authored
Make it produce a source_set which can be depended on rather than directly including sources into the parent target. Bug: chromium:682122 Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 Reviewed-on: https://chromium-review.googlesource.com/c/1348042Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
-
Marc Treib authored
This will be used by some autofill metrics. Bug: 903290 Change-Id: I40df75f93a3b25d1beb2ba77cb231a227b44c8ab Reviewed-on: https://chromium-review.googlesource.com/c/1350984Reviewed-by:
-
Kush Sinha authored
Add a couple of dummy token values in Chrome OS Account Manager for dealing with Active Directory accounts and Gaia accounts with unknown tokens: - AccountManager::kActiveDirectoryDummyToken - AccountManager::kInvalidToken Bug: 820046 Bug: 904128 Test: chromeos_unittests --gtest_filter="*AccountManager*Test*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I72ae94ef5013a61d20bac2e17bfac88ed1deb8a7 Reviewed-on: https://chromium-review.googlesource.com/c/1349973 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#611115}
-
Matthew Cary authored
The --log-native-library-residency switch is not effective unless madvise(RANDOM) is used. Our madvise strategy has changed since --log-native-library-residency was added. Also tweak the range check and increase length of time before residency is dumped to 1 minute. Change-Id: I25eb4ee4a77d8c1d7a5424dd29ec52c95baf7289 Reviewed-on: https://chromium-review.googlesource.com/c/1350976Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#611114}
-
Mohamed Amir Yosef authored
This CL plumbs the network error code through to show it in the chrome://sync-internals pages in case of NETWORK_CONNECTION_UNAVAILABLE. This should allow for easier debugging for some user reported bugs. Bug: 897049 Change-Id: Id0fc5455eb4d64b1a022898d8a898e7efa4a255c Reviewed-on: https://chromium-review.googlesource.com/c/1346460 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611113}
-
James Cook authored
Push some functionality down from AXTreeSourceAura and AXTreeSourceMus into AXTreeSourceViews. This allows AXTreeSourceViews to completely implement the AXTreeSource interface, eliminating the weird "subclasses must implement GetRoot" condition. Just cleanup, no functional changes. Bug: 888145 Test: views_unittests, views_mus_unittests Change-Id: I1c1b2cfa856fe6f5e5bcf8dfff172a7ffb6e5339 Reviewed-on: https://chromium-review.googlesource.com/c/1351776Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#611112}
-
Kent Tamura authored
Add setFormValue() implementation to blink::ElementInternals, and it also overrides ListElement::AppendToFormData(). Tests: - custom-elements/form-submission-file.html This won't be merged to WPT because this test uses a Mojo interface mock. - custom-elements/tentative/form-submission.html This will be merged to WPT. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I1d28d1d5e8c2c412e7db18a0b39eb9d517054c04 Reviewed-on: https://chromium-review.googlesource.com/c/1350418 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#611111}
-
Antonio Gomes authored
BUG=903885 Bots are true but mac_chromium_rel_gn, which is sick. Adding "notry". NOTRY=true Change-Id: I6907a8c978a4adbbbca2f5e12122c90564607b1c Reviewed-on: https://chromium-review.googlesource.com/c/1351153 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#611110}
-
Nico Weber authored
Looks like https://chromium-review.googlesource.com/c/chromium/src/+/1349854 fixed these too. Bug: 897970,897969 Change-Id: I09dac10a533511fbab3d49e9c0055ebc7b507f2d Reviewed-on: https://chromium-review.googlesource.com/c/1350190 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Andrew Grieve authored
No need to zip up the generated source just to unzip it again :P This reverts commit f4e7bed3. Reason for reland: Fixed missing deps in __final_jni template TBR=pauljensen@chromium.org,agrieve@chromium.org Bug: 908479 Change-Id: I1177d550eb33737f47192bd70db5358c6392598c Reviewed-on: https://chromium-review.googlesource.com/c/1351930 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Tarun Bansal authored
When the tab is brought to the foreground, preconnect to the origin of the main frame request. This preconnection is done at most once, and is helpful in case user clicks on a link. Change-Id: I6786c14ad7be0921bb309aabac5a75cff9819db8 Bug: 908725 Reviewed-on: https://chromium-review.googlesource.com/c/1350209Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611107}
-
Antonio Gomes authored
Ideally, it should be possible to use the IdentityTestEnvironment ctor that takes only the boolean paramater, and constructs the signin and token handler objects internally. But some tests tweak the PrefService instance, which is not exposed by IdentityTestEnvironment APIs. Bots are true but mac_chromium_rel_gn, which is sick. Adding "notry". NOTRY=true BUG=908519 Change-Id: I6b4c9076c61079b45da76960c5269fd5ca8397a8 Reviewed-on: https://chromium-review.googlesource.com/c/1351152 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2135b68548af..115df409efa1 git log 2135b68548af..115df409efa1 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 dgarrett@google.com repo_sync_manifest: Add -g cherry-pick support. 2018-11-27 dgarrett@google.com config_lib: Remove REPO_URL from site_config. 2018-11-27 mikenichols@chromium.org cidb: Working around some SSL options from new packages. 2018-11-26 bhthompson@google.com Move eve-arcnext P Android PFQ to eve 2018-11-26 cjmcdonald@chromium.org chromeos_config: Add template for unit test only buildbot Created with: gclient setdep -r src/third_party/chromite@115df409efa1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib6e71f049b8388eeb2856cc9fb53e9b1ce8e309c Reviewed-on: https://chromium-review.googlesource.com/c/1351298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611105}
-
Ali Juma authored
webViewScrollViewDidResetContentSize interprets the scroll view's content size's width being narrower than the frame's width as a sign that WebKit hasn't properly resized the content, so resets zoom scale to force WebKit to re-render. However, the zoom scale that makes the content fit exactly within the width of the frame may not be exactly representable as a float. In this case, the content size's width can be up to a pixel narrower than the frame width. There's no benefit to forcing a re-render in this case, and furthermore, resetting the zoom scale causes the page to scroll, which may trigger the page's content to spuriously change. In the worst case, this can lead to a never-ending cycle of resetting the zoom scale, the page scrolling, the page changing, resetting the zoom scale again, and so on. This CL makes webViewScrollViewDidResetContentSize ignore cases where the contentSize's width is up to a pixel narrower than the frame. Bug: 822697 Change-Id: I93e3e7efb33a6ea3b931c0d7f2b404bf93e80e12 Reviewed-on: https://chromium-review.googlesource.com/c/1348955Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#611104}
-
John Budorick authored
Tbr: sergeyberezin@chromium.org,bradhall@chromium.org No-Try: true Bug: 908551 Change-Id: I5f003793bc94930fa685fff74ae1217e208b0dc6 Reviewed-on: https://chromium-review.googlesource.com/c/1351936Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611103}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c18a1afa1a7..44d4b29082f0 git log 6c18a1afa1a7..44d4b29082f0 --date=short --no-merges --format='%ad %ae %s' 2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-26 ehmaldonado@chromium.org roll-dep: Use gclient setdep/getdep. Created with: gclient setdep -r src/third_party/depot_tools@44d4b29082f0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906114 TBR=agable@chromium.org Change-Id: I4c4668c3e3c3a02b47454b536f915980dab760c0 Reviewed-on: https://chromium-review.googlesource.com/c/1351472Reviewed-by:
-
Vaclav Brozek authored
This CL introduces a new UKM for measuring success of finding corresponding password form managers during the stages of saving a password form. There are three stages during which one of four values is reported. The reporting only takes place if the page has at least one password form, and only one value per page load is reported. Privacy review of this metric: The whole UKM event "PageWithPassword" has been reviewed in crbug.com/728707 and go/gkmnc, where the privacy TL agreed that adding new metrics for this event is OK under certain conditions (see the linked doc). The new metric satisfies such conditions, in the opinion of the CL author, and hence are covered by that review. The new metrics have been added to the requested spreadsheet listing all passwords-related metrics. Bug: 907794 Change-Id: I3cdcffeea9546474acd71ee85f74f4d2e60a6a2e Reviewed-on: https://chromium-review.googlesource.com/c/1348043 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#611101}
-
Mustaq Ahmed authored
These tests rely on assumptions on Chrome's old user gesture model. This CL fixes the assumptions for the new model (UAv2). Bug: 908531 Change-Id: I3d290489075f81f5c8fd414c050d1beabab48488 Reviewed-on: https://chromium-review.googlesource.com/c/1351570Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
