GitLab

BUG=640947
TBR=falken@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://chromiumcodereview.appspot.com/2442043002
Cr-Commit-Position: refs/heads/master@{#426839}

Currently on Blimp IME, hitting Enter only sets the text in the web
page. So user has to hit Enter twice in order to see search results.
This patch solves this by generating a synthetic Enter key press event
and sending it to the renderer.

BUG=611132

Review-Url: https://chromiumcodereview.appspot.com/2393043004
Cr-Commit-Position: refs/heads/master@{#426838}

In the preliminary CL http://crrev.com/2406153003, I changed Rietveld.latest_try_jobs to Rietveld.latest_try_job_results and made it return a dict of Builds (named tuple objects with builder_name and build_number) to result info dicts.

The purpose of this was to make it so that rebaseline-cl could look through the result info dicts to see whether each build is completed or just started, to avoid starting extra builds.

After looking at it some more, I see that in the Rietveld response, builds that are just started but not completed have no build number information.

To avoid having to pass around the result dict information from Rietveld, it's possible to just have a list of Build objects with build_number set to None when the build is just pending or started but not completed.

So, in summary, this CL makes it so that when one runs rebaseline-cl twice in a row, it now prints out:

$ ./webkit-patch rebaseline-cl
 Triggering try jobs for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished.
 $ ./webkit-patch rebaseline-cl
 There are existing pending builds for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished.

And this CL undoes some of the changes made in http://crrev.com/2406153003 in order to simplify the code, because now I think passing full result info dicts is unnecessary.

BUG=654919

Review-Url: https://chromiumcodereview.appspot.com/2439693003
Cr-Commit-Position: refs/heads/master@{#426837}

This makes WebRTCConfiguration into a data struct instead of wrapping a
RTCConfiguration. The motivation for this is to introduce
RTCConfiguration as an IDL dictionary, at which point the extra layer
starts to look unnecessary.

BUG=649343

Review-Url: https://chromiumcodereview.appspot.com/2415673003
Cr-Commit-Position: refs/heads/master@{#426836}

This change makes sure that we gracefully handle the case where a
pending pointer lock request is still active while destroying the
RenderWidgetHost.

BUG=655592

Review-Url: https://chromiumcodereview.appspot.com/2437213002
Cr-Commit-Position: refs/heads/master@{#426835}

BUG=658305
TBR=senorblanco@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://chromiumcodereview.appspot.com/2439143002
Cr-Commit-Position: refs/heads/master@{#426834}

This cl makes div output the same way as classic:
- when a div receives either ChromeVox or page focus, read its text content or its aria label
- this cleans up output and retains the previously hardened behavior in Classic.

TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience.
BUG=619279
TBR=dtseng@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65
Cr-Commit-Position: refs/heads/master@{#426497}

patch from issue 2433823003 at patchset 20001 (http://crrev.com/2433823003#ps20001)

Review-Url: https://chromiumcodereview.appspot.com/2441033002
Cr-Commit-Position: refs/heads/master@{#426833}

BUG=555865

Review-Url: https://chromiumcodereview.appspot.com/2435863004
Cr-Commit-Position: refs/heads/master@{#426832}

THROTTLED is used when the consumer is expecting that low priority
requests will soon be followed by higher priority ones.  It directs the
network stack to reserve resources to handle the coming requests.  In
practice this will mean that only a very small number of THROTTLED requests
may be outstanding at any given time.

BUG=600839

Review-Url: https://chromiumcodereview.appspot.com/1866483002
Cr-Commit-Position: refs/heads/master@{#426831}

Big CL that fixes many small things related to display information being
propagated when a display is modified. The primary change is that
ws::DisplayManager now handles OnDisplayModified() calls. This entails
the following steps:

1. The PlatformDisplay corresponding to the display is updated.
2. Mus sends an IPC to WM clients telling them the display has changed.
   This requires a new message in mojom::WindowManager and new method in
   WindowManagerDelegate.
3. Update the root ServerWindow for the display.
4. Mus sends an IPC to any other clients telling them the display has
   changed.

The ViewportMetrics class is moved from src/services/ui/ws/ to
src/services/ui/display so that it can be used in
PlatformScreenDelegate.

PlatformScreen now implements ui::DisplayController::StateController so
it can pick the display size.  A message is added to
mojom::TestDisplayController to trigger changing the display size. This
allows developers to try the functionality. An unused ash developer
keyboard shortcut is used to trigger changing the display size. This
shortcut is only temporary until settings are working.

Another small part of this change is the display insets are sent from
ash to PlatformScreen. This is tangentially related as it relies on
DisplayManager::OnDisplayModified() working.

BUG=641012

Review-Url: https://chromiumcodereview.appspot.com/2434923002
Cr-Commit-Position: refs/heads/master@{#426830}

This element is no longer used, and was included in this file by
mistake. Removing it reduces the size of the element bundle by about
7KB.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2436323002
Cr-Commit-Position: refs/heads/master@{#426829}

the "show all" button.

BUG=657935

Review-Url: https://chromiumcodereview.appspot.com/2439873002
Cr-Commit-Position: refs/heads/master@{#426828}

This CL adds support on the Blimp to propagate loading status and page
load status to Tab. This enables the UI to display the loading spinner
on the tablets and page load progress bar on phones.

The page load progress was set to 50 percent for now.

BUG=651473

Review-Url: https://chromiumcodereview.appspot.com/2394663002
Cr-Commit-Position: refs/heads/master@{#426827}

BUG=658304
TBR=bokan@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://chromiumcodereview.appspot.com/2442803002
Cr-Commit-Position: refs/heads/master@{#426826}

Added Set and Exists methods to safe_browsing_prefs and updated callers.

BUG=653122

Review-Url: https://chromiumcodereview.appspot.com/2435933003
Cr-Commit-Position: refs/heads/master@{#426825}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7d2ac2e7..580029a7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2439103002
Cr-Commit-Position: refs/heads/master@{#426824}

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences. Use initialization on demand
holder idiom to avoid synchronization issues.

BUG=656035

Review-Url: https://chromiumcodereview.appspot.com/2421833003
Cr-Commit-Position: refs/heads/master@{#426823}

I also updated the comment to better reflect the relationship between Chrome and
its dependencies. Several Chrome dependencies require a different min sdk and/or
deployment target from Chrome.

BUG=622481

Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505
Review-Url: https://chromiumcodereview.appspot.com/2420233002
Cr-Original-Commit-Position: refs/heads/master@{#425870}
Cr-Commit-Position: refs/heads/master@{#426822}

RTL is not supported in SDK level 16.
This test that relies on native RTL support should
therefore be disabled.

BUG=657927

Review-Url: https://chromiumcodereview.appspot.com/2434293002
Cr-Commit-Position: refs/heads/master@{#426821}

switches::kEnableWebRtcHWH264Encoding was added for
extensions and can be used before SW fallback is in place.
Now it's time to remove it since SW fallback is already
ready for all desktop platforms.
BTW: Another reason is after cl
https://codereview.chromium.org/2358683002/
has landed, the checking to switches::kDisableWebRtcHWEncoding
is having the same effect.

BUG=651981

Review-Url: https://chromiumcodereview.appspot.com/2428383005
Cr-Commit-Position: refs/heads/master@{#426820}

Also fix NavigationRequest not handling blocked requests.

This fixes
WebViewTests/WebViewTest.Shim_TestNestedSubframes/*
WebViewTests/WebViewTest.Shim_TestWebViewInsideFrame/*
with PlzNavigate.

BUG=504347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://chromiumcodereview.appspot.com/2441843002
Cr-Commit-Position: refs/heads/master@{#426819}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9c4cafa..5a1b3fe

$ git log 9c4cafaa..5a1b3fe --date=short --no-merges --format=%ad %ae %s
2016-10-21 magjed@webrtc.org Android VideoFileRenderer: Wait for posted frames in release()
2016-10-21 ivoc@webrtc.org Add a placeholder stat for logging the estimated residual echo likelihood.
2016-10-21 henrika@chromium.org Avoids invalid copy of audio buffer to task queue.
2016-10-21 nisse@webrtc.org Delete DataLog abstraction, which was almost unused.
2016-10-20 nisse@webrtc.org Reland of Delete unused file mediacommon.h. (patchset #1 id:1 of https://codereview.webrtc.org/2441493003/ )
2016-10-20 zijiehe@chromium.org SUCCEEDED macro is misused
2016-10-20 zijiehe@chromium.org BringSelectedWindowToFront should bring the window to front instead of only focusing it
2016-10-20 danilchap@webrtc.org Use variadic templates instead of pump for RefCountedObject
2016-10-20 aleloi@webrtc.org Move audio frame memory handling inside AudioMixer.
2016-10-20 aleloi@webrtc.org Replaced thread checker with race checker in AudioMixer.
2016-10-20 honghaiz@webrtc.org Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values.
2016-10-20 jbroman@chromium.org Return nullptr from RTCCertificate::FromPEM on failure.
2016-10-20 sergeyu@chromium.org Move shared_desktop_frame.cc to webrtc/modules/desktop_capture:primitives

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2437373002
Cr-Commit-Position: refs/heads/master@{#426818}

r426336 intended to add a data dependency for
site-per-process.content_browsertests.filter on Android builds.  The CL
missed the fact that the modified line (where "|| is_android" was added)
is nested in a long if that says "if (!is_android)".  Doh...
This CL tries to ensure that the dependency is *really* there.

The CL also refactors away nested ifs and ifs with negative conditions.
Hopefully this will help avoid similar confusion in the future.

BUG=654569

Review-Url: https://chromiumcodereview.appspot.com/2434983003
Cr-Commit-Position: refs/heads/master@{#426817}

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the "quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().

Review-Url: https://chromiumcodereview.appspot.com/2365243004
Cr-Commit-Position: refs/heads/master@{#426816}

We would like to share the event handling logic of RenderWidgetHostViewAura with RenderWidgetHostViewMus. As a first step this change refactors the EventHandler code out of RenderWidgetHostViewAura into its own class

TEST=manually run browser, dry-run of CQ to verify all existing tests.
BUG=631270

Review-Url: https://chromiumcodereview.appspot.com/2317333002
Cr-Commit-Position: refs/heads/master@{#426815}

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63..71692eaab2a0

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376

Review-Url: https://chromiumcodereview.appspot.com/2436913003
Cr-Commit-Position: refs/heads/master@{#426814}

BUG=658024

Review-Url: https://chromiumcodereview.appspot.com/2438883002
Cr-Commit-Position: refs/heads/master@{#426813}

BUG=658287
TBR=wkorman@chromium.org
NOTRY=true
NOTREETESTS=true

Review-Url: https://chromiumcodereview.appspot.com/2433373005
Cr-Commit-Position: refs/heads/master@{#426812}

TBR=dtseng@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review URL: https://codereview.chromium.org/2428413007 .

Cr-Commit-Position: refs/heads/master@{#426811}

https://chromium.googlesource.com/skia.git/+log/a9f64dec63b6..4e56a9139373

$ git log a9f64dec6..4e56a9139 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 jvanverth Add Android viewer to GN
2016-10-21 reed add pipe to nanobench

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=mtklein@google.com

Review-Url: https://chromiumcodereview.appspot.com/2436343002
Cr-Commit-Position: refs/heads/master@{#426810}

After plznavigate, GetChildId/GetRenderFrameID will return -1. Instead,
use GetWebContentsGetterForRequest.

BUG=645983

Review-Url: https://chromiumcodereview.appspot.com/2438913002
Cr-Commit-Position: refs/heads/master@{#426809}

BUG=655585

Review-Url: https://chromiumcodereview.appspot.com/2434313002
Cr-Commit-Position: refs/heads/master@{#426808}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2417303002
Cr-Commit-Position: refs/heads/master@{#426807}

IOServiceAddInterestNotification will only notify when the hardware sensor
value changes however when calling StartSensor we need to make
sure to query the value of the sensor right away to return the correct
value to JavaScript. The reason is that after calling StartSensor
the light conditions may never change and the IOServiceAddInterestNotification
callback will never be called and we return the default 0.0 sensor value. We
can fix this by making sure to initialize the sensor value in
PlatformSensorAmbientLightMac StartSensor.

BUG=606766

Review-Url: https://chromiumcodereview.appspot.com/2417643006
Cr-Commit-Position: refs/heads/master@{#426806}

This blocks adding features to the query interface, which is asynchronous by design.

BUG=589526,622763

Review-Url: https://chromiumcodereview.appspot.com/2429943002
Cr-Commit-Position: refs/heads/master@{#426805}

Forward touch events from the toolbar to the NTP only if the fakebox hasn't reached the top of the NTP.

BUG=657798

Review-Url: https://chromiumcodereview.appspot.com/2430153006
Cr-Commit-Position: refs/heads/master@{#426804}

This CL adds a SdchSourceStream which implements FilterSourceStream to do
sdch decoding. This CL additionally adds a SdchPolicyDelegate which will be
the glue for URLRequestHttpJob and SdchSourceStream.

This is a part of the effort to convert net::Filter into a pull-based
interface. See the linked bug for more details.

BUG=474859

Review-Url: https://chromiumcodereview.appspot.com/2368433002
Cr-Commit-Position: refs/heads/master@{#426803}

With this CL, prefs containing the network quality would be
written to the disk if |enable_prefs| is set to true in the
field trial config params.

The prefs are written by PrefDelegateImpl which is
profile-specific.

Additionally, prefs would be read at the time of startup,
and read prefs would be parsed and notified to
NetworkQualityEstimator.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet

BUG=490870

Review-Url: https://chromiumcodereview.appspot.com/2369673004
Cr-Commit-Position: refs/heads/master@{#426802}

If the user activates a content detector for a phone number,
address, or email address, record a user action when the intent
is sent.

BUG=657852

Review-Url: https://chromiumcodereview.appspot.com/2438143002
Cr-Commit-Position: refs/heads/master@{#426801}

This is in preparation for separating diff creation from signing,
similar to the Windows processing, and needed by the new signing
pipeline.

R=mark@chromium.org
BUG=b/31931170

Review-Url: https://chromiumcodereview.appspot.com/2432933006
Cr-Commit-Position: refs/heads/master@{#426800}