- 02 Jun, 2017 40 commits
- 
- 
pdfium-deps-roller@chromium.org authoredhttps://pdfium.googlesource.com/pdfium.git/+log/5171a27eaa74..8cb884102c17 $ git log 5171a27ea..8cb884102 --date=short --no-merges --format='%ad %ae %s' 2017-06-01 tsepez Tag CFXJSE_HostObject sub-classes. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I62ce734d7943b4520fe15c571a80094b20069f59 Reviewed-on: https://chromium-review.googlesource.com/521712 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#476529} 
- 
kkhorimoto authoredBUG=546208 Review-Url: https://codereview.chromium.org/2820763002 Cr-Commit-Position: refs/heads/master@{#476528} 
- 
khushalsagar authoredWe currently bucket UMA for all decode tasks in a single histogram. With checker-imaging enabled, we expect to see a decline in the decode duration for images decoded with raster. Add UMA to track these seperately. BUG=725344 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2904743002 Cr-Commit-Position: refs/heads/master@{#476527} 
- 
catapult-deps-roller@chromium.org authoredhttps://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/817b8684be60..b33525e99124 $ git log 817b8684b..b33525e99 --date=short --no-merges --format='%ad %ae %s' 2017-06-01 benjhayden Check that Diagnostic subclasses are registered in presubmit. 2017-06-01 dtu [pinpoint] Handle Job failure. 2017-06-01 achuith Disable logging redirect on chromeos. 2017-06-01 benjhayden Simplify dashboard autocomplete-box. Created with: roll-dep src/third_party/catapult BUG=724273 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ife7287880104fcce2c3109c20e215645b0e13210 Reviewed-on: https://chromium-review.googlesource.com/521771 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#476526} 
- 
pmonette authoredThe mapping was getting copied every invocation of InspectModule, which is pretty inefficient. Review-Url: https://codereview.chromium.org/2916663002 Cr-Commit-Position: refs/heads/master@{#476525} 
- 
tguilbert authoredWhen overlays are enabled, on Nexus 5 devices, upon exiting and re-entering fullscreen, nothing is displayed on screen. This is caused by the fact that AVDACodecImage never resets |most_recent_bounds_| when a new overlay is received. This means AndroidOverlay::ScheduleLayout() is never called in AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their initial bounds of [0,0,1,1]. This CL fixes the issue by reseting the bounds when a new shared state (and therefore potential new Overlay) is set. BUG=728802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2916193002 Cr-Commit-Position: refs/heads/master@{#476524} 
- 
posciak authoredRevert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of https://codereview.chromium.org/2763223003/ ) Reason for revert: crbug.com/724812 Original issue's description: > cc: Don't use StreamVideoDrawQuad on any platform but Android. > > VideoLayerImpl is appending StreamVideoDrawQuads on CrOS. > > StreamVideoDrawQuads should be used on Android since almost all its > features are supported by TextureDrawQuad. > The only difference is that StreamVideoDrawQuad calls > glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that > just sets a uniform matrix on CrOS. > > This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only > on Android. > > BUG=702750 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2763223003 > Cr-Commit-Position: refs/heads/master@{#460547} > Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44 TBR=danakj@chromium.org,reveman@chromium.org,avi@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702750 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2920893003 Cr-Commit-Position: refs/heads/master@{#476523} 
- 
Matt Falkenhagen authoredFor the majority of tests, SetUpWithHelper() was run twice, which is confusing. Change the tests to call SetUpWithHelper() once explicitly. Change-Id: I393182eb6c6ad56a8be4a08e03f308545ae1d223 Reviewed-on: https://chromium-review.googlesource.com/522263Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#476522} 
- 
rdevlin.cronin authoredNative bindings should replace many of the core modules used in extension APIs. Don't include some of these when native bindings are enabled. Update custom bindings that are exercised in native binding tests to behavior properly with either JS or native bindings. BUG=653596 Review-Url: https://codereview.chromium.org/2908883002 Cr-Commit-Position: refs/heads/master@{#476521} 
- 
ananta authoredReplace references to constants in ui/views/layout/layout_constants.h with their equivalents using ChromeLayoutProvider. BUG=691897 Review-Url: https://codereview.chromium.org/2919903002 Cr-Commit-Position: refs/heads/master@{#476520} 
- 
tengs authoredhttps://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ff270ca217a8..d1586d3fcb3a $ git log ff270ca21..d1586d3fc --date=short --no-merges --format='%ad %ae %s' 2017-05-25 tengs cros_system_api: Add constants for valid parameters of the SetLEConnectionParameters API. Created with: roll-dep src/third_party/cros_system_api BUG=725367 Review-Url: https://codereview.chromium.org/2920863002 Cr-Commit-Position: refs/heads/master@{#476519} 
- 
xiaochengh authoredThe above mentioned function simply returns a string member of the class, and is only used inside the class. Hence, this patch removes the function to reduce code complexity and any possible confusion. BUG=721957 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2915863005 Cr-Commit-Position: refs/heads/master@{#476518} 
- 
wzang authored1) Added supervised-user and signed-in user badge. We do not have designs for other badges yet and I need to investigate on all other badge types to see which one should be switched to the new style. Before that we hide all other badges to avoid style conflict. 2) Updated caps lock icon to match the new spec. BUG=718159 Review-Url: https://codereview.chromium.org/2919523005 Cr-Commit-Position: refs/heads/master@{#476517} 
- 
amp authoredThis allows the navigator.GetVRDisplays() promise to resolve when the underlying VR libraries are not installed or out of date. BUG=727969 Review-Url: https://codereview.chromium.org/2915993004 Cr-Commit-Position: refs/heads/master@{#476516} 
- 
skym authoredThis is essentially a clone of UserEventServiceFactory that uses web::BrowserState to be iOS compatible. BUG=701032 Review-Url: https://codereview.chromium.org/2916873003 Cr-Commit-Position: refs/heads/master@{#476515} 
- 
patricialor authoredThe "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758,709171 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2912253003 Cr-Commit-Position: refs/heads/master@{#476514} 
- 
eroman authoredSupport is compliant with RFC 5280 and supports all the policy extensions specified therein: * Inhibit Any Policy * Policy Constraints * Policies * Policy Mappings Testing is done solely using the PKITS test suite, which has fairly good coverage of these extensions: 4.8 (Certificate Policies) 4.9 (Require Explicit Policy) 4.10 (Policy Mappings) 4.11 (Inhibit Policy Mapping) 4.12 (Inhibit Any Policy) BUG=634456,634453,634452 Review-Url: https://codereview.chromium.org/2903283002 Cr-Commit-Position: refs/heads/master@{#476513} 
- 
Sorin Jianu authoredThis change simplifies the scope and lifetime of the manifest_. Bug: 728667 Change-Id: Ia234f9cf6e56dac45c5f358f6b3cd8bdc6652ba3 Reviewed-on: https://chromium-review.googlesource.com/522202 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#476512} 
- 
xiaochengh authoredThis patch moves TextIteratorTextState's member initialization to the class declaration, since they are all trivially initialized. BUG=721957 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2922553002 Cr-Commit-Position: refs/heads/master@{#476511} 
- 
Nate Fischer authoredClicking back-to-safety will now navigate backward for the malicious subresource case, which is consistent with Chrome's behavior. This removes is_resource_cancellable, since it was only added for the old WebView behavior (see crrev/458833). BUG=699196 Change-Id: Idb78f514f3ccbc8d899622c3700d71c93fdc7253 Reviewed-on: https://chromium-review.googlesource.com/516803Reviewed-by: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Reviewed-by: Selim Gurun <sgurun@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476510} 
- 
rlanday authoredThis CL changes CompositionMarker to take and store its thickness param as an enum instead of a bool. This makes code creating CompositionMarkers easier to understand (and also enables us to add additional thickness values in the future if necessary). BUG=707867 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2906953002 Cr-Commit-Position: refs/heads/master@{#476509} 
- 
yosin authoredThis patch renames |VisibleSelection::end()| to |End()| to follow Blink coding style. BUG=727486 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2920733002 Cr-Commit-Position: refs/heads/master@{#476508} 
- 
Alexei Filippov authoredBug: 718063 Change-Id: Ia60355916d1e9e440f661255e40e4af83f288365 Reviewed-on: https://chromium-review.googlesource.com/521364 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#476507} 
- 
donnd authoredFixes a bug where the resolved term isn't always selected in the text. The case fixed is due to the selection including a trailing space when at the end of a line. It's unclear why the trailing space is included in the selection. We simply trim the trailing space. BUG=726767 Review-Url: https://codereview.chromium.org/2910713002 Cr-Commit-Position: refs/heads/master@{#476506} 
- 
estade authoredEven on a beefy workstation, resizing theme images takes a long time (>1s). This causes a painful hiccup in the UI. This patch addresses that by moving the operation to a helper thread. The actual application of the theme won't be any faster but it won't block interaction. As a future area of investigation it might be worth changing the "theme installed" infobar to show earlier with a message like "installing theme..." until this operation is completed, since otherwise it can feel like nothing is happening. BUG=316070 Review-Url: https://codereview.chromium.org/2799003002 Cr-Commit-Position: refs/heads/master@{#476505} 
- 
Dominic Cooney authoredMapping a custom element constructor to its definition used to look in a JavaScript map from constructor to custom element name string, and then hash that name to look up the custom element definition in the registry. After this change the JavaScript map values are IDs so the definition can be retrieved directly from a vector. This avoids marshaling the name string from V8 to C++, and avoids hashing the string, to look up a definition. (There's still a map from name to ID on the side so that CustomElementRegistry.get can look up definitions by name, but it is not used in common operations like creating a custom element.) Bug: 710184 Change-Id: I90ee5759bf692b5a2df43a4a59ef4fac94d22f2c Reviewed-on: https://chromium-review.googlesource.com/520543 Commit-Queue: Dominic Cooney <dominicc@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#476504} 
- 
rbpotter authoredChange one more native layer message to cr.sendWithPromise and adjust tests to use browser proxy for this message instead of triggering an event. BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2919693002 Cr-Commit-Position: refs/heads/master@{#476503} 
- 
eugenebut authoredBUG=687863 Review-Url: https://codereview.chromium.org/2914193003 Cr-Commit-Position: refs/heads/master@{#476502} 
- 
Evan Stade authored- make View::set_background take a smart pointer (a la SetBorder) - move background factory functions out of views::Background (also a la Border) for reduced verbosity - remove a couple redundant background factory functions No behavioral changes. Bug: none Change-Id: I4d4971ea04dcb1f17ebda5671fd997beb1a692a3 Reviewed-on: https://chromium-review.googlesource.com/520702 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#476501} 
- 
luoe authoredBUG=728789 Review-Url: https://codereview.chromium.org/2915013003 Cr-Commit-Position: refs/heads/master@{#476500} 
- 
scottchen authoredBUG=715193 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918613003 Cr-Commit-Position: refs/heads/master@{#476499} 
- 
Brian Sheedy authoredThis reverts commit eb03fb79. Reason for revert: Test is still flaky after all. Original change's description: > Re-enable WebVrTest#testPoseDataUnfocusedTab > > Re-enables the previously flaky WebVrTest#testPoseDataUnfocusedTab. > Flakiness appears to have been caused by the move to JUnit4 and fixed > in one of the CLs that did additional cleanup and improvements after the move. > > Bug: 726986 > Change-Id: I6e54b87e21eaed91ac668125857c09e6df4b46e2 > Reviewed-on: https://chromium-review.googlesource.com/521842 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#476409} TBR=mthiesse@chromium.org,bsheedy@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726986 Change-Id: Iecf5abe7ab0f1d27dcb149ca53f480f758de7be3 Reviewed-on: https://chromium-review.googlesource.com/522182 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#476498} 
- 
wzang authored1) We need the outer-container to be scrollable when gaia screen and virtual keyboard are shown together, so the dark overlay ('login-shield') should always have the same size with the larger one of the outer-container and the scroll-container, otherwise we see areas without overlay when scrolling up. 2) We should remember to clear contents on the small pods container before rebuilding pods. BUG=718156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2916973002 Cr-Commit-Position: refs/heads/master@{#476497}
- 
pkasting authoredRevert of ChromeOS: Per-user time zone: refactor tests first. (patchset #10 id:180001 of https://codereview.chromium.org/2907493002/ ) Reason for revert: Looks to have caused Linux CrOS link failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/87898 Original issue's description: > ChromeOS: Per-user time zone: refactor tests first. > > This Cl prepares tests to support per-user timezone implementation. > > BUG=622555, 699472 > > TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org > > Review-Url: https://codereview.chromium.org/2907493002 > Cr-Commit-Position: refs/heads/master@{#476478} > Committed: https://chromium.googlesource.com/chromium/src/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c TBR=stevenjb@chromium.org,phajdan.jr@chromium.org,xiyuan@chromium.org,alemate@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622555, 699472 Review-Url: https://codereview.chromium.org/2919933002 Cr-Commit-Position: refs/heads/master@{#476496} 
- 
hansberry authoredBUG=672263 Review-Url: https://codereview.chromium.org/2917803002 Cr-Commit-Position: refs/heads/master@{#476495} 
- 
scottchen authoredTBR=grt BUG=712414 Review-Url: https://codereview.chromium.org/2916953002 Cr-Commit-Position: refs/heads/master@{#476494} 
- 
patricialor authoredThe "Images" content setting is missing from "Site Details". Add it. chrome: //settings/content/siteDetails?site=http%3A%2F%2Fpermission.site%3A80 Review-Url: https://codereview.chromium.org/2915743002 Cr-Commit-Position: refs/heads/master@{#476493} 
- 
Fernando Serboncini authoredDepending on: https://chromium-review.googlesource.com/c/518308/ Bug: 727804 Change-Id: I70e48bd5336a2fca3e5661ef1df8e03941003a10 Reviewed-on: https://chromium-review.googlesource.com/517675Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#476492} 
- 
rch authoredresulting in the connection being closed due to a synchronous write error. BUG=728434 Review-Url: https://codereview.chromium.org/2915973002 Cr-Commit-Position: refs/heads/master@{#476491} 
- 
Johan Tibell authoredpreferences.mojom and preferences_configuration.mojom had to be merged as they would cause a circular import otherwise. BUG: 654988 Change-Id: I061365e7c6c7ae3c851e427a24d2a322e1210987 Reviewed-on: https://chromium-review.googlesource.com/514902Reviewed-by: Martin Barbella <mbarbella@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Johan Tibell <tibell@chromium.org> Cr-Commit-Position: refs/heads/master@{#476490} 
 
-