- 29 Jan, 2019 40 commits
-
-
Dmitry Gozman authored
The following tests were not waiting for the iframe to load, so they effectively excercised CSP against about:blank iframe: - to-javascript-parent-initiated-child-csp.html - to-javascript-parent-initiated-parent-csp.html One of the tests doesn't pass now, which needs investigation. Bug: 694525 Change-Id: I218426b5d6b1b163d5acfc01522ebf9606c977d6 Reviewed-on: https://chromium-review.googlesource.com/c/1438339Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#627005}
-
Marc Treib authored
If EncryptEverythingAllowed() was false, then PeopleHandler already skipped the call to EnableEncryptEverything(), but it did still call SetEncryptionPassphrase(). That could get users into a weird state where Sync stopped working. This CL fixes the issue by also skipping the SetEncryptionPassphrase() call in case EncryptEverythingAllowed() is false. Bug: 924847 Change-Id: I3b606e3ea9d0a8f86b865b41eda233dd472cc1eb Reviewed-on: https://chromium-review.googlesource.com/c/1439299Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#627004}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86579d2a3a9f..fdefacc215d5 Created with: gclient setdep -r src-internal@fdefacc215d5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I960f1a47416b61fc589db4e2988666360f467f51 Reviewed-on: https://chromium-review.googlesource.com/c/1442537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627003}
-
Antonio Gomes authored
[s13n] Migrate c/b/policy/cloud/user_policy_signin_service_unittest.cc away from AccountTrackerService The CL gets rid of the direct uses of AccountTrackerService API, in favor of IdentityManager APIs. The former becoming an implementation detail of the later. Two particularities are worth highlighting: 1) In test SignOutThenSignInAgain, IdentityTestEnvironment::MakeAccountAvailable gets called in a roll (via TestSuccessfulSignin() -> RegisterPolicyClientWithCallback()), being calls interpolated by a call to IdentityTestEnvironment::ClearPrimaryAccount. In order for ClearPrimaryAccount to trigger the removal of accounts in AccountTrackerService when tokens are revoked with PO2TS, AccountFetcherService::EnableNetworkFetchesForTest() is called. 2) The change above (1) forces the execution of Android specific code in AccountFetcherService, namely ChildAccountInfoFetcherAndroid within the scope of test SignOutThenSignInAgain. For this to get processed properly, the call to ChildAccountInfoFetcherAndroid::InitializeForTests() was added as well. Similar pattern is seen on [1]. [1] https://cs.chromium.org/chromium/src/components/signin/core/browser/account_tracker_service_unittest.cc?l=227 BUG=922756 Change-Id: I16c7c8489896fbe3349941d61102464e94060aba Reviewed-on: https://chromium-review.googlesource.com/c/1436534 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#627002}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22de82ca..637ba4af Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If695bccd0a7238a7d29906ae508e789333221f19 Reviewed-on: https://chromium-review.googlesource.com/c/1442754Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627001}
-
Olga Sharonova authored
They are used for audio service / audio process launch which is ongoing. Bug: 919655,919652,919650 Change-Id: I161ab638737ed56bb330a1bdc08b430879df478e Reviewed-on: https://chromium-review.googlesource.com/c/1442192Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#627000}
-
Bence Béky authored
https://github.com/quicwg/base-drafts/pull/2111 changed a whole bunch of terminology without changing the wire format. This CL updates the implementation with the name changes: s/Largest Reference/Insert Count/ s/Base Index/Base/ s/Delta Base Index/Delta Base/ s/Table State Synchronize/Insert Count Increment/ Also, decrement absolute index to make it zero-based. Internally a zero-based "real index" was used, there is no more need for that. Also rename Dynamic Table Size Update to Set Dynamic Table Capacity according to https://github.com/quicwg/base-drafts/pull/2115. Dynamic table size, dynamic table capacity, and maximum dynamic table capacity is already in the code base. This CL lands server change 230923988 by bnc. BUG=488484 Change-Id: I36ffe38a0caa22615434cbe996a20b86af47ee05 Reviewed-on: https://chromium-review.googlesource.com/c/1441496 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#626999}
-
Andrew Grieve authored
Since it's expensive to force a GC, test runners just check that all LifetimeAsserts are set as "safeToGc" between tests. Fixes missing destroy() / close() calls in tests. Bug: 149440 Change-Id: I364736a08ae9040449ea66542d65cf59b4efd020 Reviewed-on: https://chromium-review.googlesource.com/c/1432919 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#626998}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be6549a59d50..a09731e5cf3e git log be6549a59d50..a09731e5cf3e --date=short --no-merges --format='%ad %ae %s' 2019-01-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@a09731e5cf3e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ibd63c9aa403f19559fef1c5b395a0ceddcb0fc2e Reviewed-on: https://chromium-review.googlesource.com/c/1442536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626997}
-
Stephane Zermatten authored
Before this patch, the controller would stay in the running state between the end of a script and the time runnable scripts were found. In practice, for users, this meant that the website could be available, but keyboard could be unavailable until a runnable script is found. During that time the progress bar should have been pulsing but wasn't. After this patch, the controller enters the prompt state immediately after running a script, starting the pulsing and making the keyboard available right away. The cost of this is that in some corner case, the state can switch to the prompt state then quickly enter an error case. Bug: 122825639 Change-Id: Id4927a750370ec59e5c1216ebac01d54e377b2f3 Reviewed-on: https://chromium-review.googlesource.com/c/1442711 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626996}
-
Fergus Dall authored
Change-Id: If1ce2c1dc88929cce71f60f3980521f8209e8078 Reviewed-on: https://chromium-review.googlesource.com/c/1429300 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#626995}
-
Fergus Dall authored
This is needed because at the current time we have no way to get such a list, and we arguably shouldn't be trying to handle containers we didn't set up anyway. The pref is a list of dictionaries, with values for "vm_name" and "container_name". By default, the pref will be set to [{vm_name: termina, container_name: penguin}] to handle existing users. Change-Id: I69437fc3e7675da9058d9f83436edc82c5dc91db Reviewed-on: https://chromium-review.googlesource.com/c/1429320 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#626994}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2900d34d5975..40cd93a53328 git log 2900d34d5975..40cd93a53328 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 dhanyaganesh@chromium.org BuildbucketV2: Setup Buildbucket V2 client and add a call Created with: gclient setdep -r src/third_party/chromite@40cd93a53328 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I07c38b2f811865a70948752f5f96de115a4f14b4 Reviewed-on: https://chromium-review.googlesource.com/c/1442535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626993}
-
Mikel Astiz authored
Nothing really guarantees that a SyncableService (or a remote device) populates the non-unique name with an empty string, so let's relax the DCHECKs although they don't seem to fail in practice. Bug: 870624 Change-Id: If26df0329c9749c0c2eb6b0768b8ae544b1c3879 Reviewed-on: https://chromium-review.googlesource.com/c/1442653Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#626992}
-
Yutaka Hirano authored
ResponseBodyLoader is needed to provide a way to drain data pipe from the resource loader, with the following restrictions: - We are going to provide a hook point on blink::Resource. Not every Resource loading body is associated with a ResourceLoader (e.g., when MHTML is involved), so we need an abstraction layer. - Passing a broad interface is misleading and dangerous, so we want to pass an object with only "drain" function(s). Bug: 894819 Change-Id: Ia3e849d1e100e2e6936fa88a5724a7adc3b07517 Reviewed-on: https://chromium-review.googlesource.com/c/1433662 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626991}
-
Dominik Röttsches authored
Fixes emoji subdivision flag rendering when fallback is needed to find the emoji font that covers subdivision flags. Fixes conflicts between Chromium and HarfBuzz' preferences for compiler warnings configuration by using HarfBuzz' new HB_NO_PRAGMA_GCC_DIAGNOSTIC_WARNING define which avoids overriding Chromium's -Werror. Rebaselines due to a change in fallback mark positioning centering marks at the middle of the advance width instead of the middle of the ink rectangle. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/36fb2b4da971..fe5329231015 $ git log 36fb2b4da..fe5329231 --date=short --no-merges --format='%ad %ae %s' 2019-01-28 behdad [CI] Peg CircleCI badge link to master branch 2019-01-28 behdad [ci] Peg build status badges to master branch 2019-01-28 behdad Switch README / README.md 2019-01-28 behdad [uniscribe] Whitelist function type cast 2019-01-28 behdad Fix sign comparison error 2019-01-28 behdad Fix warning 2019-01-28 behdad [pragma] Silence MSVC unknown-pragma warning 2019-01-26 behdad Fix -Wcast-function-type warnings in util/ with gcc 4.8 2019-01-25 behdad Fix mac test 2019-01-25 behdad More static constexpr 2019-01-25 behdad [AAT] Add test for recent Ligature stack fix, using Zapfino on Mac 2019-01-24 behdad [AAT] Minor sign 2019-01-24 behdad [AAT] Use a ring buffer for ligature stack 2019-01-24 behdad Whitespace 2019-01-24 behdad [AAT] Handle transition errors during machine operation 2019-01-24 behdad [AAT] Ignore machine errors and continue 2019-01-24 behdad [AAT] Minor 2019-01-24 behdad [AAT] Handle out-of-bounds classes 2019-01-24 behdad [AAT] Minor 2019-01-24 behdad [AAT] Minor 2019-01-24 behdad More pragma control 2019-01-24 behdad Comment 2019-01-24 behdad Fix test 2019-01-24 behdad Form cluster for Emoji sub-region tag sequences 2019-01-24 behdad Fix macos tests with previous commit 2019-01-24 behdad Adjust mark offsets when zeroing from fallback mark positioning code Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 907385, 924848 Change-Id: I40ef6b0738c0b7d1a2d54fd75d8b83dbc680eccb Reviewed-on: https://chromium-review.googlesource.com/c/1442194Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#626990}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d02384487f8..949f0fdc10bf git log 3d02384487f8..949f0fdc10bf --date=short --no-merges --format='%ad %ae %s' 2019-01-29 nisse@webrtc.org Move FrameCountObserver from RTPSender to RtpVideoSender 2019-01-29 oprypin@webrtc.org mb: remove 'type': 'gn' because it's the default and doesn't mean anything 2019-01-29 eladalon@webrtc.org Only instantiate TemporalLayersChecker in debug builds 2019-01-29 eladalon@webrtc.org Pass explicit frame dependency information to RtpPayloadParams 2019-01-29 johnny@vidyo.com Added VcmCapturer::Create loop to allow nonzero device index. 2019-01-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ed7fd9b7..531da0ed (626752:626885) Created with: gclient setdep -r src/third_party/webrtc@949f0fdc10bf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifae532a038c6193a5708626c240287772da319a6 Reviewed-on: https://chromium-review.googlesource.com/c/1442791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626989}
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from InlineSigninHelper and uses IdentityManager instead of it. Bug: 922791 Change-Id: I5ac543078be1e08dd1c564ab2a4dcb655c55a359 Reviewed-on: https://chromium-review.googlesource.com/c/1438854 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626988}
-
Clemens Arbesser authored
before: https://screenshot.googleplex.com/T2YQ1JAP0tf.png after: https://screenshot.googleplex.com/uKLQ1UV365h.png Bug: 806868 Change-Id: Idf003094176f46b8614ea1784aec0245ef0837de Reviewed-on: https://chromium-review.googlesource.com/c/1442195 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626987}
-
Julie Jeongeun Kim authored
This CL removes unused header, signin_pref_names.h, from child_account_service.cc. Bug: 890795 Change-Id: If243590db397fd6d70cb5b23e38e500346d9f508 Reviewed-on: https://chromium-review.googlesource.com/c/1442074Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#626986}
-
Jordan Demeulenaere authored
Change-Id: Ief1b7bdb79394818d5511c7e11945d5293be1814 Reviewed-on: https://chromium-review.googlesource.com/c/1442235Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#626985}
-
jdoerrie authored
This change prepares base/files for the base::string16 switch to std::u16string. Bug: 911896 Change-Id: Ieb039f1394419291b9c710023be9e8190d3f2c54 Reviewed-on: https://chromium-review.googlesource.com/c/1437281Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#626984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 80399d3a. With Chromium commits locally applied on WPT: 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3eb404ca162bc1329369ab11a50c32b05353f14b Reviewed-on: https://chromium-review.googlesource.com/c/1442532Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626983}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c93600f78b3..86579d2a3a9f Created with: gclient setdep -r src-internal@86579d2a3a9f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iee913b4591ad8fedbcc25a915d2a324e17ada7fa Reviewed-on: https://chromium-review.googlesource.com/c/1442673Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626982}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/038fb113a1f0..acd0b9629023 git log 038fb113a1f0..acd0b9629023 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 hjd@google.com Merge "perfetto-ui: Fix two small UI bugs" Created with: gclient setdep -r src/third_party/perfetto@acd0b9629023 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I165ef08f95174ace8c61178c49b004f9ac69959a Reviewed-on: https://chromium-review.googlesource.com/c/1442671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626981}
-
Shik Chen authored
Refs: http://go/htmlcssstyle#Declaration_Order https://cs.chromium.org/chromium/src/tools/web_dev_style/css_checker.py?l=89&rcl=48ef45a0c6f5fd43faf4c1654aeacabd5ea988b6 BUG=b:117810572,chromium:918091 TEST=Manually open CCA and check preview/capture/recording still works. Change-Id: I18a2434cdc78219051a47c16fc65965b89177562 Reviewed-on: https://chromium-review.googlesource.com/c/1433661 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#626980}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eae881c2a8ba..a08f0fce7903 git log eae881c2a8ba..a08f0fce7903 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 perezju@chromium.org [Telemetry] Remove clear_caches option from browser.Create Created with: gclient setdep -r src/third_party/catapult@a08f0fce7903 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244 TBR=sullivan@chromium.org Change-Id: Ie20da52c211d6855e7f80a4afb7bd34258d665ba Reviewed-on: https://chromium-review.googlesource.com/c/1442672Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626979}
-
Stephane Zermatten authored
Before this patch, users selecting "Go Back" when asked to confirm inconsistent details caused a crash. This was caused by std::move being called twice on the same callback. This patch gets rid of the crash by keeping the callback in the action instance instead of the individual callbacks. Bug: 806868 Change-Id: I6f8520e4f3b97bed40369cc95f19c5d2e763f95f Reviewed-on: https://chromium-review.googlesource.com/c/1442651Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626978}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a58fb5f..22de82ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1e3688bcbabc067111c669955601424e9bed88ea Reviewed-on: https://chromium-review.googlesource.com/c/1442292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626977}
-
Laís Minchillo authored
Change DEV_SUFFIX presubmit check to use the pattern '\bDEV_SUFFIX\b' instead of searching for the raw string 'DEV_SUFFIX'. This can potentially avoid some false positives. boundary_interfaces no longer triggers a false positive. Bug: 921784 Test: Locally adding SOME_DEV_SUFFIX or DEV_SUFFIX_SOME in Change-Id: I5a9d6b04182ec8ebcbb3e6d9eba3f757da0c0847 Reviewed-on: https://chromium-review.googlesource.com/c/1436032 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626976}
-
Finnur Thorarinsson authored
Bug: 925374, 860467 Change-Id: If11e171966d2bca09254ec5ff942c75556c0b490 Reviewed-on: https://chromium-review.googlesource.com/c/1436261 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#626975}
-
Alessio Bazzica authored
First import of PFFFT. No build file has been added yet. For more details, see http://bugs.webrtc.org/9577 Bug: webrtc:9577 Change-Id: I62e688faf4fcd847541a885a52e7dc8ef78fe0e7 Reviewed-on: https://chromium-review.googlesource.com/c/1155600Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#626974}
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/c/chromium/src/+/1384258 it was implemented using a new architecture for automatic generation. This CL implements using the same infrastructure for manual generation with using renderer ids as indentifiers instead of id attribute. As result, it fixes cases with fields with no id attributes, on which manual generation usually failed before. Bug: 866444 Change-Id: Iaf268fc3c92e27b5ca05ba528f487558a2a168eb Reviewed-on: https://chromium-review.googlesource.com/c/1393363 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626973}
-
Martin Šrámek authored
This reverts commit 5f7f5569. Reason for revert: Seems to break multiple Chrome OS trybots. See crbug.com/926154 for more details. Original change's description: > [s13n] Migrate ContentAreaAccountsMigration away from GCMS::Observer > > CL changes the inheritance ofi ContentAreaAccountsMigration from > GaiaCookieManagerService::Observer to IdentityManager::Observer instead. > > No functionality change expected. > > BUG=859882 > > Change-Id: I907b2624d23e93b6a0ecbcda3e39f0322f238612 > Reviewed-on: https://chromium-review.googlesource.com/c/1436916 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626748} TBR=xiyuan@chromium.org,tonikitoo@igalia.com,lowell@chromium.org Change-Id: Ide04520a6a6f249e5220a6b9086c80b591bc923e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859882,926154 Reviewed-on: https://chromium-review.googlesource.com/c/1442197Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#626972}
-
François Beaufort authored
Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eFZ3h_A3VTY Bug: 917303 Change-Id: I96e19600bad93f53b2014bacea6aa49c9d74a269 Reviewed-on: https://chromium-review.googlesource.com/c/1426703Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#626971}
-
Hiroki Nakagawa authored
This CL stops calling 'delete this' in WorkerScriptLoadFailed(), and instead makes sure WorkerContextDestroyed() is called in any case. This cleanup is necessary for off-the-main-thread shared worker script fetch because when the feature is enabled, we cannot destroy the worker at WorkerScriptLoadFailed(), and need to wait for completion of worker thread termination. Bug: 924041 Change-Id: Ia4b744f1d7302efbc53fdc09e42e414a7b768865 Reviewed-on: https://chromium-review.googlesource.com/c/1441735Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#626970}
-
Takashi Toyoshima authored
Enable the feature by default, but with a FeatureList kill-switch. Bug: 570205 Change-Id: I003c21871ab71e47a863707b9709a39d76883635 Reviewed-on: https://chromium-review.googlesource.com/c/1429820Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#626969}
-
Yoav Weiss authored
The very fact that AppCache is supported introduces a delay to preloaded requests. We could use the `manifest` attribute to detect pages where AppCache is used and only delay requests there. This CL adds a counter for pages where this heuristic will fail (and likely result in a spurious download). Assuming the counter is relatively low, we'd be able to go ahead with implementing the heuristic. Bug: 788757 Change-Id: If5ca0c8682fa677677df38f59946b3198588d4a3 Reviewed-on: https://chromium-review.googlesource.com/c/1442051 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#626968}
-
BUG=762641 TBR=newcomer@google.com Change-Id: Idfee4530b90be0b2cecd0a37dfc7b7c194423bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1442533Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626967}
-
Ruben Bridgewater authored
This allows two console layout tests to fail as they have a wrong result expectation which is fixed as soon as the tests do not report failures anymore. Reference: https://chromium-review.googlesource.com/c/v8/v8/+/1350790 Issue: https://crbug.com/924308 Change-Id: I5d9fc375c675c2914a473d06d8e1ce047df30238 Reviewed-on: https://chromium-review.googlesource.com/c/1427980 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#626966}
-