GitLab

Make UploadDataStream::Reset public.
Call Reset() from HttpNetworkTransaction's dtor.
Add tests.

BUG=244725
TEST=net_unittests --gtest_filter="*HttpNetworkTransactionTest.CancelDuringInitRequestBody*"

Review URL: https://codereview.chromium.org/25217002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226433 0039d316-1c4b-4281-b951-d872f2087c98

Test introduced in r226182.

BUG=302908, 295758
TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/25474004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226431 0039d316-1c4b-4281-b951-d872f2087c98

TBR=juberti@chromium.org
BUG=298300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=kalman
NOTRY=TRUE

Review URL: https://codereview.chromium.org/25665002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226429 0039d316-1c4b-4281-b951-d872f2087c98

Split ConnectToNameOwnerChangedSignal() from ConnectToSignalInternal().
Add WaitForServiceToBeAvailable()
Add test.

BUG=141009
TEST=dbus_unittests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/25488002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226427 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=158649:158674&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/25654002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226426 0039d316-1c4b-4281-b951-d872f2087c98

MessagePumpDefault was incorrectly using system time instead of monotonic time
for PostDelayedTask. This was fixed in r226378 so we don't need this workaround
any more.

BUG=293736

Review URL: https://codereview.chromium.org/25628004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226425 0039d316-1c4b-4281-b951-d872f2087c98

Left in by mistake in https://codereview.chromium.org/3129003

NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/25479002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294465

Review URL: https://codereview.chromium.org/25444004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226423 0039d316-1c4b-4281-b951-d872f2087c98

Gets rid of run-time division. In the new empty read test, goes from ~8.7
million iterations/second to ~9.7 million iterations/second (and in perf makes
VerifyUserPointer() go from ~10% to ~0.5%).

R=darin

Review URL: https://codereview.chromium.org/25323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=covered

Review URL: https://codereview.chromium.org/25286002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226421 0039d316-1c4b-4281-b951-d872f2087c98

DirectoryContent had basically two functions.
1) The list of entries.
2) The scanning entries from backend.
This CL extracts 2) part from DirectoryContent and create ContentScanner to
simplify the code path. At the same time, some events sent from
DirectoryContent was resorted, and their handlers in FileManager is fixed at
the same time.

BUG=279614
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.

Review URL: https://codereview.chromium.org/25278002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302908
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/25679003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298398

Review URL: https://codereview.chromium.org/25144002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226416 0039d316-1c4b-4281-b951-d872f2087c98

original review: https://codereview.chromium.org/24538008/
difference to original review: android test updated.

1) fill Wallet phone number data in a format that's more similar to Autofill (i.e. whole number without any formatting)
2) display Wallet phone numbers in rAc in US-national format
3) display Autofill phone numbers in rAc in user-supplied format, unless there is no formatting. In that case add formatting.

BUG=297204
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/25092011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226415 0039d316-1c4b-4281-b951-d872f2087c98

R=derat@chromium.org

Review URL: https://codereview.chromium.org/25058009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226414 0039d316-1c4b-4281-b951-d872f2087c98

This is just a refactor to reduce some code duplication and homogenize features processing a bit.

Review URL: https://codereview.chromium.org/23867003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226413 0039d316-1c4b-4281-b951-d872f2087c98

This moves InsertSyncPoint() and SignalSyncPoint() to the gpu::GpuControl
interface to get a step closer to removing the WebGraphicsContext3D interface.

R=piman,sievers

Review URL: https://codereview.chromium.org/24925002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298240

Review URL: https://codereview.chromium.org/24632002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267888
R=bryaneyler@google.com,eroman@chromium.org,ellyjones@chromium.org,rsleevi@chromium.org,jochen@chromium.org

Review URL: https://codereview.chromium.org/24276011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226410 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268984
TEST=no functional change.

Review URL: https://codereview.chromium.org/23851016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226409 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226408 0039d316-1c4b-4281-b951-d872f2087c98

- Makes the content edge visible for restored v1 apps
- Makes the PanelFrameView header height the same as that for CustomFrameViewAsh

BUG=301865
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/25270004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226407 0039d316-1c4b-4281-b951-d872f2087c98

When web page is loading, a lot of TabChangedAt() is called. That means a
lot of UpdateAppState() is called, too.
For example, loading google drive site causes almost more than 70 calling
of TabChangedAt().
To replace TabChangedAt(), WebContentsObserver is used.

TabDetachedAt() is replaced with TabClosingAt().
When tab is detached, there are two cases.
The one case is tab is attached to other tab strip model. In this case, 
its LauncherItem is updated by ActiveTabChanged().
The other case is tab is closed. In this case TabClosingAt() can handle LauncherItem status.
TabReplacedAt() is only used when tab is discarded when low memory condition is occurred.
In this case, updating the launcher item status is not good because user don't need to know
about discarding a tab. Also it is reloaded again when user selects discarded tab.

R=skuhne@chromium.org
BUG=NONE
TEST=browser_tests, unit_tests

Review URL: https://codereview.chromium.org/23708028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226406 0039d316-1c4b-4281-b951-d872f2087c98

When a complete video frame is decoded, this CL converts the pixels from
BGRA to a format suitable for loading into a Java Bitmap directly. This
removes the need to create a temporary int[] array in Java.

Review URL: https://codereview.chromium.org/23677011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226405 0039d316-1c4b-4281-b951-d872f2087c98

Like the update nagger
Like IME
Like the drive item


BUG=227247
TEST=see bug

Review URL: https://codereview.chromium.org/23560013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226404 0039d316-1c4b-4281-b951-d872f2087c98

Adds an end-to-end browser test to Picasa.

Dependent on this fix going through:
https://codereview.chromium.org/24269007/

BUG=151701

Review URL: https://codereview.chromium.org/23513059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226402 0039d316-1c4b-4281-b951-d872f2087c98

Currently the window does not restore to its original size because we
save the current size of the window whenever it's resized. However,
during a zoom (maximize), the windowDidResize notification is fired on
every animation frame.

In this CL, the current size is only saved after the animation finishes.
|is_maximized_| and |is_fullscreen_| are also updated when a resize
finishes, and when going in and out of fullscreen.

BUG=168080, 230778, 302053
TEST=Maximize and restore an app window, it should return to its original size.
TEST=Do the following sequence on an app window:
Maximize, fullscreen, exit fullscreen, then restore.
The app should return to its original size.

Review URL: https://codereview.chromium.org/23494065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/23449041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226400 0039d316-1c4b-4281-b951-d872f2087c98

(Namespace fix will come later)

BUG=265769
TEST=build

Review URL: https://codereview.chromium.org/23440033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226399 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302530
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/25555006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226398 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226392 0039d316-1c4b-4281-b951-d872f2087c98

Fixing minor nits (added using std::pair).

Merge internal change: 53257699

Increasing the maximum tcp congestion window to 200 packets from 100.

Merge internal change: 53185276

Add a DCHECK to ensure the sent packet sequence number never goes down
and separate the send alarm into a send alarm and a resume writes
alarm to be used when the socket is still writable an there may be
more pending data to write.

Merge internal change: 53050471

Merged quic_epoll_connection_helper_test.cc from internal code.

Minor nit fixes.

Merge internal change: 53048224

Move QuicAckNotifierManager from QuicConnection to
QuicSentPacketManager.

Merge internal change: 53036185

R=jar@chromium.org, rch@chromium.org, wtc@chromium.org

Review URL: https://codereview.chromium.org/25443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297361, 299956
R=rch@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/25087007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226389 0039d316-1c4b-4281-b951-d872f2087c98

This enum is defined in chrome/common/extensions/extension_constants.h

R=jar@chromium.org

Review URL: https://codereview.chromium.org/25457002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226388 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
BUG=295499

Review URL: https://codereview.chromium.org/25589002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226387 0039d316-1c4b-4281-b951-d872f2087c98

R=jar@chromium.org

Review URL: https://codereview.chromium.org/25578002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226386 0039d316-1c4b-4281-b951-d872f2087c98

Broke the mac build: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%282%29&number=42927

> [rAC, OSX] saveInChrome status now persistent.
> 
> The AutofillDialogController already persisted the state of the
> "Save in Chrome" checkbox. This CL ensures that the OSX dialog reflects
> that persisted state and is properly updated when the state changes.
> 
> NOTRY=true
> BUG=282101
> R=avi@chromium.org
> 
> Review URL: https://codereview.chromium.org/25405003

TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/25673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226385 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have broken win and mac:
http://build.chromium.org/p/chromium/builders/Win/builds/17341
http://build.chromium.org/p/chromium/builders/Mac/builds/22281

> Fix code style and gyp files in cast to build cast_unittest
> 
> *.gypi should not be used for dependency directly. Renaming those files
> to *.gyp. Also style fixes to make compilers happy.
> 
> This change is reland of r226264.
> 
> TBR=acolwell
> 
> Review URL: https://codereview.chromium.org/25544003

TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/25662002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226381 0039d316-1c4b-4281-b951-d872f2087c98