GitLab

This is mostly duplicate code.

Bug: 
Change-Id: Id152dc65ef53eac65d40ef38b6b9da3f962ae9ba
Reviewed-on: https://chromium-review.googlesource.com/832295Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533168}

This UI is shown on the settings page when a phone tells the Chromebook
that it does not have GmsCore notifications enabled.

This CL:
  (1) Updates HostScannerOperation to accept an additional enum value
      indicating that GmsCore notifications are disabled.
  (2) Updates the settings page to show an extra step which is needed in
      some cases to enable notifications.

Bug: 793936, 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I65f34db384956189e6ea3c157a57f48bc4701fe4
Reviewed-on: https://chromium-review.googlesource.com/894729Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533167}

With crrev.com/c/889863 we aligned SCANOUT{_CPU_READ_WRITE,} formats.

This CL adds BGRX_1010102 to {_CPU_READ_WRITE,}.

Additionally, it adds RGBA_8888 and BGRX_8888 to GPU_READ_CPU_READ_WRITE
and GPU_READ_CPU_READ_WRITE_PERSISTENT, effectively aligning all the format
lists for each allowed usage.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0b789b66e0380f23d6071351746fdf94a354871e
Reviewed-on: https://chromium-review.googlesource.com/894150Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533166}

Use InstrumentationRegistry to get actual target context in the two
service test cases. Andr remove BaseITR, BaseChromiumITR, and ChromeITR

Bug: 807251
Change-Id: I9d945ce7c2ce264f84f10124af6b399cba690eef
Reviewed-on: https://chromium-review.googlesource.com/894125Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533165}

Implements Truncate for SmbFileSystem.

Bug: chromium:757625
CQ-DEPEND=CL:879566

Change-Id: Iecf94821ec7237be1fcc07b693c0bdec35903d97
Reviewed-on: https://chromium-review.googlesource.com/889558
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533164}

This CL adds the new omnibox vector icons for Touchable Chrome, and
uses them in place of the existing icons when the kTouchableChrome
feature is active.

BUG=801583
TBR=bajones@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I38b593e8ee3d734eadef00ea8b31c69affffc493
Reviewed-on: https://chromium-review.googlesource.com/885666
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533163}

This fills out screen capture by implementing the permissions prompt and
the session logic which performs the desktop capture with the GPU and
copies the result to the GPU buffer passed from Android.

It also adds a 'system_modal' parameter to the desktop picker dialog so
that it will display properly over the Android windows.

Design doc is here: goto/arcppscreencapture

Bug: b:38452042
Change-Id: Ia2541a9494485704aa290e77aef1dca4578853e7
Reviewed-on: https://chromium-review.googlesource.com/887642
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533162}

Bug: none
Change-Id: I446ceb4903ef021aee24ad6a724c97c1d778b67a
Reviewed-on: https://chromium-review.googlesource.com/894123Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533161}

This reverts commit d5bd9807.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 533073 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q1YmQ5ODA3ZTViYTI0OTBiYzQxNjViN2FlNzg0OTJkOWJlNDgyMGEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4001

Original change's description:
> [CrOS Tether] Update connection retry attempt logic.
> 
> Before this CL, we allowed 3 retries for the entire connection flow,
> which includes advertising, scanning, creating a GATT connection, and
> exchanging messages. However, it makes more sense to think of this as a
> two-part process:
>   (1) Advertising and scanning. This portion always occurs when
>       attempting a BLE connection, even if the device we're trying to
>       contact is not nearby and cannot respond.
>   (2) Creating a GATT connection and exchanging message. This portion
>       only occurs when an Android host is nearby to respond to the
>       Chromebook.
> 
> Connection attempts which fail in part (2) above indicate that the
> device actually is nearby and can potentially connect; additionally
> connection failures during this part of the connection often will
> succeed on a retry. Thus, this CL adds extra connection retry attempts
> if a previous attempt failed in part (2).
> 
> Bug: 805218, 672263
> Change-Id: Ifbedc004b96905d3f77662c45bcf2a9210b06c57
> Reviewed-on: https://chromium-review.googlesource.com/889991
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533073}

Change-Id: I60d645c8baf8c53eb46cbf9eb9341046db7e0c31
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805218, 672263
Reviewed-on: https://chromium-review.googlesource.com/894290
Cr-Commit-Position: refs/heads/master@{#533160}

Bug: none
Change-Id: Ib070e4654f73821a0de3744647e72837dbda38fd
Reviewed-on: https://chromium-review.googlesource.com/894424Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533159}

I confirm that how -g0 affects stacktrace shown in test failure/crash.
With -g1: https://chromium-review.googlesource.com/c/chromium/src/+/892540/1
With -g0: https://chromium-review.googlesource.com/c/chromium/src/+/892187/3

I summarize how stacktrace is shown on each builder affected by this CL.
This CL does not change stacktrace.

|--------------------------+---------------+------------------+---------------+------------------|
| builder                  | -g0 crash     | -g0 CHECK(false) | -g1 crash     | -g1 CHECK(false) |
|--------------------------+---------------+------------------+---------------+------------------|
| android_n5x_swarming_rel | no stacktrace | correct          | no stacktrace | correct          |
| cast_shell_linux         | correct       | correct          | correct       | correct          |
| ios-simulator            | no stacktrace | no stacktrace    | no stacktrace | no stacktrace    |
| linux-chromeos-rel       | correct       | correct          | correct       | correct          |
| linux_android_rel_ng     | no stacktrace | correct          | no stacktrace | correct          |
| mac_chromium_rel_ng      | correct       | correct          | correct       | correct          |
|--------------------------+---------------+------------------+---------------+------------------|


I see improved link time of some large binary on (very slow) andrdoin_n5x_swarming_rel builder.

With this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave603-c4/ninja_log.slave603-c4.chrome-bot.20180130-001251.4049.gz/table?dedup=true
taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350571

Without this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave604-c4/ninja_log.slave604-c4.chrome-bot.20180130-005043.1186.gz/table?dedup=true
taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350593

|-----------------------------------------+---------+-----------|
| link time of each target                | -g0     | -g1       |
|-----------------------------------------+---------+-----------|
| android_clang_arm/libmonochrome.so      | 14.206s | 27.25s    |
| android_clang_arm/libwebviewchromium.so | 12.355s | 1m44.577s |
| lib_components_unittests__library.so    | 22.194s | 1m17.442s |
| libwebviewchromium.so                   | 30.729s | 1m45.147s |
| libmonochrome.so:                       | 31.862s | 1m33.027s |
| lib_unit_tests__library.so              | 53.444s | 44.943s   |
|-----------------------------------------+---------+-----------|

This patch improved link time in most cases.

Bug: 794423
Change-Id: I757a8a01bed0dea4c62e2f8ebfccc5a163d8cc18
Reviewed-on: https://chromium-review.googlesource.com/892187Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#533158}

This CL adds back the string-to-Mojo-origin conversion removed in http://crrev.com/c/769570.
Assuming the crash seen in bug 787427 is due to users using outdated Media Router component extension (<=M59) which send origins as strings, this fixes the issue.

Bug: 787427
Change-Id: If93782a3bca3ebb2ba8d50c7b42ccbef0ba4363e
Reviewed-on: https://chromium-review.googlesource.com/894859
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533157}

Adds Truncate to SmbProviderClient and FakeSmbProviderClient

CQ-DEPEND=CL:879387

Bug: chromium:757625
Change-Id: Iff2f62efc059a41ad4d15c3cbb18bafac277c690
Reviewed-on: https://chromium-review.googlesource.com/879566
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533156}

This is to fix the crash case happened when we open user menu or the gaia
dialog and then just kill chrome.

Bug: 792579
Change-Id: I30d5e56bdf2b7e17b4f34de9e4935b42ee47c3dc
Reviewed-on: https://chromium-review.googlesource.com/894888Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533155}

Exposes chrome.management to the primary kiosk app.
Subset of the API is disabled in kiosk - the following methods will
return an error if called in kiosk:
 * launchApp
 * createAppShortcut
 * setLaunchType
 * generateAppForLink
 * uninstall
 * uninstallSelf

BUG=800441

Change-Id: Ie3cf691904f9f4442bac104c1a6b6c543d126553
Reviewed-on: https://chromium-review.googlesource.com/861210
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533154}

This reverts commit e0eac774.

Reason for revert: this patch breaks DevTools protocol, see crbug.com/807483

Original change's description:
> Always use backpressure for fetch
> 
> Previously, backpressure would only be applied to fetch responses if the
> Cache-Control: no-store header was set. This was to avoid blocking other
> resource loads that might have to wait for the lock on the http disk
> cache that was held by the resource load to which backpressure was being
> applied.
> 
> As of https://chromium-review.googlesource.com/684615 the disk cache
> supports multiple concurrent writers and so this protection is no longer
> needed.
> 
> Remove support for the non-backpressure mode and always apply
> backpressure.
> 
> The fact that the body is no longer implicitly read is visible
> to tests that observe the result of the fetch() via a side
> channel, specifically inspector and browser tests. Fix such tests
> to explicitly read the body to completion.
> 
> Additionally, in order to satisfy the presubmit check, make
> SharedMemoryDataConsumerHandle::Context::on_reader_detached_ a
> OnceClosure.
> 
> The implementation already implicitly ran on_reader_detached_ at most
> once, because is_on_reader_detached_valid_ would be set to false by
> ResetOnReaderDetached immediately after PostTask was called. Now this
> has been made explicit by using OnceClosure.
> 
> on_reader_detached_ is only reset on the writer_task_runner_
> thread. When the closure is not run this is implemented by the logic in
> ResetOnReaderDetached(), the same as before. When the closure is run the
> behaviour has changed slightly: the OnceClosure is moved into the task
> that is posted to the writer_task_runner_ thread, where it will be
> destroyed automatically after running. There's no nead for a separate
> reset in this case.
> 
> BUG=535793
> 
> Change-Id: I9d2b58e183b84640afc153ac99de08fdc2368240
> Reviewed-on: https://chromium-review.googlesource.com/861695
> Commit-Queue: Adam Rice <ricea@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#530070}

TBR=ricea@chromium.org,yhirano@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 535793
Change-Id: I79a176496f6fada40ba8f2e4d95848421809ecee
Reviewed-on: https://chromium-review.googlesource.com/894683Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533153}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bde04194..27e3a1f6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I03e19c644e4aa366e9491a374d0873408dbe6356
Reviewed-on: https://chromium-review.googlesource.com/894762Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533152}

Use more C++ and base/ features to simplify the code. Fix all the nits
and lint errors as well.

Change-Id: Ib3b80002bfd7b9df45ad535ddb94cdc086d0ca2f
Reviewed-on: https://chromium-review.googlesource.com/890239
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533151}

Ultimately this shaves a couple seconds of runtime off my local
build, so it should help with timeouts on Android bots.

This removes the following perf test cases since they don't
correspond to well used codecs. Well used in this case means
we see above 2% daily usage per relavant histograms:

DemuxerPerfTest:
- bear.avi
- sfx_s16le.wav
- bear.flac

AudioPipelineIntegrationPerfTest:
- sfx_f32le.wav
- sfx_s24le.wav
- sfx_u8.wav
- sfx.flac

It replaces the above audio tests with more appropriate ones
reflecting actual usage:
- sfx.mp3 (mp3)
- sfx.ogg (vorbis)
- sfx.m4a (aac)

This also splits out a couple chunk TEST() blocks into
parameterized tests for cleanliness, though that won't
improve performance since we run perf tests --single-process.

BUG=803460
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iebac045d09c867eb3cc7f867d62e8959aa094e66
Reviewed-on: https://chromium-review.googlesource.com/893437
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533150}

Accidentally upstreamed a test test.

TBR=nainar@chromium.org

Bug: 774887
Change-Id: I52b48d2d83f1bdc95d0ac6ffcf5c58d791aa5cf7
Reviewed-on: https://chromium-review.googlesource.com/894744
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533149}

These old webui tests don't currently run, and are being
replaced with a new system based on axe-core.
https://www.chromium.org/developers/accessibility/testing/axe-core

There will be additional cleanup to fully removed axs_testing.js.
See crbug.com/807458.

Bug: None
Change-Id: If2bfb17550fb762272173a40f572c3301c40aa4a
Reviewed-on: https://chromium-review.googlesource.com/894146Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533148}

Turns on these Omnibox UI experiments in the fieldtrial testing config:
 - Swap title and URL
 - Vertical margin 8px

Bug: 794203, 794204
Change-Id: I4f5c29ae845e38d42a5d8a1145e1d64bdb92542b
Reviewed-on: https://chromium-review.googlesource.com/891632Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533147}

To help diagnose the broken referrer chain problem to extension inline
install, we want to use Proto instead of JSON as the content format,
such that we can easily add more info to the request.

In addition, when referrer chain appears broken (completely empty, or
missing some entries), we are going to append recent navigation events
(quantity controlled by Finch) and send them for SBER/SCOUT users when
they are not in incognito.

Bug: 780532
Change-Id: I37ee0e6bf7a5e295640fca3eee86cb249595c7f5
Reviewed-on: https://chromium-review.googlesource.com/850726Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533146}

Change-Id: I169564f989c6e17d433ccf31c9b7d50ae2b3cad3
Reviewed-on: https://chromium-review.googlesource.com/889417Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533145}

This is required to roll out the heuristic language model to 1% on stable.

Bug: 762352
Change-Id: Iba29ae1e9335b38e853f46abd5e267f16705c786
Reviewed-on: https://chromium-review.googlesource.com/894743Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533144}

Bug: internal b/72704032
Test: File feedback from home app

Change-Id: I38aa32a796344c42c38bb9b0820376109586b803
Reviewed-on: https://chromium-review.googlesource.com/894641
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533143}

A previous CL (crrev.com/c/889643) made the function no longer use any
instance of RenderedPosition. As a follow-up, this CL moves the function
to VisibleUnits to join its doppelganger AbsoluteCaretBoundsOf().

Change-Id: If95cca29354ece16beb461774fab800dc9f37db0
Reviewed-on: https://chromium-review.googlesource.com/891583
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533142}

https://chromium.googlesource.com/catapult.git/+log/9fd18084bd44..7c98d04db58b

$ git log 9fd18084b..7c98d04db --date=short --no-merges --format='%ad %ae %s'
2018-01-29 dtu [pinpoint] Stats page.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ifae1b140b38e251ec87c1e578b575c3b0b6eefdb
Reviewed-on: https://chromium-review.googlesource.com/894733Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533141}

This reverts commit e1c22cc3.

Reason for revert:
Compile failure on Windows https://ci.chromium.org/buildbot/chromium/Win%20x64/18699

Original change's description:
> Move url_loader_unittest.cc and network_service_unittest.cc to services/network.
> 
> Their content dependencies have been removed in previous changes.
> 
> Bug: 753658
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62
> Reviewed-on: https://chromium-review.googlesource.com/893651
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533113}

TBR=jam@chromium.org,rockot@chromium.org,tsepez@chromium.org

Change-Id: Id179d007751f72c0813162ed0995232b033e74a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/894710Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533140}

The entirety of Polymer, seems to have been included on iOS, for no good reason.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1bfb524c0efec710de91601123800801a15ceea1
Reviewed-on: https://chromium-review.googlesource.com/892122Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533139}

https://skia.googlesource.com/skia.git/+log/51494f6615b8..ac568a934f8f

$ git log 51494f661..ac568a934 --date=short --no-merges --format='%ad %ae %s'
2018-01-25 mtklein 1010102, 101010x, 888x in sw
2018-01-30 reed saturate some irect ops for fuzzers
2018-01-30 halcanary SkQP: fix upload/download scripts
2018-01-30 bsalomon Fix mock tex rt gpu mem size
2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 513bc77df..bd6ae4aa1 (1 commit)
2018-01-30 jvanverth Revert "Reduce the amount of padding needed for SDFs, take 2"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I93cdd6392681b0a670aba84f2c260f4a08519c1b
Reviewed-on: https://chromium-review.googlesource.com/894172Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533138}

On about 3-4% of Chrome builds on my workstation one of the executables
generated and then used during the build will crash. The binary on disk
is always fine but the loader sometimes maps in pages of zeroes where it
should be mapping in pages from the just-generated binary. Having a page
of zeroes where you are expecting useful instructions tends to lead to
crashes.

This appears to be a bug in the OS disk cache. My suspicion is that this
kernel bug only happens on multi-socket systems, but this is
speculation.

This bug happens regardless of which compiler or linker is used, and
appears to happen on multiple Windows versions. The best reproes have
been on Windows 10 Creators Update, or at least that is where I have
done most of my testing.

Extensive testing - hundreds of overnight builds - has shown that the
problem goes away if FlushFileBuffers is called on the output file
after linking is finished. Eventually this fix/hack will be coded into
lld-link.exe, but for now it is put in tool_wrapper.py to fix the bug
for both link.exe and lld-link.exe.

Earlier versions of this fix only applied it to files with .exe
extensions. However the bug is believed to have happened with DLLs, and
may also affect .lib files created by the linkers, so now it is done
always. The belief is that the performance impact will be negligible.

Importing of win32file required some trickiness because in the context
of ninja builds of Chrome the depot_tools python.bat file is apparently
not called. This means that the python directory is not added to the
system path. The python runtime correctly finds win32file.pyd and calls
LoadLibrary on it but the OS then finds its dependencies in another
version of python installed on the system and the DLL load fails if
those are 64-bit instead of 32-bit.

Bug: 644525
Change-Id: I71d63b47050385e2e5ba46ced9c8018220370ba7
Reviewed-on: https://chromium-review.googlesource.com/876683
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Zachary Turner <zturner@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533137}

When tables exist, we apply a heuristic to determine whether they are
used for layout or for data. Previously, we only exposed tables using
table roles if it appeared to be used for data.

However, some screen readers on some platforms wish to make this
determination.

For some platforms, expose the layout table as a table with a hint
that it is used for layout. We can more easily change this for each
platform going forward by simply changing the mapping of
Role::kLayoutTable and kLayoutTable[Cell|Column|Row]

For now:
- Windows and ChromeOS -- treat layout tables as tables
- Mac and Android -- treat layout tables as ordinary text containers.
For Mac, we are following this convention until we determine that it
would be desirable to be different from Safari and how we worked before.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a8f59e2a2d62b6d2e65b8beae59bd923fea25d9

Bug: 804880
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a8f59e2a2d62b6d2e65b8beae59bd923fea25d9
Reviewed-on: https://chromium-review.googlesource.com/879283Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533136}

it's not necessary after 7a379f73

Bug: none
Change-Id: I0bb31204eafcd258ce42be06f6da3b300e8125de
Reviewed-on: https://chromium-review.googlesource.com/889380Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533135}

Bug: 803700
Change-Id: Ie88645a2ec0244b6f5870fdb3187087e918e8855
Reviewed-on: https://chromium-review.googlesource.com/884561
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533134}

When PWA menu buttons are visible in the title bar we fail to animate the
minimize button to the correct position when exiting tablet mode.

This CL fixes the bug by removing the assumption that the minimize button
is the left-most button and generalises the slide animation to all buttons
left of the size button.

Bug: 802144
Change-Id: I8ad560c966f9b0fa04beabcf6b96850fe784b5aa
Reviewed-on: https://chromium-review.googlesource.com/892186
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533133}

The test is timeout-flaky.

TBR=rdevlin.cronin@chromium.org

Bug: 807471
Change-Id: Ie70d0217c21ce9ed3ae1c1a79b6a030dd70886f5
Reviewed-on: https://chromium-review.googlesource.com/894736Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533132}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/7f07816e463d..476698afdd0b

$ git log 7f07816e4..476698afd --date=short --no-merges --format='%ad %ae %s'
2018-01-09 shenghuazhang [ndk] Add android ndk deps in native_client/SConstruct
2017-10-12 tandrii Remove Rietveld CQ config.

Created with:
  roll-dep src/native_client


The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mseaborn@chromium.org

Change-Id: I045e06e136ddd154a84cfd5e3500758fa7c0522b
Reviewed-on: https://chromium-review.googlesource.com/894187
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533131}

This reverts commit 39dfc337.

Reason for revert: Switching V8 to use page_allocator is blocked on removal of RWX permissions on that side. Reverting this temporarily so we can switch V8 to page_allocator.

Original change's description:
> [page_allocator] Don't allow read/write/execute permissions.
> 
> - V8 is moving to a read/write read/execute system. We won't need
>   read/write/execute and should remove it from Chrome now.
> 
> Bug: chromium:756050
> Change-Id: Icc8a3ec334535c460e74a413cb265de2872db9f5
> Reviewed-on: https://chromium-review.googlesource.com/822514
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523663}

TBR=palmer@chromium.org,bbudge@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:756050
Change-Id: I3fd2b0172822af0ce7e5cf003c53f0b6f69305e8
Reviewed-on: https://chromium-review.googlesource.com/893609Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533130}

ContentViewCore::UpdateFrameInfo() must receive positions and sizes in CSS pixel
except top_shown_pix. When --use-zoom-for-dsf is enabled, those values given to
ContentViewCore::UpdateFrameInfo() are in physical pixel. It results in test
failures of ContentViewScrollingTest#testOverScroll and
ContentViewScrollingTest#testScrollTo. This CL scales down those values given to
ContentViewCore::UpdateFrameInfo() by the device scale factor.

TEST=run_content_shell_test_apk -f ContentViewScrollingTest#testOverScroll
(and ContentViewScrollingTest#testScrollTo) on NEXUS 5X

Bug: 737777
Change-Id: I95be3ed63d569ec9d620fa431c0d6bfa932410ba
Reviewed-on: https://chromium-review.googlesource.com/888183
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533129}