GitLab

R=mkearney@chromium.org

Review URL: https://codereview.chromium.org/164813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251195 0039d316-1c4b-4281-b951-d872f2087c98

> Split out InputMethodMenuManager from InputMethodManager.
> 
> Rename input_method_property to input_method_menu_item, and move to ash/ime.
> 
> BUG=342336, 343044
> 
> Review URL: https://codereview.chromium.org/150203015

I'm reverting as test appears to be consistently failing:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39558/steps/ash_unittests/logs/TestUninitializedGet

InputMethodMenuManagerTest.TestUninitializedGet (run #1):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (4 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #2):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #3):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #4):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (1 ms)

TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/165453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251194 0039d316-1c4b-4281-b951-d872f2087c98

NetworkConnectionHandler::VerifyConfiguredAndConnect() did not
differentiate between the pre-shared key and certificate flow when
verifying the certificate properties of a L2TP/IPsec VPN connection
request. It always threw a 'configuration required' error and caused the
VPN configuration dialog to pop up even when all the credentials
information was available. This CL fixes this issue.

BUG=307665
TEST=Verified the following scenarios:
1. Add a 'L2TP/IPsec + pre-shared key' VPN with 'Save identity and
   password' unchecked. Connect to the VPN and then disconnect. Reconnect
   to the VPN and verify that it prompts for credentials.
2. Repeat 1 but with 'Save identity and password' checked and verify
   that it reconnects without prompting for credentials.

R=pneubeck@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/161083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251193 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326354
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/165373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251192 0039d316-1c4b-4281-b951-d872f2087c98

* Introduced WindowStateObserver::{Pre|Post}WindowShowTypeChange
 We had implicit dependency between OnWindowShowTypeChanged implementations. This clearly separate the things that should happen before and after the window's bounds is updated.

This is another step to introduce state machine.

BUG=318325
TEST=no functional change. all tests should pass.
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/149303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251191 0039d316-1c4b-4281-b951-d872f2087c98

Don't track mouse events in HWNDMessageHandler when they are forwarded by the LegacyRenderWidgetHostHWND class.

We use the TrackMouseEvent API in HWNDMessageHandler when we receive a WM_MOUSEMOVE message. This is to ensure that Windows sends us a WM_MOUSELEAVE
message when the cursor leaves our window bounds. Tooltips use this message to dismiss the tooltip for e.g.

Technically when the mouse enters the child window (LegacyRenderWidgetHostHWND) it has left the parent window. We end up getting WM_MOUSELEAVE messages
for WM_MOUSEMOVES which are sent to the parent window by the LegacyRenderWidgetHostHWND class causing tooltips to not show up and some other bugs.

Fixes as below:-
1. Add a special marker in the hiword of the WPARAM in WM_MOUSEMOVE messages sent by the LegacyRenderWidgetHostHWND class. This is to indicate to the parent
   that it should not track these mouse moves.
2. When we lose activation in HWNDMessageHandler we post a dummy WM_MOUSELEAVE message. This is enable tooltips if they were visible to be dismissed for e.g
   Based on code inspection a WM_MOUSELEAVE message should not cause any issues.
3. Forward WM_MOUSEWHEEL and WM_MOUSEHWHEEL messages via SendMessage to the parent without mucking with the parameters. The offsets are in screen coordinates in
   these messages.
4. Reposting events today fails when we click on the (LegacyRenderWidgetHostHWND) HWND. This is because the current code attempts to find an aura Window at the
   location which fails. I changed the RepostLocatedEvent function to allow a NULL window parameter on Windows. We attempt to forward the event to the HWND at the
   current location if it is on the same thread.

BUG=342323,342298,342299,341879,343246
R=cpu@chromium.org, sky@chromium.org, sky

Review URL: https://codereview.chromium.org/159713012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251190 0039d316-1c4b-4281-b951-d872f2087c98

This separates the frame-walking code from the appcache-setup code, allowing
the next Blink patch in this sequence to handle frame-walking on the Blink side.

BUG=343272
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/161573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251187 0039d316-1c4b-4281-b951-d872f2087c98

This patch consolidates the reset logic and adds a reason for the reset,
for use in histograms. Additionally, connection uptime and overall success
rate are now tracked as well.

BUG=284553

Review URL: https://codereview.chromium.org/160703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251186 0039d316-1c4b-4281-b951-d872f2087c98

> Disable ubercomp for kiosk mode.
> 
> This is a short term workaround. Will revert promptly.
> 
> BUG=342061
> TEST=launch app in kiosk mode and make sure things are still working, and RenderWidget::CreateOutputSurface() does not allocate DelegatedCompositorOutputSurface.
> R=xiyuan@chromium.org
> 
> Review URL: https://codereview.chromium.org/164683002

TBR=hshi@chromium.org

Review URL: https://codereview.chromium.org/165243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251184 0039d316-1c4b-4281-b951-d872f2087c98

Starting with JB MR2, a crashing service triggers a dialog. This is an
awful user experience when a Chrome renderer crashes. The system service
that triggers the dialog also prints the stacktrace to the log and
creates a tombstone.

For now, disable the tombstone and dialog on JB MR2+ "user" builds (or
rather, non-"userdebug", non-"eng" builds).

BUG=273706
TEST=navigate to "about:crash". If on JB MR2+ "user" build, no system
dialog should be shown. Otherwise, dialog should be shown.

Review URL: https://codereview.chromium.org/113873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338831

Review URL: https://codereview.chromium.org/163603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251182 0039d316-1c4b-4281-b951-d872f2087c98

Previously, all gestures would pass through Java as they were filtered prior
to being forwarded to the renderer.  However, only a small subset of gestures
really need to be seen during this filtering phase.  The rest can be accommodated
simply by inspecting the corresponding gesture ack.  This saves ~20us per
GestureScrollUpdate and GesturePinchUpdate.

BUG=341613

Review URL: https://codereview.chromium.org/164643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251181 0039d316-1c4b-4281-b951-d872f2087c98

On low-end devices (and increasingly high-end) we want to
reduce memory as much as possible for normal content yet
not cause calamitous fallbacks such as raster-on-demand
or flickering.

This adds a hard memory limit in addition to the soft limit.
The hard limit will be used only to avoid calamitous behavior.

Limits are the same for this patch and will be tweaked in
future patches.

BUG=339144
NOTRY=true

No-try since this is cc-only, cc_unittests pass, and the errors are not related.

Review URL: https://codereview.chromium.org/140673009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342543

Review URL: https://codereview.chromium.org/163113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251179 0039d316-1c4b-4281-b951-d872f2087c98

GetCategoryGroupEnabledInternal is a hotspot.
It traverses an append-only list, so it's safe to use a finer-grained lock,
and avoid it altogether for the "fast path", i.e., when the category is
already known.

BUG=

Review URL: https://codereview.chromium.org/144423009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251178 0039d316-1c4b-4281-b951-d872f2087c98

Reverting again. Confirmed that this is indeed the CL that broke
the Win7 x64 sync tests.

> Revert 251095 "Revert 250828 "Add a UMA stat to track if the Bro..."
> 
> Speculative re-land to see if this causes sync tests failures again.
> If it does, then we will know if this is the cause.
> 
> > Revert 250828 "Add a UMA stat to track if the Browser blacklist ..."
> > 
> > Speculative revert for failures here:
> > 
> > http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201
> > 
> > > Add a UMA stat to track if the Browser blacklist is Set on the Renderer
> > > 
> > > This shouldn't be happening, but we got some crash reports suggesting it
> > > does. Unable to repo locally so this stat will verify it does occur and
> > > then can be used to verify our fixes actually fix it.
> > > 
> > > BUG=329023
> > > 
> > > Review URL: https://codereview.chromium.org/140763008
> > 
> > TBR=csharp@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/163633005
> 
> TBR=asvitkine@chromium.org
> 
> Review URL: https://codereview.chromium.org/164833002

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/164913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251174 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338972

Review URL: https://codereview.chromium.org/162813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251173 0039d316-1c4b-4281-b951-d872f2087c98

> Set a reasonable icon for the media galleries scan result dialog folder viewer.
> 
> BUG=334309,161119
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/130263007

TBR=vandebo@chromium.org

Review URL: https://codereview.chromium.org/164373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342796

Review URL: https://codereview.chromium.org/163473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331305

Review URL: https://codereview.chromium.org/129793012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251165 0039d316-1c4b-4281-b951-d872f2087c98

Rename input_method_property to input_method_menu_item, and move to ash/ime.

BUG=342336, 343044

Review URL: https://codereview.chromium.org/150203015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334309,161119
NOTRY=true

Review URL: https://codereview.chromium.org/130263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251163 0039d316-1c4b-4281-b951-d872f2087c98

when they block a URLRequest.

BUG=294920

Review URL: https://codereview.chromium.org/153503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251161 0039d316-1c4b-4281-b951-d872f2087c98

Because the docserver now redirects foo.html to foo, presubmit tests
have been changed to query extensionless URLs for corresponding template
files.

BUG=343614
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/164493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251158 0039d316-1c4b-4281-b951-d872f2087c98

The Chrome OS out-of-memory tab discarder uses the "last selected" time as a signal for which tab to discard. This starts at 0 for freshly created background tabs, like those created with a control-click. The user probably doesn't want to discard those tabs, since they just opened them.

Since the only other user of WebContents::GetLastSelectedTime() is devtools, which uses it for a similar kind of sorting based on activity, rename the method to GetLastActiveTime() and start the value with the tab creation time.

BUG=338735
TEST=content_unittests WebContentsImpl.GetLastActiveTime
TBR=torne@chromium.org for rename touching android_webview

Review URL: https://codereview.chromium.org/138913021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168518
NOTRY=true

Review URL: https://codereview.chromium.org/163923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251153 0039d316-1c4b-4281-b951-d872f2087c98

Follow up of crrev.com/141893009.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/164023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/164293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251151 0039d316-1c4b-4281-b951-d872f2087c98

This is to ensure that we mark these processes as DPI aware at startup. Needed because NPAPI plugins perform UI operations like
creating windows parented to the browser etc.

BUG=341543
R=cpu@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/139253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251150 0039d316-1c4b-4281-b951-d872f2087c98

Flakily fails: MSE_ClearKey/EncryptedMediaTest.ConfigChangeVideo/0

NOTRY=true
TBR=yfriedman
BUG=343604

Review URL: https://codereview.chromium.org/163503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251149 0039d316-1c4b-4281-b951-d872f2087c98

TEST=browser_tests
BUG=342546

Review URL: https://codereview.chromium.org/153263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251148 0039d316-1c4b-4281-b951-d872f2087c98

This is the first change to allow RtcpSender to send redundant events.
Rtcp and RtcpSender interface used to accept receiver events logs. They
are now changed to accept ReceiverRtcpEventSubscriber. This allows
RtcpSender to fetch event logs from the subscriber directly.

No functional change other than passing event subscriber instead of
event logs.

Review URL: https://codereview.chromium.org/162333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251147 0039d316-1c4b-4281-b951-d872f2087c98

This is a short term workaround. Will revert promptly.

BUG=342061
TEST=launch app in kiosk mode and make sure things are still working, and RenderWidget::CreateOutputSurface() does not allocate DelegatedCompositorOutputSurface.
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/164683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251146 0039d316-1c4b-4281-b951-d872f2087c98

This change also reverts https://codereview.chromium.org/133273033/
because you don't need to fire onPageFinished separately for ssl error cancel.

BUG=342859

Review URL: https://codereview.chromium.org/144283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251145 0039d316-1c4b-4281-b951-d872f2087c98

A tool to print out static initializers in the format below.

These static initializers cause problems for some sneakier CRT initialization
tricks we do, and they also were measured to have an appreciable slowdown
on startup time (at least on CrOS) so generally trending towards 0 is
desirable.

The basic approach is looking for symbols that have the magic VS name
`dynamic initializer for ' which is the demangled name that's used for
global C++ initializers. The binary is processed by using the DIA SDK
(some of the code is from the Dia2Dump sample), which means that the
target binary requires being built with symbols for this tool to work.

The intention is that a run of this tool will be hooked into the 'sizes'
step on clobber builders on the waterfall, similar to Linux and Mac.

===
Static initializers in a.exe:
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Generic_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Iostream_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_System_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::num_put<char,std::back_insert_iterator<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > >::id''
...
===

See https://code.google.com/p/chromium/issues/detail?id=341941#c7 for logs of those found in Chromium.

R=cpu@chromium.org
BUG=341941

Review URL: https://codereview.chromium.org/66613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251144 0039d316-1c4b-4281-b951-d872f2087c98

(This reverts the revert, which was r250856).

TBR=jamesr@chromium.org
BUG=327471

Review URL: https://codereview.chromium.org/164033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251143 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds several changes:
- enables the JS handler to turn on and off the hotword recognizer
- adds a pref 'hotword.app_list_enabled' to customize the plugin usage
- synchronization logic, so if the user explicitly turns off
  hotword.search_enabled, hotword.app_list_enabled goes off too
- extract the language check of HotwordService as a static method
  and let StartPageHandler check it, because our hotword
  "Ok, Google" is US-English only

BUG=341710, 341779
R=xiyuan@chromium.org, rlp@chromium.org, estade@chromium.org
TBR=samarth@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/158143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251142 0039d316-1c4b-4281-b951-d872f2087c98

Don't attempt to unload the same extension twice if multiple ExtensionHost instances existed for the extension.

This makes sure ExtensionService doesn't schedule a second
TrackTerminatedExtension call if one call is already in progress.

BUG=327735

Review URL: https://codereview.chromium.org/162183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251141 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=340752

Review URL: https://codereview.chromium.org/164193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251140 0039d316-1c4b-4281-b951-d872f2087c98

By adding rel=next as an origin, we get histogram reporting on many of
our existing histograms.

The one tricky decision is that a prerender can have multiple rel
types (both next and prerender), and that by origin we currently
distinguish samedomain vs crossdomain.

In this CL we treat a prerender with both next and prerender rel types
as rel=prerender, and we do not distinguish cross vs same domain on
rel=next prerenders.

R=tburkard,davidben,isherman@chromium.org
BUG=329963

Review URL: https://codereview.chromium.org/121293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251139 0039d316-1c4b-4281-b951-d872f2087c98