GitLab

This code significantly simplies the logic for matching.

Indeed, the old logic was buggy because multiple prefix matches could
results in explosive growth of the list of matches (even if only one
bookmark matches).  Reviewer, I would avoid reading and trying to
understand what CombineMatches() and the code that calls it is currently
broken.  See the second test case I added.  Before this
change, that test never terminates (in the time I waited) and explodes
the machine's memory.  Luckily this was rare; there are few reports on
crbug.

It's possible this new code is slower or faster than before (when the
old code behaved correctly).  I plan to look at the
Omnibox.Providertime.Bookmarks numbers before and after this change.

TBR=sky for owners stamp; review it if you feel like

BUG=450850,434604

Review URL: https://codereview.chromium.org/882823004

Cr-Commit-Position: refs/heads/master@{#313574}

PrefsTabHelper was watching > 1K prefs so that it could update the renderer side data structures when they change. When session restore was used and it had 50 tabs, this would take almost a second on a Z620. Switch this to watching these prefs once per profile instead.

BUG=452693

Review URL: https://codereview.chromium.org/878363002

Cr-Commit-Position: refs/heads/master@{#313573}

Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.

BUG=453020
R=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/884813002

Cr-Commit-Position: refs/heads/master@{#313572}

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/876203003

Cr-Commit-Position: refs/heads/master@{#313571}

BUG=368321

Review URL: https://codereview.chromium.org/867463006

Cr-Commit-Position: refs/heads/master@{#313570}

Specifically, remove triggered builders from the list of "launched"
builders.  The new CQ verifier will pick up triggered builders from
the "triggered" section. This eliminates the duplicate specs.

This CL depends on the deployment of the (Google-only) CL:
https://chromereviews.googleplex.com/145077013/

R=phajdan.jr@chromium.org
BUG=436774

Review URL: https://codereview.chromium.org/866293003

Cr-Commit-Position: refs/heads/master@{#313569}

BUG=452249

Review URL: https://codereview.chromium.org/881203002

Cr-Commit-Position: refs/heads/master@{#313568}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/db3c2b2..c6b67b8

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/884803002

Cr-Commit-Position: refs/heads/master@{#313567}

BUG=452514

Review URL: https://codereview.chromium.org/879863004

Cr-Commit-Position: refs/heads/master@{#313566}

After crrev.com/310952 linux_me2me_host.py fails to start if it's called
using relative path. This CL fixes it. The problem was that it was trying
to run itself using sys.argv[0] after changing current directory, and
this works only if argv[0] is an absolute path.

Review URL: https://codereview.chromium.org/883063002

Cr-Commit-Position: refs/heads/master@{#313565}

At present, if a user changes zoom on OSX while the zoom bubble is
already being shown, the new zoom bubble (with the most up to date
information) is not shown. This CL changes this behaviour by allowing
a new zoom bubble to be created, and replace the existing one.

Example: load a PDF and repeatedly click the zoom +/- controls in the
lower-right corner of the viewer.

BUG=444995

Review URL: https://codereview.chromium.org/849693006

Cr-Commit-Position: refs/heads/master@{#313564}

The pieces added are as follows:

1. PresentationServiceDelegate: An interface to be implemented by an
embedder to handle Presentation API requests. Includes an Observer
interface to observe the lifetime of the delegate object.
2. PresentationScreenAvailabilityListener: An interface to be
implemented by content/ code to receive screen availability results
from the embedder.
3. Added method to ContentBrowserClient: GetPresentationServiceDelegate.
Returns nullptr by default. Embedder may override it with an
implementation that can handle Presentation API requests. Added to
allow content/ code to obtain a reference to a
PresentationServiceDelegate to forward presentation API requests to.

Presentation Mojo service patch: crrev.com/839773002/
Blink plumbing: crrev.com/832263007

The Chrome implementation of PresentationServiceDelegate is currently
in a private repo.

BUG=412331

Review URL: https://codereview.chromium.org/883953002

Cr-Commit-Position: refs/heads/master@{#313563}

The DeviceCloudPolicyInvalidator used to ensure that a suitable
InvalidationService is available on its own. This CL makes it a consumer
of AffiliatedInvalidationServiceProvider, which manages an
InvalidationService that can be shared by DeviceCloudPolicyInvalidator
and other consumers.

BUG=442800
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/846453006

Cr-Commit-Position: refs/heads/master@{#313562}

BUG=417463
TEST=build with clang plugin

Review URL: https://codereview.chromium.org/885703002

Cr-Commit-Position: refs/heads/master@{#313561}

It's not used anymore, last usage was removed
in https://codereview.chromium.org/583883003

R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/877183003

Cr-Commit-Position: refs/heads/master@{#313560}

The flake should hopefully be fixed by https://codereview.chromium.org/877213002/

R=earthdok
BUG=451988

Review URL: https://codereview.chromium.org/879053004

Cr-Commit-Position: refs/heads/master@{#313559}

There is a check in build-webapp.py (line 197) that ensures that
non-dev builds have this set to 'prod'. Up 'til now, we've been
setting this manually (hence the check in build-webapp), but it
is better to set it correctly in the gyp file.

This also allows the bots to build Official builds without
triggering the build-webapp check.

BUG=

Review URL: https://codereview.chromium.org/886543002

Cr-Commit-Position: refs/heads/master@{#313558}

Right now --disable-sync disables a lot of signin; any signin errors aren't surfaced, because nothing attempts to ping GAIA. This will help address that.

BUG=NONE
TEST=Run Chrome with the --disable-sync flag. Sign into a Profile and
the name (from G+) should appear in the Avatar Menu.

Review URL: https://codereview.chromium.org/870803003

Cr-Commit-Position: refs/heads/master@{#313557}

This fixes a problem where event listeners could stick around for a
short time period after an extension is unloaded, causing problems
with the onInstalled event for a new version of an extension.

BUG=449654

Review URL: https://codereview.chromium.org/877233002

Cr-Commit-Position: refs/heads/master@{#313556}

The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
Cr-Commit-Position: refs/heads/master@{#313446}

Review URL: https://codereview.chromium.org/864253002

Cr-Commit-Position: refs/heads/master@{#313555}

r227327 Fix indents on argument parsing code. No behavior change.
r227326 Make asan_symbolize.py not crash on Windows.

BUG=451741
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/884043004

Cr-Commit-Position: refs/heads/master@{#313554}

r313118 removed unused Cloud Devices code.
Cloud Print code must be untouched.

BUG=452871

Review URL: https://codereview.chromium.org/885683002

Cr-Commit-Position: refs/heads/master@{#313553}

R=lcwu@chromium.org,erickung@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/886583002

Cr-Commit-Position: refs/heads/master@{#313552}

BUG=447332

Review URL: https://codereview.chromium.org/853523004

Cr-Commit-Position: refs/heads/master@{#313551}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fb46751..db3c2b2

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/881363002

Cr-Commit-Position: refs/heads/master@{#313550}

Opus audio codec is supported by the android platform starting from Lollipop.
This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus
in Clank. This brings Opus feature parity with Desktop Chromium.

BUG=318436

Review URL: https://codereview.chromium.org/866573004

Cr-Commit-Position: refs/heads/master@{#313549}

As in the UsbEventRouter the UsbService must be observed from the FILE
thread (until bug 427985 is resolved, which will be soon). This change
fixes a DCHECK(CalledOnValidThread()) in UsbService::AddObserver when
permission to access an ephemeral (no serial number) device is added and
the DevicePermissionsManager starts listening for disconnection of that
device.

BUG=452652

Review URL: https://codereview.chromium.org/882813002

Cr-Commit-Position: refs/heads/master@{#313548}

The SkSurface that was being cached within the Resource was being held
and counted against skia's budget.  cc's budget is 512MB, and skia's is
~100MB, so cc would always blow skia's budget.  In the case of the ugam
page, we would end up redecoding, reupload and regenerating all of the
mip maps for each of the images on every frame.

Solution is to stop caching the SkSurface.

Additionally, we should investigate if this situation should even be
counted against skia's budget.  See crbug.com/452344

BUG=452138
BUG=447291

Review URL: https://codereview.chromium.org/874353007

Cr-Commit-Position: refs/heads/master@{#313547}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c2893c5..073720e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/878013003

Cr-Commit-Position: refs/heads/master@{#313546}

In this change we elevate the me2me native messaging host before calling into the daemon controller for the tasks that requires elevation. The daemon controller still depends on the com component for those tasks but the elevation is now done in the me2me native messaging host itself.

In followup CLs I will remove the elevated daemon controller com component and move its implementation to DaemonControllerDelegateWin.

Note that the pin confirmation dialog is removed with this CL. This change has been approved by the chrome security team.

BUG=447246

Review URL: https://codereview.chromium.org/880133003

Cr-Commit-Position: refs/heads/master@{#313545}

BUG=447311
TEST=Start Chrome. Click on the "People" menu in the OS menu bar. Any profiles
with default avatar should display the low res, transparent background images
(i.e. not the high res images with the grey background)

Review URL: https://codereview.chromium.org/882113003

Cr-Commit-Position: refs/heads/master@{#313544}

d:\src\cr3\src\base\win\pe_image.h(250): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\win\pe_image.h(250): warning C4302: 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD'

Separate ptr->int from truncation to WORD.

Also, while we're here, fix a cast in IsOrdinal.

R=cpu@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/883873002

Cr-Commit-Position: refs/heads/master@{#313543}

BUG=

Review URL: https://codereview.chromium.org/871543003

Cr-Commit-Position: refs/heads/master@{#313542}

BUG=451959

Review URL: https://codereview.chromium.org/878383003

Cr-Commit-Position: refs/heads/master@{#313541}

Adds a new file to //printing to hold the enums to be included
during the IPC generation. This allows to use them in more than
one generator at the time.

BUG=311308

Review URL: https://codereview.chromium.org/857053002

Cr-Commit-Position: refs/heads/master@{#313540}

This is a clean-up, getting rid of many manual deletes and comments about who owns forms passed around in vectors.

BUG=451018

Review URL: https://codereview.chromium.org/825773003

Cr-Commit-Position: refs/heads/master@{#313539}

This reverts the revert of https://chromiumcodereview.appspot.com/715203004/ by
fixing the build error.

BUG=376014, 376006, 376091

Review URL: https://codereview.chromium.org/868313004

Cr-Commit-Position: refs/heads/master@{#313538}

The major re-factoring for this has been done, this is mostly just
moving the files, with a small addition to ExtensionsBrowserClient.

For extensions/browser/api/networking_private/DEPS:
TBR=jamescook@chromium.org
BUG=363776

Review URL: https://codereview.chromium.org/870163002

Cr-Commit-Position: refs/heads/master@{#313537}

This CL replaces the use of XChangeActivePointerGrab() (of
which there is no XI2 equivalent) with XGrabPointer (of
which there is an XI2 equivalent).

BUG=426380
TEST=None

Review URL: https://codereview.chromium.org/821803002

Cr-Commit-Position: refs/heads/master@{#313536}

Created StatusUploader class to manage the uploading of device status.

Refactored status uploading functionality in cloud policy infrastructure - the
timing and contents of the device upload are now controlled by StatusUploader,
while CloudPolicyClient exposes an API to create the upload job.

BUG=430908

Review URL: https://codereview.chromium.org/845313008

Cr-Commit-Position: refs/heads/master@{#313535}